Subject: Re: [bug#33259] [PATCH 1/8] pack: Move store database creation to a separate derivation.

From: Danny Milosavljevic <[email-masked]>
Date: Tue, 6 Nov 2018 11:48:08 +0100

Hi Ludo,

On Sun,  4 Nov 2018 23:10:29 +0100
Ludovic Courtès <[email-masked]> wrote:

> +  (when database
> +    (install-file database (scope "/var/guix/db/"))
> +    (chmod (scope "/var/guix/db/db.sqlite") #o644)

Hmm, is it guaranteed that the basename of DATABASE is "db.sqlite" ?
Sounds a little magical.

> +  (define database
>      (and localstatedir?
> -         (local-file (search-path %load-path
> -                                  "guix/store/schema.sql"))))
> +         (file-append (store-database (list profile))
> +                      "/db/db.sqlite")))

Ah okay.

Otherwise LGTM!