From unknown Fri Jun 13 10:51:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33247: makefile mode comment color Resent-From: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Nov 2018 03:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33247 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 33247@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.154121641231894 (code B ref -1); Sat, 03 Nov 2018 03:41:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Nov 2018 03:40:12 +0000 Received: from localhost ([127.0.0.1]:60534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gImnE-0008IM-4m for submit@debbugs.gnu.org; Fri, 02 Nov 2018 23:40:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gImnB-0008I3-Bl for submit@debbugs.gnu.org; Fri, 02 Nov 2018 23:40:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gImn4-0004q1-8j for submit@debbugs.gnu.org; Fri, 02 Nov 2018 23:40:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=1.0 required=5.0 tests=BAYES_40,FROM_EXCESS_BASE64 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37091) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gImn2-0004oq-Sh for submit@debbugs.gnu.org; Fri, 02 Nov 2018 23:40:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gImn1-0001p5-Us for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2018 23:40:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gImmw-0004kE-AG for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2018 23:39:57 -0400 Received: from catfish.maple.relay.mailchannels.net ([23.83.214.32]:11968) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gImms-0004cI-GU for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2018 23:39:52 -0400 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5153C425FE for ; Sat, 3 Nov 2018 03:39:44 +0000 (UTC) Received: from pdx1-sub0-mail-a54.g.dreamhost.com (unknown [100.96.30.62]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 22A6C4266D for ; Sat, 3 Nov 2018 03:39:44 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from pdx1-sub0-mail-a54.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Sat, 03 Nov 2018 03:39:44 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Spill-Fumbling: 2842b389658356f4_1541216384201_2045961167 X-MC-Loop-Signature: 1541216384200:2474592288 X-MC-Ingress-Time: 1541216384200 Received: from pdx1-sub0-mail-a54.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTP id DDADC80084 for ; Fri, 2 Nov 2018 20:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to :subject:date:message-id:mime-version:content-type; s= jidanni.org; bh=Hg9ryX5/WhoBQmKA1687XWW7qhc=; b=bIaozbPy7XRUyYgR iKIqj1DfuILCJfM1CdTlaUXTDU1RHZsRHI7mWEZVQ+rmm1ZbACvkOTJQmM6UXsGq ydujLnsp5/IiBNcfUBYgMvrLgL8kDFOUuA2ODIphVvJXcjY0LbkK4wjz2mDCQCcc e+zQnzRrm1Rz08irlbFlWaLpr6g= Received: from jidanni.org (114-41-4-131.dynamic-ip.hinet.net [114.41.4.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTPSA id 68CC27FFE4 for ; Fri, 2 Nov 2018 20:39:43 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a54 From: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson Date: Sat, 03 Nov 2018 11:39:40 +0800 Message-ID: <877ehuhls3.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrjedtgdeigecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesthdtredttddtjeenucfhrhhomhepnjjnnjcuffgrnhculfgrtghosghsohhnuceojhhiuggrnhhnihesjhhiuggrnhhnihdrohhrgheqnecukfhppeduudegrdeguddrgedrudefudenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepjhhiuggrnhhnihdrohhrghdpihhnvghtpeduudegrdeguddrgedrudefuddprhgvthhurhhnqdhprghthheppeeruhhtfhdqkeerueerheeimhfphefnihehhegsveekreepucffrghnucflrggtohgsshhonhcuoehjihgurghnnhhisehjihgurghnnhhirdhorhhgqedpmhgrihhlfhhrohhmpehjihgurghnnhhisehjihgurghnnhhirdhorhhgpdhnrhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Makefile-mode should show comment color for both of xxx:# yyyy xxx: #zzzz not just the last. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 03 12:14:30 2018 Received: (at control) by debbugs.gnu.org; 3 Nov 2018 16:14:30 +0000 Received: from localhost ([127.0.0.1]:33109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIyZC-0007Y1-6j for submit@debbugs.gnu.org; Sat, 03 Nov 2018 12:14:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIyZA-0007Xp-N6 for control@debbugs.gnu.org; Sat, 03 Nov 2018 12:14:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIyYw-0006Tr-Br for control@debbugs.gnu.org; Sat, 03 Nov 2018 12:14:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIyYq-0006BZ-Tk for control@debbugs.gnu.org; Sat, 03 Nov 2018 12:14:09 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1gIyYq-00038v-Pn for control@debbugs.gnu.org; Sat, 03 Nov 2018 12:14:08 -0400 Subject: control message for bug 33247 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sat, 03 Nov 2018 12:14:08 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) merge 9407 33247 From unknown Fri Jun 13 10:51:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33247: makefile mode comment color References: <877ehuhls3.fsf@jidanni.org> Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Nov 2018 09:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33247 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson Cc: 33247@debbugs.gnu.org, Stefan Monnier Received: via spool by 33247-submit@debbugs.gnu.org id=B33247.154149764727009 (code B ref 33247); Tue, 06 Nov 2018 09:48:01 +0000 Received: (at 33247) by debbugs.gnu.org; 6 Nov 2018 09:47:27 +0000 Received: from localhost ([127.0.0.1]:35999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJxxG-00071Z-T9 for submit@debbugs.gnu.org; Tue, 06 Nov 2018 04:47:27 -0500 Received: from colin.muc.de ([193.149.48.1]:57172 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1gJxxC-00071N-Ok for 33247@debbugs.gnu.org; Tue, 06 Nov 2018 04:47:23 -0500 Received: (qmail 92935 invoked by uid 3782); 6 Nov 2018 09:47:21 -0000 Date: 6 Nov 2018 09:47:21 -0000 Message-ID: <20181106094721.92934.qmail@mail.muc.de> From: Alan Mackenzie Organization: muc.de e.V. In-Reply-To: X-Newsgroups: gnu.emacs.bug User-Agent: tin/2.4.2-20171224 ("Lochhead") (UNIX) (FreeBSD/11.2-RELEASE-p4 (amd64)) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Dan. In article you wrote: > Makefile-mode should show comment color for both of > xxx:# yyyy > xxx: #zzzz > not just the last. Yes. In make-mode.el, at line 525, there's a syntax-propertize-function setting which decommentises a # unless the previous character was one of |, &, ;, <, > (, ), `, \, ", ', , , . : is not in that list. The comment to this setting: ;; From sh-script.el. ;; A `#' begins a comment in sh when it is unquoted and at the beginning ;; of a word. In the shell, words are separated by metacharacters. ;; The list of special chars is taken from the single-unix spec of the ;; shell command language (under `quoting') but with `$' removed. confirms that the setting was taken over from shell-script-mode, and it is essentially unchanged. Why do we have this setting for makefiles at all? Are there any such restrictions on comments in Makefiles? Stefan? As a quick fix, please try the following (based off of master, though it'll probably work on released versions, too): diff --git a/lisp/progmodes/make-mode.el b/lisp/progmodes/make-mode.el index f67407f48e..27da624086 100644 --- a/lisp/progmodes/make-mode.el +++ b/lisp/progmodes/make-mode.el @@ -522,7 +522,7 @@ makefile-syntax-propertize-function ;; of a word. In the shell, words are separated by metacharacters. ;; The list of special chars is taken from the single-unix spec of the ;; shell command language (under `quoting') but with `$' removed. - ("[^|&;<>()`\\\"' \t\n]\\(#+\\)" (1 "_")) + ;; ("[^|&;<>()`\\\"' \t\n]\\(#+\\)" (1 "_")) ;; Change the syntax of a quoted newline so that it does not end a comment. ("\\\\\n" (0 ".")))) -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Jun 13 10:51:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33247: makefile mode comment color In-Reply-To: <877ehuhls3.fsf@jidanni.org> Resent-From: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Nov 2018 10:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33247 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Mackenzie Cc: 33247@debbugs.gnu.org, Stefan Monnier Received: via spool by 33247-submit@debbugs.gnu.org id=B33247.154149851928379 (code B ref 33247); Tue, 06 Nov 2018 10:02:02 +0000 Received: (at 33247) by debbugs.gnu.org; 6 Nov 2018 10:01:59 +0000 Received: from localhost ([127.0.0.1]:36014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJyBL-0007Nf-8X for submit@debbugs.gnu.org; Tue, 06 Nov 2018 05:01:59 -0500 Received: from otter.birch.relay.mailchannels.net ([23.83.209.139]:4685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJyBI-0007NU-NU for 33247@debbugs.gnu.org; Tue, 06 Nov 2018 05:01:57 -0500 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D7F4768304B; Tue, 6 Nov 2018 10:01:51 +0000 (UTC) Received: from pdx1-sub0-mail-a29.g.dreamhost.com (unknown [100.96.30.62]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9F61D682704; Tue, 6 Nov 2018 10:01:51 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Received: from pdx1-sub0-mail-a29.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 06 Nov 2018 10:01:51 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Chemical-Macabre: 4591709668369d57_1541498511738_1245095370 X-MC-Loop-Signature: 1541498511738:4087031524 X-MC-Ingress-Time: 1541498511737 Received: from pdx1-sub0-mail-a29.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a29.g.dreamhost.com (Postfix) with ESMTP id 5B9ED80A01; Tue, 6 Nov 2018 02:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=jidanni.org; bh=6PYKE6Tya6PrceiUyfsjkCoyHMI=; b=Trd5djY4m3uDF g9PnvNQjSnKzEpQnC4PsOHFQwUQaQPo0JMVtC3PmiHeA22hiEfflgkijZwRCTDXt tWOkuvmYYIVVnhxcsXIl3R+/DrkYGmOxAV5DCJ9C3Z/fQiKkV8AHQVLUe+nRv3XJ WSAZ3GjMg2kMcGMieg11VwIdwBzfu4= Received: from jidanni.org (111-246-96-57.dynamic-ip.hinet.net [111.246.96.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a29.g.dreamhost.com (Postfix) with ESMTPSA id 9CFCC8086B; Tue, 6 Nov 2018 02:01:49 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a29 From: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson References: <20181106094721.92934.qmail@mail.muc.de> Date: Tue, 06 Nov 2018 18:01:46 +0800 Message-ID: <877ehqcynp.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrjeejgdduudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufhffkfggtgesthdtredttddtjeenucfhrhhomhepnjjnnjcuffgrnhculfgrtghosghsohhnuceojhhiuggrnhhnihesjhhiuggrnhhnihdrohhrgheqnecukfhppeduuddurddvgeeirdeliedrheejnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehjihgurghnnhhirdhorhhgpdhinhgvthepudduuddrvdegiedrleeirdehjedprhgvthhurhhnqdhprghthheppeeruhhtfhdqkeerueerheeimhfphefnihehhegsveekreepucffrghnucflrggtohgsshhonhcuoehjihgurghnnhhisehjihgurghnnhhirdhorhhgqedpmhgrihhlfhhrohhmpehjihgurghnnhhisehjihgurghnnhhirdhorhhgpdhnrhgtphhtthhopehmohhnnhhivghrsehirhhordhumhhonhhtrhgvrghlrdgtrgenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Glad you found the bug. From unknown Fri Jun 13 10:51:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33247: makefile mode comment color Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Nov 2018 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33247 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Mackenzie Cc: 33247@debbugs.gnu.org, =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson Received: via spool by 33247-submit@debbugs.gnu.org id=B33247.154151074523124 (code B ref 33247); Tue, 06 Nov 2018 13:26:02 +0000 Received: (at 33247) by debbugs.gnu.org; 6 Nov 2018 13:25:45 +0000 Received: from localhost ([127.0.0.1]:36129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK1MX-00060u-Ib for submit@debbugs.gnu.org; Tue, 06 Nov 2018 08:25:45 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:33339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK1MV-00060m-2P for 33247@debbugs.gnu.org; Tue, 06 Nov 2018 08:25:43 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id wA6DPecD006712; Tue, 6 Nov 2018 08:25:41 -0500 Received: by pastel.home (Postfix, from userid 20848) id 16D296A522; Tue, 6 Nov 2018 08:25:39 -0500 (EST) From: Stefan Monnier Message-ID: References: <20181106094721.92934.qmail@mail.muc.de> Date: Tue, 06 Nov 2018 08:25:39 -0500 In-Reply-To: <20181106094721.92934.qmail@mail.muc.de> (Alan Mackenzie's message of "6 Nov 2018 09:47:21 -0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6412=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6412> : inlines <6952> : streams <1803480> : uri <2745171> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Why do we have this setting for makefiles at all? That's to handle the /bin/sh comments on the command lines of rules, where the code is run by /bin/sh and hence obeys the corresponding rules. E.g. foo.o: foo.c echo This is#not a comment $(CC) $(CFLAGS) -o $@ $< #This is an sh comment > Are there any such > restrictions on comments in Makefiles? Stefan? Maybe we should conditionalize on the presence of a leading TAB at the beginning of the line. BTW, I recently saw that the above is wrong in cases like foo.o: foo.c @#An sh comment not recognized by current makefile mode $(CC) $(CFLAGS) -o $@ $< #This is a comment so if you can fix both of those while you're there, that'd be great! -- Stefan