GNU bug report logs - #33237
26.1, 7.3 emacs-mac: <fnum> list order in C-h b

Previous Next

Full log

Message #11 received at 33237 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: van <at> scratch.space, 33237 <at> debbugs.gnu.org
Subject: Re: bug#33237: 26.1, 7.3 emacs-mac: <fnum> list order in C-h b
Date: Wed, 10 Jul 2019 18:02:36 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Wed, 10 Jul 2019 15:36:53 +0200
> Cc: 33237 <at> debbugs.gnu.org
> 
> <f1>		help-command
> <f2>		2C-command
> <f3>		kmacro-start-macro-or-insert-counter
> <f4>		kmacro-end-or-call-macro
> <f10>		menu-bar-open
> <f11>		toggle-frame-fullscreen
> <f16>		clipboard-kill-ring-save
> <f18>		clipboard-yank
> <f20>		clipboard-kill-region
> 
> Looks nicer to me.  Does anybody object to this change?
> 
> diff --git a/src/keymap.c b/src/keymap.c
> index 2ac3d33460..8c2c209e64 100644
> --- a/src/keymap.c
> +++ b/src/keymap.c
> @@ -3098,8 +3098,8 @@ describe_map_compare (const void *aa, const void *bb)
>    if (FIXNUMP (a->event) && !FIXNUMP (b->event))
>      return -1;
>    if (SYMBOLP (a->event) && SYMBOLP (b->event))
> -    return (!NILP (Fstring_lessp (a->event, b->event)) ? -1
> -	    : !NILP (Fstring_lessp (b->event, a->event)) ? 1
> +    return (!NILP (Fstring_version_lessp (a->event, b->event)) ? -1
> +	    : !NILP (Fstring_version_lessp (b->event, a->event)) ? 1
>  	    : 0);
>    return 0;
>  }

It sounds very strange to use string-version-lessp here, so I think
this must have a comment explaining why.

Btw, did you try string-collate-lessp instead?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.