Subject: Re: bug#33237: 26.1, 7.3 emacs-mac: <fnum> list order in C-h b

From: Lars Ingebrigtsen <[email-masked]>
Date: Wed, 10 Jul 2019 15:36:53 +0200

Van L <[email-masked]> writes:

> This is a suggestion. 
>
> The ordering on the f-number keys listed in the help buffer looks to
> me to be improvable.
>
> The numsort as applied after f but before the greater-thang(>) will look nicer.
>
> <f1>		help-command
> <f10>		menu-bar-open
> <f11>		toggle-frame-fullscreen
> <f16>		clipboard-kill-ring-save
> <f18>		clipboard-yank
> <f2>		2C-command
> <f20>		clipboard-kill-region
> <f3>		kmacro-start-macro-or-insert-counter
> <f4>		kmacro-end-or-call-macro

With the patch below, I get:

<f1>		help-command
<f2>		2C-command
<f3>		kmacro-start-macro-or-insert-counter
<f4>		kmacro-end-or-call-macro
<f10>		menu-bar-open
<f11>		toggle-frame-fullscreen
<f16>		clipboard-kill-ring-save
<f18>		clipboard-yank
<f20>		clipboard-kill-region

Looks nicer to me.  Does anybody object to this change?

diff --git a/src/keymap.c b/src/keymap.c
index 2ac3d33460..8c2c209e64 100644
--- a/src/keymap.c
+++ b/src/keymap.c
@@ -3098,8 +3098,8 @@ describe_map_compare (const void *aa, const void *bb)
   if (FIXNUMP (a->event) && !FIXNUMP (b->event))
     return -1;
   if (SYMBOLP (a->event) && SYMBOLP (b->event))
-    return (!NILP (Fstring_lessp (a->event, b->event)) ? -1
-	    : !NILP (Fstring_lessp (b->event, a->event)) ? 1
+    return (!NILP (Fstring_version_lessp (a->event, b->event)) ? -1
+	    : !NILP (Fstring_version_lessp (b->event, a->event)) ? 1
 	    : 0);
   return 0;
 }

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no