From unknown Fri Jun 13 11:31:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33237: 26.1, 7.3 emacs-mac: list order in C-h b Resent-From: Van L Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Nov 2018 04:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 33237@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15411340881682 (code B ref -1); Fri, 02 Nov 2018 04:49:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Nov 2018 04:48:08 +0000 Received: from localhost ([127.0.0.1]:59164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIRNQ-0000R4-JT for submit@debbugs.gnu.org; Fri, 02 Nov 2018 00:48:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIRNP-0000Qh-2p for submit@debbugs.gnu.org; Fri, 02 Nov 2018 00:48:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIRNJ-00034W-6A for submit@debbugs.gnu.org; Fri, 02 Nov 2018 00:48:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43117) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gIRNJ-00034S-2a for submit@debbugs.gnu.org; Fri, 02 Nov 2018 00:48:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIRNI-0003PM-DC for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2018 00:48:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIRNF-00032x-4k for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2018 00:48:00 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:42385) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gIRNE-00031x-Um for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2018 00:47:57 -0400 X-Originating-IP: 14.203.214.4 Received: from epi.local (14-203-214-4.tpgi.com.au [14.203.214.4]) (Authenticated sender: van@scratch.space) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 7306D1C0002 for ; Fri, 2 Nov 2018 04:47:52 +0000 (UTC) From: Van L Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: <1905EAD6-8AD3-4ED2-A80B-26DAF98FF08C@scratch.space> Date: Fri, 2 Nov 2018 15:47:48 +1100 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) Hello, This is a suggestion.=20 The ordering on the f-number keys listed in the help buffer looks to me = to be improvable. The numsort as applied after f but before the greater-thang(>) will look = nicer. help-command menu-bar-open toggle-frame-fullscreen clipboard-kill-ring-save clipboard-yank 2C-command clipboard-kill-region kmacro-start-macro-or-insert-counter kmacro-end-or-call-macro From unknown Fri Jun 13 11:31:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33237: 26.1, 7.3 emacs-mac: list order in C-h b Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2019 13:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Van L Cc: 33237@debbugs.gnu.org Received: via spool by 33237-submit@debbugs.gnu.org id=B33237.156276582230577 (code B ref 33237); Wed, 10 Jul 2019 13:38:01 +0000 Received: (at 33237) by debbugs.gnu.org; 10 Jul 2019 13:37:02 +0000 Received: from localhost ([127.0.0.1]:35088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlCmM-0007ww-94 for submit@debbugs.gnu.org; Wed, 10 Jul 2019 09:37:02 -0400 Received: from quimby.gnus.org ([80.91.231.51]:37794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlCmK-0007wU-1f for 33237@debbugs.gnu.org; Wed, 10 Jul 2019 09:37:01 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlCmD-0000fZ-Q4; Wed, 10 Jul 2019 15:36:56 +0200 From: Lars Ingebrigtsen References: <1905EAD6-8AD3-4ED2-A80B-26DAF98FF08C@scratch.space> Date: Wed, 10 Jul 2019 15:36:53 +0200 In-Reply-To: <1905EAD6-8AD3-4ED2-A80B-26DAF98FF08C@scratch.space> (Van L.'s message of "Fri, 2 Nov 2018 15:47:48 +1100") Message-ID: <87lfx63tai.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Van L writes: > This is a suggestion. > > The ordering on the f-number keys listed in the help buffer looks to > me to be improvable. > > The numsort as applied after f but before the greater-thang(>) will look nic [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Van L writes: > This is a suggestion. > > The ordering on the f-number keys listed in the help buffer looks to > me to be improvable. > > The numsort as applied after f but before the greater-thang(>) will look nicer. > > help-command > menu-bar-open > toggle-frame-fullscreen > clipboard-kill-ring-save > clipboard-yank > 2C-command > clipboard-kill-region > kmacro-start-macro-or-insert-counter > kmacro-end-or-call-macro With the patch below, I get: help-command 2C-command kmacro-start-macro-or-insert-counter kmacro-end-or-call-macro menu-bar-open toggle-frame-fullscreen clipboard-kill-ring-save clipboard-yank clipboard-kill-region Looks nicer to me. Does anybody object to this change? diff --git a/src/keymap.c b/src/keymap.c index 2ac3d33460..8c2c209e64 100644 --- a/src/keymap.c +++ b/src/keymap.c @@ -3098,8 +3098,8 @@ describe_map_compare (const void *aa, const void *bb) if (FIXNUMP (a->event) && !FIXNUMP (b->event)) return -1; if (SYMBOLP (a->event) && SYMBOLP (b->event)) - return (!NILP (Fstring_lessp (a->event, b->event)) ? -1 - : !NILP (Fstring_lessp (b->event, a->event)) ? 1 + return (!NILP (Fstring_version_lessp (a->event, b->event)) ? -1 + : !NILP (Fstring_version_lessp (b->event, a->event)) ? 1 : 0); return 0; } -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Jun 13 11:31:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33237: 26.1, 7.3 emacs-mac: list order in C-h b Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2019 15:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: van@scratch.space, 33237@debbugs.gnu.org Received: via spool by 33237-submit@debbugs.gnu.org id=B33237.156277097924802 (code B ref 33237); Wed, 10 Jul 2019 15:03:01 +0000 Received: (at 33237) by debbugs.gnu.org; 10 Jul 2019 15:02:59 +0000 Received: from localhost ([127.0.0.1]:36432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlE7X-0006Ry-0r for submit@debbugs.gnu.org; Wed, 10 Jul 2019 11:02:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlE7V-0006Rm-NL for 33237@debbugs.gnu.org; Wed, 10 Jul 2019 11:02:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hlE7P-0004g4-KE; Wed, 10 Jul 2019 11:02:51 -0400 Received: from [176.228.60.248] (port=4092 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hlE7N-0001E2-D1; Wed, 10 Jul 2019 11:02:51 -0400 Date: Wed, 10 Jul 2019 18:02:36 +0300 Message-Id: <838st63pbn.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87lfx63tai.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Wed, 10 Jul 2019 15:36:53 +0200) References: <1905EAD6-8AD3-4ED2-A80B-26DAF98FF08C@scratch.space> <87lfx63tai.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Wed, 10 Jul 2019 15:36:53 +0200 > Cc: 33237@debbugs.gnu.org > > help-command > 2C-command > kmacro-start-macro-or-insert-counter > kmacro-end-or-call-macro > menu-bar-open > toggle-frame-fullscreen > clipboard-kill-ring-save > clipboard-yank > clipboard-kill-region > > Looks nicer to me. Does anybody object to this change? > > diff --git a/src/keymap.c b/src/keymap.c > index 2ac3d33460..8c2c209e64 100644 > --- a/src/keymap.c > +++ b/src/keymap.c > @@ -3098,8 +3098,8 @@ describe_map_compare (const void *aa, const void *bb) > if (FIXNUMP (a->event) && !FIXNUMP (b->event)) > return -1; > if (SYMBOLP (a->event) && SYMBOLP (b->event)) > - return (!NILP (Fstring_lessp (a->event, b->event)) ? -1 > - : !NILP (Fstring_lessp (b->event, a->event)) ? 1 > + return (!NILP (Fstring_version_lessp (a->event, b->event)) ? -1 > + : !NILP (Fstring_version_lessp (b->event, a->event)) ? 1 > : 0); > return 0; > } It sounds very strange to use string-version-lessp here, so I think this must have a comment explaining why. Btw, did you try string-collate-lessp instead? From unknown Fri Jun 13 11:31:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#33237: 26.1, 7.3 emacs-mac: list order in C-h b Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2019 14:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: van@scratch.space, 33237@debbugs.gnu.org Received: via spool by 33237-submit@debbugs.gnu.org id=B33237.156285663227749 (code B ref 33237); Thu, 11 Jul 2019 14:51:01 +0000 Received: (at 33237) by debbugs.gnu.org; 11 Jul 2019 14:50:32 +0000 Received: from localhost ([127.0.0.1]:38363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlaP1-0007DT-Hm for submit@debbugs.gnu.org; Thu, 11 Jul 2019 10:50:31 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlaOx-0007DG-7V for 33237@debbugs.gnu.org; Thu, 11 Jul 2019 10:50:28 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlaOs-0004b8-8y; Thu, 11 Jul 2019 16:50:24 +0200 From: Lars Ingebrigtsen References: <1905EAD6-8AD3-4ED2-A80B-26DAF98FF08C@scratch.space> <87lfx63tai.fsf@mouse.gnus.org> <838st63pbn.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUkGwwNCQT5+OtyZj5A NhuekmO8tIfMxJpwXbpLAAACRElEQVQ4jWWTwZKbMAyG5YG925PdPkC2W67bsc3ZGat77gxr8gAp 5p4U/PqVZEgzrQZI7A/pl2QB1yNZV9ac5/JgKwg4dsuYMy3zxD+l5LyB480mMdvnObP/P2CwPW2y 7eDN2Wp93kDZRH4hsO1ghXkDNwwYCIy7x7yLuMYOG2AZGOcKXmNaJqc9h5orqC6v/dxdnfJ38TFX 8HW8Hrvfyv4HuuNxKq8qjn9BqSKlXM6jwnu6d5CWfvSn9se43j0k1jLOabInaPy4g5rWW9+tFxug sZUQqOpdLqNzQKASBiJynlLCoEIzEHkAb2tyiKCk9UxYQ9Qv3lEPIWcG1DHxoJon66nv5kCHm/hY kgCKVQZHoD2vfLxsEqocKVPaV/psHwB5XBfLCsY8xW+PIJeLKBvT4I2BE0BovqAyplUm2iixvIUz 92xe7MnocNLR+rJSXj7BTNNFt/1uUKlnP/Q0j1QKg8JDOXwSIIcPTp26Q4Ammiqfkmq1vn2RhhLJ 4kH34l0bVHq5MikyVzXUYhOifjrQisWt5zoS3ZNNTh2aZ1pJFy34tM2/fVeHp+ClcIwWtiG3jiZX xxDlLxnwIyLS6gQG8Yay29IVoI2yUEYjUgpBvgdo6aIvYAcUHDQYzSgABZSm64Ctf6c3yMQLgxyT eQZ4mZTsGzB0boQwhLrx01QDVtchtigRNEfcAL0NECkzFmGqdg+krFrEgcI177uDqWlBdB8DttBs KTHQpM0JRxcUAfXgQfVIkVyWuRtoTU+l6/Q82B+a9AiHe95C5gAAAABJRU5ErkJggg== Date: Thu, 11 Jul 2019 16:50:22 +0200 In-Reply-To: <838st63pbn.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 Jul 2019 18:02:36 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > It sounds very strange to use string-version-lessp here, so I think > this must have a comment explaining why. Yup. I mean, it's a function with a strange name, but what it does is nice (i.e., sort stretches of digits as a number). In other environments the function is often called something like "natural sort [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > It sounds very strange to use string-version-lessp here, so I think > this must have a comment explaining why. Yup. I mean, it's a function with a strange name, but what it does is nice (i.e., sort stretches of digits as a number). In other environments the function is often called something like "natural sort". > Btw, did you try string-collate-lessp instead? Yes, I tried it first, and it didn't do what I thought it would do: (sort '("1" "2" "11") 'string-collate-lessp) => ("1" "11" "2") Which isn't what we want... I'll go ahead and apply the patch (with a comment) and we can see how we like the result. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 11 10:54:44 2019 Received: (at control) by debbugs.gnu.org; 11 Jul 2019 14:54:44 +0000 Received: from localhost ([127.0.0.1]:38373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlaT6-0007Jp-BL for submit@debbugs.gnu.org; Thu, 11 Jul 2019 10:54:44 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hlaT4-0007Jf-9z for control@debbugs.gnu.org; Thu, 11 Jul 2019 10:54:42 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hlaT1-0004e3-5k for control@debbugs.gnu.org; Thu, 11 Jul 2019 16:54:41 +0200 Date: Thu, 11 Jul 2019 16:54:39 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #33237 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 33237 fixed close 33237 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 33237 fixed close 33237 27.1 quit