GNU bug report logs - #33233
27.0.50; Replace gnus-correct-length with string-width

Previous Next

Package: emacs;

Reported by: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Date: Thu, 1 Nov 2018 23:55:02 UTC

Severity: normal

Found in version 27.0.50

Done: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33233 in the body.
You can then email your comments to 33233 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#33233; Package emacs. (Thu, 01 Nov 2018 23:55:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Eric Abrahamsen <eric <at> ericabrahamsen.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 01 Nov 2018 23:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Replace gnus-correct-length with string-width
Date: Thu, 01 Nov 2018 16:53:44 -0700

[Message part 1 (text/plain, inline)]
The one is trivially replaceable by the other, this patch defines an
obsolete alias.


[0001-Obsolete-gnus-correct-length-in-favor-of-string-widt.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33233; Package emacs. (Fri, 02 Nov 2018 03:06:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#33233: 27.0.50; Replace gnus-correct-length with string-width
Date: Thu, 01 Nov 2018 20:05:09 -0700

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> The one is trivially replaceable by the other, this patch defines an
> obsolete alias.

Oh, in this situation should I be replacing the `gnus-correct-length'
calls with `string-width' directly, and just leaving the alias behind?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33233; Package emacs. (Fri, 02 Nov 2018 08:20:02 GMT) Full text and rfc822 format available.

Message #11 received at 33233 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 33233 <at> debbugs.gnu.org
Subject: Re: bug#33233: 27.0.50; Replace gnus-correct-length with string-width
Date: Fri, 02 Nov 2018 10:19:10 +0200

> From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
> Date: Thu, 01 Nov 2018 20:05:09 -0700
> 
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
> 
> > The one is trivially replaceable by the other, this patch defines an
> > obsolete alias.
> 
> Oh, in this situation should I be replacing the `gnus-correct-length'
> calls with `string-width' directly, and just leaving the alias behind?

Yes, I think so.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33233; Package emacs. (Fri, 02 Nov 2018 16:35:01 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#33233: 27.0.50; Replace gnus-correct-length with string-width
Date: Fri, 02 Nov 2018 09:34:12 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

>>> From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
>> Date: Thu, 01 Nov 2018 20:05:09 -0700
>> 
>> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>> 
>> > The one is trivially replaceable by the other, this patch defines an
>> > obsolete alias.
>> 
>> Oh, in this situation should I be replacing the `gnus-correct-length'
>> calls with `string-width' directly, and just leaving the alias behind?
>
> Yes, I think so.

Weirdly, it doesn't seem to be used anywhere anymore. I guess the alias
should still go in for a while, though; I'll push this to master.
Reply sent to Eric Abrahamsen <eric <at> ericabrahamsen.net>:
You have taken responsibility. (Fri, 02 Nov 2018 17:12:02 GMT) Full text and rfc822 format available.
Notification sent to Eric Abrahamsen <eric <at> ericabrahamsen.net>:
bug acknowledged by developer. (Fri, 02 Nov 2018 17:12:02 GMT) Full text and rfc822 format available.

Message #19 received at 33233-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: 33233-done <at> debbugs.gnu.org
Subject: Re: bug#33233: 27.0.50; Replace gnus-correct-length with string-width
Date: Fri, 02 Nov 2018 10:11:21 -0700

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>>> From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
>>> Date: Thu, 01 Nov 2018 20:05:09 -0700
>>> 
>>> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>>> 
>>> > The one is trivially replaceable by the other, this patch defines an
>>> > obsolete alias.
>>> 
>>> Oh, in this situation should I be replacing the `gnus-correct-length'
>>> calls with `string-width' directly, and just leaving the alias behind?
>>
>> Yes, I think so.
>
> Weirdly, it doesn't seem to be used anywhere anymore. I guess the alias
> should still go in for a while, though; I'll push this to master.

Pushed
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 01 Dec 2018 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 6 years and 195 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.