GNU bug report logs - #33172
[PATCH] gnu: linux-libre: Enable BOCHS DRM support.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33172 in the body.
You can then email your comments to 33172 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: Re: [PATCH] gnu: linux-libre: Enable BOCHS DRM support.
Date: Sat, 27 Oct 2018 17:41:12 +0900

Hi,

This article might help to understand what's new in QEMU 3.0 with VGA
emulation.

https://www.kraxel.org/blog/2018/10/qemu-vga-emulation-and-bochs-display/

Thanks,

Mathieu

Mathieu Othacehe writes:

> * gnu/packages/aux-files/linux-libre/4.19-x86_64.conf: Build DRM BOCHS support
> as a module.  It adds DRM support for BOCHS dispi vga interface used by
> qemu (-vga std option). It will also be useful for QEMU 3.0 to enable the new
> "bochs-display" display device.
> * gnu/packages/aux-files/linux-libre/4.19-i686.conf: Ditto.
> ---
>  gnu/packages/aux-files/linux-libre/4.19-i686.conf   | 2 +-
>  gnu/packages/aux-files/linux-libre/4.19-x86_64.conf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/aux-files/linux-libre/4.19-i686.conf b/gnu/packages/aux-files/linux-libre/4.19-i686.conf
> index 07a035be9..c1df3f0f4 100644
> --- a/gnu/packages/aux-files/linux-libre/4.19-i686.conf
> +++ b/gnu/packages/aux-files/linux-libre/4.19-i686.conf
> @@ -5949,7 +5949,7 @@ CONFIG_DRM_AST=m
>  # CONFIG_DRM_MGAG200 is not set
>  CONFIG_DRM_CIRRUS_QEMU=m
>  CONFIG_DRM_QXL=m
> -# CONFIG_DRM_BOCHS is not set
> +CONFIG_DRM_BOCHS=m
>  CONFIG_DRM_VIRTIO_GPU=m
>  CONFIG_DRM_PANEL=y
>  
> diff --git a/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf b/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
> index 0e102c87d..a8f8c8164 100644
> --- a/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
> +++ b/gnu/packages/aux-files/linux-libre/4.19-x86_64.conf
> @@ -5853,7 +5853,7 @@ CONFIG_DRM_AST=m
>  # CONFIG_DRM_MGAG200 is not set
>  CONFIG_DRM_CIRRUS_QEMU=m
>  CONFIG_DRM_QXL=m
> -# CONFIG_DRM_BOCHS is not set
> +CONFIG_DRM_BOCHS=m
>  CONFIG_DRM_VIRTIO_GPU=m
>  CONFIG_DRM_PANEL=y

Message #8 received at 33172 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: Mark H Weaver <mhw <at> netris.org>, 33172 <at> debbugs.gnu.org
Subject: Re: [bug#33172] [PATCH] gnu: linux-libre: Enable BOCHS DRM support.
Date: Sat, 27 Oct 2018 23:18:59 +0200

Hello Mathieu,

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> This article might help to understand what's new in QEMU 3.0 with VGA
> emulation.
>
> https://www.kraxel.org/blog/2018/10/qemu-vga-emulation-and-bochs-display/

Looks interesting.

>> * gnu/packages/aux-files/linux-libre/4.19-x86_64.conf: Build DRM BOCHS support
>> as a module.  It adds DRM support for BOCHS dispi vga interface used by
>> qemu (-vga std option). It will also be useful for QEMU 3.0 to enable the new
>> "bochs-display" display device.
>> * gnu/packages/aux-files/linux-libre/4.19-i686.conf: Ditto.

Perhaps we should enable it on AArch64 as well?  Mostly so that configs
don’t diverge too much.

Otherwise it LGTM.  Mark, WDYT?

Thanks,
Ludo’.

Message #11 received at 33172 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Mark H Weaver <mhw <at> netris.org>, 33172 <at> debbugs.gnu.org
Subject: Re: [bug#33172] [PATCH] gnu: linux-libre: Enable BOCHS DRM support.
Date: Sun, 28 Oct 2018 10:58:10 +0900

Hi Ludo,

> Perhaps we should enable it on AArch64 as well?  Mostly so that configs
> don’t diverge too much.

It is already built as a module on our arm and arm64 configs. The arm
config was taken from Debian and not derived from GuixSD intel configs,
so it explains the divergence. I guess it is the same for the arm64
config.

Thanks,

Mathieu

Message #14 received at 33172 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 33172 <at> debbugs.gnu.org, Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: Re: [bug#33172] [PATCH] gnu: linux-libre: Enable BOCHS DRM support.
Date: Sat, 27 Oct 2018 22:28:03 -0400

ludo <at> gnu.org (Ludovic Courtès) writes:

> Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:
>
>> This article might help to understand what's new in QEMU 3.0 with VGA
>> emulation.
>>
>> https://www.kraxel.org/blog/2018/10/qemu-vga-emulation-and-bochs-display/
>
> Looks interesting.
>
>>> * gnu/packages/aux-files/linux-libre/4.19-x86_64.conf: Build DRM BOCHS support
>>> as a module.  It adds DRM support for BOCHS dispi vga interface used by
>>> qemu (-vga std option). It will also be useful for QEMU 3.0 to enable the new
>>> "bochs-display" display device.
>>> * gnu/packages/aux-files/linux-libre/4.19-i686.conf: Ditto.

Looks good to me, please push.

> Perhaps we should enable it on AArch64 as well?  Mostly so that configs
> don’t diverge too much.

I just checked, and it's already enabled in our ARM and ARM64 configs.

FYI, our x86_64 and i686 configs were originally copied from
<https://jxself.org/git/kernel-configs.git>, and that's where the
decision to disable CONFIG_DRM_BOCHS originally came from.  In that
repo, you can see signs of indecision about whether to include that
module.  It was disabled in Jason's configs for 3.14-4.6, enabled in
4.7-4.15, disabled again in 4.16-4.18, and then enabled again in 4.19.

Since around 4.1 or 4.2, I've stopped looking at
<https://jxself.org/git/kernel-configs.git> and been using my own
judgement about new kernel configuration options brought to my attention
by "make oldconfig", but I haven't reviewed most of the older options.

Anyway, thanks for the patch!

       Mark

Message #17 received at 33172 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Mark H Weaver <mhw <at> netris.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 33172 <at> debbugs.gnu.org
Subject: Re: [bug#33172] [PATCH] gnu: linux-libre: Enable BOCHS DRM support.
Date: Sun, 28 Oct 2018 20:59:10 +0900

Hi Mark,

> FYI, our x86_64 and i686 configs were originally copied from
> <https://jxself.org/git/kernel-configs.git>, and that's where the
> decision to disable CONFIG_DRM_BOCHS originally came from.  In that
> repo, you can see signs of indecision about whether to include that
> module.  It was disabled in Jason's configs for 3.14-4.6, enabled in
> 4.7-4.15, disabled again in 4.16-4.18, and then enabled again in 4.19.
>
> Since around 4.1 or 4.2, I've stopped looking at
> <https://jxself.org/git/kernel-configs.git> and been using my own
> judgement about new kernel configuration options brought to my attention
> by "make oldconfig", but I haven't reviewed most of the older options.
>
> Anyway, thanks for the patch!

Thank you for the explanation and the review! Pushed as
81f12f33b70855c0a99d5c2f1c2526e4a21b9823.

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.