GNU bug report logs - #33145
27.0.50; rcirc race receives duplicate messages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33145 in the body.
You can then email your comments to 33145 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; rcirc race receives duplicate messages
Date: Thu, 25 Oct 2018 04:02:35 +0100

Currently, rcirc-filter clears the accumulator variable
rcirc-process-output only after each of its constituent lines has been
fed to rcirc-process-server-response, which in turn runs the abnormal
hook rcirc-receive-message-functions.

If this hook contains a function which allows process filters to be run,
e.g. by way of accept-process-output, and if process output arrives soon
enough, then rcirc-filter might be called more than once before its
previous invocation has managed to clear rcirc-process-output.

In other words, subsequent invocations may see process output that is
already being handled by previous invocations, thus potentially printing
duplicate messages in the process buffer.

Patch addressing this to follow.

Thanks,

-- 
Basil

In GNU Emacs 27.0.50 (build 31, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2018-10-24 built on thunk
Repository revision: 00027ff9d0f646662458bdb47cc7e2214f439698
Windowing system distributor 'The X.Org Foundation', version 11.0.12001000
System Description: Debian GNU/Linux buster/sid

Configured using:
 'configure --config-cache --prefix=/home/blc/.local --with-mailutils
 --with-x-toolkit=lucid --with-modules --with-file-notification=yes
 --with-x 'CC=ccache gcc' 'CFLAGS=-O2 -march=native -pipe''

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS
GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT
ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD
JSON LCMS2 GMP

Message #8 received at 33145 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: 33145 <at> debbugs.gnu.org
Subject: Re: bug#33145: 27.0.50; rcirc race receives duplicate messages
Date: Thu, 25 Oct 2018 04:07:33 +0100

[0001-Avoid-race-in-rcirc-process-filter-bug-33145.patch (text/x-diff, attachment)]

[Message part 2 (text/plain, inline)]

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Patch addressing this to follow.

I attach said patch.

Thanks,

-- 
Basil

Message #15 received at 33145-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 33145-done <at> debbugs.gnu.org
Subject: Re: bug#33145: 27.0.50; rcirc race receives duplicate messages
Date: Sat, 03 Nov 2018 10:47:41 +0200

> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> Date: Thu, 25 Oct 2018 04:07:33 +0100
> 
> > Patch addressing this to follow.
> 
> I attach said patch.

Thanks, pushed to the emacs-26 branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.