GNU bug report logs - #33142
[PATCH] Add two Lua 5.1 packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33142 in the body.
You can then email your comments to 33142 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: HiPhish <hiphish <at> posteo.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add two Lua 5.1 packages
Date: Thu, 25 Oct 2018 01:07:52 +0200

[Message part 1 (text/plain, inline)]

Hello,

This is my first time contributing a patch, so hopefully I did everything 
right. The patch adds two packages for Lua 5.1; the new packages are based on 
the existing Lua 5.2 packages. The reason we need separate packages for Lua 
5.1 and 5.2 is because Lua is not backwards compatible between releases: there 
is no guarantee that code working on 5.1 will work on 5.2 or vice-versa (even 
though it probably will, we don't want to rely on probably). These two 
packages will be needed by the Neovim package later.

[0001-Add-two-Lua-5.1-packages.patch (text/x-patch, attachment)]

Message #10 received at 33142-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: HiPhish <hiphish <at> posteo.de>
Cc: 33142-done <at> debbugs.gnu.org
Subject: Re: [bug#33142] [PATCH] Add two Lua 5.1 packages
Date: Fri, 26 Oct 2018 21:18:57 +0200

Helo Hiphish,

HiPhish <hiphish <at> posteo.de> skribis:

>>From c4cfd2080610a40518726745ed97affc90263b36 Mon Sep 17 00:00:00 2001
> From: HiPhish <hiphish <at> posteo.de>
> Date: Wed, 24 Oct 2018 14:22:14 +0200
> Subject: [PATCH] Add two Lua 5.1 packages
>
> * gnu/packages/lua.scm (lua5.1-lpeg): New package
> * gnu/packages/serialization.scm (lua5.1-libmpack): New package
>
> The packages lua-lpeg and lua-libmpack had no Lua 5.1 variants. These
> packages will be needed to build Neovim properly.

I tweaked the commit log and applied.

I applied it as one patch because I think that’s OK, but note that we
prefer one patch per package added, unless there’s a compelling reason
not to do so.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.