GNU bug report logs - #33134
[PATCH 0/1] guix-install.sh: Add ability to run it non-interactively.

Previous Next

Full log

Message #47 received at 33134 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: rsiddharth <s <at> ricketyspace.net>
Cc: 33134 <at> debbugs.gnu.org
Subject: Re: [bug#33134] [PATCH 1/5] guix-install.sh: Update welcome.
Date: Tue, 6 Nov 2018 12:32:32 +0100

[Message part 1 (text/plain, inline)]

On Fri,  2 Nov 2018 21:10:34 -0400
rsiddharth <s <at> ricketyspace.net> wrote:

> * etc/guix-install.sh (welcome): Read exactly one character from input.
> ---
>  etc/guix-install.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/etc/guix-install.sh b/etc/guix-install.sh
> index ca6874ba0..cf839c20e 100755
> --- a/etc/guix-install.sh
> +++ b/etc/guix-install.sh
> @@ -398,7 +398,7 @@ This script installs GNU Guix on your system
>  https://www.gnu.org/software/guix/
>  EOF
>      echo -n "Press return to continue..."
> -    read -r  ANSWER
> +    read -N 1 -r  ANSWER

While it's nice for the interactive user, doesn't this break

  yes | ./guix-install.sh

because now it doesn't wait for the newline?

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.