GNU bug report logs - #33134
[PATCH 0/1] guix-install.sh: Add ability to run it non-interactively.

Previous Next

Package: guix-patches;

Reported by: rsiddharth <s <at> ricketyspace.net>

Date: Wed, 24 Oct 2018 00:17:01 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #38 received at 33134 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: rsiddharth <s <at> ricketyspace.net>
Cc: 33134 <at> debbugs.gnu.org
Subject: Re: [bug#33134] [PATCH 2/5] guix-install.sh: Add parse_args.
Date: Tue, 6 Nov 2018 12:27:52 +0100
[Message part 1 (text/plain, inline)]
Hi,

> +    # process -y / -n arg.
> +    export AUTO_YN=${1:1:1}
> +    if [ -z $AUTO_YN ]; then
> +        export AUTO_YN=""
> +    fi

Why "export" ? Now all the child processes get it, making their environment
different from before.  This makes parse_args have system-wide side effects.

If we wanted to export it, we could do it explicitly after parse_args has
been called.
[Message part 2 (application/pgp-signature, inline)]

This bug report was last modified 3 years and 308 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.