GNU bug report logs - #33054
25.2; diff-model: M-k kills wrong hunk

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "dima\@secretsauce.net" <dima <at> secretsauce.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#33054: closed (25.2; diff-model: M-k kills wrong hunk)
Date: Tue, 16 Oct 2018 19:07:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 16 Oct 2018 12:06:10 -0700
with message-id <87r2gpu2xp.fsf <at> secretsauce.net>
and subject line Re: bug#33054: 25.2; diff-model: M-k kills wrong hunk
has caused the debbugs.gnu.org bug report #33054,
regarding 25.2; diff-model: M-k kills wrong hunk
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
33054: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33054
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2; diff-model: M-k kills wrong hunk
Date: Mon, 15 Oct 2018 13:56:27 -0700

[Message part 3 (text/plain, inline)]

I'm using a very recent build: e4896856172

Steps to reproduce bug:

- Open attached diff. Emacs should open it in diff-mode
- Put point on 'd' in the second "diff": (goto-char 98)
- M-k

This should kill the hunk we're on. We are unambiguously sitting on the
second hunk, but the latest diff-mode is confused, thinks we're on the
first hunk, and kills that instead. Kinda. Moving the point even one
character forward makes it work.

[bug.patch (text/x-diff, inline)]

diff --git a/111.py b/111.py
--- a/111.py
+++ b/111.py
@@ -154,3 +154,3 @@
 
-    aaa
+    bbb
 
diff --git a/222.py b/222.py
--- a/222.py
+++ b/222.py
@@ -224,3 +230,3 @@ writemodel(m_to)
     asdf
-    21234
+    345
     zxcv

[Message part 5 (message/rfc822, inline)]

From: "dima\@secretsauce.net" <dima <at> secretsauce.net>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 33054-done <at> debbugs.gnu.org
Subject: Re: bug#33054: 25.2; diff-model: M-k kills wrong hunk
Date: Tue, 16 Oct 2018 12:06:10 -0700

Alan Mackenzie <acm <at> muc.de> writes:

>> Steps to reproduce bug:
>
>> - Open attached diff. Emacs should open it in diff-mode
>> - Put point on 'd' in the second "diff": (goto-char 98)
>> - M-k
>
>> This should kill the hunk we're on.
>
> It does that for me.

Hi Alan. Thanks for the response. I was consistently seeing the problem,
but poked around a bit more after seeing your comment. I found the
issue: I was doing something wrong (specifics completely uninteresting).
There is no issue, and I'm closing the bug. Sorry for the noise.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.