From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 15 15:03:48 2018 Received: (at submit) by debbugs.gnu.org; 15 Oct 2018 19:03:48 +0000 Received: from localhost ([127.0.0.1]:51425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gC89c-0000xP-04 for submit@debbugs.gnu.org; Mon, 15 Oct 2018 15:03:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gC89b-0000xC-3E for submit@debbugs.gnu.org; Mon, 15 Oct 2018 15:03:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gC89V-0004a0-3u for submit@debbugs.gnu.org; Mon, 15 Oct 2018 15:03:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49191) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gC89U-0004Zq-Ug for submit@debbugs.gnu.org; Mon, 15 Oct 2018 15:03:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gC89U-0005G7-2r for bug-gnu-emacs@gnu.org; Mon, 15 Oct 2018 15:03:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gC89O-0004Vp-G2 for bug-gnu-emacs@gnu.org; Mon, 15 Oct 2018 15:03:40 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:47135) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gC89O-0004Oq-8g for bug-gnu-emacs@gnu.org; Mon, 15 Oct 2018 15:03:34 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 56D56202B for ; Mon, 15 Oct 2018 15:03:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 15 Oct 2018 15:03:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:subject:date:message-id:mime-version:content-type; s= fm1; bh=uK1TznGgQa9BD31p2TxswhlJhhA2PYlQoqBdJdenq74=; b=DNhz0Jxm Gedff/15O2hACxLD9/2EDZxn5qrdQ7yQ3SsQUVdYlkn/fEb2WNXBRCMYwE0em39D ZmqjsfXuhcDUZZnpl8EXceZoxumt1kYCkhIf+ZKOIKzWTf40czy/59MNNYinAeH9 2+XiNVeLA06co1anDLjb0ZEU7fdEAKU2/AVTmFqXZcO04BajOptZuw6q6hAgDK4H vBJu0Gy8BhLx2RQLRT67IT3VgEgU3MGuWRYLvvXoVnrhloMQBWOiKxNB1f5pv9OA kj2ZYDXPKPGBky5o6vsQKf37acXBj74TBLD7acHYoFtug9ojgFYivfuys6Z0IwNY 3BlS62K/WBohqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=uK1TznGgQa9BD31p2TxswhlJhhA2P YlQoqBdJdenq74=; b=MCW8sYn+A+fOczfwNBHdG39FX8Gojw28kHI4Vzemu3j4C iCGhiBmSxtXTG8d5uzSvzLCj/Z6PCaXB4RtxyZ4kZh+0x2IKCE0OYlkPPHgokKuR 0lcTibHj65nFE6Xx7dDVZqQxD2Tfqs3yosEQuxh0vHTH2tls7jUR8qbD+o64WCte cG1Fp70PY88ScgaCOoZbVpEllvcwGOxPser78R5khpdB/h1YsJgbtY0TLHw3RePd 6Q+Ni+fYz6MoRJ2Fk6r1iWoujjHy6YnvIXIoqq9Ppc1hboQiabod+MVZ3ZjoSn/u kPc9nf6wNFL/CQ2reEa6F0Q9F/WU2dyYLIrED2n5Q== X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 8A1F6E44DC for ; Mon, 15 Oct 2018 15:03:21 -0400 (EDT) From: Filipp Gunbin To: bug-gnu-emacs@gnu.org Subject: 27.0.50; [macOS] Problem with process input with process-connection-type nil Date: Mon, 15 Oct 2018 22:03:19 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) I was investigating why eudc-ldap hangs, and stripped the problem to the following (did this in emacs -Q): (let ((buf (get-buffer-create "my-process-buf"))) (with-current-buffer buf (erase-buffer) (let* ((process-connection-type nil) (proc (start-process "my-process" buf "/usr/bin/read" "-p" "enter something:"))) (while (null (progn (goto-char (point-min)) (re-search-forward "enter something:" (point-max) t))) (accept-process-output proc 1) (message "proc status: %s" (process-status proc))) (message "found prompt") (message "proc status: %s" (process-status proc)) (process-send-string proc "asdf") (process-send-string proc "\n") (while (not (memq (process-status proc) '(exit signal))) (sit-for 0.1)) (message "exited")))) If I let-bind process-connection-type to t (use pty) in above code, then it works normally: *Messages* : proc status: run found prompt proc status: run exited "exited" Buffer "my-process-buf": enter something: Process my-process<2> finished But if I let-bind process-connection-type to nil (so does ldap.el), then it hangs, and after a few seconds wait and C-g, *Messages* has only this: "proc status: run [6 times]", and buffer my-process-buf is empty. This is emacs master built with ./configure CC=/usr/bin/gcc --without-x --without-sound --with-ns --with-file-notification=no --with-gnutls --with-json --with-modules --with-threads --with-xml2 && make Also tried --without-threads - same behavior. Thanks. In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin17.7.0, NS appkit-1561.60 Version 10.13.6 (Build 17G65)) of 2018-10-15 built on fgunbin.playteam.ru Repository revision: 3d91dc1bb5aeecda786ebe1805c33d14c8bd89fa System Description: Mac OS X 10.13.6 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 20 06:10:19 2018 Received: (at 33050) by debbugs.gnu.org; 20 Oct 2018 10:10:19 +0000 Received: from localhost ([127.0.0.1]:60281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDoD5-0004xs-KV for submit@debbugs.gnu.org; Sat, 20 Oct 2018 06:10:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDoD3-0004xb-Rk for 33050@debbugs.gnu.org; Sat, 20 Oct 2018 06:10:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDoCt-00015i-Ry for 33050@debbugs.gnu.org; Sat, 20 Oct 2018 06:10:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDoCt-00015V-NB; Sat, 20 Oct 2018 06:10:07 -0400 Received: from [176.228.60.248] (port=4680 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gDoCt-0004LN-9M; Sat, 20 Oct 2018 06:10:07 -0400 Date: Sat, 20 Oct 2018 13:09:48 +0300 Message-Id: <83a7n9udxv.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin In-reply-to: (message from Filipp Gunbin on Mon, 15 Oct 2018 22:03:19 +0300) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Filipp Gunbin > Date: Mon, 15 Oct 2018 22:03:19 +0300 > > If I let-bind process-connection-type to t (use pty) in above code, then > it works normally: > > *Messages* : > proc status: run > found prompt > proc status: run > exited > "exited" > > Buffer "my-process-buf": > enter something: > Process my-process<2> finished > > But if I let-bind process-connection-type to nil (so does ldap.el), then > it hangs, and after a few seconds wait and C-g, *Messages* has only > this: "proc status: run [6 times]", and buffer my-process-buf is empty. The reason is almost certainly buffering: when the connection is via a pipe, the subprocess writes in buffered mode, so it might take quite a few characters of input before /usr/bin/read outputs something. Try using the -n or -N options, and see if that helps. Why does ldap.el set process-connection-type to nil? From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 22 11:35:49 2018 Received: (at 33050) by debbugs.gnu.org; 22 Oct 2018 15:35:49 +0000 Received: from localhost ([127.0.0.1]:36378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gEcFB-0001yd-LO for submit@debbugs.gnu.org; Mon, 22 Oct 2018 11:35:49 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:36391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gEcFA-0001yW-El for 33050@debbugs.gnu.org; Mon, 22 Oct 2018 11:35:49 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 75B75C46; Mon, 22 Oct 2018 11:35:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Oct 2018 11:35:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=WT77J5woBNAMwCGjQE0urIRzCJ cslBkKERXX7zhOA1I=; b=r9Gf9bRg24iHwY9JHjSk38B0urvvNHRe0mzBYiZfuP xsUDNPPZ05CxwrA+dMsgVScPZxsf77kgUGz9gU3AB3EahEChvKhI0yr0hBe9BDNh cakNA0pnV0wGo2oDkyK4AcmM/WlBGZJ+hWCOlH3Do13dcuh0foOVhc0sjM9LLPi5 yl7V5rhQlvc7C6gSI3R3apEd+mr7eO8yBXv+RFNNvKepWXz2mkJl2h+YauSiahmn cUM5u4KABa2UVxW/0NT9ojDa0vbBDLpBZikvfXVeAYg/YI+JmDoAM3tGt3l+oPdR 6IMj1nnIRLMfJykVXLrZaoaB+QQIRA+FTIUZEzxGnn5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=WT77J5 woBNAMwCGjQE0urIRzCJcslBkKERXX7zhOA1I=; b=EKl1cyPrF5hX4gggkCyFLg LxME6blpjHklZQYZlHdvbjyWx90Eku0CzJWWP1fCmMLxc7lSBk2lVKo0lqgGlDDy xAMDIvt6+700CJZEUdPtU7aZ/jPpgTLOsjJABn8ilQccaQ1S5lC2E/9M7oj6R7PA cUFvNhQ+fCCRsqS0gKtw8qM5Vgpfr+eARtJ8Uc/5aWJceGA3dK2+9832A0QajVdo lGt8VP530VbvLWa4LxtE6iJ68lDEBEVIggFyUHdsR8NCJeuzguTWAm66mPJaJC1I gEae0/4bkEEC/9OGqh0j+g0d1ifjuOKOmHMd/dlNCyu4v/XLpQvoq5Jj2NA47wrg == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id B8987E43AC; Mon, 22 Oct 2018 11:35:45 -0400 (EDT) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: <83a7n9udxv.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Oct 2018 13:09:48 +0300") References: <83a7n9udxv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Mon, 22 Oct 2018 18:35:43 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 20/10/2018 13:09 +0300, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Date: Mon, 15 Oct 2018 22:03:19 +0300 >> >> If I let-bind process-connection-type to t (use pty) in above code, then >> it works normally: >> >> *Messages* : >> proc status: run >> found prompt >> proc status: run >> exited >> "exited" >> >> Buffer "my-process-buf": >> enter something: >> Process my-process<2> finished >> >> But if I let-bind process-connection-type to nil (so does ldap.el), then >> it hangs, and after a few seconds wait and C-g, *Messages* has only >> this: "proc status: run [6 times]", and buffer my-process-buf is empty. > > The reason is almost certainly buffering: when the connection is via a > pipe, the subprocess writes in buffered mode, so it might take quite a > few characters of input before /usr/bin/read outputs something. Try > using the -n or -N options, and see if that helps. Thanks for looking at this. I tried wrapping read in stdbuf, but it didn't change anything: (start-process "my-process" buf "stdbuf" "-o0" "/usr/bin/read" "-p" "enter something:") read -n won't help either, because it can affect the number of chars "read" reads - while in my example we are just waiting for prompt. > Why does ldap.el set process-connection-type to nil? I don't know, and it seems like it should not mingle with this setting at all (why should it?) I've CC'ed Thomas, who is the author of these lines (ldap.el line 649), according to git blame. Filipp From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 22 21:48:54 2018 Received: (at 33050) by debbugs.gnu.org; 23 Oct 2018 01:48:54 +0000 Received: from localhost ([127.0.0.1]:36603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gEloU-0003xy-Dj for submit@debbugs.gnu.org; Mon, 22 Oct 2018 21:48:54 -0400 Received: from mail-io1-f46.google.com ([209.85.166.46]:42899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gEloS-0003xb-Hi for 33050@debbugs.gnu.org; Mon, 22 Oct 2018 21:48:52 -0400 Received: by mail-io1-f46.google.com with SMTP id n18-v6so28276679ioa.9 for <33050@debbugs.gnu.org>; Mon, 22 Oct 2018 18:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+7/X1zonYOYJsWwJISdRTRGl+YmqCtJKyLgxV+wBdZA=; b=AnUZY+6N9E8OCwnRS6/br7H356dxURcLUxhtB3vMKBfQAVSc7rNh0l8Bj/blBb4Gx7 Sb2CFd7M2fws3YMuvRXFgc+pQ10HNafnRiE1eoFYIwVI1kapX5gvwARZa3UZsktuonUU 4mdwUA+7JPbi92/XE/oFb1B/u4xdTR7qALG7qyfhW2uGpvZFNvYNwpa7tPJmO6GRQiTx K2Jnj65Pbyw5mtMRQCQwAYpnrrcK2hWFYFv5Nw3ADHuWGnMxBe1gv4PmdPH9osvLKLXH bG+4GE6bGppwkVCGPXH5Lm3z+dn0Gcj+nTUJp4q2Xp2TnotwqrqsdffUVhdjy4xmgLab Holw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+7/X1zonYOYJsWwJISdRTRGl+YmqCtJKyLgxV+wBdZA=; b=bdUd1qsMrO6YaEgp+UjEmY3ZP+Zw/hqqVkJem8g0DMzj/+jewZUcTs9Yp4GHRtUCIs nJsqTv4V1kE7bdVHjCZZuKNO4azKLOeWuEtKltpiKKZf6AxDYKg2QDpF7ClG95l1o6Yw 8BlsMpgEBMBN/heifa9Cfiqkv3XZsyH8afSLkFXPbSjWB3rzyn81qe4M1c3RJSP0zGZS Cni1Mt+EsNYa4yzHX1CKEeezVuqRV3iwlqN5Sv8Gp01VcPlpKKiJsi8r1C8cojiB5+Os FJ7r/6L6Xp1UWSL+P9x87rQ5CouaRZl20tJ9xc8ULFl9cGYGu0oHjfHSkTuujDbSm4F3 zRPg== X-Gm-Message-State: AGRZ1gK3HcmjodbB/+wCwLDAyeCmNWqxbQRUAkiCih/L6o3M8X3uLzSh ZpyDr6ilBR3xBirC8YfRZVZiQZUnyss= X-Google-Smtp-Source: AJdET5dDo0LOoXHQ4hLiutPr5UzkOq0By2uRuWWT43ezbJKCV630T7UD5ncW5CNzEFJ9i38CsoLI4A== X-Received: by 2002:a6b:18c5:: with SMTP id 188-v6mr10273256ioy.211.1540259326829; Mon, 22 Oct 2018 18:48:46 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id a136-v6sm21004ita.6.2018.10.22.18.48.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Oct 2018 18:48:46 -0700 (PDT) From: Thomas Fitzsimmons To: Filipp Gunbin Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> Date: Mon, 22 Oct 2018 21:53:00 -0400 In-Reply-To: (Filipp Gunbin's message of "Mon, 22 Oct 2018 18:35:43 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Filipp Gunbin writes: > On 20/10/2018 13:09 +0300, Eli Zaretskii wrote: > >>> From: Filipp Gunbin >>> Date: Mon, 15 Oct 2018 22:03:19 +0300 >>> >>> If I let-bind process-connection-type to t (use pty) in above code, then >>> it works normally: >>> >>> *Messages* : >>> proc status: run >>> found prompt >>> proc status: run >>> exited >>> "exited" >>> >>> Buffer "my-process-buf": >>> enter something: >>> Process my-process<2> finished >>> >>> But if I let-bind process-connection-type to nil (so does ldap.el), then >>> it hangs, and after a few seconds wait and C-g, *Messages* has only >>> this: "proc status: run [6 times]", and buffer my-process-buf is empty. >> >> The reason is almost certainly buffering: when the connection is via a >> pipe, the subprocess writes in buffered mode, so it might take quite a >> few characters of input before /usr/bin/read outputs something. Try >> using the -n or -N options, and see if that helps. > > Thanks for looking at this. > I tried wrapping read in stdbuf, but it didn't change anything: > (start-process "my-process" buf "stdbuf" "-o0" "/usr/bin/read" "-p" "enter something:") > > read -n won't help either, because it can affect the number of chars > "read" reads - while in my example we are just waiting for prompt. > >> Why does ldap.el set process-connection-type to nil? > > I don't know, and it seems like it should not mingle with this setting > at all (why should it?) > > I've CC'ed Thomas, who is the author of these lines (ldap.el line 649), > according to git blame. The overall change was to send the password to ldapsearch -W via a pipe instead of in the clear on the command line (which made it visible to other users e.g., in ps output). As for that specific line, I may have copied it from another part of Emacs that reads a password via a pipe; when I look now at other places that bind this variable to nil, I see comments like this one in lisp/gnus/nntp.el: ;; A non-nil connection type results in mightily odd behavior where ;; (process-send-string proc "\^M") ends up sending a "\n" to the ;; ssh process. --Stef ;; Also a nil connection allow ssh-askpass to work under X11. (let ((process-connection-type nil)) (apply 'start-process "nntpd" buffer command)) Today I tested my setup (x86_64 GNU/Linux, OpenLDAP ldapsearch 2.4.40) without setting process-connection-type to nil, and it still works. The documentation for that variable says that the fallback is to use a pipe if all ptys are busy in which case I guess this would still fail for you. Your test case behaves the same way for me on x86_64 GNU/Linux. Maybe our ldapsearch commands are behaving differently. What version of ldapsearch are you using? Thomas From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 23 18:41:57 2018 Received: (at 33050) by debbugs.gnu.org; 23 Oct 2018 22:41:57 +0000 Received: from localhost ([127.0.0.1]:38782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gF5N7-00035y-Cr for submit@debbugs.gnu.org; Tue, 23 Oct 2018 18:41:57 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:44799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gF5N5-00035q-Dx for 33050@debbugs.gnu.org; Tue, 23 Oct 2018 18:41:55 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 22002B5F; Tue, 23 Oct 2018 18:41:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 23 Oct 2018 18:41:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=ztkwHQBZL7Ed9hpk51mnziB00V 1I0QNjM8mkFspIi9A=; b=hz59/mVbvziWrqZhiLXOnu2q7bRRAzZ7RngnoVHY2Q emsspodRQvmRhAZWg1+kmGhOcK9PYLi2c4WZuvNB9figgvq3+tcrZRWDkv71uKIj DV79ZC6vDn6BlKxrdMrEYsawEAY3HZcEq18wClPp6a7nK49g5B96x3WENK46MI6p QebL4Obldy8GytLAaf5JQtD8G1utUcl13rCFq/dlMEago88HSVZaP0jH7HU1Z66S 0vTPwSh28mEAQxt7TL/HOfZAJf0mDACk4GaLNRp0ihlffUc0u55HGgdnDHizkp4e m8BUY8J95vqfmQilERS/bY2jtmerIxr1CoM0Zwr2f+/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ztkwHQ BZL7Ed9hpk51mnziB00V1I0QNjM8mkFspIi9A=; b=LEYF3Eyyzk4ZYJ3E6VFdaD L5y1sz9PjJ1lw4A+mnFwvJjgVJ3XBvEkMdmo20L1Y2vvaGUpkCnKpZa5rxKhlBHv 8y3O7d4MmUKV7WVQf+7+7Sv+Gn7rIp6bdiHiXZ17txYyBlZHp7sO5qXBLLEJqv89 /GraIvdhAdVmVx2H3q6nGWjGp2wqlWC80oTDEhSGa8PYEMnRhIPuI1pSffzDtmTU 4TLElG2xujLNnuZR9EISJISiYUdOF8Upez6lJpKKlcxjMWs2fYpZpu/lskzFdkc2 nlBoDPfdqlIrXFShnrEkW2Ka8ErI5WzRGpS7I1msHaMy/AM4IZIEXtxPjCvALPKA == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.local (unknown [93.185.19.142]) by mail.messagingengine.com (Postfix) with ESMTPA id 51A38102F3; Tue, 23 Oct 2018 18:41:52 -0400 (EDT) From: Filipp Gunbin To: Thomas Fitzsimmons Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Thomas Fitzsimmons's message of "Mon, 22 Oct 2018 21:53:00 -0400") References: <83a7n9udxv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Wed, 24 Oct 2018 01:41:50 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thomas, On 22/10/2018 21:53 -0400, Thomas Fitzsimmons wrote: [..] > As for that specific line, I may have copied it from another part of > Emacs that reads a password via a pipe; when I look now at other places > that bind this variable to nil, I see comments like this one in > lisp/gnus/nntp.el: > > ;; A non-nil connection type results in mightily odd behavior where > ;; (process-send-string proc "\^M") ends up sending a "\n" to the > ;; ssh process. --Stef > ;; Also a nil connection allow ssh-askpass to work under X11. > (let ((process-connection-type nil)) > (apply 'start-process "nntpd" buffer command)) > > Today I tested my setup (x86_64 GNU/Linux, OpenLDAP ldapsearch 2.4.40) > without setting process-connection-type to nil, and it still works. The > documentation for that variable says that the fallback is to use a pipe > if all ptys are busy in which case I guess this would still fail for > you. > > Your test case behaves the same way for me on x86_64 GNU/Linux. Do you mean it fails, or it works ok (regardless of process-connection-type value)? > Maybe our ldapsearch commands are behaving differently. What version of > ldapsearch are you using? I have OpenLDAP 2.4.28. Filipp From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 23 21:50:56 2018 Received: (at 33050) by debbugs.gnu.org; 24 Oct 2018 01:50:56 +0000 Received: from localhost ([127.0.0.1]:38989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gF8K0-0007PK-6V for submit@debbugs.gnu.org; Tue, 23 Oct 2018 21:50:56 -0400 Received: from mail-it1-f169.google.com ([209.85.166.169]:39788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gF8Jy-0007P5-DJ for 33050@debbugs.gnu.org; Tue, 23 Oct 2018 21:50:54 -0400 Received: by mail-it1-f169.google.com with SMTP id m15so4627300itl.4 for <33050@debbugs.gnu.org>; Tue, 23 Oct 2018 18:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=97+mckE5UYRxu5oSJ8Ol12AAookrhxUBdyEprbpbUTE=; b=XMXgYhrVd0yidvY1Stl1xmKB3QyOiYG08vyV4ws2o9l+exQ/MOTZjQRd4T5bZGCpmE lsfiUHAce7QotxIeG4WzFnNqIYyq/YLyrdmJ4fI/4R3sQpZBKC3ZuG4ZbF2/XqkCH9SJ WEu6VQ5I3/U1ylP1Mj1FtTQ6nCebl0WOvBS5p5h0YwqSBD0FDfyXfURGTbYsL9fsc7og 1Shr7TtGgaX/k2xoK6ez+fGxEVjBi30zPdeiOQP8cuNezAwQTAC71JXrnNz0PI0U7B1L yVgp1Hp8oLYAZCS7ukXBaBJP24sOxeEHUbkPXXuQS16vqed1lc3QHnbdu3HI330YjYOU fizw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=97+mckE5UYRxu5oSJ8Ol12AAookrhxUBdyEprbpbUTE=; b=QE0d/5wBaMixXri8FKfvo50Wq3Bqa/xJnNldbaeGd/eW5lobYnLGZMAIJ20s0iqBR2 1NrAdI/S63RYJllpNCZ3IWGNfp9BF549d0Ld9p3vpokPZy+QFbLMlPYavl9/7E8FpK+F K7h1uF3kbPqarmHyUrqsnB6pnkUNH+ejxT5CXyHSneGbzM5DvqdACaWmRTiJlRqCECmH czXg781CM3jzuzRcS626f6wzNHkZ7VVEJyaj15nJFWIRUbU06/v9MwiOyhHWcx0mXqU4 rrlX8XpzATyX+pAwPBn7l4fT2qUN2Sra2GsbyYtBLIk2vw/5/Vp5RGuJ2ZhkG+w0wf8b /Qpw== X-Gm-Message-State: AGRZ1gJIahKIHJlffr3oIDNg0alhXmOyDfbUOSPDjFMk8feHtlnN2iOG A5rapZNyJYu4Tqdo+m7hssRfUGi+8bc= X-Google-Smtp-Source: AJdET5f/Wcwsz0IR8OjGSMNkaG+9IHLe1lzLG/kRUbSpbq+imggoEdjqpftSK0USiHgR8k1LIx/dGA== X-Received: by 2002:a24:81c1:: with SMTP id q184-v6mr418155itd.152.1540345848415; Tue, 23 Oct 2018 18:50:48 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id p16-v6sm1280757itc.42.2018.10.23.18.50.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Oct 2018 18:50:47 -0700 (PDT) From: Thomas Fitzsimmons To: Filipp Gunbin Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> Date: Tue, 23 Oct 2018 21:55:13 -0400 In-Reply-To: (Filipp Gunbin's message of "Wed, 24 Oct 2018 01:41:50 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Filipp Gunbin writes: > Thomas, > > On 22/10/2018 21:53 -0400, Thomas Fitzsimmons wrote: > [..] >> As for that specific line, I may have copied it from another part of >> Emacs that reads a password via a pipe; when I look now at other places >> that bind this variable to nil, I see comments like this one in >> lisp/gnus/nntp.el: >> >> ;; A non-nil connection type results in mightily odd behavior where >> ;; (process-send-string proc "\^M") ends up sending a "\n" to the >> ;; ssh process. --Stef >> ;; Also a nil connection allow ssh-askpass to work under X11. >> (let ((process-connection-type nil)) >> (apply 'start-process "nntpd" buffer command)) >> >> Today I tested my setup (x86_64 GNU/Linux, OpenLDAP ldapsearch 2.4.40) >> without setting process-connection-type to nil, and it still works. The >> documentation for that variable says that the fallback is to use a pipe >> if all ptys are busy in which case I guess this would still fail for >> you. >> >> Your test case behaves the same way for me on x86_64 GNU/Linux. > > Do you mean it fails, or it works ok (regardless of > process-connection-type value)? I meant its behaviour is the same for me on x86_64 GNU/Linux as what you described its behaviour to be on Mac OS. Without: (process-connection-type nil) the test case succeeds. With it, the test case hangs. However if I change the test case program from: "/usr/bin/read" "-p" "enter something:" to: "ldapsearch" "-W" it does not hang regardless of the process-connection-type setting. Because it is missing the other options, after reading the password ldapsearch just fails to contact the server, after which my-process-buf contains... ...without (process-connection-type nil)): Enter LDAP Password: ldap_sasl_interactive_bind_s: can't contact LDAP server (-1) Process my-process<4> exited abnormally with code 255 ...with (process-connection-type nil)): Enter LDAP Password: ldap_sasl_interactive_bind_s: can't contact LDAP server (-1) Process my-process<4> exited abnormally with code 255 The only difference seems to be the missing newline. I got the above results with both my system ldapsearch (2.4.40) and with ldapseach 2.4.28 which I built from source. Anyway, at least on my system, it seems that /usr/bin/read is not doing the same thing as ldapsearch -W to read the string. What happens when you try the test case with "ldapsearch" "-W"? >> Maybe our ldapsearch commands are behaving differently. What version of >> ldapsearch are you using? > > I have OpenLDAP 2.4.28. OK, I doubt the problem is related to OpenLDAP version differences, but if it's easy it might be worth trying a newer one. Thomas From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 24 09:13:34 2018 Received: (at 33050) by debbugs.gnu.org; 24 Oct 2018 13:13:34 +0000 Received: from localhost ([127.0.0.1]:39213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFIyc-0000aX-JC for submit@debbugs.gnu.org; Wed, 24 Oct 2018 09:13:34 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:45867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFIyZ-0000aN-LH for 33050@debbugs.gnu.org; Wed, 24 Oct 2018 09:13:32 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 75523CDE; Wed, 24 Oct 2018 09:13:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 24 Oct 2018 09:13:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=KlBmaCyPflO7q5vE22wdCzn4YL Ks4CkhZdJ98q+raeo=; b=T5LR9TNvMg+lVn7NQAEvDd/6MKshxjvzV7N2A3+F6M xvRtAhmgMGOV3/YIXQfOfB632FQ4H5SHjNL/Emkvjh3lweqk/U06u8AbRTaA438E tlwzv4knV14fcTpcolyL4qU+hg5xKNK1bXOYVyL969CHRexww0PDSvtWxb5rxl6A T514Pe/GPaRB5L4w4+kBX0MkzuXvKBuyKA+37t58fV8trrCEHfuat+Ym8aigyBmH 175x7SvdySIt64jBiSxyDf5bhOp2TT+XCT9OoKej25UZp4WlNrDZhJsbp8B4s1rX 2KFdOh07buoWhTHTwkBhqh7TvVBzLVC92de3YKpwVoRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=KlBmaC yPflO7q5vE22wdCzn4YLKs4CkhZdJ98q+raeo=; b=L8l5cOedaaGI4VtvRK4U8O 0RlDJy1cief7qwDlA0bRgpgxxNV9WK7sWyWnAB/palbnV4yBteH5w6X6/E0UB3YR ZIyXXuP2vFxc5TViBuCNrOQ1VZR7U3gg6umTBZe24+j8SdVz03LZi6dURIF1iICF 9kHrEh2roi2DIBpMMgxfxu7w7ahEJGEBw0LzPhyWjupidwzrBQO9W52K8CoV9Ypg ezXEoX2PUxmFg+7V8V/0ff9yNRT2RK4cHSVjukw/nbTL5br7OJLr8Su9tRRSVGT3 IMRlHZTw0SlwlHGt+SW44Fb6V7pBzxf+SIvpkVXonJOfgSq+i2mKcrZ+iwPccYPQ == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id B56DE102FD; Wed, 24 Oct 2018 09:13:28 -0400 (EDT) From: Filipp Gunbin To: Thomas Fitzsimmons Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Thomas Fitzsimmons's message of "Tue, 23 Oct 2018 21:55:13 -0400") References: <83a7n9udxv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Wed, 24 Oct 2018 16:13:26 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thomas, On 23/10/2018 21:55 -0400, Thomas Fitzsimmons wrote: >>> Your test case behaves the same way for me on x86_64 GNU/Linux. >> >> Do you mean it fails, or it works ok (regardless of >> process-connection-type value)? > > I meant its behaviour is the same for me on x86_64 GNU/Linux as what you > described its behaviour to be on Mac OS. Without: > > (process-connection-type nil) > > the test case succeeds. With it, the test case hangs. Good that it can be "reproduced" at least in this form. If I change args to "ldapsearch" "-W" (and prompt, accordingly), then - with process-connection-type t, the test exits normally, and buffer contains the same text as for you: Enter LDAP Password: ldap_sasl_interactive_bind_s: Can't contact LDAP server (-1) Process my-process exited abnormally with code 255 - with process-connection-type nil, the test hangs, and when I quit, the buffer contains: Process my-process stopped (tty output): 22 I see that /usr/bin/read is not the best thing to test with, because I don't know exactly what it's doing. My ldapsearch (2.4.28) is from macOS - they don't update it frequently. I'll try a later version. Other than that, I don't know what to do for now :-( Filipp From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 24 10:05:45 2018 Received: (at 33050) by debbugs.gnu.org; 24 Oct 2018 14:05:45 +0000 Received: from localhost ([127.0.0.1]:40364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFJn7-0002An-EX for submit@debbugs.gnu.org; Wed, 24 Oct 2018 10:05:45 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:53483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFJn6-0002Ag-CE for 33050@debbugs.gnu.org; Wed, 24 Oct 2018 10:05:44 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4E677E94; Wed, 24 Oct 2018 10:05:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 24 Oct 2018 10:05:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type:content-transfer-encoding; s=fm1; bh= n0M/P6kn7pWpjia5GSEvw8/dHE+RRq1AsT9rZC/0nu8=; b=El4AJEJa4+Z3KrHT jLQaoklWx3J4b0+Du4omtFkFm1geTk4x2KFpVeM4IJURqXEgk18K94UuAuSKAUmk IlMMTyPUKVgtzfiN3g6X9NttM5CzuSAHUinvwJJlHoqGjxaMHeNDIHOmoy5XD1XD jWWXYYwVAwwd2+jKdC16SQharK/bJBpwjMIM9NtJSQ7L/N8ymice9eq9Ksf/CV+W v4T7LDVgbHZhQpvwp/GMHGnJ/kRo22F0CxIrb60D+7r0B4ZVQB1QLIVXh3XSg5Ao FabmZ/4FBY8QDwDlYqRUQ0vXx4CVcka9ly39JcVdFd7RKcnxy5DeDRPgZXGhkwq4 8jQmgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=n0M/P6kn7pWpjia5GSEvw8/dHE+RRq1AsT9rZC/0n u8=; b=CPXvgC9wZDBI5KE8haSFse0BDfWSlf8lh4Q34TVMW4G7BzqSr3TUNwcdy yqrMPcZoDaJF9Y1yARAipxXzLlU4DQNKmsoSZ4dVEtwwqeO6zCsUUN3fAUfNdnZu aYmdBj5YOeAEVj1YQfnocNw4/YM/BQRBSfrYHLLkO9cqLgHYtFIOGyTrIsmQo3gw izabCbLqf3e+ci/A3YRLzPp3AsVJgbeCLOgK1rbSV0GGmR/3ovTSrKRvyJpyFs0y To4H1HEMh+IPgLatxuX69UG6DQhO4gBXgTq9GluhmlJc6QLNeYfaw+jtV7FVPXzc xkeeAUntT7PybZ4Ido3+VwDl5LiUw== X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 5912A102DE; Wed, 24 Oct 2018 10:05:41 -0400 (EDT) From: Filipp Gunbin To: Thomas Fitzsimmons Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Thomas Fitzsimmons's message of "Tue, 23 Oct 2018 21:55:13 -0400") References: <83a7n9udxv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Wed, 24 Oct 2018 17:05:39 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This may be the clue to the problem: man termios(4): If a process is in the foreground process group of its controlling termi- nal, read operations are allowed. Any attempts by a process in a back- ground process group to read from its controlling terminal causes a SIGTTIN signal to be sent to the process's group unless one of the fol- lowing special cases apply: If the reading process is ignoring or block- ing the SIGTTIN signal, or if the process group of the reading process is orphaned, the read(2) returns -1 with errno set to EIO and no signal is sent. The default action of the SIGTTIN signal is to stop the process to which it is sent. I output the process-attributes of the started process, and note tpgid (ID of foreground process group on the process=E2=80=99s tty) and tty: - p-c-t t attrs=3D((etime 0 0 7080 0) (start 23504 29912 167367 0) (nice . 0) (tpgid . 16419) (tty . ttys001) (pgrp . 16419) (ppid . 98669) (state . R) (comm . ldapsearch) (group . staff) (egid . 20) (user . fgunbin) (euid . 501)) ldapsearch's pgrp=3D16419, it is using ttys001 for r/w, and it's in foreground process group on that tty (tpgid . 16419) - p-c-t nil attrs=3D((etime 0 0 6177 0) (start 23504 29897 662718 0) (nice . 0) (tpgid . 98669) (tty . ttys000) (pgrp . 16416) (ppid . 98669) (state . R) (comm . ldapsearch) (group . staff) (egid . 20) (user . fgunbin) (euid . 501)) ldapsearch's pgrp=3D16416, it is using ttys000 for r/w (??), and it is NOT in foreground process group on that tty - (tpgid . 98669). 98669 is emacs, and emacs is in foreground - this is ok. So the question is - why the process in the second case thinks that it has a tty? When it tries to use it, it receives SIGTTIN and is stopped, as termios man page says. My test case with p-c-t nil results in the processed being stopped, indeed. My knowledge of these things is very limited, forgive me if I'm clearly wrong somewhere. Filipp From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 24 12:16:09 2018 Received: (at 33050) by debbugs.gnu.org; 24 Oct 2018 16:16:09 +0000 Received: from localhost ([127.0.0.1]:40412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFLpI-0005eF-0I for submit@debbugs.gnu.org; Wed, 24 Oct 2018 12:16:09 -0400 Received: from mail-it1-f171.google.com ([209.85.166.171]:40724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFLpF-0005dT-NJ for 33050@debbugs.gnu.org; Wed, 24 Oct 2018 12:16:06 -0400 Received: by mail-it1-f171.google.com with SMTP id i191-v6so7299967iti.5 for <33050@debbugs.gnu.org>; Wed, 24 Oct 2018 09:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=WpssGnNJhU1e+gdpE1R3JVmei3B1NsTmCCBnC1HQUUE=; b=1AJ/XEZBDhUelqqgpMF9wq7pifFVHtzcoBWfjYVJYQDnMkxMmzC8qSgLppTe9WmwC+ /GX5UqyaEBnpCRWBJjCCGdNQbkqouFIWB6FF9Wbtw6ID//X1DcuudWh8DztDa+F/ZaY9 YXF74tcmuV1T03hgdk8x8TQHyjllZoL0EWwWiOTshszwvPUYALqgXLDfJivQ9AZIBvqD R0cNjNT0XYiM5kuzj25YyaXqZV+eqVhErwlWCEp4x3LNv22jBz1UlGVEQuIOFgLDxSuu 15VGVVaIasD05E1YCFoUpgu/y6rfeAY+qviubeSNugJqxOtuk8A5VnBcGnRTtJAiwrSi dxhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=WpssGnNJhU1e+gdpE1R3JVmei3B1NsTmCCBnC1HQUUE=; b=PGMERvnmgeVU4lj5CcyrZxaASIFfIOLAIg8zsGIO0geBU82HgRnXzA/XHIzzb4Eb7a prMrcslwCVCSXTE7aLk9uqBkZ3ka4JeDK1GXzCXVUgOAjcYOa4ZNS0//Z4IqzN0bzUZk nzcYfr3JPbL+2njwrbogyRtJk0q/bHhUE/NfAXozxFHVMWQAIZMw3z04+q2f2vv2S1bZ KBdXM08F54QT1UdOB/7iSugTF2VWiv4G3cJvKyVL9Y0Y0xrUc4uagz8DwG8iPU8CPMNQ mQziSkB2CGpT8hIkbgYQjsAcRIGaTc47j1SEOwtJbjf7He7zSk0Rw/MCaeNoENVJGCaQ aleg== X-Gm-Message-State: AGRZ1gIBnKcGRIB85D+1DnTspuGy86JDxltaypihEclHRyMZ1jzN5G9t xjQ3yiF9/b5IYNRf+5G84FZRPG/KRaI= X-Google-Smtp-Source: AJdET5eHXgdPB/UdpyfDy/Bp8vauwzUCoJsMeg1mkqB6mpY8fcS21v9m/ot1g74WntH9FzTXH7U1ng== X-Received: by 2002:a02:9609:: with SMTP id c9-v6mr2291118jai.118.1540397759678; Wed, 24 Oct 2018 09:15:59 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id p8-v6sm1777387iog.60.2018.10.24.09.15.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Oct 2018 09:15:58 -0700 (PDT) From: Thomas Fitzsimmons To: Filipp Gunbin Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> Date: Wed, 24 Oct 2018 12:20:31 -0400 In-Reply-To: (Filipp Gunbin's message of "Wed, 24 Oct 2018 17:05:39 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Filipp Gunbin writes: > This may be the clue to the problem: > > man termios(4): > > If a process is in the foreground process group of its controlling ter= mi- > nal, read operations are allowed. Any attempts by a process in a back- > ground process group to read from its controlling terminal causes a > SIGTTIN signal to be sent to the process's group unless one of the fol- > lowing special cases apply: If the reading process is ignoring or blo= ck- > ing the SIGTTIN signal, or if the process group of the reading process= is > orphaned, the read(2) returns -1 with errno set to EIO and no signal is > sent. The default action of the SIGTTIN signal is to stop the process= to > which it is sent. > > I output the process-attributes of the started process, and note tpgid > (ID of foreground process group on the process=E2=80=99s tty) and tty: > > - p-c-t t > > attrs=3D((etime 0 0 7080 0) (start 23504 29912 167367 0) (nice . 0) > (tpgid . 16419) (tty . ttys001) (pgrp . 16419) (ppid . 98669) (state > . R) (comm . ldapsearch) (group . staff) (egid . 20) (user . fgunbin) > (euid . 501)) > > ldapsearch's pgrp=3D16419, it is using ttys001 for r/w, and it's in > foreground process group on that tty (tpgid . 16419) > > - p-c-t nil > > attrs=3D((etime 0 0 6177 0) (start 23504 29897 662718 0) (nice . 0) > (tpgid . 98669) (tty . ttys000) (pgrp . 16416) (ppid . 98669) (state > . R) (comm . ldapsearch) (group . staff) (egid . 20) (user . fgunbin) > (euid . 501)) > > ldapsearch's pgrp=3D16416, it is using ttys000 for r/w (??), and it is > NOT in foreground process group on that tty - (tpgid . 98669). 98669 > is emacs, and emacs is in foreground - this is ok. > > So the question is - why the process in the second case thinks that it > has a tty? When it tries to use it, it receives SIGTTIN and is stopped, > as termios man page says. My test case with p-c-t nil results in the > processed being stopped, indeed. Try the test case again but with the command "/usr/bin/tty" (with no arguments). For me (GNU/Linux, x86_64): - p-c-t t /dev/pts/51 Process my-process<4> finished - p-c-t nil not a tty Process my-process<4> exited abnormally with code 1 (Meanwhile the test case hangs looking for the expected string until I Ctrl-g it.) Thomas From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 24 15:34:06 2018 Received: (at 33050) by debbugs.gnu.org; 24 Oct 2018 19:34:06 +0000 Received: from localhost ([127.0.0.1]:40511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFOuq-0006AA-9D for submit@debbugs.gnu.org; Wed, 24 Oct 2018 15:34:06 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:48831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFOuo-0006A3-Jz for 33050@debbugs.gnu.org; Wed, 24 Oct 2018 15:34:03 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8EDE7D0B; Wed, 24 Oct 2018 15:34:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 24 Oct 2018 15:34:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=2Hf4yjJa7Eulc0yMhsJPeGgDre +rLPAHdBixlHgAWwY=; b=CeEfwKyvFRcDwDAvKmtVAkwbOX65RTaWcVmPl788SY UKQ5IkRYy39q1dAHLLEQR6qNiKEke4j+5QmprpUdHuDmR2HnJppiTe9CEEQ3FlLS 9pIc/x9OQm5l88PK41u/QH87MyHE69PxurdIfHFQ8JyspQ+5wdMBSWzYgj7t6dXT +OYyZ/raHcog2uAMY0foQcGZg7eSl3nHdMkHBEWhzuKjP6SU0v1xQpBlq0tDrX6z UXAejcWmrsQAC8/9KLoPkr67bl/dW3fJh6eSlBl0NP0P0Nc3yia+4cMbCmcTga82 Uhrp5kdTG6uuPwlRCU5jyAJcYV+/vmv6p609b9wJX81w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=2Hf4yj Ja7Eulc0yMhsJPeGgDre+rLPAHdBixlHgAWwY=; b=KgJfG3PHPFMgw+jjHjl6LM 0XxhtUm1AcGdxBlP7pHS2ouhlloobZmphj/rps7QOcjKtg9Xq4YrancQiMo/u2uy F9GmTwZZj2PfuvDQ1rr4H4jjdFRcxJlOdET0rvkPCjDS+jl7USG4Ol9rMyEJm/fF 35eTKnUOYe7U3MRsdIB+rnKZ3jz/vBUe1H+E37eeUtJSiYdBoFGaQo08rvD8XUDv PKFBUxr2UKBkPw+vodUFhe5z1m+TPWlZeKyQrLi8LE233rvq6KFUCerEzbAxJxMZ 1OlJH4FMH6o/cgs8zu0AJZHdfSEWH5p4PYgxm2xZrSEENNjGGg31CWKINZXODXDw == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id CD7FB102EB; Wed, 24 Oct 2018 15:33:59 -0400 (EDT) From: Filipp Gunbin To: Thomas Fitzsimmons Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Thomas Fitzsimmons's message of "Wed, 24 Oct 2018 12:20:31 -0400") References: <83a7n9udxv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Wed, 24 Oct 2018 22:33:58 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Tried on macOS, here's the output. On 24/10/2018 12:20 -0400, Thomas Fitzsimmons wrote: > Try the test case again but with the command "/usr/bin/tty" (with no > arguments). > > For me (GNU/Linux, x86_64): > > - p-c-t t > > /dev/pts/51 > > Process my-process<4> finished /dev/ttys003 Process my-process finished > > - p-c-t nil > > not a tty > > Process my-process<4> exited abnormally with code 1 not a tty Process my-process exited abnormally with code 1 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 24 15:46:29 2018 Received: (at 33050) by debbugs.gnu.org; 24 Oct 2018 19:46:29 +0000 Received: from localhost ([127.0.0.1]:40541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFP6r-0006Ts-7n for submit@debbugs.gnu.org; Wed, 24 Oct 2018 15:46:29 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:49179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFP6o-0006Tk-Va for 33050@debbugs.gnu.org; Wed, 24 Oct 2018 15:46:27 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2F62BCEE; Wed, 24 Oct 2018 15:46:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 24 Oct 2018 15:46:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=YqgQacD/L7lMhyukKSTx1NA+GS AW8blq/Gvl659z8GM=; b=hVC1959fnzjX8rpb7yk057M56LYXK9vhMSd6UHW1tz Pmkwl8MTgCBwtC9CaYe0UbdJg6/wFahZdCOc9O/vSkH7KAto8sF3cmuXdMQmK5zc AE65Z0E2ruWgPknHWigR2BOuLPxute/JZo5FIFfi/o3q9T3E7sJaTPtviPl4F9J3 rKKK1MGgphSw07Fo8k+suMH2Ivo+6xHT3dRtd+9ZxkPCqUKyfMy/Ph4UEG/ZEItN rJ4OKpI0YWowVSEPFIArQV2wQq3br632BMtnpOip3iGeg19BHfi/N56sIHICKay9 XzgAotqJASxicSvdb7uAbu9IdLOGeSRdgR5rbBAgOMGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=YqgQac D/L7lMhyukKSTx1NA+GSAW8blq/Gvl659z8GM=; b=jCS2oBo/nPWaBzhnOEvD0Q 9Ktl0siSZj8WUmnI3pCRcUBbLZ1Q6WI3DsJ3oKgi2o44m3oc3c0++Ofu2xIP+0Jl ZKsgdigxmZlOw8jt2ZsUjTd+32R+6u8MF2+EXYiJvp5P4lJFeXVxZZDMwYAybEr1 E2qIBUvLF8wi8T1+vq+L/Pp+XCO4bQ6dWN5HT4l+hPxVtOJvBxUhk3JIRVxAsqrw voRjPq9espFPcwtvuhAgnW5hp3O4PBJre+O5e+pMqot9mA5c8LMcwta5EtgHgb3m 5cBu3N+3Jvkrpu1R1anftck7VqYGeyu3Cv421JiZCgnnQuq03qj6ODd7RV3Ek/bw == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 3C269102FA; Wed, 24 Oct 2018 15:46:24 -0400 (EDT) From: Filipp Gunbin To: Thomas Fitzsimmons Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Thomas Fitzsimmons's message of "Wed, 24 Oct 2018 12:20:31 -0400") References: <83a7n9udxv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Wed, 24 Oct 2018 22:46:22 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thomas, what does (process-attributes (process-id proc)) output for you? (say, right after the process creation). The fact that the process is stopped by OS (in my case) makes me think that the process is indeed trying to use tty in p-c-t nil case. So it could be bug in process creation. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 24 18:02:41 2018 Received: (at 33050) by debbugs.gnu.org; 24 Oct 2018 22:02:41 +0000 Received: from localhost ([127.0.0.1]:40937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFREe-0005Jt-JC for submit@debbugs.gnu.org; Wed, 24 Oct 2018 18:02:40 -0400 Received: from mail-it1-f182.google.com ([209.85.166.182]:34750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFREd-0005Ft-BK for 33050@debbugs.gnu.org; Wed, 24 Oct 2018 18:02:39 -0400 Received: by mail-it1-f182.google.com with SMTP id e81-v6so614744itc.1 for <33050@debbugs.gnu.org>; Wed, 24 Oct 2018 15:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XiTSLkcsB7OHV6p4ZZRnYx2XQ8VOj41+pjNfwP0b0iY=; b=OdOLPTb7TCKP8wxPEaXFDp5BOE4tX2nrF+Q90nw4rXCujVVqjI9VZV2ZFUyEvivuL7 UyBfPoGhLE4yoShooFI9bQShyGHcgeK75T+KwdP8WOwZB8tGYz9TIA9fTpy8ynYiqsIL hDxJrvOmbsQI0jrkZ1C97AZSQJkjvW2Bld45Lovv6QrVZ7XLs4BVyIW3F3qnIX4Q8IXO ZSlaCvzHdI3eQeEJmQJivHU9R7GWKBQA9/llTWyIjwYLEjQcquhtpL1AY3mrdaeJw0J+ uUr2x18zwcTpTpkTcd/pL/EL2k6D0ka7UZO57hKo8ztFYTULr7brG23C2j8LxicTKyc1 MXvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XiTSLkcsB7OHV6p4ZZRnYx2XQ8VOj41+pjNfwP0b0iY=; b=tzAlpKIpaZ7qwRbuyRVGvYIiZzv1fqakGeh2rkgilBnlqHGMT78QaWTSfkz50LdOH2 Zb2gXTprx5Z3hpNfrbv8+Ri3+CJldY7HbHVC7KRq6h+PNLj4cwCQT6CC0wDCYoT3VbiM rFWT82abxjyDp6jFeSogXCMn7Qp6YLViCeIcs0m9rLfcjm4vF78kJWSH8KkAvrFTwp/2 mhcyMsDvtsyPhPen0t7TPzy0ZJfXAP1Y7D2/KCI882YY2wn4QeV8CwLId+XeDUBuI4sy Lmj/LzqxWXvZvPYxcgAtjY5KeswMs0rVFqzNKq6lXY/B1BNH5iRwUIadljA61tQjhgom pZMQ== X-Gm-Message-State: AGRZ1gLR5o3vtsVziUxNfD37wCC95yyNwuqSejG9CwMRYXQOPHupf6eu ZHrsSp33fC591wSM5JRCPY5ajRtInyw= X-Google-Smtp-Source: AJdET5fP+nJR2d0p8WeI1tVsoWi5udu7rqCqTe4HiCIAgXkdIik5fk/C5bj6Lc19iROigu+tMZBCSA== X-Received: by 2002:a24:9644:: with SMTP id z65-v6mr2536447itd.175.1540418553510; Wed, 24 Oct 2018 15:02:33 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id v24-v6sm1724287iom.85.2018.10.24.15.02.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Oct 2018 15:02:32 -0700 (PDT) From: Thomas Fitzsimmons To: Filipp Gunbin Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> Date: Wed, 24 Oct 2018 18:07:08 -0400 In-Reply-To: (Filipp Gunbin's message of "Wed, 24 Oct 2018 22:46:22 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Filipp, Filipp Gunbin writes: > Thomas, what does (process-attributes (process-id proc)) output for you? > (say, right after the process creation). > > The fact that the process is stopped by OS (in my case) makes me think > that the process is indeed trying to use tty in p-c-t nil case. So it > could be bug in process creation. p-c-t t ((args . /usr/bin/ldapsearch -W) (pmem . 0.006538857941754344) (pcpu . -0.0e+NaN) (etime 0 0 0 0) (rss . 1596) (vsize . 42680) (start 23504 58749 447508 202000) (thcount . 1) (nice . 0) (pri . 20) (ctime 0 0 0 0) (cstime 0 0 0 0) (cutime 0 0 0 0) (time 0 0 0 0) (stime 0 0 0 0) (utime 0 0 0 0) (cmajflt . 0) (cminflt . 0) (majflt . 0) (minflt . 485) (tpgid . [...]) (ttname . /dev/pts54) (sess . 29274) (pgrp . 29274) (ppid . 29075) (state . S) (comm . ldapsearch) (group . [...]) (egid . [...]) (user . [...]) (euid . [...])) p-c-t nil ((args . /usr/bin/ldapsearch -W) (pmem . 0.006538857941754344) (pcpu . 0.0) (etime 0 1 10000 0) (rss . 1596) (vsize . 42684) (start 23504 58688 70097 688000) (thcount . 1) (nice . 0) (pri . 20) (ctime 0 0 0 0) (cstime 0 0 0 0) (cutime 0 0 0 0) (time 0 0 0 0) (stime 0 0 0 0) (utime 0 0 0 0) (cmajflt . 0) (cminflt . 0) (majflt . 0) (minflt . 483) (tpgid . [...]) (ttname . ) (sess . 29201) (pgrp . 29201) (ppid . 29075) (state . S) (comm . ldapsearch) (group . [...]) (egid . [...]) (user . [...]) (euid . [...])) I had been testing on Emacs 26.1, but noticed the difference: (tty . ...) vs (ttname . ...) and so retested on master tip to see if the Emacs version accounted for that, but I get the same result. "tty" isn't listed as a key in src/process.c, so I'm don't know where it's coming from on Darwin. However, ttname's value on my system does correspond to the process-connection-type setting. Thomas From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 11:51:27 2018 Received: (at 33050) by debbugs.gnu.org; 25 Oct 2018 15:51:27 +0000 Received: from localhost ([127.0.0.1]:42666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFhuv-0004Ac-Im for submit@debbugs.gnu.org; Thu, 25 Oct 2018 11:51:26 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:40101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFhut-0004AU-Ge for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 11:51:23 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 44BE2EAE; Thu, 25 Oct 2018 11:51:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 11:51:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=yGoTzyy0+Ds2V4VE0HbZx/MJdl mFFuuf5wR0zzTDzu0=; b=wlwr6ros3NE1M9JyXrmWlFOOVDxXQJqfULAp2IIX6C 5zGHYBiUlraUEOXelttzPj815QtO4MJszN1XW/EUaNFjk5fU5yj80QaY/C6c+XsI F7DFvWaY1d/LEwTo1gSVNftmRLnbtSz4IJbG93QBm9AEj6Y+noe3ofIvi9HmSMj7 F0wUdTU7JSNlYwbS8L4i2eCHWAaLM91oN2lef+BFmEm6kyiJHv5yZpPOK9mdDb8/ vy8uW1UTURqvAUMHB45jPFN4T3MoFsm0owsLTRO3eS16FQQcC3E9xIJiHOnTzHcp bWe7rAeJqr5cflIIWdonUp+TodzjgoaqbghtPrpf0i5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=yGoTzy y0+Ds2V4VE0HbZx/MJdlmFFuuf5wR0zzTDzu0=; b=q2aEYxM+dPqaC2Mng11EVc wuqS8tSruNRDrzmPsyJTGfHQTKfG991SecTWwjDbI9QyrbGbXcRrdG3eUi2F8A44 iLyk8/nv809H1M9+4Y8u69Yrbf9vdUWctnuYSEWmjp09/TShyUKip71PT/2SZDsF 8quz+jKOEQK/dtSBce9pry/ecY9cm5XHY/rkq8i9ZlOVZA1wHqNWEa3lBqruznYe vukX1znXSGKrH3u4vyEu0We9Jec4WVMl0wbvSx0SoQto1fJQfpV/DiEZwirFLO7r djbcJOZFg8YWUlrQSEttTw450u6Zjm0ciCIQUenMmfQe++E5TCgyfBiScCW6zrcw == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 5B90EE47C6; Thu, 25 Oct 2018 11:51:20 -0400 (EDT) From: Filipp Gunbin To: Thomas Fitzsimmons Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Thomas Fitzsimmons's message of "Wed, 24 Oct 2018 18:07:08 -0400") References: <83a7n9udxv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Thu, 25 Oct 2018 18:51:17 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 24/10/2018 18:07 -0400, Thomas Fitzsimmons wrote: > Hi Filipp, > [...] > However, ttname's value on my system does correspond to the > process-connection-type setting. Yes, so in your case child process doesn't have controlling terminal, while in my case it does. process.c Line 2069: #ifdef DARWIN_OS /* Darwin doesn't let us run setsid after a vfork, so use fork when necessary. Also, reset SIGCHLD handling after a vfork, as apparently macOS can mistakenly deliver SIGCHLD to the child. */ if (pty_flag) pid = fork (); else { pid = vfork (); if (pid == 0) signal (SIGCHLD, SIG_DFL); } #else pid = vfork (); #endif With process-connection-type nil, we call vfork() and then setsid() apparently fails (at least to reset child's controlling terminal). I tried to change the above to just use fork(), and got the correct behavior. If only I knew how to fix this correctly, without reverting to fork() :-) Does anyone have ideas? I'll try to look into this further myself, and will write back. Filipp From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 12:25:14 2018 Received: (at 33050) by debbugs.gnu.org; 25 Oct 2018 16:25:14 +0000 Received: from localhost ([127.0.0.1]:42763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFiRe-0000nt-1B for submit@debbugs.gnu.org; Thu, 25 Oct 2018 12:25:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFiRb-0000nd-Jt for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 12:25:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFiRR-0008Nq-D2 for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 12:25:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFiRR-0008Ne-91; Thu, 25 Oct 2018 12:25:01 -0400 Received: from [176.228.60.248] (port=4216 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gFiRP-0007c0-VV; Thu, 25 Oct 2018 12:25:01 -0400 Date: Thu, 25 Oct 2018 19:24:53 +0300 Message-Id: <83ftwuq9ii.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin In-reply-to: (message from Filipp Gunbin on Thu, 25 Oct 2018 18:51:17 +0300) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Filipp Gunbin > Cc: Eli Zaretskii , 33050@debbugs.gnu.org > Date: Thu, 25 Oct 2018 18:51:17 +0300 > > With process-connection-type nil, we call vfork() and then setsid() > apparently fails (at least to reset child's controlling terminal). > > I tried to change the above to just use fork(), and got the correct > behavior. > > If only I knew how to fix this correctly, without reverting to fork() > :-) Does anyone have ideas? I'll try to look into this further myself, > and will write back. I'm probably missing something: why are you still trying to find a solution, when one was already found? What's wrong with setting process-connection-type non-nil in this case, at least for Darwin? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 12:41:17 2018 Received: (at 33050) by debbugs.gnu.org; 25 Oct 2018 16:41:17 +0000 Received: from localhost ([127.0.0.1]:42770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFihB-0001CG-FD for submit@debbugs.gnu.org; Thu, 25 Oct 2018 12:41:17 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:60993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFih9-0001C8-E3 for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 12:41:15 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 0AA74E00; Thu, 25 Oct 2018 12:41:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 12:41:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=9Bfue2ERkAm4DHnMXptwWaMbGj FiMPbLsl0oa3xI3Vo=; b=DDbLOjKRpBC2vTXh3DpoLKBn7OJGUEvg0h5jC9jsPM X4Jl1Z10FvBndtL9RPTmDfmnWjQdgzdJwlX4SzwYGj+/nlY49GLV+azayaEo7EQX gnKB6nwtBJhkQ9jFbd4F1KjuxwNMIW7fltVrEVV1zwTfALvx7lpFg/uhL3hfkP6y 62/GwDQlLc4HLRWocwuCEgS63gRKJI55vh7WUxF7O+DZKLgqYsbyVD54VZ+4u3cy 5D5aB1ZNjc02McLEcySBzMTftyS8qPRubm3Gz8/ESNJISsFkRMrCSzRFyGtLi5b2 iD83ewy4mGdmXBN8YOzqsHPkwqJWe0ICYLNvrST4YJmw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9Bfue2 ERkAm4DHnMXptwWaMbGjFiMPbLsl0oa3xI3Vo=; b=ELECFuvVKtNyOD7GMoWKK2 LreObt6nLVPMuTEnPOLrDXhUqBvlbvUZKm9Rs0I/tLKe7B/TsyHf9/pXjibf6Ff5 uu/HAP0r+K4WHIwUvUftJ8p5f+2yL5V7mb2hv7rBUh6j2vCz4Rec4i69ovCsH2Df 2JgyWnENkmLyFULp93pXGto0KH2h0fd3VyKJU+qmAB0AAMci8xr3Rtz+UDDLIJ1E /bqinRf/kzHrJ92lcy0K4qBCIPFBlDuD1wc4tzZr+LZULn+I8hUdAltEHjtpq+BP RqeuUJpLboYOC63WuymvnzXMfJFgx22CIg2Ul3TGyCTDch+DAYFqDeqPW3Cm59eQ == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 45AA6102EB; Thu, 25 Oct 2018 12:41:12 -0400 (EDT) From: Filipp Gunbin To: alan@idiocy.org Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Filipp Gunbin's message of "Thu, 25 Oct 2018 18:51:17 +0300") References: <83a7n9udxv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Thu, 25 Oct 2018 19:41:10 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , Thomas Fitzsimmons , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Alan, Your commit [1] fixes usage of setsid() on macOS in call_process() (callproc.c), seems that the same thing needs to be done in process.c in create_process(). That setsid() in create_process() seems to be the cause of this thread's bug. WDYT? [1]: commit a13eaddce2ddbe3ba0b7f4c81715bc0fcdba99f6 Author: Alan Third Date: Sun Apr 9 20:10:33 2017 +0100 Filipp From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 13:10:12 2018 Received: (at 33050) by debbugs.gnu.org; 25 Oct 2018 17:10:12 +0000 Received: from localhost ([127.0.0.1]:42780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFj99-0001qr-Rf for submit@debbugs.gnu.org; Thu, 25 Oct 2018 13:10:12 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:40665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFj98-0001qk-FA for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 13:10:10 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 694CAD92; Thu, 25 Oct 2018 13:10:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 13:10:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=Ol6LErPqUH/7tj4VMxxwc7IK9T 6z7Cl4Vr4ydzEvyug=; b=VtJw/afC/CzLs7Qfpx9j97n545tS1ZWiJ/Z3TwFtWa Zi/1+wCS/Jkut8MepHaidAFkGqtPRg2PaTC/zjzdug5zU8P2yHK1OIbNMFFvsvIU Iu19aim2FhFvv7X+aGrktDg+V48OrD8iOKan80vEg7dQ6/kUJ53SLSZe7pyIPJ5i L7f4o6G59cl3sWOugpzKBmEI3nKUdR1ZZY7VLk4HsP9FcW6shfxyk0UXaWUXSBWx b7N3KEHgNWW4Dm05AQI/li5GMXIVEsMpwBTJi3nKgkqRfZ4EFSz5Z5Li/FKSfqBL jf8oS0SJNPu85NXswJmAsre7mUk0Zl7vSpzahIDGNnsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Ol6LEr PqUH/7tj4VMxxwc7IK9T6z7Cl4Vr4ydzEvyug=; b=oPyzDkspJ9HX+uiQVjzX/0 ojz38X4lqUrIpxX8UFBebDyKaRhPjZOJZ6J7vjTpGsKKTuEQMLSlhhbr/XFgDGgb Nj++oOomelxW314yKhHe5VMJuLKoajddm/tsx3yIiVhExEEmd9sneCihldGiU2X0 /cG1LyRySFqn95CtK3N1ZOcIkB7p56IT2BTb+fRDew2mjorqckV3GEoxkWfeotDw IVJz15Qmgs1gQidzzP4P2Xb4aWCnKvMH41EyHOwvfwxRT5M9dejPGKrXLEpb6IF6 np8R+h/Ip3We39ywZaWQvcnrCBa/7qe9SMw68M9pEnmdrJG2WV4PmO3qG3tQwfxw == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 50C30102E8; Thu, 25 Oct 2018 13:10:07 -0400 (EDT) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: <83ftwuq9ii.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Oct 2018 19:24:53 +0300") References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Thu, 25 Oct 2018 20:10:06 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 25/10/2018 19:24 +0300, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Cc: Eli Zaretskii , 33050@debbugs.gnu.org >> Date: Thu, 25 Oct 2018 18:51:17 +0300 >> >> With process-connection-type nil, we call vfork() and then setsid() >> apparently fails (at least to reset child's controlling terminal). >> >> I tried to change the above to just use fork(), and got the correct >> behavior. >> >> If only I knew how to fix this correctly, without reverting to fork() >> :-) Does anyone have ideas? I'll try to look into this further myself, >> and will write back. > > I'm probably missing something: why are you still trying to find a > solution, when one was already found? What's wrong with setting > process-connection-type non-nil in this case, at least for Darwin? Yes, setting p-c-t to t worked from the start, but it's just a workaround - there's still problem with p-c-t nil. I'm currently running with this patch, which is based on Alan's fix in callproc.c (call_process() had the same problem on Darwin). Filipp diff --git a/src/process.c b/src/process.c index 6cda4f27ac..1f8810927d 100644 --- a/src/process.c +++ b/src/process.c @@ -2066,21 +2066,7 @@ create_process (Lisp_Object process, char **new_argv, Lisp_Object current_dir) int volatile forkerr_volatile = forkerr; struct Lisp_Process *p_volatile = p; -#ifdef DARWIN_OS - /* Darwin doesn't let us run setsid after a vfork, so use fork when - necessary. Also, reset SIGCHLD handling after a vfork, as - apparently macOS can mistakenly deliver SIGCHLD to the child. */ - if (pty_flag) - pid = fork (); - else - { - pid = vfork (); - if (pid == 0) - signal (SIGCHLD, SIG_DFL); - } -#else pid = vfork (); -#endif current_dir = current_dir_volatile; lisp_pty_name = lisp_pty_name_volatile; @@ -2091,15 +2077,35 @@ create_process (Lisp_Object process, char **new_argv, Lisp_Object current_dir) p = p_volatile; pty_flag = p->pty_flag; - if (pid == 0) #endif /* not WINDOWSNT */ { +#ifdef DARWIN_OS + /* Work around a macOS bug, where SIGCHLD is apparently + delivered to a vforked child instead of to its parent. See: + https://lists.gnu.org/r/emacs-devel/2017-05/msg00342.html + */ + signal (SIGCHLD, SIG_DFL); +#endif + /* Make the pty be the controlling terminal of the process. */ #ifdef HAVE_PTYS /* First, disconnect its current controlling terminal. Do this even if !PTY_FLAG; see Bug#30762. */ +#ifdef DARWIN_OS + /* Darwin doesn't let us run setsid after a vfork, so use + TIOCNOTTY when necessary. */ + { + int j = emacs_open (DEV_TTY, O_RDWR, 0); + if (j >= 0) + { + ioctl (j, TIOCNOTTY, 0); + emacs_close (j); + } + } +#else setsid (); +#endif /* Make the pty's terminal the controlling terminal. */ if (pty_flag && forkin >= 0) { From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 13:30:02 2018 Received: (at 33050) by debbugs.gnu.org; 25 Oct 2018 17:30:02 +0000 Received: from localhost ([127.0.0.1]:42791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFjSL-0002Jb-U7 for submit@debbugs.gnu.org; Thu, 25 Oct 2018 13:30:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFjSK-0002Iz-GL for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 13:30:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFjSB-00061g-Nv for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 13:29:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFjRl-0005m2-7u; Thu, 25 Oct 2018 13:29:26 -0400 Received: from [176.228.60.248] (port=4216 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gFjRi-0003Dc-V5; Thu, 25 Oct 2018 13:29:25 -0400 Date: Thu, 25 Oct 2018 20:29:12 +0300 Message-Id: <83a7n2q6jb.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin In-reply-to: (message from Filipp Gunbin on Thu, 25 Oct 2018 20:10:06 +0300) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Filipp Gunbin > Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, alan@idiocy.org > Date: Thu, 25 Oct 2018 20:10:06 +0300 > > > I'm probably missing something: why are you still trying to find a > > solution, when one was already found? What's wrong with setting > > process-connection-type non-nil in this case, at least for Darwin? > > Yes, setting p-c-t to t worked from the start, but it's just a > workaround - there's still problem with p-c-t nil. > > I'm currently running with this patch, which is based on Alan's fix in > callproc.c (call_process() had the same problem on Darwin). I don't understand why: using nil process-connection-type for programs that prompt the user is a bug anyway. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 14:10:33 2018 Received: (at 33050) by debbugs.gnu.org; 25 Oct 2018 18:10:33 +0000 Received: from localhost ([127.0.0.1]:42801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFk5Y-0003JB-Cb for submit@debbugs.gnu.org; Thu, 25 Oct 2018 14:10:32 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:47145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFk5W-0003J1-7P for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 14:10:30 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 1C245D61; Thu, 25 Oct 2018 14:10:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 14:10:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=TsmwRpRGlfpllHSAQaxlncWwE/ HVHpJS72Io2QGCZ5E=; b=SB/wxat8iqjs6eta6QU7AcWDX6W2MFaSmv4Hd4Vb6z L1SGN5TSg5XHnhW7m7/f8IZB5Stp7DMFVL2ookAMBX9sRoEFErhvf7Cuvdem3RwW PpCqDsGdi0dDcNRtXFtzn/oaJmHCVQE3xTz5ZzUYQwbba8mTOvjld9eEz3cHj4Vc QbWev8GKohAqVoh5U4vMbeCsAGYsDf/btIUpmRkUMwEoLrzK6vecjhATZav4LgWh 6AlmF6akay1P26NwpWEp1/op1HDeUgrwsqropTUM9RAg+pRaB/Y0efDXjxStTy3k feLivsHe9qNonl4eeltnkqUas8kx650FxQ1HAjFMsw2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=TsmwRp RGlfpllHSAQaxlncWwE/HVHpJS72Io2QGCZ5E=; b=PvoJM2YrO1Grm8GPHU+Wt9 CXdmMVIMBDZ5DNDpG0YFmmwMI9fT+WLD+ZjzxlBoL9SbZjqMHmssb8utfXwQmUo5 1vXmzrgpJntw1rzInWOcov5JbAH7KIs26GPpq8pcG6tkOyhbohQRarSWqilXPvpx xzw/pGINrQzfNd9mvuFFIy03WcXb/Dez4Z2NSXMCOeESaNfcMOfeUcLCcJE0ueN0 RIHueCt3IaXCrsGjKFrXuG8925Eq+5gWfvNAZTeO3mSgFz4afeipniQC1vxiMssU M3Jegae2K8M4upw3o0TW+j1A7ZvWTNDO536zsbBY92uwhr+vccK+Rnq+cUoSOJIA == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F269102F3; Thu, 25 Oct 2018 14:10:27 -0400 (EDT) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: <83a7n2q6jb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Oct 2018 20:29:12 +0300") References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Thu, 25 Oct 2018 21:10:25 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 25/10/2018 20:29 +0300, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, alan@idiocy.org >> Date: Thu, 25 Oct 2018 20:10:06 +0300 >> >> > I'm probably missing something: why are you still trying to find a >> > solution, when one was already found? What's wrong with setting >> > process-connection-type non-nil in this case, at least for Darwin? >> >> Yes, setting p-c-t to t worked from the start, but it's just a >> workaround - there's still problem with p-c-t nil. >> >> I'm currently running with this patch, which is based on Alan's fix in >> callproc.c (call_process() had the same problem on Darwin). > > I don't understand why: using nil process-connection-type for programs > that prompt the user is a bug anyway. I think these are separate problems. Here's my explanation of this problem on Darwin: Some time ago, setsid() was called only if (pty_flag). Alan's commit a13eaddce2ddbe3ba0b7f4c81715bc0fcdba99f6 (fixes bug 26397) changes vfork() to fork() for this case - so we never call setsid() after vfork(). Then Paul's commit 5c91ca8f30098cb2593ca375daa82d25aef03ad7 (fixes bug 30762) changes setsid() to be invoked always. So it again became possible that we call setsid() after vfork(), and this I believe is the root case of the current problem. My patch tries to fix that. I don't think it matters here whether we call ldapsearch with correct value of p-c-t or not, it just the case which was missed. And vfork() should perform better than fork(), so it looks like an improvement. Filipp From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 14:20:46 2018 Received: (at 33050) by debbugs.gnu.org; 25 Oct 2018 18:20:46 +0000 Received: from localhost ([127.0.0.1]:42806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFkFR-0003aw-Ps for submit@debbugs.gnu.org; Thu, 25 Oct 2018 14:20:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFkFP-0003ad-VW for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 14:20:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFkFH-0002v2-CI for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 14:20:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFkEx-0002mh-N2; Thu, 25 Oct 2018 14:20:15 -0400 Received: from [176.228.60.248] (port=3391 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gFkEv-000747-Vo; Thu, 25 Oct 2018 14:20:15 -0400 Date: Thu, 25 Oct 2018 21:20:03 +0300 Message-Id: <837ei5rir0.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin In-reply-to: (message from Filipp Gunbin on Thu, 25 Oct 2018 21:10:25 +0300) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Filipp Gunbin > Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, alan@idiocy.org > Date: Thu, 25 Oct 2018 21:10:25 +0300 > > On 25/10/2018 20:29 +0300, Eli Zaretskii wrote: > > >> From: Filipp Gunbin > >> Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, alan@idiocy.org > >> Date: Thu, 25 Oct 2018 20:10:06 +0300 > >> > >> > I'm probably missing something: why are you still trying to find a > >> > solution, when one was already found? What's wrong with setting > >> > process-connection-type non-nil in this case, at least for Darwin? > >> > >> Yes, setting p-c-t to t worked from the start, but it's just a > >> workaround - there's still problem with p-c-t nil. > >> > >> I'm currently running with this patch, which is based on Alan's fix in > >> callproc.c (call_process() had the same problem on Darwin). > > > > I don't understand why: using nil process-connection-type for programs > > that prompt the user is a bug anyway. > > I think these are separate problems. They are, indeed; and I thought this bug report is about the problem with ldapsearch. If you think the way we start subprocesses on macOS needs fixing, it should be a separate bug, most probably with a different urgency and severity. > So it again became possible that we call setsid() after vfork(), and > this I believe is the root case of the current problem. Once again, I believe the root cause is that process-connection-type has the wrong value. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 15:36:57 2018 Received: (at 33050) by debbugs.gnu.org; 25 Oct 2018 19:36:57 +0000 Received: from localhost ([127.0.0.1]:42845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFlRA-0005cY-S6 for submit@debbugs.gnu.org; Thu, 25 Oct 2018 15:36:57 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:42973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFlR9-0005cH-7k for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 15:36:55 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 270CECF5; Thu, 25 Oct 2018 15:36:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 15:36:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=5dQGMaIazQPO7fXxqr6IjQTTTq eLGP27d1Og78aUYNE=; b=FhZMv/ykhPNjn0Ax8qV+vMbB9wPKTxaRx6+iXHPcfI k84i3eWYlOCO7LJxuqKNOq8YSCbuOjMvUt0eUs+5Us70+u0jCJM/a9KBGBiTEdsC 75OGXW7CAcATwjMjqpIzRSruD2aoQ/Zqhl2HDhiqedFbZZ/6w/reRbcGLJjIxDda aZ9EKi5kHgG/o6hbGeiYYZzf1EAN8IJ0s9UJfYHdU0Hz8TnUr/mdAZuxTjJ65OwI 9F9utH48uA68rwcoQJLW6EOXz7DBjuZU5XUnqsq+uEqXwrZ2yIQbUZIa6KVU5bvF CichKv2qlwNcyXjREGDM37+eetQsMXskJlIsP+aTRdrg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5dQGMa IazQPO7fXxqr6IjQTTTqeLGP27d1Og78aUYNE=; b=i08Z+b0wHpuYFOsspR6ymL ubvY3vQbdgG58tPsGJMSY6BHWzygrK+lEvIWuQ0kRUfwCj3D7BKw/0ZiZ2uz0Udz etJJ7cC0LMcrLA65Qoa6L5vFqsDwUy1k4WiuFA6jDZXELp7JzYJ2dfQxZb65wPuf Sa8R7ENqWEHibZgWiivO3gYXt4/yGveH4UDjRS/ikuzn9pdPx2AdhhzuMUeDybzm A5FxM4KLV/1F+AC6BCUwHC2MpW3luZannm/pQR6BeGGmhp4399+hv2iA14zdUlvM nBixyo8u7Comr8eDJSwA6YDCBBJZZsJymSMNdEBFmEu75cNxSrz7iwZQVXX15OoA == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id DFEC1102EB; Thu, 25 Oct 2018 15:36:51 -0400 (EDT) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: <837ei5rir0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Oct 2018 21:20:03 +0300") References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <837ei5rir0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Thu, 25 Oct 2018 22:36:50 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli, On 25/10/2018 21:20 +0300, Eli Zaretskii wrote: >> I think these are separate problems. > > They are, indeed; and I thought this bug report is about the problem > with ldapsearch. If you think the way we start subprocesses on macOS > needs fixing, it should be a separate bug, most probably with a > different urgency and severity. Sure, filed bug #33154. >> So it again became possible that we call setsid() after vfork(), and >> this I believe is the root case of the current problem. > > Once again, I believe the root cause is that process-connection-type > has the wrong value. I have no opinion on the correctness of p-c-t in ldap-search-internal in ldap.el. If 33154 gets fixed, then code in ldap.el works regardless of its value. Filipp From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 15:41:19 2018 Received: (at 33050) by debbugs.gnu.org; 25 Oct 2018 19:41:19 +0000 Received: from localhost ([127.0.0.1]:42850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFlVP-0005j6-Di for submit@debbugs.gnu.org; Thu, 25 Oct 2018 15:41:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFlVL-0005io-Hv for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 15:41:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFlVC-0005cB-EB for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 15:41:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFlUv-0005WB-Uc; Thu, 25 Oct 2018 15:40:50 -0400 Received: from [176.228.60.248] (port=4684 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gFlUu-0005n0-PT; Thu, 25 Oct 2018 15:40:49 -0400 Date: Thu, 25 Oct 2018 22:40:42 +0300 Message-Id: <834ld9rf0l.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin In-reply-to: (message from Filipp Gunbin on Thu, 25 Oct 2018 22:36:50 +0300) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <837ei5rir0.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Filipp Gunbin > Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, alan@idiocy.org > Date: Thu, 25 Oct 2018 22:36:50 +0300 > > > Once again, I believe the root cause is that process-connection-type > > has the wrong value. > > I have no opinion on the correctness of p-c-t in ldap-search-internal in > ldap.el. If 33154 gets fixed, then code in ldap.el works regardless of > its value. Is this bug important to fix, or can it wait for Emacs 27? If it cannot wait, then setting process-connection-type non-nil is the only way we can have it fixed on the release branch, because changes like those which you propose for process.c can only go to master. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 16:47:06 2018 Received: (at 33050) by debbugs.gnu.org; 25 Oct 2018 20:47:06 +0000 Received: from localhost ([127.0.0.1]:42929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFmX4-0000zN-HI for submit@debbugs.gnu.org; Thu, 25 Oct 2018 16:47:06 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:58043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFmX3-0000zG-8u for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 16:47:05 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 1BE5ECE9; Thu, 25 Oct 2018 16:47:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 16:47:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=ilZayWjL/uiSAp1Bcs9XNZPz2R BoVudM3SsPUmbPv18=; b=DOSM9RZthf/P1ZdC966INLS80ZxdCpfFc2VjDFSWxi zcKYPzpAVyOHmCNbjG/IDaWCmmlDl9rEneM1utOOhipschROkGQ4T5tKaAQK2kyx utRvIbBie9ty9zACZqftm5xzjsNea6VlODq4sgfL/+YdYM80UyrOnISC8VvRe0lI FFyA+dfM/1KmFh1iBFy4FssKCYqRi12/ZUesiBN6JLjE0rXqFv42+towpDOdcHD/ dVb7Q1g73zWH7VXDa8xGr8SKlCAlnw0Mgov32nwSmEfHmaGrK1CdfRubrvI6cvZ4 EM3LS00Mdj1Mz1S7QMvBple7n8K5TS8isMVvzQpg16sg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ilZayW jL/uiSAp1Bcs9XNZPz2RBoVudM3SsPUmbPv18=; b=dZe7KyJagPDQP3u+ocXqQB WTBgeg83VxRSaTKu86ox22hf26S56y0h7fkad5uY9j0iw1q8Kp4xqeUXlUT9pKSo dOV+4yfSmUa1Re/JpzlnuAzX8cnfQRAdbJpU2VpFqe36VUN8h63MLFv7SsnF7SvQ wR4O+hnRw1XvwgYox/iA2tNkRTbl02kjIhd0gZHRIjzDtzGnjkYokSTgdoEJNGSr eUu5XB+cLm/0Tizv4ftMIZ8N+ERmIn4zb9y6rQuWdTdkwqBEZCA2fSOUCeq6tEqn FZr1hnaoWp7+ymFWz3ONS8/g4GyP80L2JLNc/lWFpW/R8YWYv/uE9kjn0BH34YdQ == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 0E5B6102F5; Thu, 25 Oct 2018 16:47:01 -0400 (EDT) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: <834ld9rf0l.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Oct 2018 22:40:42 +0300") References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <837ei5rir0.fsf@gnu.org> <834ld9rf0l.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Thu, 25 Oct 2018 23:47:00 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 25/10/2018 22:40 +0300, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, alan@idiocy.org >> Date: Thu, 25 Oct 2018 22:36:50 +0300 >> >> > Once again, I believe the root cause is that process-connection-type >> > has the wrong value. >> >> I have no opinion on the correctness of p-c-t in ldap-search-internal in >> ldap.el. If 33154 gets fixed, then code in ldap.el works regardless of >> its value. > > Is this bug important to fix, or can it wait for Emacs 27? If it > cannot wait, then setting process-connection-type non-nil is the only > way we can have it fixed on the release branch, because changes like > those which you propose for process.c can only go to master. If someone could confirm that setting process-connection-type to t (ldap.el, line 649) doesn't break it on GNU/Linux, then I think it's good to have it on release branch. This bug prevents at least eudc-expand-inline with ldap on macOS from working. Filipp From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 21:36:56 2018 Received: (at 33050) by debbugs.gnu.org; 26 Oct 2018 01:36:56 +0000 Received: from localhost ([127.0.0.1]:43051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFr3Y-0007wK-0N for submit@debbugs.gnu.org; Thu, 25 Oct 2018 21:36:56 -0400 Received: from mail-it1-f179.google.com ([209.85.166.179]:36252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFr3V-0007w8-4n for 33050@debbugs.gnu.org; Thu, 25 Oct 2018 21:36:54 -0400 Received: by mail-it1-f179.google.com with SMTP id h14-v6so4259156itf.1 for <33050@debbugs.gnu.org>; Thu, 25 Oct 2018 18:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=odtpAEft2O9ePBMYqWrxaaQCQsnJkWeQ8/2nn4bh4Tw=; b=lXMQCLAABIQ75CVJ62b/1ct0X6pLsL0dxp8Ydfin0gapqnQZm7gyshUhXWd8VICPRz 3dV/shJix81jRh6o2gjlPO7hxqiRKFd09w1PjYFt8kz5Om2tbrglRVhbo3ytzeSz+iii kvkzGwPk/WMLdWAjI89oizk+Xd6/DESk+px+t/SDQej/ud+IX9V/EvG75K8ngZFsRONb FA3oZH16LDdQWJbRq9/INg2nHXP/cgJUFV+1VZLCPzcAjXhGfkK0H78cC2Llot1OLArW 3oiUy/2g1na1aCwEfjSkjN7zYpVvSyA4seAmlkl8B4sTtmZd22bOAKBZVU533U/SU2gH O0LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=odtpAEft2O9ePBMYqWrxaaQCQsnJkWeQ8/2nn4bh4Tw=; b=qlVQFCjpOnfViEGi1lRQYg7cqDA+RPhQWGerA23KO07IITzG50DXbmmOWNFoH+tyia GCPTQBhjvxsuI5dHvMTqVaNu0ayLpNptdo1gXLonsHCwGn90qOoJsrOH+fu6AgA+d1ZJ USSSI6X+/wuLjqZIvtfCd+xwHkcoo+JcxLzK1UrtLuQKi+X9ThRBKeavmiCO0vm7kRKq LcTGkQyxKqWdng6BmGiAVyxkcLqUXhQKWMFGM/oH83+NbrqLVWAyP6aHWd1ohaKH1o7u 7qbHkfA9LbROLwn5Tqbtd4omvNk1OHp3FmP0SMBdUoy/paRveYPFzgG+gV6VmtKJMbF0 raYQ== X-Gm-Message-State: AGRZ1gIksCREDBr4S19nCM2GKdOJ9+GNSOcvlw18FneFvSqLw2f3D82L /aPSpgIQ1VMJfv/n7T+524R3iA== X-Google-Smtp-Source: AJdET5dSpgcb5pwHOEHv7vuMnpOZ95Oga+bZsrrqzc+S4CkrumTX9SiuQoFa0swAyWgg2VQ2kAhbnw== X-Received: by 2002:a05:660c:510:: with SMTP id d16mr2275415itk.109.1540517807505; Thu, 25 Oct 2018 18:36:47 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id p16-v6sm1373116itc.42.2018.10.25.18.36.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 18:36:46 -0700 (PDT) From: Thomas Fitzsimmons To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> Date: Thu, 25 Oct 2018 21:41:34 -0400 In-Reply-To: <83a7n2q6jb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Oct 2018 20:29:12 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, Filipp Gunbin , alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, Eli Zaretskii writes: >> From: Filipp Gunbin >> Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, alan@idiocy.org >> Date: Thu, 25 Oct 2018 20:10:06 +0300 >>=20 >> > I'm probably missing something: why are you still trying to find a >> > solution, when one was already found? What's wrong with setting >> > process-connection-type non-nil in this case, at least for Darwin? >>=20 >> Yes, setting p-c-t to t worked from the start, but it's just a >> workaround - there's still problem with p-c-t nil. >>=20 >> I'm currently running with this patch, which is based on Alan's fix in >> callproc.c (call_process() had the same problem on Darwin). > > I don't understand why: using nil process-connection-type for programs > that prompt the user is a bug anyway. I'm interested to know why you think this is a bug (or even not preferable) in the specific case of ldap.el. When ldap.el calls ldapsearch, ldapsearch doesn't prompt the user for the password directly. ldap.el (having pre-read the password into Elisp by various means) runs the command, and, in response to its prompt, sends it the password. I re-read the Elisp "Asynchronous Processes" node; when I was deciding how to set process-connection-type, I think I was following the _underlined_ part in: [...] If available, ptys are usually preferable for processes visible to the user, as in Shell mode, because they allow for job control (=E2=80=98C-c=E2=80=99, =E2=80=98C-z=E2=80=99, etc.) between the process= and its children, and because interactive programs treat ptys as terminal devices, whereas pipes don=E2=80=99t support these features. However, _for subprocesses = used by Lisp programs for internal purposes, it is often better to use a pipe_, because pipes are more efficient, and because they are immune to stray character injections that ptys introduce for large (around 500 byte) messages. Also, the total number of ptys is limited on many systems and it is good not to waste them. Given that ldapsearch can operate over a pipe (i.e., doesn't need terminal features, seems to be unaffected by buffering), and is used for internal purposes (i.e., is not visible to the user) isn't pipe mode preferable for the reasons given there? ldapsearch works for me on GNU/Linux either way, and I don't mind changing process-connection-type to t on the release branch to work around the Darwin behaviour. But if ldap.el's current setting of process-connection-type really is a flat out bug then the Elisp manual might need clarification or stronger language about when not to set it to "pipe mode". Thanks, Thomas From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 02:30:11 2018 Received: (at 33050) by debbugs.gnu.org; 26 Oct 2018 06:30:11 +0000 Received: from localhost ([127.0.0.1]:43110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFvdL-0006u5-0V for submit@debbugs.gnu.org; Fri, 26 Oct 2018 02:30:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFvdI-0006sx-OY for 33050@debbugs.gnu.org; Fri, 26 Oct 2018 02:30:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFvd9-0003Ux-4t for 33050@debbugs.gnu.org; Fri, 26 Oct 2018 02:30:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFvct-0003I8-7e; Fri, 26 Oct 2018 02:29:43 -0400 Received: from [176.228.60.248] (port=4802 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gFvcs-0008Ms-Qv; Fri, 26 Oct 2018 02:29:43 -0400 Date: Fri, 26 Oct 2018 09:29:43 +0300 Message-Id: <83zhv1p6eg.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin In-reply-to: (message from Filipp Gunbin on Thu, 25 Oct 2018 23:47:00 +0300) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <837ei5rir0.fsf@gnu.org> <834ld9rf0l.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Filipp Gunbin > Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, alan@idiocy.org > Date: Thu, 25 Oct 2018 23:47:00 +0300 > > > Is this bug important to fix, or can it wait for Emacs 27? If it > > cannot wait, then setting process-connection-type non-nil is the only > > way we can have it fixed on the release branch, because changes like > > those which you propose for process.c can only go to master. > > If someone could confirm that setting process-connection-type to t > (ldap.el, line 649) doesn't break it on GNU/Linux, then I think it's > good to have it on release branch. This bug prevents at least > eudc-expand-inline with ldap on macOS from working. We could make the change conditional on macOS, if we want to be extra-careful. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 03:01:30 2018 Received: (at 33050) by debbugs.gnu.org; 26 Oct 2018 07:01:30 +0000 Received: from localhost ([127.0.0.1]:43124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFw7e-0007ib-1m for submit@debbugs.gnu.org; Fri, 26 Oct 2018 03:01:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFw7b-0007iJ-Uf for 33050@debbugs.gnu.org; Fri, 26 Oct 2018 03:01:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFw7R-0004Br-LY for 33050@debbugs.gnu.org; Fri, 26 Oct 2018 03:01:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFw6h-0003pY-Lv; Fri, 26 Oct 2018 03:00:31 -0400 Received: from [176.228.60.248] (port=2738 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gFw6h-0005wZ-7m; Fri, 26 Oct 2018 03:00:31 -0400 Date: Fri, 26 Oct 2018 10:00:31 +0300 Message-Id: <83sh0tp4z4.fsf@gnu.org> From: Eli Zaretskii To: Thomas Fitzsimmons In-reply-to: (message from Thomas Fitzsimmons on Thu, 25 Oct 2018 21:41:34 -0400) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Thomas Fitzsimmons > Cc: Filipp Gunbin , 33050@debbugs.gnu.org, alan@idiocy.org > Date: Thu, 25 Oct 2018 21:41:34 -0400 > > > I don't understand why: using nil process-connection-type for programs > > that prompt the user is a bug anyway. > > I'm interested to know why you think this is a bug (or even not > preferable) in the specific case of ldap.el. When ldap.el calls > ldapsearch, ldapsearch doesn't prompt the user for the password > directly. ldap.el (having pre-read the password into Elisp by various > means) runs the command, and, in response to its prompt, sends it the > password. First, I must apologize in advance: I might be mis-interpreting the situation, because I don't use ldap.el or ldapsearch. In that case, what I said before and what I say below might not make sense. That said, my rationale was simple: _any_ program that interacts with the user will generally behave better when connected through pty than when connected through a pipe, because the former looks and feels as a terminal, and thus will cause the program to use the appropriate buffering, will support terminal-only features like various escape sequences, cursor control, job control, etc. Using pipes will probably work in most cases, but might fail in some of them, so good engineering tells us to prefer pty's, like the ELisp manual says. > I re-read the Elisp "Asynchronous Processes" node; when I was deciding > how to set process-connection-type, I think I was following the > _underlined_ part in: > > [...] If available, ptys are usually preferable for processes visible > to the user, as in Shell mode, because they allow for job control > (‘C-c’, ‘C-z’, etc.) between the process and its children, and > because interactive programs treat ptys as terminal devices, whereas > pipes don’t support these features. However, _for subprocesses used > by Lisp programs for internal purposes, it is often better to use a > pipe_, because pipes are more efficient, and because they are immune > to stray character injections that ptys introduce for large (around > 500 byte) messages. Also, the total number of ptys is limited on > many systems and it is good not to waste them. > > Given that ldapsearch can operate over a pipe (i.e., doesn't need > terminal features, seems to be unaffected by buffering), and is used for > internal purposes (i.e., is not visible to the user) isn't pipe mode > preferable for the reasons given there? Not in my opinion, no. AFAIU, the efficiency considerations don't really apply here, since the amount of data exchanged is small (right?). All in all, I consider the "however" part above too vague to be useful (what exactly does "internal purposes" mean in this context?). I think it's even slightly misleading. I'll think about rewording it to make the point more clear and the decision easier. > But if ldap.el's current setting of process-connection-type really > is a flat out bug then the Elisp manual might need clarification or > stronger language about when not to set it to "pipe mode". Agreed. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 11:36:15 2018 Received: (at 33050) by debbugs.gnu.org; 26 Oct 2018 15:36:15 +0000 Received: from localhost ([127.0.0.1]:44254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gG49m-0005Ue-Qh for submit@debbugs.gnu.org; Fri, 26 Oct 2018 11:36:15 -0400 Received: from mail-it1-f172.google.com ([209.85.166.172]:35430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gG49l-0005UR-01 for 33050@debbugs.gnu.org; Fri, 26 Oct 2018 11:36:13 -0400 Received: by mail-it1-f172.google.com with SMTP id p64-v6so2188376itp.0 for <33050@debbugs.gnu.org>; Fri, 26 Oct 2018 08:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=6tdIgKSJsZDImL03TomxlM6hdBvS3oCOfqaCuDmQ/WU=; b=Ls3g33xl1HYdpG8pOgTGhLur0QIJd/h8VZ0aWH8RXqzH/+3Ww5oxWJxzTSC0DRbZ8d 5VKwtmVjacmCThHz5h9pzYqkMZeYu49iudFafuUQ1WVkfioxmIaZ3Q+kJLK7VffE8TST aiydPpfs6upPNLEdsRe+5rY7RzQnZGxv7rEB6AlYs3Rxq5q6d7TDDf+dKn428WUuCZeq qbtM8cChF0wVaG1gJCYiSWt1oYY3iH9WNVVLD93RtcwDhc9rSEDIKAsuy9nmCZedfgkG f3bpDqjYnpG1Ew8aDcJGKdtU+w5ex4QEViwSaF7ADOBytXowDAzJMkCZNz+xIHSYCRfj E7bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=6tdIgKSJsZDImL03TomxlM6hdBvS3oCOfqaCuDmQ/WU=; b=obent82YeXCpeMR+kD0Qrj8AI7v97/ZJ52h5euZ7xk3cAfww/E/RdFqSLEZwayqFRd fmv66141mTPp4389e+wLkhxItgZkgbL31fboZEra1D1NnoISCawq1ebnjPXQKudBGvC9 0+dr8VSypwLiyryBUB78dNujSHSU/xHcOeqhHvX2DFS6I6sCmsdFGP5eAuU/5v+BzzNE gnpvGLlF3hNk9rlZmIxn6+j1ixtGBCgwquzgkOib5nyj7dKLxES1APCKUWFpLzbwUx2l q3yUF7f0ZP6UAIAtSrunikSllnJc3wr4w/ZaGXG5mZX3ORK49MWHjMBp52jl8gmDULhp Rlpg== X-Gm-Message-State: AGRZ1gKW4G+S+aMIu76hab+PqUNIreQknGufJtjNpw/JceLqVqkr03QC A6KfQYKAFwXS9mYeJxLMWHn+3Q== X-Google-Smtp-Source: AJdET5fYsoF95U0OacZT0f/xagvW5WnvwsxyEPLdbZEkKwx/gWTHFxaxY4wPx08YEs4TghOP81tD/g== X-Received: by 2002:a24:d703:: with SMTP id y3-v6mr4294125itg.154.1540568167065; Fri, 26 Oct 2018 08:36:07 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id d8sm2069869itk.38.2018.10.26.08.36.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 08:36:06 -0700 (PDT) From: Thomas Fitzsimmons To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> Date: Fri, 26 Oct 2018 11:41:02 -0400 In-Reply-To: <83sh0tp4z4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Oct 2018 10:00:31 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Thomas Fitzsimmons >> Cc: Filipp Gunbin , 33050@debbugs.gnu.org, alan@i= diocy.org >> Date: Thu, 25 Oct 2018 21:41:34 -0400 >>=20 >> > I don't understand why: using nil process-connection-type for programs >> > that prompt the user is a bug anyway. >>=20 >> I'm interested to know why you think this is a bug (or even not >> preferable) in the specific case of ldap.el. When ldap.el calls >> ldapsearch, ldapsearch doesn't prompt the user for the password >> directly. ldap.el (having pre-read the password into Elisp by various >> means) runs the command, and, in response to its prompt, sends it the >> password. > > First, I must apologize in advance: I might be mis-interpreting the > situation, because I don't use ldap.el or ldapsearch. In that case, > what I said before and what I say below might not make sense. > > That said, my rationale was simple: _any_ program that interacts with > the user will generally behave better when connected through pty than > when connected through a pipe, because the former looks and feels as a > terminal, and thus will cause the program to use the appropriate > buffering, will support terminal-only features like various escape > sequences, cursor control, job control, etc. Using pipes will > probably work in most cases, but might fail in some of them, so good > engineering tells us to prefer pty's, like the ELisp manual says. OK, this makes sense, thanks for providing the rationale. Given that ldapsearch does issue a human-readable prompt for the password, it was likely written and tested assuming a pty. >> I re-read the Elisp "Asynchronous Processes" node; when I was deciding >> how to set process-connection-type, I think I was following the >> _underlined_ part in: >>=20 >> [...] If available, ptys are usually preferable for processes visible >> to the user, as in Shell mode, because they allow for job control >> (=E2=80=98C-c=E2=80=99, =E2=80=98C-z=E2=80=99, etc.) between the proc= ess and its children, and >> because interactive programs treat ptys as terminal devices, whereas >> pipes don=E2=80=99t support these features. However, _for subprocess= es used >> by Lisp programs for internal purposes, it is often better to use a >> pipe_, because pipes are more efficient, and because they are immune >> to stray character injections that ptys introduce for large (around >> 500 byte) messages. Also, the total number of ptys is limited on >> many systems and it is good not to waste them. >>=20 >> Given that ldapsearch can operate over a pipe (i.e., doesn't need >> terminal features, seems to be unaffected by buffering), and is used for >> internal purposes (i.e., is not visible to the user) isn't pipe mode >> preferable for the reasons given there? > > Not in my opinion, no. AFAIU, the efficiency considerations don't > really apply here, since the amount of data exchanged is small > (right?). Right. > All in all, I consider the "however" part above too vague to be useful > (what exactly does "internal purposes" mean in this context?). I > think it's even slightly misleading. I'll think about rewording it to > make the point more clear and the decision easier. OK, sounds good. One worry I have about always leaving process-connection-type t is that, depending on the external system state -- specifically whether or not all ptys are busy -- process-connection-type might not have any effect, and the underlying process will rarely (and silently AFAICT) operate in pipe mode. By forcing process-connection-type nil, one is always testing in the same known mode. That said, it is probably a bad idea to warn or signal an error if all ptys are busy in the p-c-t t case. Anyway, I thought I'd mention it; maybe the documentation update can address this point as well. How about I make the change conditional on Mac OS on the release branch, and unconditional on the master branch (once the fix for 33154 is committed)? That way users on the master branch will be able to test pty mode before the next release, and we fix the release branch without potentially destabilizing non-Darwin users. Thomas From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 13:20:49 2018 Received: (at 33050) by debbugs.gnu.org; 26 Oct 2018 17:20:49 +0000 Received: from localhost ([127.0.0.1]:44304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gG5mz-00080Q-0Q for submit@debbugs.gnu.org; Fri, 26 Oct 2018 13:20:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gG5mx-00080A-7f for 33050@debbugs.gnu.org; Fri, 26 Oct 2018 13:20:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gG5mo-0001dA-1s for 33050@debbugs.gnu.org; Fri, 26 Oct 2018 13:20:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG5mP-0001RQ-FO; Fri, 26 Oct 2018 13:20:14 -0400 Received: from [176.228.60.248] (port=1603 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gG5mO-0005t5-Kh; Fri, 26 Oct 2018 13:20:13 -0400 Date: Fri, 26 Oct 2018 20:20:14 +0300 Message-Id: <83y3akoca9.fsf@gnu.org> From: Eli Zaretskii To: Thomas Fitzsimmons In-reply-to: (message from Thomas Fitzsimmons on Fri, 26 Oct 2018 11:41:02 -0400) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Thomas Fitzsimmons > Cc: fgunbin@fastmail.fm, 33050@debbugs.gnu.org, alan@idiocy.org > Date: Fri, 26 Oct 2018 11:41:02 -0400 > > That said, it is probably a bad idea to warn or signal an error if all > ptys are busy in the p-c-t t case. Anyway, I thought I'd mention it; > maybe the documentation update can address this point as well. Right, thanks for pointing that out. > How about I make the change conditional on Mac OS on the release branch, > and unconditional on the master branch (once the fix for 33154 is > committed)? Sounds good to me, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 19:12:27 2018 Received: (at 33050) by debbugs.gnu.org; 26 Oct 2018 23:12:27 +0000 Received: from localhost ([127.0.0.1]:44435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGBHG-0007rZ-V1 for submit@debbugs.gnu.org; Fri, 26 Oct 2018 19:12:27 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:37345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGBHF-0007rS-59 for 33050@debbugs.gnu.org; Fri, 26 Oct 2018 19:12:25 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DE23021E06; Fri, 26 Oct 2018 19:12:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 26 Oct 2018 19:12:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=vnUlNNeVvRKEfsuWs6XEar44YO p1TymjGLeBEJNJwMs=; b=snP9O34B+uIBgWc4Yt0huKgLhnhZ31ks3ypBLfiGGz CZ3W+ecU0LsuLz6mqA1qXx7+5cUGEyBIillo6tuDVciBGQlVpMSh4BTPAPmCEqz2 rpjmKfe0+XudE8xU2cLvbRzhOOndqUuFEid15Yi3LfWNtL9W2EcGWFuMHrAfOb5V eaZ+/XnGmY2VP0HICaumj9WTOssO2C6kfrTZqNnTFD+nttRUpXWy9DLaz4HNJssb QNs1z84mJbSejSHPax+siwAQk5wnY4BsW3Vaic+ppkS6W8THbVFNumGWNaH9i5NR oq/6NwhpZ29bPNpvvc3gr5klMxGGGrRHkV7Xs4ED+aMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=vnUlNN eVvRKEfsuWs6XEar44YOp1TymjGLeBEJNJwMs=; b=rs/cQXjT8aArbTFdElK2FX xA9qrLlGymq/Gh47r4jQ10SyCAAIAT/LkrarVuKgznZ0+1uh26LAJJDv529/PgIa vOIU8S+4eqs7tAVT3Pil7joGzwbAU0ZUkD531qEmtBe05F8mvjwrFlNALgyu+j1e F1tg2Xlr7HbbzrdbBP0OqDH8YCn3r7B2tbqJCrZnnN22Iym84oD6/Yl1mQa7Qn1Q XptaCxv7je5XCWSBLQNCvowxqfanvY2nS4SMT35YMXfvboDjQxWwPn5JGVdHC3Oj iUjPR80qUBc6K4z2ZqY+5ecgG71LEHLEOhhGgQatyT2fFvvNbuRsQb/CXVW2Jf7A == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 6F49E102A0; Fri, 26 Oct 2018 19:12:23 -0400 (EDT) From: Filipp Gunbin To: Thomas Fitzsimmons Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Thomas Fitzsimmons's message of "Fri, 26 Oct 2018 11:41:02 -0400") References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Sat, 27 Oct 2018 02:12:21 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thomas, On 26/10/2018 11:41 -0400, Thomas Fitzsimmons wrote: > One worry I have about always leaving process-connection-type t is > that, depending on the external system state -- specifically whether > or not all ptys are busy -- process-connection-type might not have any > effect, and the underlying process will rarely (and silently AFAICT) > operate in pipe mode. By forcing process-connection-type nil, one is > always testing in the same known mode. I don't really understand why pty mode is better here than pipe mode. Do we need job control, or escape sequences, or anything else specific to pty? If we use pty, won't these features, on the contrary, get in the way somewhere? We have to respond to only one prompt from ldapsearch, and for that pipes should work well. It's not like when the user is interacting with the process (like in shell mode). The user may be unaware that external process is at all invoked. Your suggestion to condionally fix this for Darwin on release looks good. As for 33154, I'll live with it for some more days, and wait for more people to look at it. And if all goes well, then I'll push it next week. Thanks. Filipp From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 22:04:38 2018 Received: (at 33050) by debbugs.gnu.org; 27 Oct 2018 02:04:38 +0000 Received: from localhost ([127.0.0.1]:44474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGDxu-0003Ti-3T for submit@debbugs.gnu.org; Fri, 26 Oct 2018 22:04:38 -0400 Received: from mail-it1-f182.google.com ([209.85.166.182]:36542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGDxs-0003TU-7X for 33050@debbugs.gnu.org; Fri, 26 Oct 2018 22:04:36 -0400 Received: by mail-it1-f182.google.com with SMTP id h14-v6so3901580itf.1 for <33050@debbugs.gnu.org>; Fri, 26 Oct 2018 19:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=gbNC3srVzBt/lsgfJ0tKuqCOIcIXby3TwjiRSKkfI+Y=; b=bamu8hVZdCjoz77Trt1t6mUThhTt3cg0/aL1x0lo2u2WQdtL/j7NZlNuNGdO2Tpu1L zr/78JurytqASmImm3KhTsL4OvxZASRseEXwjzsou0+1eM+AT5C3EFjDtojeMvTnF13I Kc/ebaDiNfliOqPdj7rG0VtlVxgfogARANKfZdDqtzyX2vDzpGX2I+lZxTmaumTmPI7K eZCI2vdyvRxT56+B8iUC49Z6bA1IHsgwk4iik232EQS1rilVui3ixYx8D6C5wq3m9Gfu YWeE1QeWuVxXVnyhZ48BKHkTiQMJs3P0N75Y3Tr7d09Bk/c2jkwAtEqzB/ZSjIVLr9B6 JfEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=gbNC3srVzBt/lsgfJ0tKuqCOIcIXby3TwjiRSKkfI+Y=; b=lq2TCIZuyg+lQ67qQxVzIZOVrXasvWMS7rNO00IfYpgF+8KeuWkLbtnUE/UnGnFbhT qi2IwSPLMz9CPlyjnD9GPnVOKQyhizZ+IMEJrhCG+GMPiT6N4KPF4jYNZApnZSvoiFzf wqlMhiVupYrFqNv7hOvR8UpOwTiNUP8XlRAM1DMwil6Ifw7fggDQHceg+EiXE2ONFRBN o8EP08IAcvd+wkbkR30+kVBGGOWbj+e5G1wUeHXQ3FjBpdhETEfN7Bg4K3J9Nn4UWU4/ P+9btMyiUne5avJQW3ZNNVADlvJTgAixz7RtA8Y2ZWePK5DWAx59d5EwldUjk6xozCaD NCIQ== X-Gm-Message-State: AGRZ1gLRDTr++kXKRBXPaQblt+BQktAljUwuuKB5j/p74tYH2c15pQB8 u1EjB0m5il8UVIISh+7O0JCAsw== X-Google-Smtp-Source: AJdET5drchy82+HU2fWWsXyCIVV93BgsHnKUBjYPgLaX1U6RjG9qxOFVOHSYqm7ojIGVBTzuy95rDg== X-Received: by 2002:a05:660c:74d:: with SMTP id a13mr4531502itl.64.1540605870365; Fri, 26 Oct 2018 19:04:30 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id w134-v6sm2792817itc.12.2018.10.26.19.04.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 19:04:27 -0700 (PDT) From: Thomas Fitzsimmons To: Filipp Gunbin Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> Date: Fri, 26 Oct 2018 22:09:28 -0400 In-Reply-To: (Filipp Gunbin's message of "Sat, 27 Oct 2018 02:12:21 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Filipp Gunbin writes: > Thomas, > > On 26/10/2018 11:41 -0400, Thomas Fitzsimmons wrote: > >> One worry I have about always leaving process-connection-type t is >> that, depending on the external system state -- specifically whether >> or not all ptys are busy -- process-connection-type might not have any >> effect, and the underlying process will rarely (and silently AFAICT) >> operate in pipe mode. By forcing process-connection-type nil, one is >> always testing in the same known mode. > > I don't really understand why pty mode is better here than pipe mode. > Do we need job control, or escape sequences, or anything else specific > to pty? If we use pty, won't these features, on the contrary, get in > the way somewhere? We have to respond to only one prompt from > ldapsearch, and for that pipes should work well. It's not like when the > user is interacting with the process (like in shell mode). The user may > be unaware that external process is at all invoked. Yes, my inclination was (and is) to use pipe mode, but I don't know enough about the implications of either mode, in practice, to definitively say. I searched the mailing list archives and current Emacs source code for process-connection-type and there are many different places where it is set to either t or nil to accommodate some specific operating system or program. Some of these might even have been workarounds for the Darwin process.c bug you seem to have fixed properly. Others, like the one I saw for Solaris, would be harder to test. Unless we can prove that pty mode can fail against ldapsearch -W in some semi-realistic valid use case -- maybe a password with a weird character, or a really really long password that gets buffered or something -- or conversely that pipe mode can fail in some case where pty mode would succeed, then I feel I have to defer to Eli's experience and recommendation. I need to at least give him a chance to update the documentation; hopefully that will clarify when to use each mode definitively. (I also wonder what happens to a process (e.g., Bash) that needs a pty, when all ptys are busy. I haven't done any experiments to check. At least in one case I saw in the source code, ange-ftp.el, the program would just hang in pipe mode. In that case, it seems like there should be a way to tell start-process to signal an error if it doesn't get the desired pty.) > Your suggestion to condionally fix this for Darwin on release looks > good. OK, can you try the attached patch before I push it to emacs-26? > As for 33154, I'll live with it for some more days, and wait for more > people to look at it. And if all goes well, then I'll push it next > week. OK, sounds good. Thanks, Thomas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-LDAP-Set-process-connection-type-to-t-on-Darwin.patch >From ce820679ecc4585dd6ab401f8f027e0e527b6092 Mon Sep 17 00:00:00 2001 From: Thomas Fitzsimmons Date: Fri, 26 Oct 2018 16:53:19 -0400 Subject: [PATCH] LDAP: Set process-connection-type to t on Darwin * lisp/net/ldap.el (ldap-search-internal): Set process-connection-type to t on Darwin. Do not merge to master. (Bug#33050) --- lisp/net/ldap.el | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/net/ldap.el b/lisp/net/ldap.el index 7b47a54b9f..b106de02e9 100644 --- a/lisp/net/ldap.el +++ b/lisp/net/ldap.el @@ -646,7 +646,12 @@ ldap-search-internal (not (equal "" sizelimit))) (setq arglist (nconc arglist (list (format "-z%s" sizelimit))))) (if passwd - (let* ((process-connection-type nil) + ;; Work around Bug#33154, see also Bug#33050. Leaving + ;; process-connection-type at its default (typically t) + ;; would probably be fine too, however this is the minimal + ;; change on the release branch that fixes ldap.el on Darwin + ;; and leaves other operating systems unchanged. + (let* ((process-connection-type (eq system-type 'darwin)) (proc-args (append arglist ldap-ldapsearch-args filter)) (proc (apply #'start-process "ldapsearch" buf -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 03:00:11 2018 Received: (at 33050) by debbugs.gnu.org; 27 Oct 2018 07:00:12 +0000 Received: from localhost ([127.0.0.1]:44517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGIZv-0002Ai-MU for submit@debbugs.gnu.org; Sat, 27 Oct 2018 03:00:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGIZu-00029e-4d for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 03:00:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGIZl-00078L-1z for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 03:00:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGIZT-000733-DQ; Sat, 27 Oct 2018 02:59:43 -0400 Received: from [176.228.60.248] (port=4767 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gGIZT-0006tl-0C; Sat, 27 Oct 2018 02:59:43 -0400 Date: Sat, 27 Oct 2018 09:59:46 +0300 Message-Id: <83k1m3oowt.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin In-reply-to: (message from Filipp Gunbin on Sat, 27 Oct 2018 02:12:21 +0300) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Filipp Gunbin > Cc: Eli Zaretskii , 33050@debbugs.gnu.org, alan@idiocy.org > Date: Sat, 27 Oct 2018 02:12:21 +0300 > > Thomas, I'm not him, but since you asked... > I don't really understand why pty mode is better here than pipe mode. > Do we need job control, or escape sequences, or anything else specific > to pty? Yes, we want the buffering be as if ldapsearch was invoked from a terminal. Possibly also other features, but I don't know enough about the program to tell. Basically, if the program was written for interactive invocation communicating through pty is always better. > If we use pty, won't these features, on the contrary, get in > the way somewhere? If they get in the way, it's another bug, which needs to be analyzed and solved. It could be (although IMO improbable) that we decide to go back to pipes, but then we will know why we did that, and we should leave behind a comment with the explanation. > Your suggestion to condionally fix this for Darwin on release looks > good. Right. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 06:21:18 2018 Received: (at 33050) by debbugs.gnu.org; 27 Oct 2018 10:21:18 +0000 Received: from localhost ([127.0.0.1]:44594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGLiX-0000a6-VV for submit@debbugs.gnu.org; Sat, 27 Oct 2018 06:21:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGLiV-0000Zt-Ve for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 06:21:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGLiQ-0004Bj-6Y for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 06:21:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGLi5-0003rq-Th; Sat, 27 Oct 2018 06:20:49 -0400 Received: from [176.228.60.248] (port=1546 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gGLi5-0001kQ-FO; Sat, 27 Oct 2018 06:20:49 -0400 Date: Sat, 27 Oct 2018 13:20:52 +0300 Message-Id: <834ld7ofln.fsf@gnu.org> From: Eli Zaretskii To: fitzsim@fitzsim.org In-reply-to: <83y3akoca9.fsf@gnu.org> (message from Eli Zaretskii on Fri, 26 Oct 2018 20:20:14 +0300) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83y3akoca9.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Fri, 26 Oct 2018 20:20:14 +0300 > From: Eli Zaretskii > Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org > > > From: Thomas Fitzsimmons > > Cc: fgunbin@fastmail.fm, 33050@debbugs.gnu.org, alan@idiocy.org > > Date: Fri, 26 Oct 2018 11:41:02 -0400 > > > > That said, it is probably a bad idea to warn or signal an error if all > > ptys are busy in the p-c-t t case. Anyway, I thought I'd mention it; > > maybe the documentation update can address this point as well. > > Right, thanks for pointing that out. I've updated the documentation, please see if the new text makes sense. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 09:37:18 2018 Received: (at 33050) by debbugs.gnu.org; 27 Oct 2018 13:37:18 +0000 Received: from localhost ([127.0.0.1]:44726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGOmE-00058K-BT for submit@debbugs.gnu.org; Sat, 27 Oct 2018 09:37:18 -0400 Received: from mail-io1-f45.google.com ([209.85.166.45]:34856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGOmD-000589-2A for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 09:37:17 -0400 Received: by mail-io1-f45.google.com with SMTP id 79-v6so2411710iou.2 for <33050@debbugs.gnu.org>; Sat, 27 Oct 2018 06:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=VBYDGIUtouP+5ua1bnK5nYhoj7iT2mAhE29GQLacEuA=; b=Xw24f8NYzgqkCTbTayTdUJGYuLMQ28ctgKTCXtisWdnKlT1RqJ4yNoTcrITtYMLAAh 4TV4HSeiw1PDIDO3/xhegfNirtbdnTyvLIJp1gMeUgcEqAisO6n0aaLSqL5PaYrjOSNB C6UiTsBprbEiT/mxmIZlgDRdTOViL0HPIgdMnwj8Of4YmRCpJ+mEKX6JREDa0MTREoRL ECPuAsAbkTpqj9fIOAfjX0Pgo6SQN785/cVY0tpHLML4Uh8PNgKRw++43su1f59vNtZ5 1M3kTVNaEMyrCa0tmnGWKDcqWmlqK2m6qqvnwhFyz/nBLljyKc8fzLdmtYrA0Kr84Pq+ 4RbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=VBYDGIUtouP+5ua1bnK5nYhoj7iT2mAhE29GQLacEuA=; b=Rmubqc9yqvOvscCgjOZwTQ7zswbmroZ8Jwq4n1h/oRjuCrord/MN1D5HsQQWleX12n 24ryIzr09CGtonVRqyoZAOatN58gkPDTJ6f0Kk9rglgEh2ChjTWu3xnAnX8GxRe2T+lL rfc64BGrtOS0TTFti8xS779q1Ud3EiDohFe8Iozn9CBO4cJSjAzp5U8Yi7u7/RKj+E6b iY5rH3zN+KbRshtCK1BvPI9XKgmRNDk6En0DU2R792dr6xscqIY4xffdMGOMAlaLav/2 D1CIy47o2eFattX85uyp3OMS4rRWKHaIbUw0rud0Q0gV0Bo9OhCDl0/NvoepOdfB9iPr /NqQ== X-Gm-Message-State: AGRZ1gL4Q2QbfiAjexKNQZFXpE+6V2D4CxNiAZAtn8cuxK8wOcIu8UfU w5sx5DyJew6qm2u505ee+NiwAg== X-Google-Smtp-Source: AJdET5eEaM1IwDqTZACq6bXfu5BXMBek26m61q7+GLQiNSbDbv2z56+yvcZBm8rkA07kNMoNpEef+A== X-Received: by 2002:a5e:d809:: with SMTP id l9-v6mr4773175iok.238.1540647431542; Sat, 27 Oct 2018 06:37:11 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id f20-v6sm4715176itc.13.2018.10.27.06.37.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Oct 2018 06:37:10 -0700 (PDT) From: Thomas Fitzsimmons To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83y3akoca9.fsf@gnu.org> <834ld7ofln.fsf@gnu.org> Date: Sat, 27 Oct 2018 09:42:17 -0400 In-Reply-To: <834ld7ofln.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Oct 2018 13:20:52 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Fri, 26 Oct 2018 20:20:14 +0300 >> From: Eli Zaretskii >> Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org >> >> > From: Thomas Fitzsimmons >> > Cc: fgunbin@fastmail.fm, 33050@debbugs.gnu.org, alan@idiocy.org >> > Date: Fri, 26 Oct 2018 11:41:02 -0400 >> > >> > That said, it is probably a bad idea to warn or signal an error if all >> > ptys are busy in the p-c-t t case. Anyway, I thought I'd mention it; >> > maybe the documentation update can address this point as well. >> >> Right, thanks for pointing that out. > > I've updated the documentation, please see if the new text makes > sense. Yes, though I might still read that and choose a pipe for ldapsearch. How about adding this sentence: [...] these features. A Lisp program should prefer a pty when interacting with a subprocess that prompts the user for information (e.g., a password) because that feature of the subprocess was probably developed and tested assuming a pty. However, for subprocesses used by Lisp programs [...] AIUI, this is your main rationale for using a pty for ldapsearch -- though feel free to reword it. Thanks, Thomas From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 10:36:14 2018 Received: (at 33050) by debbugs.gnu.org; 27 Oct 2018 14:36:14 +0000 Received: from localhost ([127.0.0.1]:45573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGPhG-0002Ut-Gn for submit@debbugs.gnu.org; Sat, 27 Oct 2018 10:36:14 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGPhE-0002Ul-T1 for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 10:36:13 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 716DD21F79; Sat, 27 Oct 2018 10:36:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 27 Oct 2018 10:36:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=OMZbJyX19AeQGVGaeAWNvdh5EF 4MTzVhuOuGQQUH+L8=; b=rtJWfQsx9OJWXfhUElETjwzwOIikEu7dang1sA770Q 0a7MY9/JRZMh7ILhesEKd5BbpVaq7xaO7ny/p7Ti//pKjVPoY5u/E+wWqPbNS/A4 aZ86WTZlkanf8ybi2Dkrdb8xm5XCDl/G1bh72M+TvAHYIEAGm2qUb2RhDrBo6Gzj 80v+C686TNvommtPpi5oQIE33Siozb+nwj8I0c3uppG7pQt9mMsE6h9pQ5xQn9fB IEQIwcX4hw033GCpNYOVl2xmvlMAPL3fA1kNbWEIAeFo2hnJueiD5bXaFoxvfDyf oC4HTxJDwjRNbiN+kuocjWTaDeMGqifkBJLL/9whfxwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=OMZbJy X19AeQGVGaeAWNvdh5EF4MTzVhuOuGQQUH+L8=; b=RUTGso/j8RMTxcbF5iyw7S 8XqeH+luHA4TvyCDaeC4YsTx1aguaPpBqBemrOPZ/1KcSCsV1cNCu4mP3QHMtQ9E LRmjGe6iBFlqaGb5mlLGYIAhfssR29nYLRrBfENq1tk7Xa+RS7NMsvw36JhNNbHQ /U0eQLVYAFr/XjkmQ59cYGh8T+3Q/wns/E7IIwJotHxThQjSVSYWiFJQSkCNQqXY MH4etAK5Bw1LZTMGV24D9jpr712GDFRlCzuHCoGP8isR2GK+fgMnT2Oc6zJPlk3W PruWEkIoz345++TFP8pygHBRS6oqxviIX0P1sWRxs3RfzwsWaNo+M0VXENbHhUIA == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.local (unknown [93.185.27.190]) by mail.messagingengine.com (Postfix) with ESMTPA id CC726E43AC; Sat, 27 Oct 2018 10:36:10 -0400 (EDT) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: <83k1m3oowt.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Oct 2018 09:59:46 +0300") References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83k1m3oowt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Sat, 27 Oct 2018 17:37:26 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 27/10/2018 09:59 +0300, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Cc: Eli Zaretskii , 33050@debbugs.gnu.org, alan@idiocy.org >> Date: Sat, 27 Oct 2018 02:12:21 +0300 >> >> Thomas, > > I'm not him, but since you asked... > >> I don't really understand why pty mode is better here than pipe mode. >> Do we need job control, or escape sequences, or anything else specific >> to pty? > > Yes, we want the buffering be as if ldapsearch was invoked from a > terminal. Possibly also other features, but I don't know enough about > the program to tell. > > Basically, if the program was written for interactive invocation > communicating through pty is always better. > >> If we use pty, won't these features, on the contrary, get in >> the way somewhere? > > If they get in the way, it's another bug, which needs to be analyzed > and solved. It could be (although IMO improbable) that we decide to > go back to pipes, but then we will know why we did that, and we should > leave behind a comment with the explanation. Thanks, got it. Filipp From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 10:52:16 2018 Received: (at 33050) by debbugs.gnu.org; 27 Oct 2018 14:52:16 +0000 Received: from localhost ([127.0.0.1]:45600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGPwm-0002su-8M for submit@debbugs.gnu.org; Sat, 27 Oct 2018 10:52:16 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGPwk-0002sn-GE for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 10:52:14 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 575B521E79; Sat, 27 Oct 2018 10:52:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 27 Oct 2018 10:52:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=aBBIL7N+u9IFi51ska6QnV2uu3 edX9MhruS7jZ+BnQc=; b=lCpH4ardxsY0n+JiSH12arGpZz2SV1pDnYOhp2PjEM q/h6pIyhYFhTEGbHVxK6ys6qfcx6lPfLUYIkesL+RDA96LfpNWF52gKATIY4PF/B AbNYWKhPQZZl8V1QvqZIgwBs3vbc9dkqmfywdQb+XdRo5Ohrf9Ov7vEbneT/92sc CO4KCB5csfz87QLkL31oOr95cHjuivvES/JSQxnpNPHQzrveid23ljcvC7GrEeNR Obsb6qx9Mny+j5zdInPxyZ0wceru0LGc46sQdrHKR/qH1I85MU7g2V6vRVqzD5kP eIrpsEVNmu54jaV89HHDUoWtXHxca+qyY+9idFaszyjw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=aBBIL7 N+u9IFi51ska6QnV2uu3edX9MhruS7jZ+BnQc=; b=bB7G8kfjURQ6q5i2/lgLyV 74SoaWzxh2cPS3i96E5zLcSRRuqAlWaJP9aH8Besjff9NRYP1BQD6Ze0uw1DR5EA r9bRw0g5hp2M12mS3aUgZbE3GRgawo+3iNbApzm8iDRJlYYN2OiPpYwvy6dn0/DF DvGcIIhWML5C0Brb0X/pf2yRQkPuArGC6FKxF31YBZ6GRgj0WIz7JicTOvs/vjjE R/GGa+/LJPFYX6s02rVdprjBtc5vmFy1Gf+Jt6Jh2h3CPs9GWKTiilFK1+4eoZ2K mT1Tagb6XO0BCKKB4F4s9/4meiEvfq1piSYb4pEJVMsZ9CQcOaVwHg1F0msBfk9Q == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.local (unknown [93.185.27.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 1B521E49EB; Sat, 27 Oct 2018 10:52:11 -0400 (EDT) From: Filipp Gunbin To: Thomas Fitzsimmons Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Thomas Fitzsimmons's message of "Fri, 26 Oct 2018 22:09:28 -0400") References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Sat, 27 Oct 2018 17:52:10 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 26/10/2018 22:09 -0400, Thomas Fitzsimmons wrote: > (I also wonder what happens to a process (e.g., Bash) that needs a pty, > when all ptys are busy. I haven't done any experiments to check. At > least in one case I saw in the source code, ange-ftp.el, the program > would just hang in pipe mode. In that case, it seems like there should > be a way to tell start-process to signal an error if it doesn't get the > desired pty.) Yes, would be good to check this. >> Your suggestion to condionally fix this for Darwin on release looks >> good. > > OK, can you try the attached patch before I push it to emacs-26? I tried it on emacs-26, and couldn't get eudc-expand-inline to work, but I think that's a different unrelated problem (maybe auth-source reading .authinfo or something). Otherwise it looks safe. I can look more into it on Monday.. Filipp From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 10:54:12 2018 Received: (at 33050) by debbugs.gnu.org; 27 Oct 2018 14:54:12 +0000 Received: from localhost ([127.0.0.1]:45604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGPyd-0002vl-Lb for submit@debbugs.gnu.org; Sat, 27 Oct 2018 10:54:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGPyb-0002vY-RK for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 10:54:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGPyS-0008L8-By for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 10:54:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGPy1-00089n-ID; Sat, 27 Oct 2018 10:53:33 -0400 Received: from [176.228.60.248] (port=2516 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gGPxz-0007cP-Ob; Sat, 27 Oct 2018 10:53:33 -0400 Date: Sat, 27 Oct 2018 17:53:35 +0300 Message-Id: <83tvl7moeo.fsf@gnu.org> From: Eli Zaretskii To: Thomas Fitzsimmons In-reply-to: (message from Thomas Fitzsimmons on Sat, 27 Oct 2018 09:42:17 -0400) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83y3akoca9.fsf@gnu.org> <834ld7ofln.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Thomas Fitzsimmons > Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org > Date: Sat, 27 Oct 2018 09:42:17 -0400 > > > I've updated the documentation, please see if the new text makes > > sense. > > Yes, though I might still read that and choose a pipe for ldapsearch. > How about adding this sentence: > > [...] these features. A Lisp program should prefer a pty when > interacting with a subprocess that prompts the user for information > (e.g., a password) because that feature of the subprocess was probably > developed and tested assuming a pty. However, for subprocesses used by > Lisp programs [...] Wouldn't this just reiterate what the text already says? [...] However, for subprocesses used by Lisp programs for internal purposes (i.e., with no user interaction), where significant amounts of data need to be exchanged between the subprocess and the Lisp program, it is often better to use a pipe, because pipes are more efficient, and because they are immune to stray character injections that ptys introduce for large (around 500 byte) messages. [...] This explicitly says that pipes are preferable when NO user interaction is done, especially when large amounts of data are to be exchanged with Emacs. I don't think that asking for a password is a special case in this context. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 12:48:03 2018 Received: (at 33050) by debbugs.gnu.org; 27 Oct 2018 16:48:03 +0000 Received: from localhost ([127.0.0.1]:45693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGRkp-0003On-1f for submit@debbugs.gnu.org; Sat, 27 Oct 2018 12:48:03 -0400 Received: from mail-io1-f51.google.com ([209.85.166.51]:40664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGRkn-0003KR-0N for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 12:48:01 -0400 Received: by mail-io1-f51.google.com with SMTP id a23-v6so2579324iod.7 for <33050@debbugs.gnu.org>; Sat, 27 Oct 2018 09:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uhId3pPe2Fnc/oS6O7SizSeo13DPeqoHriV9z5MIDT4=; b=fAFVTO/pQVv36ZahzFgl3YiYwNCJEW4dUkOlXiqHPpNu8Ld4QXelkIYY/SzxNm/W+v pQVvq7IVNCr6UpDzPlsDqTmTwZXAoKW9DnMM5pgzpCR9ToDgmndJ+H5Af6HCYToD3AVG TjZK5vqBo0dC6yMfptMWonD3j2ntdUjYQMFA8GdpJh2PRk34xkrcTojOCMuaTkA41Dkk B+Al641/7hAfOeVwpoDRiFfXGOjbCRsf5bmVcPVVr/TeAEc8WRd1+oZSGR4gYnPEG1OP hMaQQfb9bqsTKsmY76a2DoFx1WHUkGaZm2cFN+RNuNPBfsqRUJOTwi8DaGYNCxW/ncx3 zdAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uhId3pPe2Fnc/oS6O7SizSeo13DPeqoHriV9z5MIDT4=; b=k9ggW7ATVNp3jsGJcL98F9i5QNN3CFJfWMyxqpu0cGZGGQkAV9E0ImpcNwpc0f3So7 TVy3msQX8kcp9U1gmhW0fXebazO0UO1CicLKXu1W7RRMgQHqKZG+qpm5+Trz3DG/nnPJ /lKqFJUDQh1sHvmeB3VLh9LfZ1Jm7lYx7A0Y6WKF/N3d2/72uYnXBU7k2/YmWBZzitJH RvTdy+Pxw7pepE71YYVdb0YdGh56884PW2NhBDHCa4kz9QVHGjgc3Ug3ZKadcp3Eckp5 tnYvya/opN2EW3CHXmazzdgM59QVhu9FplcP7KgdlhLItgc1kRyO6hHRTcqwyqu/XX5+ wTOQ== X-Gm-Message-State: AGRZ1gKKL1stjC/8/hs0PHJ2pl5+FJP0dX3sfhFJvp+TMBjqPn5SfkOH ZEjd6FN12AbCzF5lyFnQktI0pQ== X-Google-Smtp-Source: AJdET5c5UkmP+BmrVVQVU6DDtPtrxsZXdCAUCjlb8OYxFbnMh7uyFuovVD+V6xSTS3wmnbiRSCjgzg== X-Received: by 2002:a6b:b8d4:: with SMTP id i203-v6mr4790435iof.287.1540658875243; Sat, 27 Oct 2018 09:47:55 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id v134-v6sm4532009ita.23.2018.10.27.09.47.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Oct 2018 09:47:54 -0700 (PDT) From: Thomas Fitzsimmons To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83y3akoca9.fsf@gnu.org> <834ld7ofln.fsf@gnu.org> <83tvl7moeo.fsf@gnu.org> Date: Sat, 27 Oct 2018 12:53:02 -0400 In-Reply-To: <83tvl7moeo.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Oct 2018 17:53:35 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Thomas Fitzsimmons >> Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org >> Date: Sat, 27 Oct 2018 09:42:17 -0400 >> >> > I've updated the documentation, please see if the new text makes >> > sense. >> >> Yes, though I might still read that and choose a pipe for ldapsearch. >> How about adding this sentence: >> >> [...] these features. A Lisp program should prefer a pty when >> interacting with a subprocess that prompts the user for information >> (e.g., a password) because that feature of the subprocess was probably >> developed and tested assuming a pty. However, for subprocesses used by >> Lisp programs [...] > > Wouldn't this just reiterate what the text already says? > > [...] However, for > subprocesses used by Lisp programs for internal purposes (i.e., with no > user interaction), where significant amounts of data need to be > exchanged between the subprocess and the Lisp program, it is often > better to use a pipe, because pipes are more efficient, and because they > are immune to stray character injections that ptys introduce for large > (around 500 byte) messages. [...] > > This explicitly says that pipes are preferable when NO user > interaction is done, especially when large amounts of data are to be > exchanged with Emacs. I don't think that asking for a password is a > special case in this context. Then maybe change "(i.e., with no user interaction)", which could be talking about the Lisp program itself or the subprocess, to "(i.e., when the subprocess does not require user interaction)". In the case of ldapsearch, there is user interaction, but it's handled by the Lisp program, then passed to the subprocess. That parenthetical part is the part that I consider in its current form to be a little unclear. Thomas From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 14:49:47 2018 Received: (at 33050) by debbugs.gnu.org; 27 Oct 2018 18:49:47 +0000 Received: from localhost ([127.0.0.1]:45719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGTed-0006DZ-6p for submit@debbugs.gnu.org; Sat, 27 Oct 2018 14:49:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGTeb-0006DM-MW for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 14:49:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGTeV-0006co-PO for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 14:49:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGTe8-0006QA-AY; Sat, 27 Oct 2018 14:49:16 -0400 Received: from [176.228.60.248] (port=1430 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gGTe7-0005Dd-1R; Sat, 27 Oct 2018 14:49:16 -0400 Date: Sat, 27 Oct 2018 21:49:10 +0300 Message-Id: <83k1m3mdi1.fsf@gnu.org> From: Eli Zaretskii To: Thomas Fitzsimmons In-reply-to: (message from Thomas Fitzsimmons on Sat, 27 Oct 2018 12:53:02 -0400) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83y3akoca9.fsf@gnu.org> <834ld7ofln.fsf@gnu.org> <83tvl7moeo.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Thomas Fitzsimmons > Cc: 33050@debbugs.gnu.org, fgunbin@fastmail.fm, alan@idiocy.org > Date: Sat, 27 Oct 2018 12:53:02 -0400 > > Then maybe change "(i.e., with no user interaction)", which could be > talking about the Lisp program itself or the subprocess, to "(i.e., when > the subprocess does not require user interaction)". Done, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 16:22:53 2018 Received: (at 33050) by debbugs.gnu.org; 27 Oct 2018 20:22:53 +0000 Received: from localhost ([127.0.0.1]:45799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGV6j-0000Av-Ee for submit@debbugs.gnu.org; Sat, 27 Oct 2018 16:22:53 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:45142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGV6h-0000Ag-5l for 33050@debbugs.gnu.org; Sat, 27 Oct 2018 16:22:51 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id EFC79228BD for <33050@debbugs.gnu.org>; Sat, 27 Oct 2018 20:27:07 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1540672026; x=1541536027; bh=RX DyOaakddlHDybNnqgxz55iXtDhlz6cWaDPCFN2OHg=; b=mAYB7HfZrCdtP26mrQ tRNNKctyX03Kwfpuo8gNPNJV61sHWiqRj021mVPSFzAizAuBnquOji+rmo181rMb nZsKo/QGLQS/dvV7vQOrNAnSDkgWQ89vW/dsZ9imjfDg8xTFW3SsuorpwRWEE/x/ HNS9kosNRZceY6Pvxl9G7wMvY= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VNJ6frTjqpda for <33050@debbugs.gnu.org>; Sat, 27 Oct 2018 20:27:06 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 5F12822897; Sat, 27 Oct 2018 20:27:05 +0000 (UTC) Date: Sat, 27 Oct 2018 22:28:15 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Thomas Fitzsimmons In-reply-to: (message from Thomas Fitzsimmons on Thu, 25 Oct 2018 21:41:34 -0400) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33050 Cc: eliz@gnu.org, fgunbin@fastmail.fm, 33050@debbugs.gnu.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: charles@aurox.ch Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Thomas Fitzsimmons > Date: Thu, 25 Oct 2018 21:41:34 -0400 > > I re-read the Elisp "Asynchronous Processes" node; when I was deciding > how to set process-connection-type, I think I was following the > _underlined_ part in: > > [...] > > However, _for subprocesses used > by Lisp programs for internal purposes, it is often better to use a > pipe_, because pipes are more efficient, and because they are immune > to stray character injections that ptys introduce for large (around > 500 byte) messages. Does anyone recall where these "character injections" come from? ISTR that these no longer happen... Maybe this is a reference to the code deleted here: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2b0a91e78f83fb446cc38efb99399e83ad2cded3 (as seen, e.g., in Bug#32438) Also, both "process-send-region" and "process-send-string" (in master) claim to split their process input if it is longer than 500 /characters/ (not bytes) -- but reading through the code in process.c, it's not clear where (or if) this still happens. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 28 12:01:14 2018 Received: (at 33050) by debbugs.gnu.org; 28 Oct 2018 16:01:14 +0000 Received: from localhost ([127.0.0.1]:49192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGnV4-0008Oj-0V for submit@debbugs.gnu.org; Sun, 28 Oct 2018 12:01:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGnV2-0008OU-B6 for 33050@debbugs.gnu.org; Sun, 28 Oct 2018 12:01:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGnUu-0005HT-Ve for 33050@debbugs.gnu.org; Sun, 28 Oct 2018 12:01:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGnUZ-00057k-06; Sun, 28 Oct 2018 12:00:43 -0400 Received: from [176.228.60.248] (port=4221 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gGnUY-00072U-It; Sun, 28 Oct 2018 12:00:42 -0400 Date: Sun, 28 Oct 2018 18:00:49 +0200 Message-Id: <8336sqm572.fsf@gnu.org> From: Eli Zaretskii To: charles@aurox.ch In-reply-to: (charles@aurox.ch) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, fgunbin@fastmail.fm, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Sat, 27 Oct 2018 22:28:15 +0200 > From: charles@aurox.ch (Charles A. Roelli) > CC: eliz@gnu.org, 33050@debbugs.gnu.org, fgunbin@fastmail.fm, > alan@idiocy.org > > > However, _for subprocesses used > > by Lisp programs for internal purposes, it is often better to use a > > pipe_, because pipes are more efficient, and because they are immune > > to stray character injections that ptys introduce for large (around > > 500 byte) messages. > > Does anyone recall where these "character injections" come from? ISTR > that these no longer happen... Maybe this is a reference to the code > deleted here: > > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2b0a91e78f83fb446cc38efb99399e83ad2cded3 > (as seen, e.g., in Bug#32438) Probably. > Also, both "process-send-region" and "process-send-string" (in master) > claim to split their process input if it is longer than 500 > /characters/ (not bytes) -- but reading through the code in process.c, > it's not clear where (or if) this still happens. pty_max_bytes was deleted as well, so I think you are right. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 28 15:54:03 2018 Received: (at 33050) by debbugs.gnu.org; 28 Oct 2018 19:54:03 +0000 Received: from localhost ([127.0.0.1]:49359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGr8N-0005NU-74 for submit@debbugs.gnu.org; Sun, 28 Oct 2018 15:54:03 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:46172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGr8L-0005N0-RP for 33050@debbugs.gnu.org; Sun, 28 Oct 2018 15:54:02 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 8F562228BB for <33050@debbugs.gnu.org>; Sun, 28 Oct 2018 19:58:19 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1540756698; x=1541620699; bh=4Q VguTrgZ7q3WfwveGAaBNqmbnUdo8nPHtZ9vU/VMEY=; b=i7SxwxJMf6pmjBL8fz At9aliHd3frAbeMVbrhW0p8Pqg6y8lpFJ9RjkdQufShz0Qra+lDKLu660qX5EJND zLBQ4GdnbJTVQA8piHRzA0sUmh9jLrx6ZXB2JGF+IHg8zL+yXyoYKQcZaPiBKKv7 tShZB1n8h2q+JFCNYB3wCanzM= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id N_DQShaYeY1p for <33050@debbugs.gnu.org>; Sun, 28 Oct 2018 19:58:18 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id DD02022897; Sun, 28 Oct 2018 19:58:17 +0000 (UTC) Date: Sun, 28 Oct 2018 20:53:55 +0100 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Eli Zaretskii In-reply-to: <8336sqm572.fsf@gnu.org> (message from Eli Zaretskii on Sun, 28 Oct 2018 18:00:49 +0200) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <8336sqm572.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org, fgunbin@fastmail.fm, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: charles@aurox.ch Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 28 Oct 2018 18:00:49 +0200 > From: Eli Zaretskii > > > Does anyone recall where these "character injections" come from? ISTR > > that these no longer happen... Maybe this is a reference to the code > > deleted here: > > > > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2b0a91e78f83fb446cc38efb99399e83ad2cded3 > > (as seen, e.g., in Bug#32438) > > Probably. > > > Also, both "process-send-region" and "process-send-string" (in master) > > claim to split their process input if it is longer than 500 > > /characters/ (not bytes) -- but reading through the code in process.c, > > it's not clear where (or if) this still happens. > > pty_max_bytes was deleted as well, so I think you are right. Aha, yes, pty_max_bytes was removed later after going unused for some time: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3d082a269ece18058ed82957f8a056822b39789e IIUC, there might be a good case for bringing it back, with respect to Bug#6149 and Bug#32438. At least so that we can warn users (or prevent them from) overflowing a pty input queue. For the doc issue, I've opened Bug#33191. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 29 20:44:06 2018 Received: (at 33050) by debbugs.gnu.org; 30 Oct 2018 00:44:06 +0000 Received: from localhost ([127.0.0.1]:52349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHI8c-0007Y4-Id for submit@debbugs.gnu.org; Mon, 29 Oct 2018 20:44:06 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:46185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHI8a-0007XS-3k for 33050@debbugs.gnu.org; Mon, 29 Oct 2018 20:44:04 -0400 Received: by mail-io1-f67.google.com with SMTP id y22-v6so6206774ioj.13 for <33050@debbugs.gnu.org>; Mon, 29 Oct 2018 17:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cuERpqdTGR+PQWu1z0Mjpcy1fiCk9ysqr98Ad7IBVUY=; b=AaQIi3PgeLIZXxKT1FleH4INAwq11WItkFEwp9OhSE94iZaPtiUsb7/nJSu8fABmCr Wpku5bxR6PYmls6C6u22U3rTbvGogvpxzJAnUx22wYuBt0iCPeGilORbfFleIybmzu2T 67Jzarg+C03QCI1Yht3YFnBl3rrR6NURl9bHQY/YRE9mctKdhfG1452qCp7Eskf9PKpR s67sgK1bd7d0nNgRTKLu4Fb0NeY1vFZeiye+W32KXzlP0EwM1D44gPH1QwPcS8m8rzTI o4OstHj9UAtm4Ws8IsES9PUULkgYzOnkcjSjnIIYwvVRJ46UIGM9MzwxFakff3qQSzJs YBpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cuERpqdTGR+PQWu1z0Mjpcy1fiCk9ysqr98Ad7IBVUY=; b=eojgwrGub14C7F0hfBpotCBLuc2qAVV4l+iCFGiutWO8LQ0qftegFeZPRqYucz9CQD 6y63VuaYVev+hN3ZMpP95820lIpg6hZNK+udwfNdj4vzmOLbYUKWulYflznwvRL2nf+2 B08hkywqAveFry8q6r1QAllRcnOqtwtAR5Fxi5e2J0VrB24e/1vNUxrxRx4/KzM/4nZP VUuXxyyi5lnRZLYibuMuipOV/3gr2l8gu3skL2sLH5J4Axys7ZDhaK/7zikBZkCSQBJy QBPKKgORCE0+kOMLUK9WSlV5qbLoa0KMeMwBwXovKplVcNUuTIFIWod78fqhXzpFRpuJ hwgg== X-Gm-Message-State: AGRZ1gIvMaI2pwXMDJ8v9trtgNP+rmadStF5hUSsP0nUJkm88GM592SI hgOfcYPtTCR+Un66qEcjkEyMeQ== X-Google-Smtp-Source: AJdET5fOy+B2JSAtrb083jiLElxQNWiVuF+q3mWrTL47Tpb+S+3+7+aTLkd6eh9BbDA6DUCd4jzrQA== X-Received: by 2002:a5e:8619:: with SMTP id z25-v6mr10514886ioj.28.1540860238437; Mon, 29 Oct 2018 17:43:58 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id h130-v6sm7694205ioa.52.2018.10.29.17.43.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Oct 2018 17:43:57 -0700 (PDT) From: Thomas Fitzsimmons To: Filipp Gunbin Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> Date: Mon, 29 Oct 2018 20:49:32 -0400 In-Reply-To: (Filipp Gunbin's message of "Sat, 27 Oct 2018 17:52:10 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Filipp Gunbin writes: > On 26/10/2018 22:09 -0400, Thomas Fitzsimmons wrote: > >> (I also wonder what happens to a process (e.g., Bash) that needs a pty, >> when all ptys are busy. I haven't done any experiments to check. At >> least in one case I saw in the source code, ange-ftp.el, the program >> would just hang in pipe mode. In that case, it seems like there should >> be a way to tell start-process to signal an error if it doesn't get the >> desired pty.) > > Yes, would be good to check this. I tested ldapsearch after setting the maximum number of ptys to the number of currently-busy ptys: cat /proc/sys/kernel/pty/nr > /proc/sys/kernel/pty/max It does get run in pipe mode silently (i.e., no warning messages are generated), and as we already confirmed, ldapsearch happens to still work when run in pipe mode. >>> Your suggestion to condionally fix this for Darwin on release looks >>> good. >> >> OK, can you try the attached patch before I push it to emacs-26? > > I tried it on emacs-26, and couldn't get eudc-expand-inline to work, but > I think that's a different unrelated problem (maybe auth-source reading > .authinfo or something). Otherwise it looks safe. I can look more into > it on Monday.. OK, I guess file another bug if there's another issue preventing eudc-expand-inline from working on emacs-26. Thanks, Thomas From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 30 15:11:44 2018 Received: (at 33050) by debbugs.gnu.org; 30 Oct 2018 19:11:44 +0000 Received: from localhost ([127.0.0.1]:55933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHZQW-0005TR-Cl for submit@debbugs.gnu.org; Tue, 30 Oct 2018 15:11:44 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:47105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHZQV-0005TF-9n for 33050@debbugs.gnu.org; Tue, 30 Oct 2018 15:11:43 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1459D22201; Tue, 30 Oct 2018 15:11:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 30 Oct 2018 15:11:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=q8HB5ueXBISGCks99j6GVAIGBr RaSLQ6OQ47dBOOLiQ=; b=tcGo0CNNMz5FK1pRJGQfEclaw+I/hgO78mUdQ6h24u LpQ9Uf2ncvdg0nrIctXiv4mugJoTqwWWZjQu+UuA6eoF8LxT4Ray2JegybmSBJ01 1CZzDIWPDAovSHI2IuORJRugikIVXndIUvUJXLMhp1W6AIKNFnO9T/LQwZdRSBNq H5Tf4d6skiD3c0RcJCPEz9Xzqx3Dv8Z5vl6Ks/3jkacMt9SB0x7JExNizeX8tSaI jNPxB137CtxVnSoaOk/MLsiO2WYbJvj/wBcaePdTIraUV+GHDXgeVUU/2kTZ34bE xqEAVk6bmmXS8NapbgRGtXkRgqGnrfPttuCNPmUPM2Ww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=q8HB5u eXBISGCks99j6GVAIGBrRaSLQ6OQ47dBOOLiQ=; b=qvyOVb4xQIMG61hWRMsxT9 SbGA2vPAp2fBUU2OT79s7nH6GoDkW23Lzs1gOgpRK8t561/h/gbEv9/fc5NeCZAE JmHi+Ykh749K+7WToluYBxwXo6cS/S/jxAzpda7RxVQmoBfKSiVfHRrZdWmAXuhG n8hrX2vvaX5+01Z6oFgs8i6FhfI9nXWFmuUUI+gb2x2W566sftSV8oXTtXW1l6YK 7eIVkxCTUAG6ncj95S4Gv438yXdzEoA1fWLR39npLE7eOuytbO7yB6ytb96Xx5ff St73ckKWa8Fq0scZTYLGtoHd/OYa8+Yn22qMqTEKIJmHea62/uSSvqG6157+fSdA == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.local (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 1928E102ED; Tue, 30 Oct 2018 15:11:35 -0400 (EDT) From: Filipp Gunbin To: Thomas Fitzsimmons Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Thomas Fitzsimmons's message of "Mon, 29 Oct 2018 20:49:32 -0400") References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Tue, 30 Oct 2018 22:11:34 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org, alan@idiocy.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 29/10/2018 20:49 -0400, Thomas Fitzsimmons wrote: > I tested ldapsearch after setting the maximum number of ptys to the > number of currently-busy ptys: > > cat /proc/sys/kernel/pty/nr > /proc/sys/kernel/pty/max > > It does get run in pipe mode silently (i.e., no warning messages are > generated), and as we already confirmed, ldapsearch happens to still > work when run in pipe mode. Thanks for testing this! >>> OK, can you try the attached patch before I push it to emacs-26? >> >> I tried it on emacs-26, and couldn't get eudc-expand-inline to work, but >> I think that's a different unrelated problem (maybe auth-source reading >> .authinfo or something). Otherwise it looks safe. I can look more into >> it on Monday.. > > OK, I guess file another bug if there's another issue preventing > eudc-expand-inline from working on emacs-26. Yes, I'll get to it soon, thanks. Filipp From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 28 18:09:39 2018 Received: (at 33050) by debbugs.gnu.org; 28 Nov 2018 23:09:39 +0000 Received: from localhost ([127.0.0.1]:53876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gS8xe-0002w3-V5 for submit@debbugs.gnu.org; Wed, 28 Nov 2018 18:09:39 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gS8xd-0002vo-QF for 33050@debbugs.gnu.org; Wed, 28 Nov 2018 18:09:38 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9778721FA9; Wed, 28 Nov 2018 18:09:31 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 28 Nov 2018 18:09:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=NrEVi544qfBdmg0FUkL4tzzxAT aFIlQGgxTzsJdRf/M=; b=RpWczqh0D5Eh45YEpCgb9nlIxx+uJLJumuW8hqNz/R fvnROGcmCX9J+E1K6ELY2CA4O8Ox4tj4dwhiaym9sftOWFHCWO2oJI/2DWqycmkT fU6F19mCknNIgILQ/ing5r4PmtNHxrgXg9oEL2j5SBFHKTtDCGvT5MeML7CZwWC4 c48S8EY5futQO20+d1P/0d3YzNs34GZV6Fsxc3qM+UZzchqSrUhgyqenZZheJV1q eeFZAFcFLCDOpyBax0nm810ddiNkSQcLwS9HcMjAkxjjtxqQ+BwVnSCqDs4A/raj kSC9rorL0aQhfa8YJNUxcugKfEhUucJtWirhzREZVikA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=NrEVi5 44qfBdmg0FUkL4tzzxATaFIlQGgxTzsJdRf/M=; b=GyqDonWnuPVgo+3d0TqwFG o2w6eCvv80YDOJSbEkeb4Rh5gA00vlcTuMGWTzR7Ju5jP5QuJI5ckU5eqTgzMI9k WZR6A9DISq5D7qFS261Aub6MvMGXSqEtKQyf9qLjdiBjgqPg/OCIhITIAfsWbM7Y lmw1CZRhlawErCUoLYVemN21bR9Je/8ixCng55AU7hqtAuA17SYLx6A5eBbRNql+ FK88Ujkkhvpq0QRErJIbXeC214XGVVGuC1Vc1yIWeO9ngGig7iAXH3LuyQOgUXgE lBcFyNXAv0eFhaKKpDpFzx0jNSSZyxPFXULQC8Vs171XXFbGvaUlPdcHpHtooTIQ == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.local (unknown [93.185.19.13]) by mail.messagingengine.com (Postfix) with ESMTPA id D490A102F4; Wed, 28 Nov 2018 18:09:29 -0500 (EST) From: Filipp Gunbin To: Thomas Fitzsimmons Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Thomas Fitzsimmons's message of "Fri, 26 Oct 2018 22:09:28 -0400") References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Thu, 29 Nov 2018 02:09:27 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: Eli Zaretskii , 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 26/10/2018 22:09 -0400, Thomas Fitzsimmons wrote: > OK, can you try the attached patch before I push it to emacs-26? Thomas, sorry for the late reply. I finally checked your conditional patch on emacs-26 (after make bootstrap) and it works. So if no one objects, it can be committed (and this bug resolved). Bug 33154 was resolved, and we can also commit setting p-c-t to t unconditionally on master. We just need to make sure that change from emacs-26 doesn't propagate to master. Thanks. Filipp From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 29 02:22:05 2018 Received: (at 33050) by debbugs.gnu.org; 29 Nov 2018 07:22:05 +0000 Received: from localhost ([127.0.0.1]:54024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSGeD-0006NP-6H for submit@debbugs.gnu.org; Thu, 29 Nov 2018 02:22:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSGeC-0006Mv-1N for 33050@debbugs.gnu.org; Thu, 29 Nov 2018 02:22:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSGdo-0003si-Lh for 33050@debbugs.gnu.org; Thu, 29 Nov 2018 02:21:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSGdo-0003ra-9J; Thu, 29 Nov 2018 02:21:40 -0500 Received: from [176.228.60.248] (port=2525 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gSGdn-0002Jd-TE; Thu, 29 Nov 2018 02:21:40 -0500 Date: Thu, 29 Nov 2018 09:21:52 +0200 Message-Id: <83d0qoe4bz.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin , Paul Eggert In-reply-to: (message from Filipp Gunbin on Thu, 29 Nov 2018 02:09:27 +0300) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org, fitzsim@fitzsim.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Filipp Gunbin > Cc: Eli Zaretskii , 33050@debbugs.gnu.org > Date: Thu, 29 Nov 2018 02:09:27 +0300 > > On 26/10/2018 22:09 -0400, Thomas Fitzsimmons wrote: > > > OK, can you try the attached patch before I push it to emacs-26? > > Thomas, sorry for the late reply. > > I finally checked your conditional patch on emacs-26 (after make > bootstrap) and it works. So if no one objects, it can be committed (and > this bug resolved). > > Bug 33154 was resolved, and we can also commit setting p-c-t to t > unconditionally on master. > > We just need to make sure that change from emacs-26 doesn't propagate to > master. The patch was installed on master already, by Paul, and the bug was closed. Why do we need this on emacs-26? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 29 03:46:38 2018 Received: (at 33050) by debbugs.gnu.org; 29 Nov 2018 08:46:38 +0000 Received: from localhost ([127.0.0.1]:54074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSHy1-0008Pu-Si for submit@debbugs.gnu.org; Thu, 29 Nov 2018 03:46:38 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSHxz-0008Pg-PM for 33050@debbugs.gnu.org; Thu, 29 Nov 2018 03:46:36 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5C680221D6; Thu, 29 Nov 2018 03:46:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 29 Nov 2018 03:46:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=S9mrAvY8OtCkRpr2KM0DysP9uc DUZSzUKagZ7oVWbvQ=; b=c+zMMCJ2NrYzFbapb5u43G1itKjhMAkJIuvDlhAHIF LFGCLfyZKOy0YC7DTed+igWrNKwF+MAk8tX4o0gSWTMpqzG5JqdCOw0Ws4TpZTXL g7bTUNIpqyQ8Dd/Uuktqf9H67DFsKr/iMZS8xIwminWQy69vQxAQkKfGvcTzB2QX u+S88WsKi2tuHCzQvEnJvhORKhfywzuTxYUiTFIZ9hIHevArexj5zhI9wkp00smf yP1uLUkVwVasYjeYbpuk8UBPTaVCPagUdbwXI3kKbMkkEXkV3NQQqTm7X0WUM4iF qIfwikXwyvu9s2YWkphyU0jbIsHlpZ4GWaQX0v0/awbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=S9mrAv Y8OtCkRpr2KM0DysP9ucDUZSzUKagZ7oVWbvQ=; b=dNix131fHky1EVZbQ6a3C/ UVi1q5/lkD/RUoNRDAURAPiCT8RK3HpQXmKi9aPNOmPd3iJAQkkW46/oJCUNFk8l AuzSIRW0AtGe/c2yVlry3wH72ncsuZZAubCC07tRJoOGYePBTc2yylcsbPAsqDeJ +sp/oI51kMQ8nsCAwfb9MFQZpFgOAFT8dgPn6AyDXjf8H4aOAEJkQ7J1vs3r7ELj TtW2U7gwmvT0hRaxOb1A2SfM3u3dAB5nNfR6p2QaLwoxRFp+FE20fvC4IHN1AptV tbJ/S6fVOmXwlC6EdFmfJUzEO4Nc7eN1WfQmQyzTqzt/RkWnvl7q7f3xI66yHEPw == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id D6E3BE405E; Thu, 29 Nov 2018 03:46:28 -0500 (EST) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: <83d0qoe4bz.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Nov 2018 09:21:52 +0200") References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83d0qoe4bz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Thu, 29 Nov 2018 11:46:27 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 29/11/2018 09:21 +0200, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Cc: Eli Zaretskii , 33050@debbugs.gnu.org >> Date: Thu, 29 Nov 2018 02:09:27 +0300 >> >> On 26/10/2018 22:09 -0400, Thomas Fitzsimmons wrote: >> >> > OK, can you try the attached patch before I push it to emacs-26? >> >> Thomas, sorry for the late reply. >> >> I finally checked your conditional patch on emacs-26 (after make >> bootstrap) and it works. So if no one objects, it can be committed (and >> this bug resolved). >> >> Bug 33154 was resolved, and we can also commit setting p-c-t to t >> unconditionally on master. >> >> We just need to make sure that change from emacs-26 doesn't propagate to >> master. > > The patch was installed on master already, by Paul, and the bug was > closed. > > Why do we need this on emacs-26? Paul closed 33154, there was C-level change. It goes only on master. This bug is about process-connection-type in ldap-search-internal. In this thread, we seemingly agreed to set it to t conditionally for Darwin on emacs-26, and unconditionally on master. Filipp From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 29 04:19:26 2018 Received: (at 33050) by debbugs.gnu.org; 29 Nov 2018 09:19:26 +0000 Received: from localhost ([127.0.0.1]:54102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSITm-0000on-7u for submit@debbugs.gnu.org; Thu, 29 Nov 2018 04:19:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSITk-0000oY-QX for 33050@debbugs.gnu.org; Thu, 29 Nov 2018 04:19:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSITc-0004os-99 for 33050@debbugs.gnu.org; Thu, 29 Nov 2018 04:19:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSITc-0004ok-5i; Thu, 29 Nov 2018 04:19:16 -0500 Received: from [176.228.60.248] (port=2506 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gSITb-0004RI-KM; Thu, 29 Nov 2018 04:19:16 -0500 Date: Thu, 29 Nov 2018 11:19:26 +0200 Message-Id: <834lc0dyw1.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin In-reply-to: (message from Filipp Gunbin on Thu, 29 Nov 2018 11:46:27 +0300) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83a7n9udxv.fsf@gnu.org> <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83d0qoe4bz.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Filipp Gunbin > Cc: Paul Eggert , fitzsim@fitzsim.org, 33050@debbugs.gnu.org > Date: Thu, 29 Nov 2018 11:46:27 +0300 > > > Why do we need this on emacs-26? > > Paul closed 33154, there was C-level change. It goes only on master. > > This bug is about process-connection-type in ldap-search-internal. In > this thread, we seemingly agreed to set it to t conditionally for Darwin > on emacs-26, and unconditionally on master. I guess I'm confused regarding what you'd like to see on emacs-26. Was there a patch to that effect posted in this discussion, and if so, could you point me to it, please? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 29 04:51:20 2018 Received: (at 33050) by debbugs.gnu.org; 29 Nov 2018 09:51:20 +0000 Received: from localhost ([127.0.0.1]:54119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSIye-0001aB-C7 for submit@debbugs.gnu.org; Thu, 29 Nov 2018 04:51:20 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSIyc-0001Zz-Ec for 33050@debbugs.gnu.org; Thu, 29 Nov 2018 04:51:18 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B20FB2221E; Thu, 29 Nov 2018 04:51:12 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 29 Nov 2018 04:51:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=O+tCmqOt7TXWP2eeSCy/demTgn 0QnQo/E2ysINzf/iw=; b=unEXvq+42Zwqu9iDJug2v80TTRLS5Ed5SrE71G2UCG gTEuio8ZmYHOqhBaRgt5Agwv+gkFi8cBCXLSFlOc6xJt2rgq5V5jda/P5N6p37od d+JUQEdKj2DSoD0+xU6iZrgU7/3gGCh7MZPuAHVhwXmOgLeTA184fmdstMUNWgFj E2sRg2juUBJIHQcYoYb6+mnhK/3uzc0pRqKznja0l2dYCVWkWP4kY0p2Oc7d7rge WZ9i2mn4mapJ1iYN9OGmPH27fDM5Y5quppUukw2TdbekeUZA2Fm5n2E6p86uk/rL bA75ZP7KlKnKfcwS9ITpCuVR2P+o4gFY9xgd407OC+uw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=O+tCmq Ot7TXWP2eeSCy/demTgn0QnQo/E2ysINzf/iw=; b=glwULD52riXM85ovyxAx4N fjZbOsAjz0HI/+VXVlshP+EkOQP/BStnQbq+xQR7k+e9pRxk8V6PZr0Xq6x0iC6Z A+0lwS6KV/C662krQwygzQkM8zK/H8q+9speCJMDUFBz6Wz3Knn1bU1RlKyMz4tF S1kzluxx6SD3X2zLBd8ZXdxpnndE2U5C33G2G+d6lRdZr7fx7LQPla53liBRgQZO qsAbzpeQJVJ2AftJ9r7BC7B800bJKChALCrw8UiZzYiz5Hf5tZDdP/4Pz1zVls9c a1U5Q9mB+NTqM0HKmFukba3JVnhpw1C3sVV0kGlSYC8JPY2nvRRr5vnwwYPtMX+Q == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 17E5F104F1; Thu, 29 Nov 2018 04:51:10 -0500 (EST) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: <834lc0dyw1.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Nov 2018 11:19:26 +0200") References: <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83d0qoe4bz.fsf@gnu.org> <834lc0dyw1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Thu, 29 Nov 2018 12:51:09 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 29/11/2018 11:19 +0200, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Cc: Paul Eggert , fitzsim@fitzsim.org, 33050@debbugs.gnu.org >> Date: Thu, 29 Nov 2018 11:46:27 +0300 >> >> > Why do we need this on emacs-26? >> >> Paul closed 33154, there was C-level change. It goes only on master. >> >> This bug is about process-connection-type in ldap-search-internal. In >> this thread, we seemingly agreed to set it to t conditionally for Darwin >> on emacs-26, and unconditionally on master. > > I guess I'm confused regarding what you'd like to see on emacs-26. > Was there a patch to that effect posted in this discussion, and if so, > could you point me to it, please? Sure, it's in message https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33050#89 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 29 05:41:21 2018 Received: (at 33050) by debbugs.gnu.org; 29 Nov 2018 10:41:21 +0000 Received: from localhost ([127.0.0.1]:54140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSJl3-0002og-Hf for submit@debbugs.gnu.org; Thu, 29 Nov 2018 05:41:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSJl1-0002oS-H1 for 33050@debbugs.gnu.org; Thu, 29 Nov 2018 05:41:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSJkt-0004Vp-3l for 33050@debbugs.gnu.org; Thu, 29 Nov 2018 05:41:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSJks-0004Vh-Vp; Thu, 29 Nov 2018 05:41:11 -0500 Received: from [176.228.60.248] (port=3687 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gSJks-0005vP-IN; Thu, 29 Nov 2018 05:41:10 -0500 Date: Thu, 29 Nov 2018 12:41:23 +0200 Message-Id: <8336rkdv3g.fsf@gnu.org> From: Eli Zaretskii To: Filipp Gunbin In-reply-to: (message from Filipp Gunbin on Thu, 29 Nov 2018 12:51:09 +0300) Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83d0qoe4bz.fsf@gnu.org> <834lc0dyw1.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33050 Cc: fitzsim@fitzsim.org, 33050@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Filipp Gunbin > Cc: eggert@cs.ucla.edu, fitzsim@fitzsim.org, 33050@debbugs.gnu.org > Date: Thu, 29 Nov 2018 12:51:09 +0300 > > > I guess I'm confused regarding what you'd like to see on emacs-26. > > Was there a patch to that effect posted in this discussion, and if so, > > could you point me to it, please? > > Sure, it's in message https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33050#89 Thanks, now pushed to the emacs-26 branch. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 29 09:09:31 2018 Received: (at 33050-done) by debbugs.gnu.org; 29 Nov 2018 14:09:32 +0000 Received: from localhost ([127.0.0.1]:54209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSN0V-0001bi-Ek for submit@debbugs.gnu.org; Thu, 29 Nov 2018 09:09:31 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34943) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSN0T-0001bT-HO for 33050-done@debbugs.gnu.org; Thu, 29 Nov 2018 09:09:29 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 66C2C22219; Thu, 29 Nov 2018 09:09:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 29 Nov 2018 09:09:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=LYnzAvNaSg8E2/EwgDqFzPYB5z myZS31kcS26duzTBI=; b=dct/U9U8HFmMlx5Yz2wHeezGqUGB7yLUGE4CRuSzSH ThT+8wgTs8VkbLl/BdJ3BCuos9wDl6d6JZcLnyNXOwA951GtfswklcRPiaDoVmf/ l81eixndMIJ46lH80YK8Oa38iQBfJjNxHQIgTmK2HenB8YfmmGCYQzfQ8vCT3Bjz 96jyv+iqjGQ4alidOhLFO1CgkWIR6MtciAIpGKX8yVjSyuatvHNbrRg3vB1KmHDK VX4BpJydIvOB5HGPWAjDZOFwUtPe4vG1lCweH3WvUA64ROt0pO82y678YmoX8+NO y4lo7tKMsDWmLfu/NA/inmicurr8VinQsvIXXQ6g0Wcw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=LYnzAv NaSg8E2/EwgDqFzPYB5zmyZS31kcS26duzTBI=; b=Rybr5PfJk//KryUcvv6jvg d3+lW0reNRDO+fcCsr8gvHnAD7q1fC1wMomk4qVavrL0rm3nRt9x9betcAe9cPGX XICtSAt3+gR96rDsY93h2XUDuCaZWzE5bPePMlJkWqfQqsiJnHXD8l5frxdCfSYv ka2wOp6mmEEoEWXRSjLyNKkfh8UZx+F8D6xnH0Woi319Z+Pg9aJRLiT6saeZxmQ7 Y3KnuwutQraHf5/DZePPBme83qQRgjB51HdTjWOIgnUsapUIDdL0aNWamp8zesLL XqoXdgJJjycUIdueUBYEvj2zPJOHc92dCusZnxFt0ppNDoLLZeJHEyArGi2ycZYw == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 94795E405E; Thu, 29 Nov 2018 09:09:22 -0500 (EST) From: Filipp Gunbin To: Eli Zaretskii Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: <8336rkdv3g.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Nov 2018 12:41:23 +0200") References: <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83d0qoe4bz.fsf@gnu.org> <834lc0dyw1.fsf@gnu.org> <8336rkdv3g.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Thu, 29 Nov 2018 17:09:20 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050-done Cc: fitzsim@fitzsim.org, 33050-done@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 29/11/2018 12:41 +0200, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Cc: eggert@cs.ucla.edu, fitzsim@fitzsim.org, 33050@debbugs.gnu.org >> Date: Thu, 29 Nov 2018 12:51:09 +0300 >> >> > I guess I'm confused regarding what you'd like to see on emacs-26. >> > Was there a patch to that effect posted in this discussion, and if so, >> > could you point me to it, please? >> >> Sure, it's in message https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33050#89 > > Thanks, now pushed to the emacs-26 branch. Ok, I pushed the unconditional setting on master and am closing this bug. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 03 21:17:51 2018 Received: (at 33050) by debbugs.gnu.org; 4 Dec 2018 02:17:51 +0000 Received: from localhost ([127.0.0.1]:59653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gU0HX-0001wU-1O for submit@debbugs.gnu.org; Mon, 03 Dec 2018 21:17:51 -0500 Received: from mail-it1-f181.google.com ([209.85.166.181]:50761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gU0HV-0001wE-6k for 33050@debbugs.gnu.org; Mon, 03 Dec 2018 21:17:49 -0500 Received: by mail-it1-f181.google.com with SMTP id z7so12840846iti.0 for <33050@debbugs.gnu.org>; Mon, 03 Dec 2018 18:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UV7nWta4TG50IHx9KfFZUjarlY5qjrRJUe+pgMqgOFo=; b=k0JpytXh+j5oS4KGRn8dwMZR8Z0/on7790ConPHOteZIywaQLYiA1oNzGf9OCdjfIR fsD0k43PYp8DUa1FlWsN4GdYr/6wgB209FwCiGKj0o2XtRpBzjGp0LZM+yF0sTchMqio FJ7t2wdC1rfswdLxiK3vXFvWWw1q87AqlL8CaY2VMztG8ZyeGy3p3r7FefIhhGX0EDv+ LMc7z2dWAt1dU6uRGcR20j8v2o7bkAZajpvQDIey56VCLi+1vH/09IB25jHkqdw8nJ/y qevOb0Fve0epeLKymVXT8GCStGkNEwbqUdD85fng5qETQ6tSRObMluL8yDCuCCjxjIz0 kPmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UV7nWta4TG50IHx9KfFZUjarlY5qjrRJUe+pgMqgOFo=; b=qd1sjfpLDJ9IR3kjB4goWqx6n9PuBkHsDDlYfmWJTibmcu1XBBdrcFgAqUueyYoG5a ogm0s9Dl1kJtk7ZXJkyQdzSAESCeUZkbkFrfK3CyieRI/svitqDDMBC3X+9JyO+2PxNv TuDtNFnr60ai30egPcXla8ZZTBGOLjoGnaDoCWOFqcqbwdA1P/7P8ECX6rR7Uie6wi1D zlXQx+d3WisBbhY1KRFTj0Ng2f76i8II6UyaBZIcqFX4oe4ecztqaSJHGTbpMjMV0e4+ j79Btf8EFyzlC7wf3ENphJpQdLu10JhYaUEAS7VUU/GWRgSdm1iefr53EuJXqrcvhRtI uXng== X-Gm-Message-State: AA+aEWYAFiO6ItuIOdGTptOHDkV6/72veU4bRujAnqRZWeZysMVAFTnB TdMoEvIuFFbf2H32nHYvSysLuw== X-Google-Smtp-Source: AFSGD/XZj1ufKhvO+vDvI4V4tGXr+6SFpCXBGrs5EUPnXR2O6aZk2wGEtwZGzsnQ5zRxuSUwsT9OpQ== X-Received: by 2002:a02:3d42:: with SMTP id n63mr17617361jan.136.1543889863450; Mon, 03 Dec 2018 18:17:43 -0800 (PST) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id p19sm4533045itp.13.2018.12.03.18.17.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Dec 2018 18:17:42 -0800 (PST) From: Thomas Fitzsimmons To: 33050@debbugs.gnu.org Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83d0qoe4bz.fsf@gnu.org> <834lc0dyw1.fsf@gnu.org> <8336rkdv3g.fsf@gnu.org> Date: Mon, 03 Dec 2018 09:17:17 -0500 In-Reply-To: (Filipp Gunbin's message of "Thu, 29 Nov 2018 17:09:20 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 33050 Cc: fgunbin@fastmail.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --=-=-= Content-Type: text/plain Filipp Gunbin writes: > On 29/11/2018 12:41 +0200, Eli Zaretskii wrote: > >>> From: Filipp Gunbin >>> Cc: eggert@cs.ucla.edu, fitzsim@fitzsim.org, 33050@debbugs.gnu.org >>> Date: Thu, 29 Nov 2018 12:51:09 +0300 >>> >>> > I guess I'm confused regarding what you'd like to see on emacs-26. >>> > Was there a patch to that effect posted in this discussion, and if so, >>> > could you point me to it, please? >>> >>> Sure, it's in message https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33050#89 >> >> Thanks, now pushed to the emacs-26 branch. > > Ok, I pushed the unconditional setting on master and am closing this > bug. Thanks Eli and Filipp for pushing these. Filipp, on master is there any reason not to just leave process-connection-type at its default value? The patch I was going to push for this is attached. Thomas --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-ldap.el-Do-not-set-process-connection-type.patch >From 5e933b39d1ce8016a8d989cef99a19e12eb36039 Mon Sep 17 00:00:00 2001 From: Thomas Fitzsimmons Date: Fri, 26 Oct 2018 16:59:09 -0400 Subject: [PATCH] ldap.el: Do not set process-connection-type * lisp/net/ldap.el (ldap-search-internal): Leave process-connection-type at its default value. (Bug#33050) --- lisp/net/ldap.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/net/ldap.el b/lisp/net/ldap.el index 7b47a54..4b49f76 100644 --- a/lisp/net/ldap.el +++ b/lisp/net/ldap.el @@ -646,8 +646,9 @@ ldap-search-internal (not (equal "" sizelimit))) (setq arglist (nconc arglist (list (format "-z%s" sizelimit))))) (if passwd - (let* ((process-connection-type nil) - (proc-args (append arglist ldap-ldapsearch-args + ;; Leave process-connection-type at its default value. See + ;; discussion in Bug#33050. + (let* ((proc-args (append arglist ldap-ldapsearch-args filter)) (proc (apply #'start-process "ldapsearch" buf ldap-ldapsearch-prog -- 1.8.3.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 04 07:37:46 2018 Received: (at 33050) by debbugs.gnu.org; 4 Dec 2018 12:37:46 +0000 Received: from localhost ([127.0.0.1]:59952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gU9xS-0004k7-6Q for submit@debbugs.gnu.org; Tue, 04 Dec 2018 07:37:46 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:60377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gU9xR-0004js-4A for 33050@debbugs.gnu.org; Tue, 04 Dec 2018 07:37:45 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B0B0221F24; Tue, 4 Dec 2018 07:37:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 04 Dec 2018 07:37:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=sb6MMNp6OpQnL6sfJ5qmik3St/ GIL2QDIZxw80AzuBs=; b=Ynoq6ZlJj5MAJxWn3D0KcSchaU17DwpL/DZ1BM+kz7 EavKvzELqdSVbLdJyGDYC12rL8v9xEjoMRKOI3PGVRvugdGOJR7jXLS5DNMsMPms dS7dZQjkn8oV2UMRDvutrjNewZcMb7M+pI+MZca04J9gnOVtNvVz+ipxCu6q3htC VDRtPBZKDsUSoJ2pLD9aCq1f3eVNM4U3mQ+dQeozlrTm4UTUVczqbXngVqK61AYV 3xVsXdYPKJs+5dYrOSxzaLe3DbwUrDQt/bnADm1aONrmep5ISwGFlHvJ5Cc83des UZG17hK9/M8PT73NKkZD0fO+ia2buJIGVasFP8jZAFig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=sb6MMN p6OpQnL6sfJ5qmik3St/GIL2QDIZxw80AzuBs=; b=tqMlkSwyKmQH4XkjbAUxC4 wpR61CuvVCZyNXPF6HkBvs4V/wLjpNeBMFjP7E082cgZeExJm66SE2+M5r7R1A89 3xHsJ0Qn0jH9tffsgkBigi6vPjSeJy4Wio+DQ605hJiBaiq1eUPX7553wmtfyPas JcjpsBN2t2jzYrXR6mHYMlH1UHvRty9U/fsUZhbbVEtJdn7JonK6p1gKHTBCqMB3 BQdEHJxhWLj3A716nuFZGIrDjVnqJAOUUGOmXFoFX4HqXXZDaShHrr5U6xf3TSJt 3AqWm6RG2sqM5igYNrnrZXG1cxf3yans3KzNRi037zupE99g1i3RXXCUPs9WvaJw == X-ME-Sender: X-ME-Proxy: Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 9C71310392; Tue, 4 Dec 2018 07:37:38 -0500 (EST) From: Filipp Gunbin To: Thomas Fitzsimmons Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil In-Reply-To: (Thomas Fitzsimmons's message of "Mon, 03 Dec 2018 09:17:17 -0500") References: <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83d0qoe4bz.fsf@gnu.org> <834lc0dyw1.fsf@gnu.org> <8336rkdv3g.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Date: Tue, 04 Dec 2018 15:37:36 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 03/12/2018 09:17 -0500, Thomas Fitzsimmons wrote: > Filipp Gunbin writes: > >> On 29/11/2018 12:41 +0200, Eli Zaretskii wrote: >> >>>> From: Filipp Gunbin >>>> Cc: eggert@cs.ucla.edu, fitzsim@fitzsim.org, 33050@debbugs.gnu.org >>>> Date: Thu, 29 Nov 2018 12:51:09 +0300 >>>> >>>> > I guess I'm confused regarding what you'd like to see on emacs-26. >>>> > Was there a patch to that effect posted in this discussion, and if so, >>>> > could you point me to it, please? >>>> >>>> Sure, it's in message https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33050#89 >>> >>> Thanks, now pushed to the emacs-26 branch. >> >> Ok, I pushed the unconditional setting on master and am closing this >> bug. > > Thanks Eli and Filipp for pushing these. Filipp, on master is there any > reason not to just leave process-connection-type at its default value? > The patch I was going to push for this is attached. > > Thomas I find explicit setting more descriptive, but if you think default is better - please push :-) Filipp From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 22 10:05:59 2018 Received: (at 33050) by debbugs.gnu.org; 22 Dec 2018 15:05:59 +0000 Received: from localhost ([127.0.0.1]:60124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaiql-0007jo-39 for submit@debbugs.gnu.org; Sat, 22 Dec 2018 10:05:59 -0500 Received: from mail-io1-f47.google.com ([209.85.166.47]:43931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gaiqh-0007jZ-J5 for 33050@debbugs.gnu.org; Sat, 22 Dec 2018 10:05:56 -0500 Received: by mail-io1-f47.google.com with SMTP id q17so2617449ior.10 for <33050@debbugs.gnu.org>; Sat, 22 Dec 2018 07:05:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UwITwrn3BwQ3wZHXNvzx/N9puvWhEBDcHG1m/0yP0ME=; b=nvGjdHufx28kcuGUBN6sY1vT8a/rSXSxtFbuN7WUNqzl+owxkfWtKxJWQ9nPhzDniZ F7Y+kSm63NpsB7WytPMajf/qiDFByVSXPiHNIfiDHQM5MaNPyo+V34u4xnCsKqdJWAd6 19YjCqc43n68nw4Ret6LePNN15o3KEKI8yo+0BWIEDrS5TqhIXF5KlrgFArkJ6g2S0Yc JzUQCSu0hKI1S5Yp9MD1KXkofE3QGiuFEsBdbt3U01I5vIVcfu6mEhuLsaZ/wYuyArrd lJ1z+6xKnKebfWcAbUOfYPkSpRw0vDGvXgLhjLSM4dHiXSymRm+uhlxk1zZMpWjhmXci Eumw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UwITwrn3BwQ3wZHXNvzx/N9puvWhEBDcHG1m/0yP0ME=; b=hdF9M1O5pUnqWifsazlmxI00TKtu2p6hJ7xMFhCEC8a7hjNgDRs5l/rbXN4HgcJxL+ qC4njKpb2R7jTUyZzwdzvv5U7NC7nuSiK+QPMmObbj5OAkRG7eHv2Yg8iH2RgO0AXvkH vCKLAS+TJP3Z03QbEYrf5JrtmZZ2EAcihHaM7nFVGPdrN286IgmfV8I1mD6JD9tLunyr rzq6dMgwRWAHDGrxn7HfeFktDb+wJL0Ohq/hqH6jG0Onpj0S4zATf+Z1Fnm49C0IpCSm G6nmIhQzjCdYOFrKcT6FoYL3cvKvxd3ZXok1YSIetSv/Kp7r7HrIn3Z796maLipZ1BqO XWZw== X-Gm-Message-State: AJcUukd7SuO5j0QG4eY5x1uyROPQ3m95Ds9z6zVTFGKyy/J/TfuTnpkZ E6J2c3Wvw2dVHOYogUOrq/xQutVljeI= X-Google-Smtp-Source: ALg8bN6dpM++gfzY1cfLbyYG1w1w/vUkDeuDx6dIBkoLspKQuBrTc6x0f7Dv/luo2908ECLwT8AcDg== X-Received: by 2002:a6b:7c04:: with SMTP id m4mr1096696iok.122.1545491149884; Sat, 22 Dec 2018 07:05:49 -0800 (PST) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id v19sm8170694itb.0.2018.12.22.07.05.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Dec 2018 07:05:48 -0800 (PST) From: Thomas Fitzsimmons To: Filipp Gunbin Subject: Re: bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil References: <83ftwuq9ii.fsf@gnu.org> <83a7n2q6jb.fsf@gnu.org> <83sh0tp4z4.fsf@gnu.org> <83d0qoe4bz.fsf@gnu.org> <834lc0dyw1.fsf@gnu.org> <8336rkdv3g.fsf@gnu.org> Date: Sat, 22 Dec 2018 10:05:47 -0500 In-Reply-To: (Filipp Gunbin's message of "Tue, 04 Dec 2018 15:37:36 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33050 Cc: 33050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Filipp Gunbin writes: > On 03/12/2018 09:17 -0500, Thomas Fitzsimmons wrote: > >> Filipp Gunbin writes: >> >>> On 29/11/2018 12:41 +0200, Eli Zaretskii wrote: >>> >>>>> From: Filipp Gunbin >>>>> Cc: eggert@cs.ucla.edu, fitzsim@fitzsim.org, 33050@debbugs.gnu.org >>>>> Date: Thu, 29 Nov 2018 12:51:09 +0300 >>>>> >>>>> > I guess I'm confused regarding what you'd like to see on emacs-26. >>>>> > Was there a patch to that effect posted in this discussion, and if so, >>>>> > could you point me to it, please? >>>>> >>>>> Sure, it's in message https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33050#89 >>>> >>>> Thanks, now pushed to the emacs-26 branch. >>> >>> Ok, I pushed the unconditional setting on master and am closing this >>> bug. >> >> Thanks Eli and Filipp for pushing these. Filipp, on master is there any >> reason not to just leave process-connection-type at its default value? >> The patch I was going to push for this is attached. >> >> Thomas > > I find explicit setting more descriptive, but if you think default is > better - please push :-) OK, pushed. I put a comment in to reference this discussion. Thomas From unknown Fri Jun 20 07:18:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 20 Jan 2019 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator