GNU bug report logs - #33043
27.0.50; wishlist: rcirc should allow truncation of visible URLs

Previous Next

Full log

Message #28 received at 33043 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 33043 <at> debbugs.gnu.org, dme <at> dme.org
Subject: Re: bug#33043: [PATCH v1 1/1] Support for the truncation of displayed
 URLs
Date: Sun, 28 Oct 2018 03:14:39 +0000

[0001-Add-URL-truncation-support-to-rcirc-bug-33043.patch (text/x-diff, attachment)]

[0002-Reuse-URL-truncation-function-in-rcirc-bug-33043.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
>> Date: Thu, 18 Oct 2018 11:38:04 +0100
>> Cc: 33043 <at> debbugs.gnu.org
>> 
>> > I didn't know about url-truncate-url-for-viewing, no other reason.
>> >
>> > I'd be happy with your change, but note that it will always truncate
>> > URLs that are wider than the current frame - there is no way to have no
>> > truncation take place.
>> >
>> > If a user is most familiar with something like ffap to open URLs then
>> > this is unfortunate - ffap doesn't see the full URL in the buffer.
>> 
>> Sorry, that was an oversight.  Here's how the last patch can be patched
>> to support the default of no truncation:
>
> If you two are in agreement wrt what should be installed, I'd need a
> full changeset from Basil to push.

I attach two patches.  The first comprises David's original patch, but
with an added :version tag and reworded commit message.  The second
switches to reusing url-truncate-url-for-viewing.  WDYT?

Thanks,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.