From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 14 16:18:32 2018 Received: (at submit) by debbugs.gnu.org; 14 Oct 2018 20:18:32 +0000 Received: from localhost ([127.0.0.1]:49603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBmqK-0001Hi-Id for submit@debbugs.gnu.org; Sun, 14 Oct 2018 16:18:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBmqJ-0001HW-4D for submit@debbugs.gnu.org; Sun, 14 Oct 2018 16:18:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gBmqC-000877-TB for submit@debbugs.gnu.org; Sun, 14 Oct 2018 16:18:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,UNPARSEABLE_RELAY autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57362) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gBmqB-00082U-2J for submit@debbugs.gnu.org; Sun, 14 Oct 2018 16:18:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBmq9-0004W2-U4 for guix-patches@gnu.org; Sun, 14 Oct 2018 16:18:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gBmq5-0007un-7G for guix-patches@gnu.org; Sun, 14 Oct 2018 16:18:17 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:49792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBmq4-0007tR-1Y for guix-patches@gnu.org; Sun, 14 Oct 2018 16:18:12 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 2B16F16709; Sun, 14 Oct 2018 21:18:11 +0100 (BST) Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id D18941667A for ; Sun, 14 Oct 2018 21:18:10 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id fd895b6b for ; Sun, 14 Oct 2018 20:18:10 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] gnu: Add soundconverter. Date: Sun, 14 Oct 2018 21:18:10 +0100 Message-Id: <20181014201810.619-1-mail@cbaines.net> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/packages/gnome.scm (soundconverter): New variable. --- gnu/packages/gnome.scm | 61 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index de938e4b14..ab7352e104 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -7220,6 +7220,67 @@ It supports ripping to any audio codec supported b= y a GStreamer plugin, such as mp3, Ogg Vorbis and FLAC") (license license:gpl2+))) =20 +(define-public soundconverter + (package + (name "soundconverter") + (version "3.0.0") + (source + (origin + (method url-fetch) + (uri (string-append "https://launchpad.net/soundconverter/trunk/" + version "/+download/" + "soundconverter-" version ".tar.xz")) + + (sha256 + (base32 + "1wrxf5py54xplrf97qp24pzbis0cvax5c6k0c7vr3z3ry8r7gd7c")) + (patches + (list + (origin + (method url-fetch) + (uri (string-append + "https://salsa.debian.org/multimedia-team/soundconverte= r" + "/raw/master/debian/patches/" + "0002-Only-fetch-profiles-if-GConf-is-still-available.p= atch")) + (sha256 + (base32 + "00nxpbkz7ihzrbz91ms7bd2mjgyhkbxpaa8zxj4xnkv4pjmg61hh")))))= )) + (build-system glib-or-gtk-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'fix-POTFILES.in + (lambda _ + (substitute* "po/POTFILES.in" + (("soundconverter/gconfstore\\.py") "")))) + (add-after 'install 'wrap-rhythmbox + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (python-path (getenv "PYTHONPATH")) + (gi-typelib-path (getenv "GI_TYPELIB_PATH")) + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))= ) + (wrap-program (string-append out "/bin/soundconverter") + `("PYTHONPATH" ":" prefix (,python-path)) + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path= )) + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path= )))) + #t))))) + (native-inputs + `(("intltool" ,intltool) + ("pkg-config" ,pkg-config) + ("glib:bin" ,glib "bin"))) + (inputs + `(("gtk+" ,gtk+) + ("python" ,python) + ("python-pygobject" ,python-pygobject) + ("gstreamer" ,gstreamer))) + (home-page "http://soundconverter.org/") + (synopsis "Audio file converter for the GNOME Desktop") + (description + "SoundConverter supports converting between many audio formats incl= uding +Opus, Ogg Vorbis, FLAC and more. It supports parallel conversion, and +configurable file renaming. ") + (license license:gpl3))) + (define-public workrave (let ((commit "v1_10_21")) (package --=20 2.19.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 16 12:43:33 2018 Received: (at 33042) by debbugs.gnu.org; 16 Oct 2018 16:43:33 +0000 Received: from localhost ([127.0.0.1]:53878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCSRR-0003nK-Bk for submit@debbugs.gnu.org; Tue, 16 Oct 2018 12:43:33 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:42825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCSRP-0003nA-8n for 33042@debbugs.gnu.org; Tue, 16 Oct 2018 12:43:32 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 25B83753; Tue, 16 Oct 2018 12:43:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 16 Oct 2018 12:43:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=sQ/ptX/l48IqSFUEmhqK4xY+ 6CT6/Jz/+TbbT+X8ZMc=; b=jDRSiMz+oW8yPp6eWnFTA9KKlLY07XqL6MpCLRIB j6c+8p8ge8LFlAxam74RMmuzUHKK30zim74jmn2cNplfZvke9cZIwtjaSkR6aXLu 5gHE1NpAAErypl/CzDzX3Cei/GNvruQUB/eA5DNvSH8VDB4VZl66a5qjInHxDp0t jF8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=sQ/ptX /l48IqSFUEmhqK4xY+6CT6/Jz/+TbbT+X8ZMc=; b=TZK9U/JVn2X2dYr3CvMzpc EM7Tc45nWE5qYn8gbVG+SkJi8VTcWiBPMQZVOSRQNMMNomkCerpBvzHdtz8xqb4g 9Yq6PLTixugGkwOgdYzAF0BnbmVMNCQngYncHDfaJr1knBvzgyxlUE20TaWhDwN1 +wRQQB43Jy0xkML9Srcdy+5pxxG1KIDjA/5MU/GXSFxSqo2YrvhCQY8rVvj05sJB sKdfQrIlVmAPvCAtjwQHhheo0XfE5VVdlTZoKa0zLgbOR0qqzz5+9c1e8UrJbCcf vnulI1In2F2gz8Vn3JX/7QbQMV5BIqIaVgmkpv1ruywJRJ+6FY7gCXx7aP/JCoQw == X-ME-Sender: X-ME-Proxy: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 9CAFBE43A6; Tue, 16 Oct 2018 12:43:28 -0400 (EDT) Date: Tue, 16 Oct 2018 12:43:27 -0400 From: Leo Famulari To: Christopher Baines Subject: Re: [bug#33042] [PATCH] gnu: Add soundconverter. Message-ID: <20181016164327.GC25057@jasmine.lan> References: <20181014201810.619-1-mail@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZmUaFz6apKcXQszQ" Content-Disposition: inline In-Reply-To: <20181014201810.619-1-mail@cbaines.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33042 Cc: 33042@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --ZmUaFz6apKcXQszQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Oct 14, 2018 at 09:18:10PM +0100, Christopher Baines wrote: > * gnu/packages/gnome.scm (soundconverter): New variable. Thanks, it's nice to have graphical programs for this sort of task :) > + (patches > + (list > + (origin > + (method url-fetch) > + (uri (string-append > + "https://salsa.debian.org/multimedia-team/soundconverter" > + "/raw/master/debian/patches/" > + "0002-Only-fetch-profiles-if-GConf-is-still-available.patch")) > + (sha256 > + (base32 > + "00nxpbkz7ihzrbz91ms7bd2mjgyhkbxpaa8zxj4xnkv4pjmg61hh"))))))) I think it's better if we include this file in our source code, since it's not very big and Debian's code infrastructure URLs seem to change every few years. Also, the URL is not versioned, so maybe the patch would change in the future. > + (add-after 'unpack 'fix-POTFILES.in > + (lambda _ > + (substitute* "po/POTFILES.in" > + (("soundconverter/gconfstore\\.py") "")))) Please add an explanatory comment for this. > + (add-after 'install 'wrap-rhythmbox > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out")) > + (python-path (getenv "PYTHONPATH")) > + (gi-typelib-path (getenv "GI_TYPELIB_PATH")) > + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))) > + (wrap-program (string-append out "/bin/soundconverter") > + `("PYTHONPATH" ":" prefix (,python-path)) > + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)) > + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))) > + #t))))) If possible, I think it's better to use the python-build-system's wrap phase for PYTHONPATH. The hplip package has an example. > + (synopsis "Audio file converter for the GNOME Desktop") It works in i3, too :) --ZmUaFz6apKcXQszQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlvGFS8ACgkQJkb6MLrK fwjrCw/+Oewa7FHBGiKK687mke+YoZwbTrpp2sOCIvKe1E0SGliHfp27gmPpn7Ev xFyHgyL/g10XAEgSCYdwA310/bkTf9qplZmVhuTuUXBU7d8+Mu39L4hD+UsTzivW AVd/WrnyMUZh7pgJOKJAwJdi9YfZULv3f9t9KmC1HoWiAzCHCGmZSDtXkpyXO/kv KiDBPbA+hqj4O7GjOhVtmDyOfTphiuMCEeZjnIpo538m0C5EycY172jPb9Kus9fY Jjeslgal9cMbKEeBud7EWGkm6F93RyQKIXKL6bAEeGcIpTM1C5Zj3tP1FDHU+WnE xfEVb9S5r3HvhxbscNI5DE3LWaJ1478iRj1UIJTrEEPOniDmOLt//453oHX/qfJ0 1eDTBR6YEdCV1qYn/5HvfZp2dmALbUwfKjTeFlzsTMQ6jCV9J0f7+tRV1uqWMC5z dk4Graknh7i24aPJbkUw5toJE1SAgxaQf8cJwFlNxZUsM08n0xKr1U5O+jvi2uD8 Wom37eTMsS/UezbPZcEzuEJaCQ/tw5qSZdDZOKAwpvJqNdf6KVZQHBVuaJbQBl1h 7iYVZvCOVRHLiqrlIdVod2+H/Yaq8RrqmrRiiGUwQoAz+u2XDvSm87OK8MPPXmUr aF8HYoJlAxifAwkMnF73aJu95u1vHePGw0rm3JuPeArXOM+f7XQ= =SMoI -----END PGP SIGNATURE----- --ZmUaFz6apKcXQszQ-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 19 09:43:38 2018 Received: (at 33042) by debbugs.gnu.org; 19 Oct 2018 13:43:38 +0000 Received: from localhost ([127.0.0.1]:58265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDV3p-0001WT-U4 for submit@debbugs.gnu.org; Fri, 19 Oct 2018 09:43:38 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:37216 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDV3n-0001WL-K5 for 33042@debbugs.gnu.org; Fri, 19 Oct 2018 09:43:28 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 025CD1652A; Fri, 19 Oct 2018 14:43:27 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 11238164B2 for <33042@debbugs.gnu.org>; Fri, 19 Oct 2018 14:43:26 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id ed80c1c7 for <33042@debbugs.gnu.org>; Fri, 19 Oct 2018 13:43:25 +0000 (UTC) From: Christopher Baines To: 33042@debbugs.gnu.org Subject: [PATCH] gnu: Add soundconverter. Date: Fri, 19 Oct 2018 14:43:25 +0100 Message-Id: <20181019134325.22400-1-mail@cbaines.net> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33042 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/gnome.scm (soundconverter): New variable. * gnu/packages/patches/soundconverter-remove-gconf-dependency.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. --- gnu/local.mk | 1 + gnu/packages/gnome.scm | 65 +++++++++++++++ ...undconverter-remove-gconf-dependency.patch | 83 +++++++++++++++++++ 3 files changed, 149 insertions(+) create mode 100644 gnu/packages/patches/soundconverter-remove-gconf-dependency.patch diff --git a/gnu/local.mk b/gnu/local.mk index af3773c893..6108ba8b82 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1146,6 +1146,7 @@ dist_patch_DATA = \ %D%/packages/patches/slim-reset.patch \ %D%/packages/patches/slim-login.patch \ %D%/packages/patches/sooperlooper-build-with-wx-30.patch \ + %D%/packages/patches/soundconverter-remove-gconf-dependency.patch \ %D%/packages/patches/soundtouch-CVE-2018-14044-14045.patch \ %D%/packages/patches/soundtouch-CVE-2018-1000223.patch \ %D%/packages/patches/steghide-fixes.patch \ diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index de938e4b14..2b75439a95 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -7220,6 +7220,71 @@ It supports ripping to any audio codec supported by a GStreamer plugin, such as mp3, Ogg Vorbis and FLAC") (license license:gpl2+))) +(define-public soundconverter + (package + (name "soundconverter") + (version "3.0.0") + (source + (origin + (method url-fetch) + (uri (string-append "https://launchpad.net/soundconverter/trunk/" + version "/+download/" + "soundconverter-" version ".tar.xz")) + + (sha256 + (base32 + "1wrxf5py54xplrf97qp24pzbis0cvax5c6k0c7vr3z3ry8r7gd7c")) + (patches + (search-patches + "soundconverter-remove-gconf-dependency.patch")))) + (build-system glib-or-gtk-build-system) + (arguments + `(#:imported-modules ((guix build python-build-system) + (guix build glib-or-gtk-build-system) + ,@%gnu-build-system-modules) + + #:modules ((guix build glib-or-gtk-build-system) + (guix build utils) + ((guix build gnu-build-system) #:prefix gnu:) + ((guix build python-build-system) #:prefix python:)) + + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'fix-POTFILES.in + (lambda _ + (substitute* "po/POTFILES.in" + ;; This file doesn't exist, so without removing it, the 'check + ;; phase fails for the po directory + (("soundconverter/gconfstore\\.py") "")))) + (add-after 'install 'wrap-soundconverter-for-python + (assoc-ref python:%standard-phases 'wrap)) + (add-after 'install 'wrap-soundconverter + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (gi-typelib-path (getenv "GI_TYPELIB_PATH")) + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))) + (wrap-program (string-append out "/bin/soundconverter") + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)) + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))) + #t))))) + (native-inputs + `(("intltool" ,intltool) + ("pkg-config" ,pkg-config) + ("glib:bin" ,glib "bin"))) + (inputs + `(("gtk+" ,gtk+) + ("python" ,python) + ("python-pygobject" ,python-pygobject) + ("gstreamer" ,gstreamer) + ("gst-plugins-base" ,gst-plugins-base))) + (home-page "http://soundconverter.org/") + (synopsis "Audio file converter for the GNOME Desktop") + (description + "SoundConverter supports converting between many audio formats including +Opus, Ogg Vorbis, FLAC and more. It supports parallel conversion, and +configurable file renaming. ") + (license license:gpl3))) + (define-public workrave (let ((commit "v1_10_21")) (package diff --git a/gnu/packages/patches/soundconverter-remove-gconf-dependency.patch b/gnu/packages/patches/soundconverter-remove-gconf-dependency.patch new file mode 100644 index 0000000000..f065b9a3d4 --- /dev/null +++ b/gnu/packages/patches/soundconverter-remove-gconf-dependency.patch @@ -0,0 +1,83 @@ +From: Sebastian Ramacher +Date: Fri, 6 Apr 2018 13:25:35 +0200 +Subject: Only fetch profiles if GConf is still available + +--- + bin/soundconverter.py | 1 - + soundconverter/gstreamer.py | 44 ++++++++++++++++++++++++-------------------- + 2 files changed, 24 insertions(+), 21 deletions(-) + +diff --git a/bin/soundconverter.py b/bin/soundconverter.py +index 39055ce..5198443 100644 +--- a/bin/soundconverter.py ++++ b/bin/soundconverter.py +@@ -66,7 +66,6 @@ def _check_libs(): + import gi + gi.require_version('Gst', '1.0') + gi.require_version('Gtk', '3.0') +- gi.require_version('GConf', '2.0') + from gi.repository import GObject + # force GIL creation - see https://bugzilla.gnome.org/show_bug.cgi?id=710447 + import threading +diff --git a/soundconverter/gstreamer.py b/soundconverter/gstreamer.py +index 23aaa9b..211b052 100644 +--- a/soundconverter/gstreamer.py ++++ b/soundconverter/gstreamer.py +@@ -25,7 +25,7 @@ from urllib.parse import urlparse + from gettext import gettext as _ + + import gi +-from gi.repository import Gst, Gtk, GObject, GConf, Gio ++from gi.repository import Gst, Gtk, GObject, Gio + + from soundconverter.fileoperations import vfs_encode_filename, file_encode_filename + from soundconverter.fileoperations import unquote_filename, vfs_makedirs, vfs_unlink +@@ -66,25 +66,29 @@ _GCONF_PROFILE_LIST_PATH = "/system/gstreamer/1.0/audio/global/profile_list" + audio_profiles_list = [] + audio_profiles_dict = {} + +-_GCONF = GConf.Client.get_default() +-profiles = _GCONF.all_dirs(_GCONF_PROFILE_LIST_PATH) +-for name in profiles: +- if _GCONF.get_bool(_GCONF_PROFILE_PATH + name + "/active"): +- # get profile +- description = _GCONF.get_string(_GCONF_PROFILE_PATH + name + "/name") +- extension = _GCONF.get_string(_GCONF_PROFILE_PATH + name + "/extension") +- pipeline = _GCONF.get_string(_GCONF_PROFILE_PATH + name + "/pipeline") +- # check profile validity +- if not extension or not pipeline: +- continue +- if not description: +- description = extension +- if description in audio_profiles_dict: +- continue +- # store +- profile = description, extension, pipeline +- audio_profiles_list.append(profile) +- audio_profiles_dict[description] = profile ++try: ++ from gi.repository import GConf ++ _GCONF = GConf.Client.get_default() ++ profiles = _GCONF.all_dirs(_GCONF_PROFILE_LIST_PATH) ++ for name in profiles: ++ if _GCONF.get_bool(_GCONF_PROFILE_PATH + name + "/active"): ++ # get profile ++ description = _GCONF.get_string(_GCONF_PROFILE_PATH + name + "/name") ++ extension = _GCONF.get_string(_GCONF_PROFILE_PATH + name + "/extension") ++ pipeline = _GCONF.get_string(_GCONF_PROFILE_PATH + name + "/pipeline") ++ # check profile validity ++ if not extension or not pipeline: ++ continue ++ if not description: ++ description = extension ++ if description in audio_profiles_dict: ++ continue ++ # store ++ profile = description, extension, pipeline ++ audio_profiles_list.append(profile) ++ audio_profiles_dict[description] = profile ++except ImportError: ++ pass + + required_elements = ('decodebin', 'fakesink', 'audioconvert', 'typefind', 'audiorate') + for element in required_elements: -- 2.19.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 19 10:05:46 2018 Received: (at 33042) by debbugs.gnu.org; 19 Oct 2018 14:05:46 +0000 Received: from localhost ([127.0.0.1]:59634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDVPM-0002Od-Mt for submit@debbugs.gnu.org; Fri, 19 Oct 2018 10:05:44 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:37252 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDVPK-0002OU-Fm for 33042@debbugs.gnu.org; Fri, 19 Oct 2018 10:05:43 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 87004165A6; Fri, 19 Oct 2018 15:05:41 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 4AAFC1652A; Fri, 19 Oct 2018 15:05:38 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ccafd903; Fri, 19 Oct 2018 14:05:37 +0000 (UTC) References: <20181014201810.619-1-mail@cbaines.net> <20181016164327.GC25057@jasmine.lan> User-agent: mu4e 1.0; emacs 26.1 From: Christopher Baines To: Leo Famulari Subject: Re: [bug#33042] [PATCH] gnu: Add soundconverter. In-reply-to: <20181016164327.GC25057@jasmine.lan> Date: Fri, 19 Oct 2018 15:05:35 +0100 Message-ID: <87o9bqav68.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33042 Cc: 33042@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Leo Famulari writes: > On Sun, Oct 14, 2018 at 09:18:10PM +0100, Christopher Baines wrote: >> * gnu/packages/gnome.scm (soundconverter): New variable. > > Thanks, it's nice to have graphical programs for this sort of task :) Yeah, thanks for taking a look. I've sent an updated patch :) >> + (patches >> + (list >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "https://salsa.debian.org/multimedia-team/soundconverter" >> + "/raw/master/debian/patches/" >> + "0002-Only-fetch-profiles-if-GConf-is-still-available.patch")) >> + (sha256 >> + (base32 >> + "00nxpbkz7ihzrbz91ms7bd2mjgyhkbxpaa8zxj4xnkv4pjmg61hh"))))))) > > I think it's better if we include this file in our source code, since > it's not very big and Debian's code infrastructure URLs seem to change > every few years. Also, the URL is not versioned, so maybe the patch > would change in the future. Sure, I've included the file now. This patch has been merged upstream, so hopefully it can be removed here when the next release comes out. >> + (add-after 'unpack 'fix-POTFILES.in >> + (lambda _ >> + (substitute* "po/POTFILES.in" >> + (("soundconverter/gconfstore\\.py") "")))) > > Please add an explanatory comment for this. I have done. This has also been fixed upstream, so hopefully can also be removed on the next release. >> + (add-after 'install 'wrap-rhythmbox >> + (lambda* (#:key inputs outputs #:allow-other-keys) >> + (let ((out (assoc-ref outputs "out")) >> + (python-path (getenv "PYTHONPATH")) >> + (gi-typelib-path (getenv "GI_TYPELIB_PATH")) >> + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))) >> + (wrap-program (string-append out "/bin/soundconverter") >> + `("PYTHONPATH" ":" prefix (,python-path)) >> + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)) >> + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))) >> + #t))))) > > If possible, I think it's better to use the python-build-system's wrap > phase for PYTHONPATH. The hplip package has an example. I've changed this now. >> + (synopsis "Audio file converter for the GNOME Desktop") > > It works in i3, too :) I couldn't quite work out how better to get across that it's a graphical application, as compared to a command line tool. But, as you say, it's not specific to GNOME. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlvJ5K9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdYuxAAseLAJfzRvqU8g6SBmPNZghA9J49cf1mfqzFw+KerEqKkDE/TtC+iyTEQ 8F9gkqxT2YZIpG0sIoqv/FK+6RJ4+q+9RUN+G33uul5rTp56YEjDuHT2Hc+pmIR2 xQei5eJZE6ccIH8P2RzEbHUHKvuzBQB6iaCgmO3v0CPXsQTN6qwv3I+Ap1rYl0aW HYijzgXfBX0ddgmlOqf8cmlkmTmpK8WoI9BS9imLSM+4S0r8y0x0876+RygOgtEq J8f3MyVlbIiXOdDNk0iuiplzIn4dJ1TlOwFfzSdqiDg42loyHP3YO6zdrcKK+u1E nypkiQ3TIEfoCjDzIDadSrxTIcP3cKTanfMeAJXSxvp71W4OEMKK1gtD9ZK4G+YA mrEEerTZza616KiU/wi1Tdc0VQOm8eNqu+JUnvC+fi4eBZjUDrWQM4cZ0nvWqToS ZbyAhB1kboBdDpFvS6h1HMonSVY67h1Y4rdo4n4bq2rbyCp89d1ldlsaG3h/W7z5 1P3PnM6IS5Su8bQZrzGKnY775zC2JY5afntN6bs2YclD7YwZN3Svs0tX/Cn3RDJ6 ODXnIlvuDKrNcEzpE/VpDcNvQl+CCullbU660p1x6sPJZHJLyZLPbLapu40sEdBc Tg+RoURke9dTcwdAAakgKQv8uqooM/qfSU2YCUiAX4SAh24tRSs= =jlYA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 19 16:08:39 2018 Received: (at 33042) by debbugs.gnu.org; 19 Oct 2018 20:08:39 +0000 Received: from localhost ([127.0.0.1]:59807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDb4Z-0002SK-KX for submit@debbugs.gnu.org; Fri, 19 Oct 2018 16:08:39 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:57851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDb4W-0002SB-Sr for 33042@debbugs.gnu.org; Fri, 19 Oct 2018 16:08:38 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id C0542C3D; Fri, 19 Oct 2018 16:08:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 19 Oct 2018 16:08:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=Jo/xy8f6gGMVEeB7EfZvteH1 5QSIULtYeYx6lrzftjk=; b=1+fJ/L5UgzRpGi9I/QF523d6rnJDIeZ9CZrXe69x riS6VmhAW8N9vsYJNGFk0PkxL+qiECDrXISsKkCuH2nBz+A3dxPtn3jex+hcOYZX y1/TNUwKEVgUu7yMqIInRvPiEkIocNVVqR2EG0Q8GkJwzBWdBQPU6Ysh8FzhEh/T uew= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Jo/xy8 f6gGMVEeB7EfZvteH15QSIULtYeYx6lrzftjk=; b=XSCNAze2VT2JqrM8Ua1ydE RtYwHOtzR9l0dOzcL89ihFse/jRVFLxBPzAaounzjOGokpXPC6ltWsRqftHb2ZRZ X92QAoW+hhwwU9kDYZCjfv7FJQRtbaOuC4MBhKwGHzNnSym8wbIJpN1qEbfh0o3W jIFGGHAWWPl+iOATM3FwfIL4ZTAMJLpDiWpbHZXGQPIpVw1uEG8JsZ+ak8ozBqPo COgHWxbSOsa2NMTXJugjiGbWminbF0VT7EF8qnkHvPmz1RRIjknBD2auDLB9sAA9 YhCrBabcVu+cCaEXD6Z56XAHVAA3/tcU098P7yej8GNRRG9V9aPB2Bmg4mVktT5w == X-ME-Sender: X-ME-Proxy: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id EFA6CE4071; Fri, 19 Oct 2018 16:08:33 -0400 (EDT) Date: Fri, 19 Oct 2018 16:08:32 -0400 From: Leo Famulari To: Christopher Baines Subject: Re: [bug#33042] [PATCH] gnu: Add soundconverter. Message-ID: <20181019200832.GB9979@jasmine.lan> References: <20181014201810.619-1-mail@cbaines.net> <20181016164327.GC25057@jasmine.lan> <87o9bqav68.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: <87o9bqav68.fsf@cbaines.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33042 Cc: 33042@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 19, 2018 at 03:05:35PM +0100, Christopher Baines wrote: > >> + (synopsis "Audio file converter for the GNOME Desktop") > > > > It works in i3, too :) >=20 > I couldn't quite work out how better to get across that it's a graphical > application, as compared to a command line tool. But, as you say, it's > not specific to GNOME. I would say something like this: "Convert between audio formats in a graphical interface". LGTM with that change! --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlvKOb0ACgkQJkb6MLrK fwjA3RAA0wTN70F4/mvvD4qlinjS6qjbjPhyksLEJpSVMqXhQKkg724KOUV16JnS 0dDDH8dPmriwdQw50DTqT+j+trgpwewCpX00r8qIN0u71OMIPUs90XMFKemmC7ch xUFEwCR/ghC9fQ9yzQ7NIk8P4VUztY16tg4FVnwGU5F18VIuWIsNBPbiz8VzRBaN TFEHEkjKzRkgPCvtUx0kZCdWdF4Nx9YHuqtUB4Q92fV6XktBWvTe4Q8+DiT/nZj9 IQhu9tsGXgwqzkUsaT0IKZr2GSldpBXIEH5YZ9Cmn9t63+5NuS5nMRQi/U210n6I SzHL2VWbjDnmLUH+TMN+o6IDKfB1AgXCjWLo/Kqab0Lk793BleJWYYHIHTj9DAOA 7QcurCUMdRez6cLXNrsbEz+X1Rwnw7+xigLerW4zM7Jk5Cm01chwvJLrFOY+qWeR FPeajeGDhp1eGg4VfIG/cPLpg0N2jT+U2I/pUu2bCHRFVGroQwR49j+QZuwMMGIZ yQYahKtgRFDY18E5JYr4JzIGGyZ15lwswHHn1t9EaPpDATUi5UAC76hhH56IpKcN IOBPyVaKvUXE3fLF3rzbRXRfZeAz+JURpBWwcq+54P/UpDcq9CpaLf6QuOX+c452 yBnK2jmxPTPouLjIg446gzUXOL7/8gIggXPu0GPCr7ORmBXGv3c= =953L -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 20 07:31:19 2018 Received: (at 33042-done) by debbugs.gnu.org; 20 Oct 2018 11:31:19 +0000 Received: from localhost ([127.0.0.1]:60319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDpTT-0007zf-Cl for submit@debbugs.gnu.org; Sat, 20 Oct 2018 07:31:19 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:37956 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDpTR-0007xB-3m for 33042-done@debbugs.gnu.org; Sat, 20 Oct 2018 07:31:17 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 4DEDA1666B; Sat, 20 Oct 2018 12:31:16 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 11E32164B2; Sat, 20 Oct 2018 12:31:15 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id b485da82; Sat, 20 Oct 2018 11:31:14 +0000 (UTC) References: <20181014201810.619-1-mail@cbaines.net> <20181016164327.GC25057@jasmine.lan> <87o9bqav68.fsf@cbaines.net> <20181019200832.GB9979@jasmine.lan> User-agent: mu4e 1.0; emacs 26.1 From: Christopher Baines To: Leo Famulari Subject: Re: [bug#33042] [PATCH] gnu: Add soundconverter. In-reply-to: <20181019200832.GB9979@jasmine.lan> Date: Sat, 20 Oct 2018 12:31:12 +0100 Message-ID: <87lg6sc0sf.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33042-done Cc: 33042-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Fri, Oct 19, 2018 at 03:05:35PM +0100, Christopher Baines wrote: >> >> + (synopsis "Audio file converter for the GNOME Desktop") >> > >> > It works in i3, too :) >>=20 >> I couldn't quite work out how better to get across that it's a graphical >> application, as compared to a command line tool. But, as you say, it's >> not specific to GNOME. > > I would say something like this: "Convert between audio formats in a > graphical interface". > > LGTM with that change! Great, I went with "with a" rather than "in a" as that reads a bit better to me, and I've pushed this to master now. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlvLEgBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfpJg//ba+Wvt/q2MU7cT2l3onGxlZLwu4V0IAKUKBGL9kw9Con4DL/HHloPHiI XU2GRB8ts7Tkh6RP6mvYvnwbdm6A7t/lZPcA6lvgEO6fjRURtANbLCLfy8abLa57 IwX6y3mQMNTU8uiUoKip6876DQJb4rvZZfsbkQG211tPVXZSK+v58HhHUwRpZ6Vv U3HmbvHlR7hKAvmTw6AwJ2NTxr7mqKZ8fVQ4drlrEDp8KXaXmN7ZL0nr+ujhXF/m prp9yjv/OzWPVjyinwB5dvZ9C2NtUKl20cCrdg63I9QJsuJmY1AHFU0lP9tMldbD DfFWb2zg8nvzz6w3OsLU3dNgbGPdBmDX6v7PRWTmJo6eiyONwD1nrjx1209nNrwJ lzp0TS7B8kMRlmTmg3avP2+jeAW8RnVYM/8UtCXq3ofrZ71Kyo2f0Gb+lc+PVV2Z 20oqOf9Hp5hzGCqeUWdao8bc6v6twjn3JFfa/4braAAqMCOIdkp3qUGMb+VyxKcd LQQC7yaf1unSC4c4ULFjjQB30eKhvD0GtTt4oDrBR/9Aj7PeoCmSRkAcQSaWfZwk Feq/S6MDB+1g5mxdQIDAe6LH7ydwVAQmCj85FpH3ybCHbS7zbl9GaM5lCe50GIqP XLtMLiPA0C/7eYLdTgIQtMoOOVTnSZoOtRdcD12E31Opbj2C6vI= =U9O3 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 21 15:21:00 2018 Received: (at 33042-done) by debbugs.gnu.org; 21 Oct 2018 19:21:00 +0000 Received: from localhost ([127.0.0.1]:34594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gEJHY-0004Ju-Kl for submit@debbugs.gnu.org; Sun, 21 Oct 2018 15:21:00 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gEJHW-0004Jm-Rd for 33042-done@debbugs.gnu.org; Sun, 21 Oct 2018 15:20:59 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id F0CBC21AE0; Sun, 21 Oct 2018 15:20:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 21 Oct 2018 15:20:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=9ceqSuaDB1oXsYZk/fxpxhjG iAeiVNYSK1IbWKnsJ78=; b=01OdMH5xH7/2bhHs8i9ZfEppBCd5UM27PMzyhMoj X2uYUL7ur6fhZoJ2lCZ2gxwDp7OupKkwi8tvuYXaiODmHJudOtqflf1kJUmY0LDP 0NhnTkLYhXSVOlnUaWsFI6OADioPuw2cBGVrfQv7w6LbewE8KNH171ZHgunc1QGu Jxg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9ceqSu aDB1oXsYZk/fxpxhjGiAeiVNYSK1IbWKnsJ78=; b=LhGajaHaCr5fdeqkFvG9qX agtI5DIZx/d72xI4vddFK3/MqZQteGNHpG6jL50W9C0AdadIuh2AIj5pilzc2ONj 1Rq/KWcWaf6N1zlDmdlWDeQe5HVKgzurQM6Xhkzak+WCDVmT7w2GqYpNgG2x0zK8 weB6XI5MWUg/V8PPX6Q75mQSnaANZy9Yk2s1q7chc9E9WaeA8UsU0DVXM5K11Lp5 irtWZe5qcFU3lMwStNDSxrNt1QVajF0VOTdzhiD2Rvv+Iru1ouqs3aZknZM9xAfn FanWMaRT1xVZG+vFeaawSqLyySpLaw31vLZfap+dvY3yt6mng6UmGGw+ZWvfzjww == X-ME-Sender: X-ME-Proxy: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 4DC29E421C; Sun, 21 Oct 2018 15:20:57 -0400 (EDT) Date: Sun, 21 Oct 2018 15:20:56 -0400 From: Leo Famulari To: Christopher Baines Subject: Re: [bug#33042] [PATCH] gnu: Add soundconverter. Message-ID: <20181021192056.GC18445@jasmine.lan> References: <20181014201810.619-1-mail@cbaines.net> <20181016164327.GC25057@jasmine.lan> <87o9bqav68.fsf@cbaines.net> <20181019200832.GB9979@jasmine.lan> <87lg6sc0sf.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4ZLFUWh1odzi/v6L" Content-Disposition: inline In-Reply-To: <87lg6sc0sf.fsf@cbaines.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33042-done Cc: 33042-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --4ZLFUWh1odzi/v6L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Oct 20, 2018 at 12:31:12PM +0100, Christopher Baines wrote: > Great, I went with "with a" rather than "in a" as that reads a bit > better to me, and I've pushed this to master now. Perfect! That does sound better. --4ZLFUWh1odzi/v6L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlvM0ZgACgkQJkb6MLrK fwjAmRAAyjHKeCVv9YHOSZY8J3NzjK8zq2ZivqbK0iDJXJkXbtNIk1KP4sqrHPzp yfBQXfkAeKYToliB2WgFOqNUiq7kU6sOATHbrETrqge0Msa8atjQzMqemeBjz13v zrlwzTQkY4WkFou/R6VrzSp34q9XccFKh+hdK0t10liy2Rnu2fb8v7I+ma3O7ccq 6XCHVfvgpFIBIYnBJU/bcO6Wt4vrSCYlxuDTXHh9FxrmhDp9BUpEnIcmoYcLWKDG nnXHihNJ4IQAirBJgIiYk7+lwwtsFQ+noe8VcG6WP/hp3Iql66gVSgyREAlCPdAA KSBvQeWHl7cw3SOF4NE3cU3+jr8yEf6gNe1K15F+oHyt50q/NWLk24vQq5KEZnKo YOxE1kL3b5AaOuyGRCxqjwTrpQNMzkGk2XvjCrQ8wwPOjIKmz15jeEmtVNVvAhXF s0tPf2pszuz0cPsEwEwa25YL52wwB81N9st+38X5QonVY+Z5XXC+CudQWy5l69/s VBVWHTR00YGyTaVf5G4WsowhPLjM1KwxEUxHhH0lbC5tKDvEpp4EAFUVPQ71iLK5 miTTl4eVNv6KXMOXyB2K1Kw6brNQzze3pdCJ9BS0xJj9+q+7V1OZzYKhm1OUq56T 8zURXkHYJ5kEeoT8EZPnFQjqNfg9J3gNVgrKm9Dz+NOBTJwKT1A= =APa+ -----END PGP SIGNATURE----- --4ZLFUWh1odzi/v6L-- From unknown Tue Jun 17 01:50:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 19 Nov 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator