Subject: Re: [bug#33020] [PATCH] gnu: Add nullmailer.

From: [email-masked] (Ludovic Courtès)
Date: Mon, 15 Oct 2018 22:01:26 +0200

Hello!

Tobias Geerinckx-Rice <[email-masked]> skribis:

> * gnu/packages/mail.scm (nullmailer): New public variable.

[...]

> +         (add-before 'check 'delete-failing-tests
> +           (lambda _
> +             (with-directory-excursion "test/tests"
> +               (for-each delete-file
> +                         (list
> +                          ;; XXX 'nullmailer-inject: nullmailer-queue failed: 15'
> +                          "inject/queue"
> +                          ;; XXX This equires the not-yet-packaged tcpserver.
> +                          "protocols")))

(Typo in the second comment.)

If the first failure something we should worry about?

> +    (synopsis "Simple relay-only mail transport agent")

s/transport/transfer/

> +    (description
> +     "Nullmailer is a simple replacement Mail Transfer Agent (@dfn{MTA}) for

I think you can remove @dfn here (normally it’s used on a phrase that is
being introduced, not on an abbreviation.)

Otherwise LGTM, thanks!

Ludo’.