GNU bug report logs - #33016
26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist

Previous Next

Full log

Message #23 received at 33016 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 33016 <at> debbugs.gnu.org, Klaus-Dieter Bauer <bauer.klaus.dieter <at> gmail.com>
Subject: Re: bug#33016: 26.1; (make-process ...) doesn't signal an error, when
 executable given as absolute Windows path does not exist
Date: Tue, 9 Apr 2019 10:13:58 -0400

[Message part 1 (text/plain, inline)]

On Mon, 8 Apr 2019 at 14:59, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > The confusing thing here is that the error is signaled between
> > block_input()...unblock_input(), which prevents the debugger from
> > triggering.

> > The attached patch fixes this by moving the signal to after the unblock_input().
>
> Thanks, but could we have a test for this, please?

Yes (I had initially thought it wouldn't work because of the way ert
uses the debugger internally, but it actually turns out fine).

By the way, I modified the error message in call_process in addition
to create_process for completeness, but I can't see a way to trigger
this for call_process: it searches for PROGRAM and signals an error
early, regardless of whether the filename is absolute or not.

[v2-0001-Let-debugger-handle-process-spawn-errors-on-w32-B.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.