From unknown Sun Jun 22 08:10:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32994: 27.0.50; Regression in image type auto-detection Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Oct 2018 23:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32994 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 32994@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15390397723489 (code B ref -1); Mon, 08 Oct 2018 23:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Oct 2018 23:02:52 +0000 Received: from localhost ([127.0.0.1]:40906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9eY8-0000uD-F8 for submit@debbugs.gnu.org; Mon, 08 Oct 2018 19:02:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9eY6-0000u0-VD for submit@debbugs.gnu.org; Mon, 08 Oct 2018 19:02:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9eY0-0000om-Bv for submit@debbugs.gnu.org; Mon, 08 Oct 2018 19:02:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59264) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9eY0-0000od-8P for submit@debbugs.gnu.org; Mon, 08 Oct 2018 19:02:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9eXz-00034S-JG for bug-gnu-emacs@gnu.org; Mon, 08 Oct 2018 19:02:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9eXv-0000nM-J4 for bug-gnu-emacs@gnu.org; Mon, 08 Oct 2018 19:02:43 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:42726 helo=pdx1-sub0-mail-a36.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9eXv-0000mm-Aj for bug-gnu-emacs@gnu.org; Mon, 08 Oct 2018 19:02:39 -0400 Received: from pdx1-sub0-mail-a36.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a36.g.dreamhost.com (Postfix) with ESMTP id 309468035F for ; Mon, 8 Oct 2018 16:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=Z1ZUKH0q3xSRjt2hSUlEGr3LlmU=; b=oMIOF+C8QPnQFf78n 71axz4SPcV3su3RAGQvPb5dK1uG1uLeaZIMN+AtAhSwU3Yg5fN+VTFE/VzMEl4Lq ZC2y2rzVd68taj8vsIMLTTKrzHTvtpuUZoq0t1iVfG0PMEK05wvYi0sB+OM0W4+n ltcovCKFSJcoCSn1WgsVFK3MXU= Received: from localhost.linkov.net (m91-129-107-184.cust.tele2.ee [91.129.107.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a36.g.dreamhost.com (Postfix) with ESMTPSA id 5985D80364 for ; Mon, 8 Oct 2018 16:02:35 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a36 From: Juri Linkov Organization: LINKOV.NET Date: Tue, 09 Oct 2018 01:08:13 +0300 Message-ID: <87woqst7le.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudefgddukecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrddukeegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehlohgtrghlhhhoshhtrdhlihhnkhhovhdrnhgvthdpihhnvghtpeeluddruddvledruddtjedrudekgedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Tags: patch A recent change in image-mode.el broke a useful feature that automatically detects an image type, so now visiting an image file without a file extension signals the error "upcase(nil) - (wrong-type-argument char-or-string-p nil)". This patch fixes it: diff --git a/lisp/image-mode.el b/lisp/image-mode.el index 19fa28d440..eb7b410f4a 100644 --- a/lisp/image-mode.el +++ b/lisp/image-mode.el @@ -781,8 +785,9 @@ image-toggle-display-image (defun image--imagemagick-wanted-p (filename) (and (fboundp 'imagemagick-types) (not (eq imagemagick-types-inhibit t)) - (not (memq (intern (upcase (file-name-extension filename)) obarray) - imagemagick-types-inhibit)))) + (not (and (file-name-extension filename) + (memq (intern (upcase (file-name-extension filename)) obarray) + imagemagick-types-inhibit))))) (defun image-toggle-hex-display () "Toggle between image and hex display." From unknown Sun Jun 22 08:10:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#32994: closed (Re: bug#32994: 27.0.50; Regression in image type auto-detection) Message-ID: References: <8736t6dels.fsf@mail.linkov.net> <87woqst7le.fsf@mail.linkov.net> X-Gnu-PR-Message: they-closed 32994 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 32994@debbugs.gnu.org Date: Mon, 15 Oct 2018 22:35:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1539642902-25708-1" This is a multi-part message in MIME format... ------------=_1539642902-25708-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #32994: 27.0.50; Regression in image type auto-detection which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 32994@debbugs.gnu.org. --=20 32994: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32994 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1539642902-25708-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 32994-done) by debbugs.gnu.org; 15 Oct 2018 22:34:16 +0000 Received: from localhost ([127.0.0.1]:51578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCBRH-0006fa-R4 for submit@debbugs.gnu.org; Mon, 15 Oct 2018 18:34:16 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:35248 helo=pdx1-sub0-mail-a75.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCBRG-0006fS-Kf for 32994-done@debbugs.gnu.org; Mon, 15 Oct 2018 18:34:15 -0400 Received: from pdx1-sub0-mail-a75.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTP id EF85E805B1 for <32994-done@debbugs.gnu.org>; Mon, 15 Oct 2018 15:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=Cswp/TDSDAmD6s0lde/5Vd1cMN8=; b= URNaXUMKQ2ep8ecnnI3WrJ48tDHNOdtBgQEacD/xF2UshAZbidQisv+ChklXgIrR gONk3i4DmitWUdD/JxfrjJ6gF6Zpm2j79W2MTPBoAh4fgBHmCFRa5DvzZBk+yXu8 gcCm/eLcLwxXiG2ZhXKe0Nhsyrv056KsakICCElTj38= Received: from localhost.linkov.net (m91-129-104-210.cust.tele2.ee [91.129.104.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTPSA id 2CC64805C4 for <32994-done@debbugs.gnu.org>; Mon, 15 Oct 2018 15:34:12 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a75 From: Juri Linkov To: 32994-done@debbugs.gnu.org Subject: Re: bug#32994: 27.0.50; Regression in image type auto-detection Organization: LINKOV.NET References: <87woqst7le.fsf@mail.linkov.net> Date: Tue, 16 Oct 2018 01:33:51 +0300 In-Reply-To: <87woqst7le.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 09 Oct 2018 01:08:13 +0300") Message-ID: <8736t6dels.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrvdelgddvgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdegrddvuddtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehlohgtrghlhhhoshhtrdhlihhnkhhovhdrnhgvthdpihhnvghtpeeluddruddvledruddtgedrvddutddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopeefvdelleegqdguohhnvgesuggvsggsuhhgshdrghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32994-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Tags: patch > > A recent change in image-mode.el broke a useful feature that > automatically detects an image type, so now visiting an image file > without a file extension signals the error "upcase(nil) - > (wrong-type-argument char-or-string-p nil)". This patch fixes it: Fixed. ------------=_1539642902-25708-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Oct 2018 23:02:52 +0000 Received: from localhost ([127.0.0.1]:40906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9eY8-0000uD-F8 for submit@debbugs.gnu.org; Mon, 08 Oct 2018 19:02:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9eY6-0000u0-VD for submit@debbugs.gnu.org; Mon, 08 Oct 2018 19:02:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9eY0-0000om-Bv for submit@debbugs.gnu.org; Mon, 08 Oct 2018 19:02:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59264) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9eY0-0000od-8P for submit@debbugs.gnu.org; Mon, 08 Oct 2018 19:02:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9eXz-00034S-JG for bug-gnu-emacs@gnu.org; Mon, 08 Oct 2018 19:02:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9eXv-0000nM-J4 for bug-gnu-emacs@gnu.org; Mon, 08 Oct 2018 19:02:43 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:42726 helo=pdx1-sub0-mail-a36.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9eXv-0000mm-Aj for bug-gnu-emacs@gnu.org; Mon, 08 Oct 2018 19:02:39 -0400 Received: from pdx1-sub0-mail-a36.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a36.g.dreamhost.com (Postfix) with ESMTP id 309468035F for ; Mon, 8 Oct 2018 16:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=Z1ZUKH0q3xSRjt2hSUlEGr3LlmU=; b=oMIOF+C8QPnQFf78n 71axz4SPcV3su3RAGQvPb5dK1uG1uLeaZIMN+AtAhSwU3Yg5fN+VTFE/VzMEl4Lq ZC2y2rzVd68taj8vsIMLTTKrzHTvtpuUZoq0t1iVfG0PMEK05wvYi0sB+OM0W4+n ltcovCKFSJcoCSn1WgsVFK3MXU= Received: from localhost.linkov.net (m91-129-107-184.cust.tele2.ee [91.129.107.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a36.g.dreamhost.com (Postfix) with ESMTPSA id 5985D80364 for ; Mon, 8 Oct 2018 16:02:35 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a36 From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Regression in image type auto-detection Organization: LINKOV.NET Date: Tue, 09 Oct 2018 01:08:13 +0300 Message-ID: <87woqst7le.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudefgddukecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufhofffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrddukeegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehlohgtrghlhhhoshhtrdhlihhnkhhovhdrnhgvthdpihhnvghtpeeluddruddvledruddtjedrudekgedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Tags: patch A recent change in image-mode.el broke a useful feature that automatically detects an image type, so now visiting an image file without a file extension signals the error "upcase(nil) - (wrong-type-argument char-or-string-p nil)". This patch fixes it: diff --git a/lisp/image-mode.el b/lisp/image-mode.el index 19fa28d440..eb7b410f4a 100644 --- a/lisp/image-mode.el +++ b/lisp/image-mode.el @@ -781,8 +785,9 @@ image-toggle-display-image (defun image--imagemagick-wanted-p (filename) (and (fboundp 'imagemagick-types) (not (eq imagemagick-types-inhibit t)) - (not (memq (intern (upcase (file-name-extension filename)) obarray) - imagemagick-types-inhibit)))) + (not (and (file-name-extension filename) + (memq (intern (upcase (file-name-extension filename)) obarray) + imagemagick-types-inhibit))))) (defun image-toggle-hex-display () "Toggle between image and hex display." ------------=_1539642902-25708-1--