GNU bug report logs - #32989
26.1; Opening PDF attachments in Gnus with doc-view-mode causes error on Windows

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32989 in the body.
You can then email your comments to 32989 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jordan Wilson <jordan.t.wilson <at> gmx.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1;
 Opening PDF attachments in Gnus with doc-view-mode causes error on
 Windows
Date: Mon, 08 Oct 2018 15:44:55 +0100

Hi,

I'm running Emacs 26.1 on Windows 10. I've replicated this with "emacs -Q"

In a gnus article buffer, opening a PDF attachment in doc-view causes
doc-view to fail with the error:
  File error: "Opening output file", "Invalid argument", "c:/Users/Jordan/Emacs/.cache/docview-cache/ *mm*-012345" 

this leaves a buffer showing the file literally. If I rename that buffer
to something not containing an asterisk, it displays fine when running
"doc-view-mode". Windows apparently can't handle asterisks in
directory/file names.

Thanks



In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
 of 2018-05-29 built on TPW550S
Windowing system distributor 'Microsoft Corp.', version 10.0.17134

Configured using:
 'configure --without-compress-install --without-dbus --with-modules
 'CFLAGS= -O2 -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND NOTIFY ACL GNUTLS LIBXML2
ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS LCMS2

Important settings:
  value of $LANG: ENG
  locale-coding-system: cp1252

-- 
Jordan Wilson
    Sent from Gnus v5.13, GNU Emacs 26.1

Message #8 received at 32989 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jordan Wilson <jordan.t.wilson <at> gmx.com>
Cc: 32989 <at> debbugs.gnu.org
Subject: Re: bug#32989: 26.1;
 Opening PDF attachments in Gnus with doc-view-mode causes error on
 Windows
Date: Mon, 08 Oct 2018 23:02:32 +0300

> From: Jordan Wilson <jordan.t.wilson <at> gmx.com>
> Date: Mon, 08 Oct 2018 15:44:55 +0100
> 
>   File error: "Opening output file", "Invalid argument", "c:/Users/Jordan/Emacs/.cache/docview-cache/ *mm*-012345" 
> 
> this leaves a buffer showing the file literally. If I rename that buffer
> to something not containing an asterisk, it displays fine when running
> "doc-view-mode". Windows apparently can't handle asterisks in
> directory/file names.

Windows doesn't allow '*' (and a few other characters) in any file
name, not just in directory name.  Gnus should run the file name
through convert-standard-filename to get something that is guaranteed
to work on any filesystem.

Message #11 received at 32989 <at> debbugs.gnu.org (full text, mbox):

From: Jordan Wilson <jordan.t.wilson <at> gmx.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32989 <at> debbugs.gnu.org
Subject: Re: bug#32989: 26.1;
 Opening PDF attachments in Gnus with doc-view-mode causes error on
 Windows
Date: Wed, 10 Oct 2018 11:45:57 +0100

[Message part 1 (text/plain, inline)]

On 2018-10-08 (Mon) at 23:02 (ZZZ), Eli Zaretskii <eliz <at> gnu.org> wrote:
>> From: Jordan Wilson <jordan.t.wilson <at> gmx.com>
>> Date: Mon, 08 Oct 2018 15:44:55 +0100
>> 
>>   File error: "Opening output file", "Invalid argument", "c:/Users/Jordan/Emacs/.cache/docview-cache/ *mm*-012345" 
>> 
>> this leaves a buffer showing the file literally. If I rename that buffer
>> to something not containing an asterisk, it displays fine when running
>> "doc-view-mode". Windows apparently can't handle asterisks in
>> directory/file names.
>
> Windows doesn't allow '*' (and a few other characters) in any file
> name, not just in directory name.  Gnus should run the file name
> through convert-standard-filename to get something that is guaranteed
> to work on any filesystem.
Looking, it seems to be on doc-view's side -- if a buffer isn't
associated with a file, it uses the buffer name for the file's cache
directory. Here's a patch to the 26 and trunk branches of doc-view.el to
run the file names through `convert-standard-filename'. It fixes the
problem for me, at least.

[doc-view-26.diff (text/x-patch, attachment)]

[doc-view-trunk.diff (text/x-patch, attachment)]

[Message part 4 (text/plain, inline)]

-- 
Jordan Wilson
    Sent from Gnus v5.13, GNU Emacs 26.1

Message #14 received at 32989 <at> debbugs.gnu.org (full text, mbox):

From: Jordan Wilson <jordan.t.wilson <at> gmx.com>
To: Jordan Wilson <jordan.t.wilson <at> gmx.com>
Cc: 32989 <at> debbugs.gnu.org
Subject: Re: bug#32989: 26.1;
 Opening PDF attachments in Gnus with doc-view-mode causes error on
 Windows
Date: Sun, 28 Oct 2018 22:57:17 +0000

I was just wondering if these are going to be applied? It's a pretty
easy fix.

On 2018-10-10 (Wed) at 11:45 (+01), Jordan Wilson <jordan.t.wilson <at> gmx.com> wrote:
>Here's a patch to the 26 and trunk branches of doc-view.el to
> run the file names through `convert-standard-filename'. It fixes the
> problem for me, at least.
-- 
Jordan Wilson
    Sent from Gnus v5.13, GNU Emacs 26.1

Message #19 received at 32989-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jordan Wilson <jordan.t.wilson <at> gmx.com>
Cc: 32989-done <at> debbugs.gnu.org
Subject: Re: bug#32989: 26.1;
 Opening PDF attachments in Gnus with doc-view-mode causes error on
 Windows
Date: Sat, 03 Nov 2018 10:32:09 +0200

> From: Jordan Wilson <jordan.t.wilson <at> gmx.com>
> Cc: 32989 <at> debbugs.gnu.org
> Date: Wed, 10 Oct 2018 11:45:57 +0100
> 
> 
> [1:text/plain Hide]
> 
> On 2018-10-08 (Mon) at 23:02 (ZZZ), Eli Zaretskii <eliz <at> gnu.org> wrote:
> >> From: Jordan Wilson <jordan.t.wilson <at> gmx.com>
> >> Date: Mon, 08 Oct 2018 15:44:55 +0100
> >> 
> >>   File error: "Opening output file", "Invalid argument", "c:/Users/Jordan/Emacs/.cache/docview-cache/ *mm*-012345" 
> >> 
> >> this leaves a buffer showing the file literally. If I rename that buffer
> >> to something not containing an asterisk, it displays fine when running
> >> "doc-view-mode". Windows apparently can't handle asterisks in
> >> directory/file names.
> >
> > Windows doesn't allow '*' (and a few other characters) in any file
> > name, not just in directory name.  Gnus should run the file name
> > through convert-standard-filename to get something that is guaranteed
> > to work on any filesystem.
> Looking, it seems to be on doc-view's side -- if a buffer isn't
> associated with a file, it uses the buffer name for the file's cache
> directory. Here's a patch to the 26 and trunk branches of doc-view.el to
> run the file names through `convert-standard-filename'. It fixes the
> problem for me, at least.

Thanks, pushed to the emacs-26 branch (will be merged to master from
there shortly).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.