GNU bug report logs - #32984
[PATCH] gnu: Add filtlong.

Previous Next

Full log

View this message in rfc822 format

From: mpatras <madalinionel.patrascu <at> mdc-berlin.de>
To: Leo Famulari <leo <at> famulari.name>
Cc: 32984 <at> debbugs.gnu.org
Subject: [bug#32984] [PATCH] gnu: filtlong: update path in aux script.
Date: Mon, 5 Nov 2018 17:26:12 +0100

[Message part 1 (text/plain, inline)]

Hello Leo,

I am sorry for this delayed response!

In the initial version of this description, I have put the auxiliary 
scripts in /scripts/.

I didn't know that all auxiliary scripts should be put in 
/share/name_of_package/scripts.

The script loads the package using a relative path.

Ludo corrected my description and changed my substitute lines to this,

-                 (wrap-program (string-append out "/scripts/histogram.py")
+                 (wrap-program (string-append out
+                                              "/share/filtlong/scripts/histogram.py")

Now the script is on the right place 
(/share/filtlong/scripts/histogram.py), but it does not contain the 
right relative path. So, this patch is needed to correct the relative path.

+               (substitute* "scripts/read_info_histograms.sh"
+                (("/../") "/../../../"))

Sorry, from the beginning was my mistake!
On 11.10.2018 22:55, Leo Famulari wrote:
> On Tue, Oct 09, 2018 at 06:22:39PM +0200, pimi wrote:
>> * gnu/packages/bioinformatics.scm (filtlong)[extra scritps]: corrected
>> the loading path for the filtlong in the script read_info_histograms.sh.
> [...]
>
>>                (lambda _
>>                  (substitute* "scripts/read_info_histograms.sh"
>>                    (("awk") (which "gawk")))
>> +               (substitute* "scripts/read_info_histograms.sh"
>> +                (("/../") "/../../../"))
>>                  #t)))))
> Can you add a code comment explaining the effect of this change? It's
> rather cryptic! :)

-- 
All the best!

Mădălin Ionel Patrașcu

System Administrator
The Berlin Institute for Medical Systems Biology (BIMSB)
Max Delbrück Center (MDC)
Robert-Rössle-Straße 10
House 87, room 1.10
13125 Berlin, Germany

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.