Subject: bug#32975: Emacs 26.1; GTK Warnings

From: Robert Pluim <[email-masked]>
Date: Thu, 11 Oct 2018 11:50:04 +0200

martin rudalics <[email-masked]> writes:

>> We do, but I only see xg_set_widget_bg getting called on scrollbar
>> widgets when USE_TOOLKIT_SCROLL_BARS is set, in which case they're GTK
>> widgets, so thatʼs the right thing to do.
>
> I apologize for my stubbornness.
>

No apology needed

> xg_set_background_color (struct frame *f, unsigned long bg)
>
> has
>
>       xg_set_widget_bg (f, FRAME_GTK_WIDGET (f), FRAME_BACKGROUND_PIXEL (f));
>
> which IIUC does not work on scrollbar widgets.

There is only one call to xg_set_background_color, from xfns.c, which looks
like this with my patch applied:

#ifdef USE_TOOLKIT_SCROLL_BARS
# ifdef USE_GTK
      xg_set_background_color (f, bg);
# endif
#else

So it will only ever happen when the scrollbars are GTK widgets.

Robert