GNU bug report logs - #32969
"Confirm--do you mean to use ‘*’ as a wildcard? (y or n)" stays in minibuffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32969 in the body.
You can then email your comments to 32969 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: "Confirm--do you mean to use ‘*’ as a
 wildcard? (y or n)" stays in minibuffer
Date: Sun, 07 Oct 2018 20:26:02 +0800

Dired has a message:
Confirm--do you mean to use ‘*’ as a wildcard? (y or n)
if one answers "n" the message just stays in the minibuffer.

It should instead say "command aborted", else the user thinks it used
'*' in its other (text replacement) way. Which it turns out it doesn't.

emacs-version "25.2.2"

Message #8 received at 32969 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 32969 <at> debbugs.gnu.org
Subject: Re: bug#32969: "Confirm--do you mean to use ‘*’ as a wildcard? (y or n)" stays in minibuffer
Date: Mon, 08 Oct 2018 02:44:12 +0900

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> Dired has a message:
> Confirm--do you mean to use ‘*’ as a wildcard? (y or n)
> if one answers "n" the message just stays in the minibuffer.
>
> It should instead say "command aborted", else the user thinks it used
> '*' in its other (text replacement) way. Which it turns out it doesn't.
Thank you for the report!
I agree.

--8<-----------------------------cut here---------------start------------->8---
commit e76bbfa62b7185cd3284d69483704366dc54e7e8
Author: Tino Calancha <tino.calancha <at> gmail.com>
Date:   Mon Oct 8 02:40:30 2018 +0900

    dired-do-shell-command: Notify users after abort the command
    
    * lisp/dired-aux.el (dired-do-shell-command):  Notify users that
    the command have aborted when they answer 'n' to the prompt (Bug#32969).

diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index 1f13204b7c..a4145eb67a 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -763,16 +763,17 @@ dired-do-shell-command
 	            (y-or-n-p (format-message
 			       "Confirm--do you mean to use `?' as a wildcard? ")))
 	           (t))))
-    (when ok
-      (if on-each
-	  (dired-bunch-files (- 10000 (length command))
-	                     (lambda (&rest files)
-	                       (dired-run-shell-command
-                                (dired-shell-stuff-it command files t arg)))
-	                     nil file-list)
-	;; execute the shell command
-	(dired-run-shell-command
-	 (dired-shell-stuff-it command file-list nil arg)))))))
+    (cond ((not ok) (message "OK, canceled"))
+          (t
+           (if on-each
+	       (dired-bunch-files (- 10000 (length command))
+	                          (lambda (&rest files)
+	                            (dired-run-shell-command
+                                     (dired-shell-stuff-it command files t arg)))
+	                          nil file-list)
+	     ;; execute the shell command
+	     (dired-run-shell-command
+	      (dired-shell-stuff-it command file-list nil arg))))))))
 
 ;; Might use {,} for bash or csh:
 (defvar dired-mark-prefix ""

--8<-----------------------------cut here---------------end--------------->8---

Message #11 received at 32969 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: 32969 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#32969: "Confirm--do you mean to use
 ‘*’ as a wildcard? (y or n)" stays in minibuffer
Date: Sun, 07 Oct 2018 21:23:57 +0300

> From: Tino Calancha <tino.calancha <at> gmail.com>
> Date: Mon, 08 Oct 2018 02:44:12 +0900
> Cc: 32969 <at> debbugs.gnu.org
> 
> +    (cond ((not ok) (message "OK, canceled"))

I'd suggest to use "Command canceled".  the "OK" part might confuse
some non-native English speakers to think the command was executed.

Thanks.

Message #14 received at 32969 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: jidanni <at> jidanni.org, 32969 <at> debbugs.gnu.org,
 Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#32969: "Confirm--do you mean to use ‘*’ as a wildcard? (y or n)" stays in minibuffer
Date: Mon, 8 Oct 2018 04:43:18 +0900 (JST)

On Sun, 7 Oct 2018, Eli Zaretskii wrote:

>> From: Tino Calancha <tino.calancha <at> gmail.com>
>> Date: Mon, 08 Oct 2018 02:44:12 +0900
>> Cc: 32969 <at> debbugs.gnu.org
>>
>> +    (cond ((not ok) (message "OK, canceled"))
>
> I'd suggest to use "Command canceled".  the "OK" part might confuse
> some non-native English speakers to think the command was executed.
OK (I mean, I updated the patch as you mentioned :-)

BTW, emacs-26 or master?

Message #17 received at 32969 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: 32969 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#32969: "Confirm--do you mean to use ‘*’
 as a wildcard? (y or n)" stays in minibuffer
Date: Mon, 08 Oct 2018 05:27:17 +0300

> From: Tino Calancha <tino.calancha <at> gmail.com>
> Date: Mon, 8 Oct 2018 04:43:18 +0900 (JST)
> cc: Tino Calancha <tino.calancha <at> gmail.com>, jidanni <at> jidanni.org, 
>     32969 <at> debbugs.gnu.org
> 
> >> +    (cond ((not ok) (message "OK, canceled"))
> >
> > I'd suggest to use "Command canceled".  the "OK" part might confuse
> > some non-native English speakers to think the command was executed.
> OK (I mean, I updated the patch as you mentioned :-)
> 
> BTW, emacs-26 or master?

I think emacs-26.  Thanks.

Message #20 received at 32969 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: jidanni <at> jidanni.org, 32969 <at> debbugs.gnu.org,
 Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#32969: "Confirm--do you mean to use ‘*’ as a wildcard? (y or n)" stays in minibuffer
Date: Mon, 8 Oct 2018 16:55:30 +0900 (JST)

On Mon, 8 Oct 2018, Eli Zaretskii wrote:

>> From: Tino Calancha <tino.calancha <at> gmail.com>
>> Date: Mon, 8 Oct 2018 04:43:18 +0900 (JST)
>> cc: Tino Calancha <tino.calancha <at> gmail.com>, jidanni <at> jidanni.org,
>>     32969 <at> debbugs.gnu.org
>>
>>>> +    (cond ((not ok) (message "OK, canceled"))
>>>
>>> I'd suggest to use "Command canceled".  the "OK" part might confuse
>>> some non-native English speakers to think the command was executed.
>> OK (I mean, I updated the patch as you mentioned :-)
>>
>> BTW, emacs-26 or master?
> I think emacs-26.  Thanks.
OK (I mean, 0 killed, understood, got it, entendido, wakarimashita)
I will wait some days before push it.  Thanks.

Message #25 received at 32969-done <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: 32969-done <at> debbugs.gnu.org
Subject: Re: bug#32969: "Confirm--do you mean to use ‘*’ as a wildcard? (y or n)" stays in minibuffer
Date: Thu, 11 Oct 2018 17:28:44 +0900

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Tino Calancha <tino.calancha <at> gmail.com>
>> Date: Mon, 8 Oct 2018 04:43:18 +0900 (JST)
>> cc: Tino Calancha <tino.calancha <at> gmail.com>, jidanni <at> jidanni.org, 
>>     32969 <at> debbugs.gnu.org
>> 
>> >> +    (cond ((not ok) (message "OK, canceled"))
>> >
>> > I'd suggest to use "Command canceled".  the "OK" part might confuse
>> > some non-native English speakers to think the command was executed.
>> OK (I mean, I updated the patch as you mentioned :-)
>> 
>> BTW, emacs-26 or master?
>
> I think emacs-26.  Thanks.
Implemeted in emacs-26 as commit
'dired-do-shell-command: Notify users after abort the command'
(a7ebc6bf633bd3849ccab032dad6b1fd31b1ef43)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.