GNU bug report logs - #32947
[PATCH 0/3] Add java-xalan.

Previous Next

Full log

Message #68 received at 32947 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Frank Pursel <frank.pursel <at> gmail.com>, 32947 <at> debbugs.gnu.org
Subject: Re: [bug#32947] Add java-xalan.
Date: Fri, 18 Mar 2022 21:07:50 +0100

[Message part 1 (text/plain, inline)]

Frank Pursel schreef op vr 18-03-2022 om 19:16 [+0000]:
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://apache/xalan/xalan-j/source/xalan-j_"
> +                           (string-replace-substring
> +                            version "." "_")
> +                           "-src.tar.gz"))
> +       (sha256
> +        (base32 "166vg9i11qzi0vbv09abfb50q8caq8wr6zrwg0cwqws9k394l62w"))
> +       (modules '((guix build utils)))
> +       (snippet '(begin
> +                   ;; Removing bundled jars
> +                   (for-each
> +                    (lambda (f)
> +                      (delete-file f))
> +                    (find-files "." "\\.(jar|tar\\.gz)$"))))))

Can be simplified to:

    (snippet '(for-each delete-file (delete-files "." "\\.(jar|tar\\.gz)$")))

Also, xalan-j_2_7_2/samples/AppletXMLtoHTML/rabbitwhorn.jpg is an (uncoloured)
picture of a rabbit from Alice in Wonderland (not asl2.0).  According to
<https://commons.wikimedia.org/wiki/File:Alice_par_John_Tenniel_37.png>,
the copyright has been expired.  As such, perhaps the 'license' field
needs to be changed to

  (license (list license:asl2.0 ; almost everything
                 ;; samples/AppletXMLtoHTML/rabbitwhorn.jpg, according to
                 ;; <https://commons.wikimedia.org/wiki/File:Alice_par_John_Tenniel_37.png>
                 license:public-domain))

Aside from that, LGTM.  I've been reading the source code, not seeing anything
‘suspicous’ (malware etc.) so far (I'm currently at
xalan-j_2_7_2/src/org/apache/xalan/templates/FuncKey.java, 25%).

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.