GNU bug report logs - #32945
[PATCH] Prefer delete-char

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32945 in the body.
You can then email your comments to 32945 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Prefer delete-char
Date: Fri, 05 Oct 2018 09:11:05 -0500

[Message part 1 (text/plain, inline)]

Hi -

This is a trivial change that silences the byte compiler warning in
lisp/eshell/em-rebind.el.

Thanks for all your work on Emacs!
Alex

From 40563de898d99a81d05d3d1585f753e20f815b60 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham <at> gmail.com>
Date: Fri, 5 Oct 2018 09:07:13 -0500
Subject: [PATCH] ; lisp/eshell/em-rebind.el (eshell-delete-backward-char):
 Prefer delete-char

---
 lisp/eshell/em-rebind.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/eshell/em-rebind.el b/lisp/eshell/em-rebind.el
index e6f04b68e0..064dcc762d 100644
--- a/lisp/eshell/em-rebind.el
+++ b/lisp/eshell/em-rebind.el
@@ -223,7 +223,7 @@ lock it at that."
   (interactive "P")
   (let ((count (prefix-numeric-value n)))
     (if (eshell-point-within-input-p (- (point) count))
-	(delete-backward-char count n)
+	(delete-char (- count) n)
       (beep))))

 (defun eshell-delchar-or-maybe-eof (arg)
--
2.19.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 32945 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 32945 <at> debbugs.gnu.org
Subject: Re: bug#32945: [PATCH] Prefer delete-char
Date: Fri, 12 Oct 2018 11:40:39 +0300

> From: Alex Branham <alex.branham <at> gmail.com>
> Date: Fri, 05 Oct 2018 09:11:05 -0500
> 
> This is a trivial change that silences the byte compiler warning in
> lisp/eshell/em-rebind.el.

Thanks, pushed to the emacs-26 branch.

Message #13 received at 32945 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 32945 <at> debbugs.gnu.org
Subject: Re: bug#32945: [PATCH] Prefer delete-char
Date: Mon, 15 Oct 2018 16:07:19 -0400

Alex Branham wrote:

> This is a trivial change that silences the byte compiler warning in
> lisp/eshell/em-rebind.el.

Since eshell-delete-backward-char acts as a replacement for
delete-backward-char in eshell, it's never been obvious to me whether
such a change is the right thing to do.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.