From unknown Sat Jun 14 14:30:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32940: 26.1.50; nneething fails with CRLF-encoded files Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Oct 2018 00:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 32940@debbugs.gnu.org Cc: Kazuhiro NISHIYAMA , TSUCHIYA Masatoshi X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.153869881415741 (code B ref -1); Fri, 05 Oct 2018 00:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Oct 2018 00:20:14 +0000 Received: from localhost ([127.0.0.1]:37258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8Dqn-00045o-VB for submit@debbugs.gnu.org; Thu, 04 Oct 2018 20:20:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8Dqm-00045Y-0E for submit@debbugs.gnu.org; Thu, 04 Oct 2018 20:20:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g8Dqg-00004v-5n for submit@debbugs.gnu.org; Thu, 04 Oct 2018 20:20:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g8Dqg-0008WS-2D for submit@debbugs.gnu.org; Thu, 04 Oct 2018 20:20:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g8Dqf-0008Tl-8Z for bug-gnu-emacs@gnu.org; Thu, 04 Oct 2018 20:20:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g8Dqc-0008L0-KD for bug-gnu-emacs@gnu.org; Thu, 04 Oct 2018 20:20:05 -0400 Received: from gecko.birch.relay.mailchannels.net ([23.83.209.66]:19654) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g8Dqc-0007PN-Bw for bug-gnu-emacs@gnu.org; Thu, 04 Oct 2018 20:20:02 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 371F4501F59; Fri, 5 Oct 2018 00:19:19 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.20.98]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 971C3501E48; Fri, 5 Oct 2018 00:19:18 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Fri, 05 Oct 2018 00:19:19 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Industry-Skirt: 669c1b4765552d54_1538698759063_4142867251 X-MC-Loop-Signature: 1538698759063:1973499358 X-MC-Ingress-Time: 1538698759063 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1g8Dpq-001KPJ-Rs; Thu, 04 Oct 2018 19:19:16 -0500 Date: Fri, 05 Oct 2018 09:19:14 +0900 Message-ID: From: Katsumi Yamaoka Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-unknown-cygwin) Cancel-Lock: sha1:HFKjwTbMMAOrh9pYNc2UlcjJMsY= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Hi, I will fix `nneething-request-article'[1] so as to bind the coding system to `raw-text' instead of `binary' when reading a file. If a file is encoded with a coding system of which the eol type is CRLF (or CR), the function will fail to find the header separator and the article shown will get malformed (useless to reply, copy, etc.). Thanks to NISHIYAMA-san who suggested the cause of it. Regards, [1] lisp/gnus/nneething.el, (info "(gnus) Anything Groups") From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 04 20:26:40 2018 Received: (at control) by debbugs.gnu.org; 5 Oct 2018 00:26:40 +0000 Received: from localhost ([127.0.0.1]:37264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8Dx1-0004Fr-Mo for submit@debbugs.gnu.org; Thu, 04 Oct 2018 20:26:39 -0400 Received: from common.maple.relay.mailchannels.net ([23.83.214.38]:5527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g8Dwz-0004Fi-6B for control@debbugs.gnu.org; Thu, 04 Oct 2018 20:26:38 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BCF81122738; Fri, 5 Oct 2018 00:26:35 +0000 (UTC) Received: from hampton.hostforweb.net (unknown [100.96.33.121]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 0E5A812250D; Fri, 5 Oct 2018 00:26:34 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Fri, 05 Oct 2018 00:26:35 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Cellar-Reign: 1d5cabfc1eabef40_1538699195569_3905704423 X-MC-Loop-Signature: 1538699195569:960020354 X-MC-Ingress-Time: 1538699195569 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1g8Dwt-001LxO-33; Thu, 04 Oct 2018 19:26:32 -0500 Date: Fri, 05 Oct 2018 09:26:30 +0900 Message-ID: From: Katsumi Yamaoka To: control@debbugs.gnu.org Subject: bug#32940: 26.1.50; nneething fails with CRLF-encoded files References: Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-unknown-cygwin) Cancel-Lock: sha1:vXnjjIFdZZo0uUdzHSy3br3Yu1s= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: Kazuhiro NISHIYAMA , TSUCHIYA Masatoshi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= close 32940 quit --=-=-= Content-Type: message/rfc822 Content-Disposition: inline From: yamaoka@jpl.org (Katsumi Yamaoka) Subject: emacs-26 79bda3b: Make nneething allow CRLF-encoded files (bug#32940) Date: Thu, 4 Oct 2018 20:22:46 -0400 (EDT) Message-ID: <20181005002246.6BBC320476@vcs0.savannah.gnu.org> To: emacs-diffs@gnu.org MIME-Version: 1.0 branch: emacs-26 commit 79bda3bc4731c7ac67b499a154c636d8eeb2edee Author: Katsumi Yamaoka Commit: Katsumi Yamaoka Make nneething allow CRLF-encoded files (bug#32940) * lisp/gnus/nneething.el (nneething-request-article): Bind coding system to raw-text instead of binary when reading a file, that may be CRLF-encoded (bug#32940). --- lisp/gnus/nneething.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/gnus/nneething.el b/lisp/gnus/nneething.el index 9b6a92f..886cbf8 100644 --- a/lisp/gnus/nneething.el +++ b/lisp/gnus/nneething.el @@ -123,7 +123,7 @@ included.") (file-exists-p file) ; The file exists. (not (file-directory-p file)) ; It's not a dir. (save-excursion - (let ((nnmail-file-coding-system 'binary)) + (let ((nnmail-file-coding-system 'raw-text)) (nnmail-find-file file)) ; Insert the file in the nntp buf. (unless (nnheader-article-p) ; Either it's a real article... (let ((type --=-=-=--