GNU bug report logs - #32904
[PATCH] build-system/asdf: Properly handle dependency specification casing.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andy Patterson <ajpatter <at> uwaterloo.ca>
Subject: bug#32904: closed (Re: [bug#32904] [PATCH] build-system/asdf:
 Properly handle dependency specification casing.)
Date: Tue, 02 Oct 2018 12:07:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#32904: [PATCH] build-system/asdf: Properly handle dependency specification casing.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 32904 <at> debbugs.gnu.org.

-- 
32904: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32904
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Andy Patterson <ajpatter <at> uwaterloo.ca>
Cc: 32904-done <at> debbugs.gnu.org
Subject: Re: [bug#32904] [PATCH] build-system/asdf: Properly handle dependency
 specification casing.
Date: Tue, 02 Oct 2018 14:06:26 +0200

Andy Patterson <ajpatter <at> uwaterloo.ca> skribis:

> From fd4047ab93f9be94ddfeef48248fca6a0580131f Mon Sep 17 00:00:00 2001
> From: Andy Patterson <ajpatter <at> uwaterloo.ca>
> Date: Tue, 2 Oct 2018 04:57:31 -0400
> Subject: [PATCH] build-system/asdf: Properly handle dependency
> specification casing.
>
> * guix/build/lisp-utils.scm (normalize-dependency): Modify match
> clauses to match the upper-case symbols that lisp produces.

Applied, thanks!

Ludo'.

[Message part 3 (message/rfc822, inline)]

From: Andy Patterson <ajpatter <at> uwaterloo.ca>
To: guix-patches <at> gnu.org
Subject: [PATCH] build-system/asdf: Properly handle dependency specification
 casing.
Date: Tue, 2 Oct 2018 05:17:03 -0400

From fd4047ab93f9be94ddfeef48248fca6a0580131f Mon Sep 17 00:00:00 2001
From: Andy Patterson <ajpatter <at> uwaterloo.ca>
Date: Tue, 2 Oct 2018 04:57:31 -0400
Subject: [PATCH] build-system/asdf: Properly handle dependency
specification casing.

* guix/build/lisp-utils.scm (normalize-dependency): Modify match
clauses to match the upper-case symbols that lisp produces.
---
 guix/build/lisp-utils.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/guix/build/lisp-utils.scm b/guix/build/lisp-utils.scm
index 6470cfec9..3f5cdf86b 100644
--- a/guix/build/lisp-utils.scm
+++ b/guix/build/lisp-utils.scm
@@ -84,11 +84,12 @@
 (define (normalize-dependency dependency)
   "Normalize the name of DEPENDENCY.  Handles dependency definitions
of the dependency-def form described by
-<https://common-lisp.net/project/asdf/asdf.html#The-defsystem-grammar>."
+<https://common-lisp.net/project/asdf/asdf.html#The-defsystem-grammar>.
+Assumes that any symbols in DEPENDENCY will be in upper-case."
   (match dependency
-    ((':version name rest ...)
+    ((':VERSION name rest ...)
      `(:version ,(normalize-string name) ,@rest))
-    ((':feature feature-specification dependency-specification)
+    ((':FEATURE feature-specification dependency-specification)
      `(:feature
        ,feature-specification
        ,(normalize-dependency dependency-specification)))
-- 
2.19.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.