From unknown Mon Aug 18 06:57:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32868: Check if make supports nested variables is done twice when using silent rules Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Fri, 28 Sep 2018 20:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32868 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: jacob.kroon@gmail.com, bug-autoconf@gnu.org, 32868@debbugs.gnu.org X-Debbugs-Original-To: Jacob Kroon , bug-autoconf@gnu.org, bug-automake@gnu.org Reply-To: bug-automake@gnu.org, Jacob Kroon Received: via spool by submit@debbugs.gnu.org id=B.153816701820273 (code B ref -1); Fri, 28 Sep 2018 20:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Sep 2018 20:36:58 +0000 Received: from localhost ([127.0.0.1]:58035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5zVR-0005Gt-3e for submit@debbugs.gnu.org; Fri, 28 Sep 2018 16:36:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5zVP-0005Gg-7D for submit@debbugs.gnu.org; Fri, 28 Sep 2018 16:36:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5zVJ-00049L-53 for submit@debbugs.gnu.org; Fri, 28 Sep 2018 16:36:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34539) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g5zVJ-00048q-1g for submit@debbugs.gnu.org; Fri, 28 Sep 2018 16:36:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5zVI-0000xk-6z for bug-automake@gnu.org; Fri, 28 Sep 2018 16:36:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5zVH-00046H-H5 for bug-automake@gnu.org; Fri, 28 Sep 2018 16:36:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52992) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g5zVD-0003u6-Co; Fri, 28 Sep 2018 16:36:43 -0400 Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2E7C63091794; Fri, 28 Sep 2018 20:36:42 +0000 (UTC) Received: from [10.10.125.67] (ovpn-125-67.rdu2.redhat.com [10.10.125.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D31588C12; Fri, 28 Sep 2018 20:36:41 +0000 (UTC) References: From: Eric Blake Organization: Red Hat, Inc. Message-ID: <464d4269-20b5-0195-4e9a-698e0fe2cecd@redhat.com> Date: Fri, 28 Sep 2018 15:36:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 28 Sep 2018 20:36:42 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) On 9/28/18 1:47 PM, Jacob Kroon wrote: > Hi, > > If I use AM_SILENT_RULES([yes]) in my configure.ac, when I run the > configure scripts I see this: > ... > checking whether make supports nested variables... yes > checking whether make supports nested variables... (cached) yes > ... > > If I remove AM_SILENT_RULES, the test is only done once. > > Is this intended behaviour ? I don't know. But AM_SILENT_RULES is supplied by automake, not autoconf, so it's better to ask your question on the correct list. I've gone ahead and updated the CC's accordingly. > > I'm on an updated Debian Stretch system using (Debian version syntax): > autoconf 2.69-10 > automake 1:1.15-6 > > Regards Jacob > > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 20 15:16:16 2022 Received: (at control) by debbugs.gnu.org; 20 Feb 2022 20:16:16 +0000 Received: from localhost ([127.0.0.1]:33946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLscx-0006Es-Vp for submit@debbugs.gnu.org; Sun, 20 Feb 2022 15:16:16 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:52296 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLscw-0006AH-Gn for control@debbugs.gnu.org; Sun, 20 Feb 2022 15:16:14 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 0803D3438C4; Sun, 20 Feb 2022 20:16:08 +0000 (UTC) From: Mike Frysinger To: control@debbugs.gnu.org Subject: Control message Message-Id: <20220220201609.0803D3438C4@smtp.gentoo.org> Date: Sun, 20 Feb 2022 20:16:08 +0000 (UTC) X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) severity 32868 minor tag 32868 = confirmed thankyou From unknown Mon Aug 18 06:57:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32868: Check if make supports nested variables is done twice when using silent rules Resent-From: Mike Frysinger Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Sun, 20 Feb 2022 20:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32868 X-GNU-PR-Package: automake X-GNU-PR-Keywords: confirmed To: Jacob Kroon Cc: 32868@debbugs.gnu.org Received: via spool by 32868-submit@debbugs.gnu.org id=B32868.164538904232528 (code B ref 32868); Sun, 20 Feb 2022 20:31:01 +0000 Received: (at 32868) by debbugs.gnu.org; 20 Feb 2022 20:30:42 +0000 Received: from localhost ([127.0.0.1]:33965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLsqw-0008SI-5V for submit@debbugs.gnu.org; Sun, 20 Feb 2022 15:30:42 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:55478 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLsqt-0008Ij-Fe for 32868@debbugs.gnu.org; Sun, 20 Feb 2022 15:30:40 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 4B797343733; Sun, 20 Feb 2022 20:30:33 +0000 (UTC) Date: Sun, 20 Feb 2022 15:30:33 -0500 From: Mike Frysinger Message-ID: Mail-Followup-To: Jacob Kroon , 32868@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="29/Mm12Gm2aPL5km" Content-Disposition: inline In-Reply-To: X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --29/Mm12Gm2aPL5km Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 28 Sep 2018 20:47, Jacob Kroon wrote: > If I use AM_SILENT_RULES([yes]) in my configure.ac, when I run the > configure scripts I see this: > ... > checking whether make supports nested variables... yes > checking whether make supports nested variables... (cached) yes > ... >=20 > If I remove AM_SILENT_RULES, the test is only done once. >=20 > Is this intended behaviour ? it's because of how silent rules are integrated. AM_INIT_AUTOMAKE has: AC_REQUIRE([AM_SILENT_RULES]) which makes the silent rules framework always available. but if you want to opt-in to silent-by-default, you have to call that same macro: AM_SILENT_RULES([yes]) and then all the logic is expanded twice, not just that autoconf check. we could refactor AM_SILENT_RULES internally to minimize the amount of duplicated logic (just setup AM_DEFAULT_VERBOSITY and related vars). but i've also always found this config interface to be weird. most automake options are controlled by AM_INIT_AUTOMAKE, except for this. the original implementation had a "silent-rules" option, but that set whether the logic was included, not the default yes/no. with automake 1.13, this option was turned into a no-op since it's always enabled. i'm inclined to bring this back as the way to opt-in to silent-rules by default. that would address by not needing multiple calls to the AM_SILENT_RULES macro in the first place. -mike --29/Mm12Gm2aPL5km Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmISpOkACgkQQWM7n+g3 9YHddw/+JiO4CzU/B073zRjNnmTDqHo28yYpOA1Czw9fsTKma0YRn3C+CvLROFOO Z4eWUnw0gFCM2dNk6d+fINSWWdzHUSAXV6ZH0AUDsi85xjrOKurcaBdvdM4VUeaM jtsrfTq1N+EGDOWcJqR+gHcUACAZlZcaMfmwNONZ2vB9Psm+9y98yNfiIxLs1p0v STVbSJpTgS/c1ZmKNSxqg0/kWlI439WGNJGrEeHFcopo9q4hnOPOEiP9+X2JB8WQ flSt74jModvliFmjqc+f4/yPzoonqLyQTwEemV1Nxu6YietZim53MONNFEJ3oKDw zw0cUFyr8+ciha25lIZ7VAvhTeKlME+3uYlO8QYSztwyuC4MomEqNJhvled9u0BZ BJXlkoGz1IftlNNiAygqOYksl7i2fBBgU3TI2gXtzQoJEivyRSy721XaiMzsJzdt yARhIsFme35Tb33YaSxGaM8RyNDuLio1mKxjkcnrUKo7ivF4p2LqNdXTdib+KKbo PbXQcxx/XLRZ7z3iXBH2EI+MRRRUQBmIFqlxKKKaEUhzuMJKrVQe+Z9jF1EZN7rg GZpvJr6iYqHKBxgeuM0aTk7usy8ir91Fj8HUJjLi5twzIPFQ13N46c7WYTMTLU93 d1Lb7tUStP+zOBl6IiGIDY4fwAUn9+TQBnrzrpCkjE8opVFIrPw= =a8Bg -----END PGP SIGNATURE----- --29/Mm12Gm2aPL5km-- From unknown Mon Aug 18 06:57:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32868: Check if make supports nested variables is done twice when using silent rules Resent-From: "Zack Weinberg" Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Sun, 20 Feb 2022 21:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32868 X-GNU-PR-Package: automake X-GNU-PR-Keywords: confirmed To: 32868@debbugs.gnu.org X-Debbugs-Original-To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164539249011360 (code B ref -1); Sun, 20 Feb 2022 21:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Feb 2022 21:28:10 +0000 Received: from localhost ([127.0.0.1]:34007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLtkY-0002xA-Jh for submit@debbugs.gnu.org; Sun, 20 Feb 2022 16:28:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:37718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLtkW-0002x2-Jl for submit@debbugs.gnu.org; Sun, 20 Feb 2022 16:28:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLtkW-0006Le-DR for bug-automake@gnu.org; Sun, 20 Feb 2022 16:28:08 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:35791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLtkU-0008QW-83 for bug-automake@gnu.org; Sun, 20 Feb 2022 16:28:08 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 9B24B3200D98 for ; Sun, 20 Feb 2022 16:28:01 -0500 (EST) Received: from imap45 ([10.202.2.95]) by compute4.internal (MEProxy); Sun, 20 Feb 2022 16:28:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owlfolio.org; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=O3rrIQFv1t9Kly Ba1TgtjS6RRjdl1Vaw1fzONdk7IgQ=; b=nU4kTMkwU8AnZUB8Q8Jz7rrw6/c8J6 U2pAHXPPyR7dlBGkZH4K5oqJinUDzPnV7ZH2kxfZbHsa1e6x2xYGjxocIVqtJdOH QUgFw17qij2A3YsDyBu8nEAu6L129Ef1UeSsqwg/vmkltmXEYtI+qz4XNF4PrDNh tjjlTPwv0EVlNsWpX0zQAM/LrikiSDxqHYGU9DIrh5CVOpadinjutgWOLZq1pcHW 9RYwozUa4k0aDmscbdCSsTX1+E5myDYVpdmmUGa/qEjmgcicLmq9dic7zOuv8L0R p3rLCBa2+cTEdKWpADfG68un6WoDhECdqYflZl+jbbzyrQ9NLOepxv8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=O3rrIQFv1t9KlyBa1TgtjS6RRjdl1Vaw1fzONdk7IgQ=; b=nB9/VLuX bUP9yJNkvWPZiEvKXLRyVScfQzNiyr5y9prnwNCEWhu3z4SKwDsJ6iWLNOGmoQdb 9L1Lnd35pogcUsRqJblU0xuzxO8GxzUzNQ3FCoSR5kCeFzYQ//vxMNkffXd5lbyz TwHi/5SGAdlxnTcKlTRgKG3O5EzqkzEkCbLUsYQypx0Vrvl54NMoTfFQHPncH1dN pGQhfeazerXJt4zhAasXXlTIr7Rg+rEFlDRTn4HWtsZzpsfBBpdOdAKix/YcIgtS Ctj3OfxQyM91ewxx9xWD85Vt0SXVG5fuv3u6lWu+T5276Ylv8PZs9HObgEdc4iVV +IPArZ1Ayb+0oQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeeggdduhedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtgfesth hqredtreerjeenucfhrhhomhepfdgkrggtkhcuhggvihhnsggvrhhgfdcuoeiirggtkhes ohiflhhfohhlihhordhorhhgqeenucggtffrrghtthgvrhhnpeffteffkeehfeevhedule ekheeugfekjedtgfejvdefueeujeeghfeuieeijeekfeenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeiirggtkhesohiflhhfohhlihhordhorh hg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id CE54424A0077; Sun, 20 Feb 2022 16:28:00 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4778-g14fba9972e-fm-20220217.001-g14fba997 Mime-Version: 1.0 Message-Id: In-Reply-To: References: Date: Sun, 20 Feb 2022 16:27:40 -0500 From: "Zack Weinberg" Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=64.147.123.21; envelope-from=zack@owlfolio.org; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) > i'm inclined to bring this back as the way to opt-in to silent-rules > by default. And I=E2=80=99m still absolutely opposed to making it even *possible* to= have silent rules be on by default. In fact I=E2=80=99d like to see =E2= =80=94enable-silent-rules removed, with make V=3D0 the *only* way to swi= tch to silent mode. From unknown Mon Aug 18 06:57:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32868: [PATCH] m4: rework silent-rules macros to avoid double expansion References: <464d4269-20b5-0195-4e9a-698e0fe2cecd@redhat.com> In-Reply-To: <464d4269-20b5-0195-4e9a-698e0fe2cecd@redhat.com> Resent-From: Mike Frysinger Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 21 Feb 2022 00:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32868 X-GNU-PR-Package: automake X-GNU-PR-Keywords: confirmed To: 32868@debbugs.gnu.org Received: via spool by 32868-submit@debbugs.gnu.org id=B32868.16454024542955 (code B ref 32868); Mon, 21 Feb 2022 00:15:02 +0000 Received: (at 32868) by debbugs.gnu.org; 21 Feb 2022 00:14:14 +0000 Received: from localhost ([127.0.0.1]:34163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLwLF-0000lb-La for submit@debbugs.gnu.org; Sun, 20 Feb 2022 19:14:13 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:45712 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLwLD-0000lN-Q3 for 32868@debbugs.gnu.org; Sun, 20 Feb 2022 19:14:12 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 55B523436D0; Mon, 21 Feb 2022 00:14:05 +0000 (UTC) From: Mike Frysinger Date: Sun, 20 Feb 2022 19:14:00 -0500 Message-Id: <20220221001400.11892-1-vapier@gentoo.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Fixes automake bug https://bugs.gnu.org/32868. The AM_SILENT_RULES macro defines all the silent-rules related setup. It's also called by users to change the default verbosity level. This leads to a quirk where automake calls it, expands the full context, and then users call it, and it's fully expanded again. Instead, let's rename AM_SILENT_RULES to _AM_SILENT_RULES and move the initialization logic to late in the configure stage. This allows the user-centric AM_SILENT_RULES call to expand into a single line to set the default verbosity. * m4/init.m4: Switch to _AM_SILENT_RULES. * m4/silent.m4: Rename AM_SILENT_RULES to _AM_SILENT_RULES. Delay evaluation of AM_SILENT_RULES to the end. Change AM_SILENT_RULES to only define AM_SILENT_RULES. --- m4/init.m4 | 2 +- m4/silent.m4 | 48 +++++++++++++++++++++++++++++------------------- 2 files changed, 30 insertions(+), 20 deletions(-) diff --git a/m4/init.m4 b/m4/init.m4 index f3abf66c6e96..f3c7845bca70 100644 --- a/m4/init.m4 +++ b/m4/init.m4 @@ -134,7 +134,7 @@ if test -z "$CSCOPE"; then fi AC_SUBST([CSCOPE]) -AC_REQUIRE([AM_SILENT_RULES])dnl +AC_REQUIRE([_AM_SILENT_RULES])dnl dnl The testsuite driver may need to know about EXEEXT, so add the dnl 'am__EXEEXT' conditional if _AM_COMPILER_EXEEXT was seen. This dnl macro is hooked onto _AC_COMPILER_EXEEXT early, see below. diff --git a/m4/silent.m4 b/m4/silent.m4 index b1502ed389b6..9b3c7a6a017b 100644 --- a/m4/silent.m4 +++ b/m4/silent.m4 @@ -5,12 +5,12 @@ # gives unlimited permission to copy and/or distribute it, # with or without modifications, as long as this notice is preserved. -# AM_SILENT_RULES([DEFAULT]) -# -------------------------- -# Enable less verbose build rules; with the default set to DEFAULT -# ("yes" being less verbose, "no" or empty being verbose). -AC_DEFUN([AM_SILENT_RULES], -[AC_ARG_ENABLE([silent-rules], [dnl +# _AM_SILENT_RULES +# ---------------- +# Enable less verbose build rules support. +AC_DEFUN([_AM_SILENT_RULES], +[AM_DEFAULT_VERBOSITY=0 +AC_ARG_ENABLE([silent-rules], [dnl AS_HELP_STRING( [--enable-silent-rules], [less verbose build output (undo: "make V=1")]) @@ -18,11 +18,6 @@ AS_HELP_STRING( [--disable-silent-rules], [verbose build output (undo: "make V=0")])dnl ]) -case $enable_silent_rules in @%:@ ((( - yes) AM_DEFAULT_VERBOSITY=0;; - no) AM_DEFAULT_VERBOSITY=1;; - *) AM_DEFAULT_VERBOSITY=m4_if([$1], [yes], [0], [1]);; -esac dnl dnl A few 'make' implementations (e.g., NonStop OS and NextStep) dnl do not support nested variable expansions. @@ -41,14 +36,6 @@ am__doit: else am_cv_make_support_nested_variables=no fi]) -if test $am_cv_make_support_nested_variables = yes; then - dnl Using '$V' instead of '$(V)' breaks IRIX make. - AM_V='$(V)' - AM_DEFAULT_V='$(AM_DEFAULT_VERBOSITY)' -else - AM_V=$AM_DEFAULT_VERBOSITY - AM_DEFAULT_V=$AM_DEFAULT_VERBOSITY -fi AC_SUBST([AM_V])dnl AM_SUBST_NOTMAKE([AM_V])dnl AC_SUBST([AM_DEFAULT_V])dnl @@ -57,4 +44,27 @@ AC_SUBST([AM_DEFAULT_VERBOSITY])dnl AM_BACKSLASH='\' AC_SUBST([AM_BACKSLASH])dnl _AM_SUBST_NOTMAKE([AM_BACKSLASH])dnl +dnl Delay evaluation of AM_DEFAULT_VERBOSITY to the end to allow multiple calls +dnl to AM_SILENT_RULES to change the default value. +AC_CONFIG_COMMANDS_PRE([dnl +case $enable_silent_rules in @%:@ ((( + yes) AM_DEFAULT_VERBOSITY=0;; + no) AM_DEFAULT_VERBOSITY=1;; +esac +if test $am_cv_make_support_nested_variables = yes; then + dnl Using '$V' instead of '$(V)' breaks IRIX make. + AM_V='$(V)' + AM_DEFAULT_V='$(AM_DEFAULT_VERBOSITY)' +else + AM_V=$AM_DEFAULT_VERBOSITY + AM_DEFAULT_V=$AM_DEFAULT_VERBOSITY +fi +])dnl ]) + +# AM_SILENT_RULES([DEFAULT]) +# -------------------------- +# Set the default verbosity level to DEFAULT ("yes" being less verbose, "no" or +# empty being verbose). +AC_DEFUN([AM_SILENT_RULES], +[AM_DEFAULT_VERBOSITY=m4_if([$1], [yes], [0], [1])]) -- 2.34.1 From unknown Mon Aug 18 06:57:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32868: Check if make supports nested variables is done twice when using silent rules Resent-From: Mike Frysinger Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 21 Feb 2022 00:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32868 X-GNU-PR-Package: automake X-GNU-PR-Keywords: confirmed To: Zack Weinberg Cc: 32868@debbugs.gnu.org Received: via spool by 32868-submit@debbugs.gnu.org id=B32868.16454025563150 (code B ref 32868); Mon, 21 Feb 2022 00:16:01 +0000 Received: (at 32868) by debbugs.gnu.org; 21 Feb 2022 00:15:56 +0000 Received: from localhost ([127.0.0.1]:34167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLwMu-0000ok-5o for submit@debbugs.gnu.org; Sun, 20 Feb 2022 19:15:56 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:46172 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLwMs-0000oP-7I for 32868@debbugs.gnu.org; Sun, 20 Feb 2022 19:15:54 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 946643436E9; Mon, 21 Feb 2022 00:15:48 +0000 (UTC) Date: Sun, 20 Feb 2022 19:15:48 -0500 From: Mike Frysinger Message-ID: Mail-Followup-To: Zack Weinberg , 32868@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sXIsdpKMRddpUhtn" Content-Disposition: inline In-Reply-To: X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --sXIsdpKMRddpUhtn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20 Feb 2022 16:27, Zack Weinberg wrote: > > i'm inclined to bring this back as the way to opt-in to silent-rules > > by default. >=20 > And I=E2=80=99m still absolutely opposed to making it even *possible* to = have silent rules be on by default. In fact I=E2=80=99d like to see =E2=80= =94enable-silent-rules removed, with make V=3D0 the *only* way to switch to= silent mode. please don't derail threads -mike --sXIsdpKMRddpUhtn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIS2bQACgkQQWM7n+g3 9YELiw//VuZYMw0vf3pEAao4zDR9SHZTwgGmSLKgvzJF2cgTwHk1w6oMbXcpJrQP zzmphFl++jyRjlhGYDK0tpDDCItiyEyeUW3k9ZWJ75lkOW+a7+EPJyyw6ZnWU8jM xfBYRbgB9x627Jcjm0nzvEzIcafxicWmvm9zomD9lHXnHWEe3gd4pyykIkgzgPpn PYYK6jmgCZhvYybNQzL9jeWtd393Lj+yd6lI6KmAh4C2DGd0dwe/GJLKTuAXG3NW 4ka9GC8dT/9XNCwlOZtuKu+L/vzewhkQ92/gWlf4gS7k9Dequ8UMfk49i1fINX30 iQ28lLyF4N+ivMBGQlOOzeIqywfhnw2t4jgHVOoA3frgUdIYxrwp+wMTOY/qtGzS fljTDwUva/28wVnvYWuv1hhJBPwsk+xy1SUofsQipbpWwaJnMOlL867MSoKxgA1Y 2PHlE3gaqQm4Vhmu9JenuK1mkARIDJw435OMbgvwx3jVeK5pM5s8CFFuv8Jizjmz IGBDr6gGsq2HnweSL5fLTWoQ0AJMXhHk1y8g4YyG5GFzcU2ZMDNf08nuGOXw4wSL YThsqTsj4AXGRTLocWkK5hsllCSJ9piYXWJHEm17xXmIqqvlAXTSq8zXcKA5mCqg OSXlvMR2LLzBSZ5oG/W7pbKywtPY42K1QlIC8PmL73yYSIxxmKM= =VSpG -----END PGP SIGNATURE----- --sXIsdpKMRddpUhtn-- From unknown Mon Aug 18 06:57:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32868: [PATCH] m4: rework silent-rules macros to avoid double expansion Resent-From: Mike Frysinger Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 21 Feb 2022 00:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32868 X-GNU-PR-Package: automake X-GNU-PR-Keywords: confirmed To: 32868@debbugs.gnu.org Received: via spool by 32868-submit@debbugs.gnu.org id=B32868.16454032894301 (code B ref 32868); Mon, 21 Feb 2022 00:29:01 +0000 Received: (at 32868) by debbugs.gnu.org; 21 Feb 2022 00:28:09 +0000 Received: from localhost ([127.0.0.1]:34185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLwYj-00017J-0b for submit@debbugs.gnu.org; Sun, 20 Feb 2022 19:28:09 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:48674 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLwYh-00016l-Q9 for 32868@debbugs.gnu.org; Sun, 20 Feb 2022 19:28:08 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 96596343264; Mon, 21 Feb 2022 00:28:01 +0000 (UTC) Date: Sun, 20 Feb 2022 19:28:01 -0500 From: Mike Frysinger Message-ID: Mail-Followup-To: 32868@debbugs.gnu.org References: <464d4269-20b5-0195-4e9a-698e0fe2cecd@redhat.com> <20220221001400.11892-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2r8zE090Spx2i0XC" Content-Disposition: inline In-Reply-To: <20220221001400.11892-1-vapier@gentoo.org> X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --2r8zE090Spx2i0XC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20 Feb 2022 19:14, Mike Frysinger wrote: > --- a/m4/silent.m4 > +++ b/m4/silent.m4 > @@ -5,12 +5,12 @@ > # gives unlimited permission to copy and/or distribute it, > # with or without modifications, as long as this notice is preserved. > =20 > -# AM_SILENT_RULES([DEFAULT]) > -# -------------------------- > -# Enable less verbose build rules; with the default set to DEFAULT > -# ("yes" being less verbose, "no" or empty being verbose). > -AC_DEFUN([AM_SILENT_RULES], > -[AC_ARG_ENABLE([silent-rules], [dnl > +# _AM_SILENT_RULES > +# ---------------- > +# Enable less verbose build rules support. > +AC_DEFUN([_AM_SILENT_RULES], > +[AM_DEFAULT_VERBOSITY=3D0 this should be 1 instead of 0. the silent-vs-verbose is kind of a double negative, so i flipped it before testing. i've fix it locally. -mike --2r8zE090Spx2i0XC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIS3JEACgkQQWM7n+g3 9YF1hA//cVwz1krCG31REwAmRfm6nMk/D66jG5SGHEUatCpSXHuSWEBWqxdflwHJ LuJaSosDVFC0aweHmID986CPlaiDwxOM7UXyTrAiimvcLxcJK1h36pdKR+pAq35J 2nuU2pIDR5zYT3VEHXpLTlN/OvBF+c6TXKHfE9yEFcjc8NGmTFEZ1ltGWT50Skk0 xw1O8Djljmtt+uxFvd43yCZzKhHL++ioVCEYrpmk3jc1TP47o5guyA/1IcPKcYV+ QcaTIzhW4KeAwIPzHOVMWCT/seOLFwbrSHQbgm7ypztTodI2/LOQ1WWVBz4Tfuvx 6Bp16jtWtMmq9u87yY8BCHZXpDy8BLEbnu5IOhSsNJB8wHTTsiwf/rQg3uTX5W3D AfJh7j4OJ6rW3sP8LciN9yOUMBxk5joyxRMbiXu2wkWGYUrbPjCjaN/923nBcVV8 9uaTipllwMwIuR7MC7PE5HuJA2AnLGzyuXQXvvYzneNykQvZZEc/34oeJU1SrUGj DRRF09C1w32tEGfLdUfoaojsu1l/hNDBf05VaPCvYYvvI0C9xIxzgIjwsh6z0ViJ UBpRsW3zRM4eu0K4kKO/9f+DOd60tpIs11fIg92CYFbeAM81NQdARb3E66wRyjnh HP5g0/5oRDVHQYmHxbQdlbW1pezvVWxFdn24BAe6TeULg+7mNII= =ur4E -----END PGP SIGNATURE----- --2r8zE090Spx2i0XC-- From unknown Mon Aug 18 06:57:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32868: [PATCH v2] m4: rework silent-rules macros to avoid double expansion Resent-From: Mike Frysinger Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 28 Feb 2022 02:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32868 X-GNU-PR-Package: automake X-GNU-PR-Keywords: confirmed To: 32868@debbugs.gnu.org Received: via spool by 32868-submit@debbugs.gnu.org id=B32868.16460137175471 (code B ref 32868); Mon, 28 Feb 2022 02:02:01 +0000 Received: (at 32868) by debbugs.gnu.org; 28 Feb 2022 02:01:57 +0000 Received: from localhost ([127.0.0.1]:59627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOVMA-0001Pv-BC for submit@debbugs.gnu.org; Sun, 27 Feb 2022 21:01:57 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:45588 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOVM4-0001PY-UH for 32868@debbugs.gnu.org; Sun, 27 Feb 2022 21:01:45 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 6D5DE3435CB; Mon, 28 Feb 2022 02:01:34 +0000 (UTC) From: Mike Frysinger Date: Sun, 27 Feb 2022 21:01:35 -0500 Message-Id: <20220228020135.10871-1-vapier@gentoo.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220221001400.11892-1-vapier@gentoo.org> References: <20220221001400.11892-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixes automake bug https://bugs.gnu.org/32868. The AM_SILENT_RULES macro defines all the silent-rules related setup. It's also called by users to change the default verbosity level. This leads to a quirk where automake calls it, expands the full context, and then users call it, and it's fully expanded again. Instead, let's rename AM_SILENT_RULES to _AM_SILENT_RULES and move the initialization logic to late in the configure stage. This allows the user-centric AM_SILENT_RULES call to expand into a single line to set the default verbosity. * m4/init.m4: Switch to _AM_SILENT_RULES. * m4/silent.m4: Rename AM_SILENT_RULES to _AM_SILENT_RULES. Delay evaluation of AM_SILENT_RULES to the end. Define new AM_SILENT_RULES to set default rules verbosity. * t/silent-defaults.sh: New tests. * t/list-of-tests.mk: Add t/silent-defaults.sh. --- v2 - fix default handling when AM_SILENT_RULES is called before AM_INIT_AUTOMAKE. m4/init.m4 | 2 +- m4/silent.m4 | 49 ++++++++----- t/list-of-tests.mk | 1 + t/silent-defaults.sh | 164 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 196 insertions(+), 20 deletions(-) create mode 100644 t/silent-defaults.sh diff --git a/m4/init.m4 b/m4/init.m4 index f3abf66c6e96..f3c7845bca70 100644 --- a/m4/init.m4 +++ b/m4/init.m4 @@ -134,7 +134,7 @@ if test -z "$CSCOPE"; then fi AC_SUBST([CSCOPE]) -AC_REQUIRE([AM_SILENT_RULES])dnl +AC_REQUIRE([_AM_SILENT_RULES])dnl dnl The testsuite driver may need to know about EXEEXT, so add the dnl 'am__EXEEXT' conditional if _AM_COMPILER_EXEEXT was seen. This dnl macro is hooked onto _AC_COMPILER_EXEEXT early, see below. diff --git a/m4/silent.m4 b/m4/silent.m4 index b1502ed389b6..d19c56e8ac3b 100644 --- a/m4/silent.m4 +++ b/m4/silent.m4 @@ -5,12 +5,12 @@ # gives unlimited permission to copy and/or distribute it, # with or without modifications, as long as this notice is preserved. -# AM_SILENT_RULES([DEFAULT]) -# -------------------------- -# Enable less verbose build rules; with the default set to DEFAULT -# ("yes" being less verbose, "no" or empty being verbose). -AC_DEFUN([AM_SILENT_RULES], -[AC_ARG_ENABLE([silent-rules], [dnl +# _AM_SILENT_RULES +# ---------------- +# Enable less verbose build rules support. +AC_DEFUN([_AM_SILENT_RULES], +[AM_DEFAULT_VERBOSITY=1 +AC_ARG_ENABLE([silent-rules], [dnl AS_HELP_STRING( [--enable-silent-rules], [less verbose build output (undo: "make V=1")]) @@ -18,11 +18,6 @@ AS_HELP_STRING( [--disable-silent-rules], [verbose build output (undo: "make V=0")])dnl ]) -case $enable_silent_rules in @%:@ ((( - yes) AM_DEFAULT_VERBOSITY=0;; - no) AM_DEFAULT_VERBOSITY=1;; - *) AM_DEFAULT_VERBOSITY=m4_if([$1], [yes], [0], [1]);; -esac dnl dnl A few 'make' implementations (e.g., NonStop OS and NextStep) dnl do not support nested variable expansions. @@ -41,14 +36,6 @@ am__doit: else am_cv_make_support_nested_variables=no fi]) -if test $am_cv_make_support_nested_variables = yes; then - dnl Using '$V' instead of '$(V)' breaks IRIX make. - AM_V='$(V)' - AM_DEFAULT_V='$(AM_DEFAULT_VERBOSITY)' -else - AM_V=$AM_DEFAULT_VERBOSITY - AM_DEFAULT_V=$AM_DEFAULT_VERBOSITY -fi AC_SUBST([AM_V])dnl AM_SUBST_NOTMAKE([AM_V])dnl AC_SUBST([AM_DEFAULT_V])dnl @@ -57,4 +44,28 @@ AC_SUBST([AM_DEFAULT_VERBOSITY])dnl AM_BACKSLASH='\' AC_SUBST([AM_BACKSLASH])dnl _AM_SUBST_NOTMAKE([AM_BACKSLASH])dnl +dnl Delay evaluation of AM_DEFAULT_VERBOSITY to the end to allow multiple calls +dnl to AM_SILENT_RULES to change the default value. +AC_CONFIG_COMMANDS_PRE([dnl +case $enable_silent_rules in @%:@ ((( + yes) AM_DEFAULT_VERBOSITY=0;; + no) AM_DEFAULT_VERBOSITY=1;; +esac +if test $am_cv_make_support_nested_variables = yes; then + dnl Using '$V' instead of '$(V)' breaks IRIX make. + AM_V='$(V)' + AM_DEFAULT_V='$(AM_DEFAULT_VERBOSITY)' +else + AM_V=$AM_DEFAULT_VERBOSITY + AM_DEFAULT_V=$AM_DEFAULT_VERBOSITY +fi +])dnl ]) + +# AM_SILENT_RULES([DEFAULT]) +# -------------------------- +# Set the default verbosity level to DEFAULT ("yes" being less verbose, "no" or +# empty being verbose). +AC_DEFUN([AM_SILENT_RULES], +[AC_REQUIRE([_AM_SILENT_RULES]) +AM_DEFAULT_VERBOSITY=m4_if([$1], [yes], [0], [1])]) diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk index d959b68db47b..dbfd8d6d1145 100644 --- a/t/list-of-tests.mk +++ b/t/list-of-tests.mk @@ -1015,6 +1015,7 @@ t/sanity.sh \ t/seenc.sh \ t/silent-c.sh \ t/silent-cxx.sh \ +t/silent-defaults.sh \ t/silent-lt.sh \ t/silent-f77.sh \ t/silent-f90.sh \ diff --git a/t/silent-defaults.sh b/t/silent-defaults.sh new file mode 100644 index 000000000000..c4cdee548911 --- /dev/null +++ b/t/silent-defaults.sh @@ -0,0 +1,164 @@ +#!/bin/sh +# Copyright (C) 2022 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check verbose mode defaults and behavior. + +. test-init.sh + +: > Makefile.am + +# Default behavior is currently verbose. +cat <configure.ac +AC_INIT([silent-defaults], [1.0]) +AM_INIT_AUTOMAKE +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT +EOF + +$ACLOCAL +$AUTOMAKE +$AUTOCONF + +./configure -C +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +./configure -C --enable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 0' Makefile + +./configure -C --disable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +# User doesn't pick a silent mode default before AM_INIT_AUTOMAKE. +cat <configure.ac +AC_INIT([silent-defaults], [1.0]) +AM_SILENT_RULES +AM_INIT_AUTOMAKE +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT +EOF + +$AUTOCONF + +./configure -C +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +./configure -C --enable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 0' Makefile + +./configure -C --disable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +# User disables silent mode default before AM_INIT_AUTOMAKE. +cat <configure.ac +AC_INIT([silent-defaults], [1.0]) +AM_SILENT_RULES([no]) +AM_INIT_AUTOMAKE +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT +EOF + +$AUTOCONF + +./configure -C +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +./configure -C --enable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 0' Makefile + +./configure -C --disable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +# User enables silent mode default before AM_INIT_AUTOMAKE. +cat <configure.ac +AC_INIT([silent-defaults], [1.0]) +AM_SILENT_RULES([yes]) +AM_INIT_AUTOMAKE +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT +EOF + +$AUTOCONF + +./configure -C +grep '^AM_DEFAULT_VERBOSITY = 0' Makefile + +./configure -C --enable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 0' Makefile + +./configure -C --disable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +# User doesn't pick a silent mode default after AM_INIT_AUTOMAKE. +cat <configure.ac +AC_INIT([silent-defaults], [1.0]) +AM_INIT_AUTOMAKE +AM_SILENT_RULES +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT +EOF + +$AUTOCONF + +./configure -C +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +./configure -C --enable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 0' Makefile + +./configure -C --disable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +# User disables silent mode default after AM_INIT_AUTOMAKE. +cat <configure.ac +AC_INIT([silent-defaults], [1.0]) +AM_INIT_AUTOMAKE +AM_SILENT_RULES([no]) +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT +EOF + +$AUTOCONF + +./configure -C +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +./configure -C --enable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 0' Makefile + +./configure -C --disable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +# User enables silent mode default after AM_INIT_AUTOMAKE. +cat <configure.ac +AC_INIT([silent-defaults], [1.0]) +AM_INIT_AUTOMAKE +AM_SILENT_RULES([yes]) +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT +EOF + +$AUTOCONF + +./configure -C +grep '^AM_DEFAULT_VERBOSITY = 0' Makefile + +./configure -C --enable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 0' Makefile + +./configure -C --disable-silent-rules +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile + +: -- 2.34.1 From unknown Mon Aug 18 06:57:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32868: [PATCH v2] m4: rework silent-rules macros to avoid double expansion References: <464d4269-20b5-0195-4e9a-698e0fe2cecd@redhat.com> Resent-From: Karl Berry Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 28 Feb 2022 23:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32868 X-GNU-PR-Package: automake X-GNU-PR-Keywords: confirmed To: vapier@gentoo.org Cc: 32868@debbugs.gnu.org Received: via spool by 32868-submit@debbugs.gnu.org id=B32868.164608914832224 (code B ref 32868); Mon, 28 Feb 2022 23:00:02 +0000 Received: (at 32868) by debbugs.gnu.org; 28 Feb 2022 22:59:08 +0000 Received: from localhost ([127.0.0.1]:34957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOoyy-0008Ng-0F for submit@debbugs.gnu.org; Mon, 28 Feb 2022 17:59:08 -0500 Received: from freefriends.org ([96.88.95.60]:49360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOoyh-0008N0-2D for 32868@debbugs.gnu.org; Mon, 28 Feb 2022 17:59:06 -0500 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 21SMwnop002084 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Feb 2022 15:58:50 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 21SMwmEW002083; Mon, 28 Feb 2022 15:58:48 -0700 Date: Mon, 28 Feb 2022 15:58:48 -0700 Message-Id: <202202282258.21SMwmEW002083@freefriends.org> From: Karl Berry In-Reply-To: <20220228020135.10871-1-vapier@gentoo.org> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Fixes automake bug https://bugs.gnu.org/32868. Looks fine to me. +./configure -C +grep '^AM_DEFAULT_VERBOSITY = 1' Makefile Good :). I remain steadfastly opposed to (ever) changing the default to be silent rules, as we've already discussed ad nauseam :). --thanks, karl. From unknown Mon Aug 18 06:57:25 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: bug-automake@gnu.org, Jacob Kroon Subject: bug#32868: closed (Re: bug#32868: [PATCH v2] m4: rework silent-rules macros to avoid double expansion) Message-ID: References: <464d4269-20b5-0195-4e9a-698e0fe2cecd@redhat.com> X-Gnu-PR-Message: they-closed 32868 X-Gnu-PR-Package: automake X-Gnu-PR-Keywords: confirmed Reply-To: 32868@debbugs.gnu.org Date: Tue, 01 Mar 2022 06:53:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1646117582-25344-1" This is a multi-part message in MIME format... ------------=_1646117582-25344-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #32868: Check if make supports nested variables is done twice when using si= lent rules which was filed against the automake package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 32868@debbugs.gnu.org. --=20 32868: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32868 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1646117582-25344-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 32868-done) by debbugs.gnu.org; 1 Mar 2022 06:52:13 +0000 Received: from localhost ([127.0.0.1]:35283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOwMm-0006Zh-VY for submit@debbugs.gnu.org; Tue, 01 Mar 2022 01:52:13 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:50920 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOwMk-0006ZU-UU for 32868-done@debbugs.gnu.org; Tue, 01 Mar 2022 01:52:11 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 9868D3434A2; Tue, 1 Mar 2022 06:52:04 +0000 (UTC) Date: Tue, 1 Mar 2022 01:52:07 -0500 From: Mike Frysinger To: Karl Berry Subject: Re: bug#32868: [PATCH v2] m4: rework silent-rules macros to avoid double expansion Message-ID: Mail-Followup-To: Karl Berry , 32868-done@debbugs.gnu.org References: <20220228020135.10871-1-vapier@gentoo.org> <202202282258.21SMwmEW002083@freefriends.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SAojU+Z3nAZAbgrt" Content-Disposition: inline In-Reply-To: <202202282258.21SMwmEW002083@freefriends.org> X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32868-done Cc: 32868-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --SAojU+Z3nAZAbgrt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 28 Feb 2022 15:58, Karl Berry wrote: > Fixes automake bug https://bugs.gnu.org/32868. >=20 > Looks fine to me. >=20 > +./configure -C > +grep '^AM_DEFAULT_VERBOSITY =3D 1' Makefile >=20 > Good :). >=20 > I remain steadfastly opposed to (ever) changing the default to be silent > rules, as we've already discussed ad nauseam :). we shall see :p -mike --SAojU+Z3nAZAbgrt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIdwpcACgkQQWM7n+g3 9YGtDhAAw6goabBYgjiqjYNbNwl9AG9wE9EIWJXprhhnMhZZnE3SWD9Difd32g58 LQxGwbbMeMD3pvBTSx64EV100ID4bMl7TatGqg/tHv0D31QuiApgyh9rnWKnrK+j chCanKw4aDA43cM2vqr/RPSBvYxJ6WDSB3lRQwraZbi+Yl///aPcPdykFgHF6f09 gm6GNfe8XMKR+qaFushXQNWtMqnMeQ55ihgEbDDsssdP49ywvEG/aP0QVzj6ItRd dY50I7Zq7CseAe4lZvgqEfTRDJuvPCCwG8I1gfZvkuxWyG/Mg7x2zQXte+XA0poP L8SZpnmzHZfVIhODxnBEGRcFWs3+/YE4/Sd4ky64Yzbdnk0uEBPvUw/JhWmNjxs0 GfZ+sMjT7iOTOLjdHKCClHUsgh5UWZz3xFJcZj4424nLZCIVEGVztcSVQKVZMx5S AY7XQsbpmoZBeVIbfg/3GaOt0KC3FQSKi6UrsS5EeXypcaOvXkUkeBmjyqCrFMX0 Z93UlZp82ORJUy8zf4Og4v2XQk9CgHCZUg06Cij55Md9XiI6SQOXp2Kta4oxkk/u AVYUi3jgtWydbQuC7W7W/BR3KiO1LKuxkoi6nv7vXBdm8AxVvt6m+UjaKBaq/h6u Focwlf/BT5ztAopDJtR8AtHm/4tcC7SVW6eXDIX0n2xVVwd4pNg= =YXRS -----END PGP SIGNATURE----- --SAojU+Z3nAZAbgrt-- ------------=_1646117582-25344-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Sep 2018 20:36:58 +0000 Received: from localhost ([127.0.0.1]:58035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5zVR-0005Gt-3e for submit@debbugs.gnu.org; Fri, 28 Sep 2018 16:36:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5zVP-0005Gg-7D for submit@debbugs.gnu.org; Fri, 28 Sep 2018 16:36:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5zVJ-00049L-53 for submit@debbugs.gnu.org; Fri, 28 Sep 2018 16:36:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34539) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g5zVJ-00048q-1g for submit@debbugs.gnu.org; Fri, 28 Sep 2018 16:36:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5zVI-0000xk-6z for bug-automake@gnu.org; Fri, 28 Sep 2018 16:36:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5zVH-00046H-H5 for bug-automake@gnu.org; Fri, 28 Sep 2018 16:36:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52992) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g5zVD-0003u6-Co; Fri, 28 Sep 2018 16:36:43 -0400 Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2E7C63091794; Fri, 28 Sep 2018 20:36:42 +0000 (UTC) Received: from [10.10.125.67] (ovpn-125-67.rdu2.redhat.com [10.10.125.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D31588C12; Fri, 28 Sep 2018 20:36:41 +0000 (UTC) Subject: Re: Check if make supports nested variables is done twice when using silent rules To: Jacob Kroon , bug-autoconf@gnu.org, bug-automake@gnu.org References: From: Eric Blake Organization: Red Hat, Inc. Message-ID: <464d4269-20b5-0195-4e9a-698e0fe2cecd@redhat.com> Date: Fri, 28 Sep 2018 15:36:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 28 Sep 2018 20:36:42 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: bug-automake@gnu.org, Jacob Kroon Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) On 9/28/18 1:47 PM, Jacob Kroon wrote: > Hi, > > If I use AM_SILENT_RULES([yes]) in my configure.ac, when I run the > configure scripts I see this: > ... > checking whether make supports nested variables... yes > checking whether make supports nested variables... (cached) yes > ... > > If I remove AM_SILENT_RULES, the test is only done once. > > Is this intended behaviour ? I don't know. But AM_SILENT_RULES is supplied by automake, not autoconf, so it's better to ask your question on the correct list. I've gone ahead and updated the CC's accordingly. > > I'm on an updated Debian Stretch system using (Debian version syntax): > autoconf 2.69-10 > automake 1:1.15-6 > > Regards Jacob > > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org ------------=_1646117582-25344-1--