GNU bug report logs - #32866
cross-compiling grep and changing $PATH

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32866 in the body.
You can then email your comments to 32866 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Barret Rhoden <brho <at> cs.berkeley.edu>
To: bug-grep <at> gnu.org
Subject: cross-compiling grep and changing $PATH
Date: Fri, 28 Sep 2018 14:37:27 -0400

Hi -

Not sure if this is a bug or something I'm doing wrong, but when I
cross-compile grep (3.1) for another system where the binaries do not
run on the host, the make output will have a couple of these:

/bin/sh: ./src/grep: No such file or directory

It looks like the newly built grep is being used, but it won't run on
the host.  This looks like it is from cfg.mk:

export PATH := $(builddir)/src$(PATH_SEPARATOR)$(PATH)

It doesn't seem particularly harmful, but maybe that PATH change should
depend on whether it's a cross build or not.

Thanks,

Barret

Message #8 received at 32866 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Barret Rhoden <brho <at> cs.berkeley.edu>, 32866 <at> debbugs.gnu.org
Subject: Re: bug#32866: cross-compiling grep and changing $PATH
Date: Fri, 28 Sep 2018 12:02:56 -0700

On 9/28/18 11:37 AM, Barret Rhoden wrote:
> It doesn't seem particularly harmful, but maybe that PATH change should
> depend on whether it's a cross build or not.

Sounds like a good idea. Care to suggest a patch?

Message #11 received at 32866 <at> debbugs.gnu.org (full text, mbox):

From: Barret Rhoden <brho <at> cs.berkeley.edu>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 32866 <at> debbugs.gnu.org
Subject: Re: bug#32866: cross-compiling grep and changing $PATH
Date: Fri, 28 Sep 2018 15:21:17 -0400

[Message part 1 (text/plain, inline)]

On 2018-09-28 at 12:02 Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> On 9/28/18 11:37 AM, Barret Rhoden wrote:
> > It doesn't seem particularly harmful, but maybe that PATH change should
> > depend on whether it's a cross build or not.  
> 
> Sounds like a good idea. Care to suggest a patch?
> 

The attached patch works for me.  Tested it on Linux, and it still
builds and runs.

If you all like it and prefer a git format-patch or send-email, I can do
that too.

[0003-skip-path-update-when-cross-compiling.patch (text/x-patch, attachment)]

Message #16 received at 32866-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Barret Rhoden <brho <at> cs.berkeley.edu>
Cc: 32866-done <at> debbugs.gnu.org
Subject: Re: bug#32866: cross-compiling grep and changing $PATH
Date: Fri, 28 Sep 2018 14:36:36 -0700

Thanks for the patch; that was quick! It's short enough so that we 
needn't worry about copyright papers, so I installed it in your name 
into the master copy of Grep on savannah.gnu.org and am closing this bug 
report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.