GNU bug report logs - #32850
27.0.50; window-swap-states doesn't swap window prev/next-buffers

Previous Next

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>
Cc: 32850 <at> debbugs.gnu.org
Subject: bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers
Date: Thu, 01 Nov 2018 10:03:31 +0100

> Then is this right?
>
> diff --git a/lisp/window.el b/lisp/window.el
> index bcd4fa2959..346096c2f8 100644
> --- a/lisp/window.el
> +++ b/lisp/window.el
> @@ -5898,20 +5898,12 @@ window-state-put
>   windows can get as small as `window-safe-min-height' and
>   `window-safe-min-width'."
>     (setq window-state-put-stale-windows nil)
> -  (setq window (window-normalize-window window))
>
> -  ;; When WINDOW is internal, reduce it to a live one to put STATE into,
> -  ;; see Bug#16793.
> +  ;; When WINDOW is internal or nil, create a new window.
>     (unless (window-live-p window)
> -    (let ((root window))
> -      (setq window (catch 'live
> -                     (walk-window-subtree
> -                      (lambda (window)
> -                        (when (and (window-live-p window)
> -                                   (not (window-parameter window 'window-side)))
> -                          (throw 'live window)))
> -                      root)))
> -      (delete-other-windows-internal window root)))
> +    (delete-other-windows-internal)
> +    (setq window (split-window))
> +    (delete-window))
>
>     (set-window-dedicated-p window nil)

What would be bad about leaving most of that code in place and just
adding the

> +    (setq window (split-window))
> +    (delete-window))

ugliness?

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.