GNU bug report logs - #32849
26.1; xref-marker-ring-length user option doesn't have setter

Previous Next

Full log

View this message in rfc822 format

From: Allen Li <darkfeline <at> felesatra.moe>
To: eliz <at> gnu.org
Cc: 32849 <at> debbugs.gnu.org
Subject: bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter
Date: Wed, 24 Oct 2018 21:30:51 -0600

[Message part 1 (text/plain, inline)]

Patches attached.

Of note:

I added a ring-resize function.

I wrote tests with names function-to-test/case-tested.  I'm not sure
if this violates style policies for tests.  It seems like existing
code tests multiple cases in a single test, but I find separate tests
easier to understand when they regress.  The / makes the test names
easier to read.

I based this off of 26 (as I think this is a minor bugfix/feature add).
On Thu, Sep 27, 2018 at 2:24 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> > From: Allen Li <darkfeline <at> felesatra.moe>
> > Date: Wed, 26 Sep 2018 16:14:15 -0700
> >
> > The xref-marker-ring-length user option doesn't have a setter, so
> > customizing it will not affect xref--marker-ring, except if/when user
> > customizations are loaded in a new Emacs process before xref is loaded.
> > Customizations after xref is loaded will have no effect.
>
> I think the setter should use ring-extend to enlarge the ring, and
> some custom code using ring-remove to make the ring smaller.
>
> Would you like to submit a patch along those lines?
>
> Thanks.

[0002-Add-setter-for-xref-marker-ring-length.patch (text/x-patch, attachment)]

[0001-Add-ring-resize-function.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.