From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 26 19:14:46 2018 Received: (at submit) by debbugs.gnu.org; 26 Sep 2018 23:14:46 +0000 Received: from localhost ([127.0.0.1]:55759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5J13-0004b9-U4 for submit@debbugs.gnu.org; Wed, 26 Sep 2018 19:14:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5J12-0004aw-VM for submit@debbugs.gnu.org; Wed, 26 Sep 2018 19:14:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5J0w-0002zP-Fi for submit@debbugs.gnu.org; Wed, 26 Sep 2018 19:14:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g5J0u-0002yv-Iy for submit@debbugs.gnu.org; Wed, 26 Sep 2018 19:14:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5J0t-0005ix-Q4 for bug-gnu-emacs@gnu.org; Wed, 26 Sep 2018 19:14:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5J0r-0002xW-Ie for bug-gnu-emacs@gnu.org; Wed, 26 Sep 2018 19:14:35 -0400 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]:33816) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g5J0r-0002vK-8F for bug-gnu-emacs@gnu.org; Wed, 26 Sep 2018 19:14:33 -0400 Received: by mail-io1-xd2a.google.com with SMTP id h16-v6so578285ioj.1 for ; Wed, 26 Sep 2018 16:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=SHnaSlzKo94XdM8h9uCEwL1eZXCQWiDaOIuF5/RRhTg=; b=zvUDYPjJAsqtIXT0n1yJeJLM+uNVb7Poi6/O8J/gHZOatThYe7Jk5uhr0CSp6la/3k 3c5E9rdKczHJWynAUmhma68122nAzi8hX9natYIV3WxQszD/9NpgTOc2WyE4P6aSUF2R 9uZ2t2tViTW9Q5s+tvI7MtQenS2C6gq2qRED5Vs2Kv/ZVCj4keBdtAjDUmIbBd/wgeP0 t/JzoWZ4TQnXSCcIqKRB17hGqanurltkHmf3uKDq5pTPhfe9mvARPqIUK0vtfZxe2m/2 OhYO2CGOM75rextk9iPF+MBZIbwQsWgvzfekhhZcvDidiAYp6GargvSBWWzW98v/Esxq krPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=SHnaSlzKo94XdM8h9uCEwL1eZXCQWiDaOIuF5/RRhTg=; b=udYzif//nARS89H7P2I1E8x3gHIi/tG3MQ0PHPu8TPuAY9oAxALJycRDnVESTV7WjC nxCj+KZSlCwMzbO0+qlPFGT63DNb3U34Dvj2t1bUILsNJLDFkflkdwIzRDgSw/UhWSsb OhI6Pg7qXu4WiUjQvq7OJ0v77JkpGKFaiZjqoAZ6WmaBa8neyP76rSTDVFbxSzywpdUs SterVDRwPVxqsrGP7ToTPIl8BC758iYi3quAoMVNlSRXuBaR4ULXZFZDjR9JED0Uq4ZX Ke3VNrJhX38cCOtJJtFowIkOegi0BGUCrshQvy93qGzibIlQE3xlXGWWZXbgO3GtU/o6 VMRA== X-Gm-Message-State: ABuFfoi8houLXrRHyvz/qGrivrhDINaCS0XQUKHh7smxnKhIWrB7Hp4h 9VA8q2ttt1pUML+4CaPQ07A7GRU8W1uNC9cB2Fx/7bUBl7THHg== X-Google-Smtp-Source: ACcGV60486GOHvGBqLMwYLAv5sRMc6YWWQl3Q5Sj0X/rKpNutyCFBUAFEvefcqjnFzWT/02TPBykDL35fRYhQSFt0s0= X-Received: by 2002:a6b:2c08:: with SMTP id s8-v6mr7072869ios.217.1538003666670; Wed, 26 Sep 2018 16:14:26 -0700 (PDT) MIME-Version: 1.0 From: Allen Li Date: Wed, 26 Sep 2018 16:14:15 -0700 Message-ID: Subject: 26.1; xref-marker-ring-length user option doesn't have setter To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The xref-marker-ring-length user option doesn't have a setter, so customizing it will not affect xref--marker-ring, except if/when user customizations are loaded in a new Emacs process before xref is loaded. Customizations after xref is loaded will have no effect. In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.24), modified by Debian Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Debian GNU/Linux rodete (upgraded from: Ubuntu 14.04 LTS) From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 27 04:24:41 2018 Received: (at 32849) by debbugs.gnu.org; 27 Sep 2018 08:24:41 +0000 Received: from localhost ([127.0.0.1]:55879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5RbF-0003SZ-0d for submit@debbugs.gnu.org; Thu, 27 Sep 2018 04:24:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5RbC-0003SK-Up for 32849@debbugs.gnu.org; Thu, 27 Sep 2018 04:24:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5Rb4-0003yx-IX for 32849@debbugs.gnu.org; Thu, 27 Sep 2018 04:24:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5Rb4-0003yt-Es; Thu, 27 Sep 2018 04:24:30 -0400 Received: from [176.228.60.248] (port=4074 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g5Rb3-0006Vx-0G; Thu, 27 Sep 2018 04:24:30 -0400 Date: Thu, 27 Sep 2018 11:24:04 +0300 Message-Id: <831s9f8i1n.fsf@gnu.org> From: Eli Zaretskii To: Allen Li In-reply-to: (message from Allen Li on Wed, 26 Sep 2018 16:14:15 -0700) Subject: Re: bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32849 Cc: 32849@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Allen Li > Date: Wed, 26 Sep 2018 16:14:15 -0700 > > The xref-marker-ring-length user option doesn't have a setter, so > customizing it will not affect xref--marker-ring, except if/when user > customizations are loaded in a new Emacs process before xref is loaded. > Customizations after xref is loaded will have no effect. I think the setter should use ring-extend to enlarge the ring, and some custom code using ring-remove to make the ring smaller. Would you like to submit a patch along those lines? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 24 23:31:11 2018 Received: (at 32849) by debbugs.gnu.org; 25 Oct 2018 03:31:11 +0000 Received: from localhost ([127.0.0.1]:41116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFWMY-0002zl-I0 for submit@debbugs.gnu.org; Wed, 24 Oct 2018 23:31:10 -0400 Received: from mail-it1-f176.google.com ([209.85.166.176]:40650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFWMW-0002zW-J0 for 32849@debbugs.gnu.org; Wed, 24 Oct 2018 23:31:09 -0400 Received: by mail-it1-f176.google.com with SMTP id i191-v6so9349753iti.5 for <32849@debbugs.gnu.org>; Wed, 24 Oct 2018 20:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QUNOq3IcyZpYhih3isQ9e4uiXmArLNnatf6BLt1D4b0=; b=RC6tQi9JCgaBrCr51MdU6H13PNxzDUaEeMo2VajVIOxPdENFtK2XawXPq68l6JH/pb SX5mLh/6mVxb9KVoh0FYcJbdBRrXcy6d0DBYoilncKtRr7ZpFPwLlcZjQPAGGpbKcUzk F9nW2K6hoGAIkFZ67T9cM4zjSJntVTt8268ZeZA8VFu9HV6tCh4C1xRHNIk3t5MtoMIH 3omhuAA3i8Tf9Fo6+IxG7EqCewHXJWybUvvON/eRdBTGf2ucmXptEk8ICQE5u8eygnUE BoobfgPVYt5fxU0gvum8bGGHUPVDG9RXvhMSgYww7NoDS21576fpHWhGxBHzOIsvAxgv jIZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QUNOq3IcyZpYhih3isQ9e4uiXmArLNnatf6BLt1D4b0=; b=MFmkJxiUkqp7fAVwPzWyYYS3AieNNX/s1yLbZaQe8UjF1YcSQ7y/qUF7/Uzp+WzU8A fql7Rv0oXL/tBD8UfxSyfMHJ+4fN+AseTD1WazjkJ5Q8+KNTosQ2+OQhyaNcm43OGLl0 JENIxKKSYmoDSH90bT32MtwJPC8/D5wtw4gsfPvqnMFcwCjF0k5q03VRnIqc2zTnghcj 7wKdm7uPUT+CFFIwoIbV236WPXU7Jiks/Y3Rt0lSTLLkRc1jwe1qmNEJ99uFojxUcszM QGqbF/lQ5F9gnVMJKScna4Yv9UliGRtzAI3WaKxMlANdHdLmP8Pw3+HDh4mT8uTHFfMA 9rBA== X-Gm-Message-State: AGRZ1gK2toEzgYBm/wqkB1JHNhhGwK/uGT5ffflDLqn8Xo+V/+wu2jme Fwo5dZ8CuaPLZg1NDvHZJUNph1ZYLeYHFE6QSY9WkTwa X-Google-Smtp-Source: AJdET5eDSsNR9n8TnCMJwwaWRSyof0RuQWKqc/2+IuX6cvAvXEX7/W2EghlN4AcFxPa5Q7CfOtFgkp690sXQO3Fk4rc= X-Received: by 2002:a02:9795:: with SMTP id s21-v6mr3707793jaj.92.1540438262769; Wed, 24 Oct 2018 20:31:02 -0700 (PDT) MIME-Version: 1.0 References: <831s9f8i1n.fsf@gnu.org> In-Reply-To: <831s9f8i1n.fsf@gnu.org> From: Allen Li Date: Wed, 24 Oct 2018 21:30:51 -0600 Message-ID: Subject: Re: bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter To: eliz@gnu.org Content-Type: multipart/mixed; boundary="00000000000073adb80579053b9c" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 32849 Cc: 32849@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000073adb80579053b9c Content-Type: text/plain; charset="UTF-8" Patches attached. Of note: I added a ring-resize function. I wrote tests with names function-to-test/case-tested. I'm not sure if this violates style policies for tests. It seems like existing code tests multiple cases in a single test, but I find separate tests easier to understand when they regress. The / makes the test names easier to read. I based this off of 26 (as I think this is a minor bugfix/feature add). On Thu, Sep 27, 2018 at 2:24 AM Eli Zaretskii wrote: > > > From: Allen Li > > Date: Wed, 26 Sep 2018 16:14:15 -0700 > > > > The xref-marker-ring-length user option doesn't have a setter, so > > customizing it will not affect xref--marker-ring, except if/when user > > customizations are loaded in a new Emacs process before xref is loaded. > > Customizations after xref is loaded will have no effect. > > I think the setter should use ring-extend to enlarge the ring, and > some custom code using ring-remove to make the ring smaller. > > Would you like to submit a patch along those lines? > > Thanks. --00000000000073adb80579053b9c Content-Type: text/x-patch; charset="UTF-8"; name="0002-Add-setter-for-xref-marker-ring-length.patch" Content-Disposition: attachment; filename="0002-Add-setter-for-xref-marker-ring-length.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jno12fy00 RnJvbSBlYzNlMjQ4MTljNWUyZWMyZGYxZjUxYmQzY2I3MGFjNGU1OThiOWQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBXZWQsIDI0IE9jdCAyMDE4IDIwOjQ4OjE1IC0wNjAwClN1YmplY3Q6IFtQQVRDSCAyLzJd IEFkZCBzZXR0ZXIgZm9yIHhyZWYtbWFya2VyLXJpbmctbGVuZ3RoCgoqIGV0Yy9ORVdTOiBEb2N1 bWVudCBjaGFuZ2UKKiBsaXNwL3Byb2dtb2Rlcy94cmVmLmVsICh4cmVmLW1hcmtlci1yaW5nLWxl bmd0aCk6IEFkZCBzZXR0ZXIKLS0tCiBldGMvTkVXUyAgICAgICAgICAgICAgIHwgIDcgKysrKysr KwogbGlzcC9wcm9nbW9kZXMveHJlZi5lbCB8IDE2ICsrKysrKysrKysrKysrLS0KIDIgZmlsZXMg Y2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9l dGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IGM2N2IxMzIwNWMuLmY5YTlmYTZhZmMgMTAwNjQ0Ci0t LSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0xMTMsNiArMTEzLDEzIEBAIG9wdGlvbiAn dmMtaGctc3ltYm9saWMtcmV2aXNpb24tc3R5bGVzJyB0byB0aGUgdmFsdWUgJygie3Jldn0iKScu CiAtLS0KICoqIHNoYWRvd2ZpbGUuZWwgaGFzIGJlZW4gcmV3cml0dGVuIHRvIHN1cHBvcnQgVHJh bXAgZmlsZSBuYW1lcy4KIAorKiogeHJlZgorCisrKysKKyoqKiBTZXR0ZXIgYWRkZWQgZm9yICd4 cmVmLW1hcmtlci1yaW5nLWxlbmd0aCcuCitQcmV2aW91c2x5LCBzZXR0aW5nICd4cmVmLW1hcmtl ci1yaW5nLWxlbmd0aCcgd291bGQgb25seSB0YWtlIGVmZmVjdAoraWYgc2V0IGJlZm9yZSBgeHJl Zi5lbGAgd2FzIGxvYWRlZC4KKwogDAogKiBOZXcgTW9kZXMgYW5kIFBhY2thZ2VzIGluIEVtYWNz IDI2LjIKIApkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMveHJlZi5lbCBiL2xpc3AvcHJvZ21v ZGVzL3hyZWYuZWwKaW5kZXggYWJiMmE5MzQyNS4uZWFhNDAxNDE0NSAxMDA2NDQKLS0tIGEvbGlz cC9wcm9nbW9kZXMveHJlZi5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy94cmVmLmVsCkBAIC0zMTcs OCArMzE3LDEyIEBAIHhyZWYtLXNlYXJjaC1wcm9wZXJ0eQogOzs7IE1hcmtlciBzdGFjayAgKE0t LiBwdXNoZXMsIE0tLCBwb3BzKQogCiAoZGVmY3VzdG9tIHhyZWYtbWFya2VyLXJpbmctbGVuZ3Ro IDE2Ci0gICJMZW5ndGggb2YgdGhlIHhyZWYgbWFya2VyIHJpbmcuIgotICA6dHlwZSAnaW50ZWdl cikKKyAgIkxlbmd0aCBvZiB0aGUgeHJlZiBtYXJrZXIgcmluZy4KK0lmIHRoaXMgdmFyaWFibGUg aXMgbm90IHNldCB0aHJvdWdoIEN1c3RvbWl6ZSwgeW91IG11c3QgY2FsbAor4oCYeHJlZi1zZXQt bWFya2VyLXJpbmctbGVuZ3Ro4oCZIGZvciBjaGFuZ2VzIHRvIHRha2UgZWZmZWN0LiIKKyAgOnR5 cGUgJ2ludGVnZXIKKyAgOmluaXRpYWxpemUgIydjdXN0b20taW5pdGlhbGl6ZS1kZWZhdWx0Cisg IDpzZXQgIyd4cmVmLXNldC1tYXJrZXItcmluZy1sZW5ndGgpCiAKIChkZWZjdXN0b20geHJlZi1w cm9tcHQtZm9yLWlkZW50aWZpZXIgJyhub3QgeHJlZi1maW5kLWRlZmluaXRpb25zCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHhyZWYtZmluZC1kZWZpbml0aW9u cy1vdGhlci13aW5kb3cKQEAgLTM1NCw2ICszNTgsMTQgQEAgeHJlZi1hZnRlci1yZXR1cm4taG9v awogKGRlZnZhciB4cmVmLS1tYXJrZXItcmluZyAobWFrZS1yaW5nIHhyZWYtbWFya2VyLXJpbmct bGVuZ3RoKQogICAiUmluZyBvZiBtYXJrZXJzIHRvIGltcGxlbWVudCB0aGUgbWFya2VyIHN0YWNr LiIpCiAKKyhkZWZ1biB4cmVmLXNldC1tYXJrZXItcmluZy1sZW5ndGggKHZhciB2YWwpCisgICJT ZXQg4oCYeHJlZi1tYXJrZXItcmluZy1sZW5ndGjigJkuCitWQVIgaXMgdGhlIHN5bWJvbCDigJh4 cmVmLW1hcmtlci1yaW5nLWxlbmd0aOKAmSBhbmQgVkFMIGlzIHRoZSBuZXcKK3ZhbHVlLiIKKyAg KHNldC1kZWZhdWx0IHZhciB2YWwpCisgIChpZiAocmluZy1wIHhyZWYtLW1hcmtlci1yaW5nKQor ICAgICAgKHJpbmctcmVzaXplIHhyZWYtLW1hcmtlci1yaW5nIHZhbCkpKQorCiAoZGVmdW4geHJl Zi1wdXNoLW1hcmtlci1zdGFjayAoJm9wdGlvbmFsIG0pCiAgICJBZGQgcG9pbnQgTSAoZGVmYXVs dHMgdG8gYHBvaW50LW1hcmtlcicpIHRvIHRoZSBtYXJrZXIgc3RhY2suIgogICAocmluZy1pbnNl cnQgeHJlZi0tbWFya2VyLXJpbmcgKG9yIG0gKHBvaW50LW1hcmtlcikpKSkKLS0gCjIuMTkuMS41 NjguZzE1MmFkOGUzMzYtZ29vZwoK --00000000000073adb80579053b9c Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-ring-resize-function.patch" Content-Disposition: attachment; filename="0001-Add-ring-resize-function.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jno12jmy1 RnJvbSA5ODEzOGE1ZTljZjJhZmFhZTVlYzU1MjY0ZGFmMzA0MjAxYjRiNTBkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBXZWQsIDI0IE9jdCAyMDE4IDIwOjQ0OjAxIC0wNjAwClN1YmplY3Q6IFtQQVRDSCAxLzJd IEFkZCByaW5nLXJlc2l6ZSBmdW5jdGlvbgoKKiBkb2MvbGlzcHJlZi9zZXF1ZW5jZXMudGV4aSAo UmluZ3MpOiBEb2N1bWVudCBuZXcgZnVuY3Rpb24KKiBldGMvTkVXUzogRG9jdW1lbnQgbmV3IGZ1 bmN0aW9uCiogbGlzcC9lbWFjcy1saXNwL3JpbmcuZWwgKHJpbmctcmVzaXplKTogTmV3IGZ1bmN0 aW9uCiogdGVzdC9saXNwL2VtYWNzLWxpc3AvcmluZy10ZXN0cy5lbCAocmluZy10ZXN0LXJpbmct cmVzaXplKTogTmV3IHRlc3RzCi0tLQogZG9jL2xpc3ByZWYvc2VxdWVuY2VzLnRleGkgICAgICAg ICB8ICA1ICsrKysKIGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgNCArKysr CiBsaXNwL2VtYWNzLWxpc3AvcmluZy5lbCAgICAgICAgICAgIHwgMzMgKysrKysrKysrKysrKysr KystLS0tLS0tLS0KIHRlc3QvbGlzcC9lbWFjcy1saXNwL3JpbmctdGVzdHMuZWwgfCAzNyArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgNjggaW5zZXJ0aW9u cygrKSwgMTEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvc2VxdWVuY2Vz LnRleGkgYi9kb2MvbGlzcHJlZi9zZXF1ZW5jZXMudGV4aQppbmRleCA1MWQ3MjRjYjFkLi4yMzNi NjRkNDkxIDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9zZXF1ZW5jZXMudGV4aQorKysgYi9kb2Mv bGlzcHJlZi9zZXF1ZW5jZXMudGV4aQpAQCAtMTc3MSw2ICsxNzcxLDExIEBAIFJpbmdzCiByb29t IGZvciB0aGUgaW5zZXJ0ZWQgZWxlbWVudC4KIEBlbmQgZGVmdW4KIAorQGRlZnVuIHJpbmctcmVz aXplIHJpbmcgc2l6ZQorU2V0IHRoZSBzaXplIG9mIEB2YXJ7cmluZ30gdG8gQHZhcntzaXplfS4g IElmIHRoZSBuZXcgc2l6ZSBpcyBzbWFsbGVyLAordGhlbiB0aGUgb2xkZXN0IGl0ZW1zIGluIHRo ZSByaW5nIGFyZSBkaXNjYXJkZWQuCitAZW5kIGRlZnVuCisKIEBjaW5kZXggZmlmbyBkYXRhIHN0 cnVjdHVyZQogICBJZiB5b3UgYXJlIGNhcmVmdWwgbm90IHRvIGV4Y2VlZCB0aGUgcmluZyBzaXpl LCB5b3UgY2FuCiB1c2UgdGhlIHJpbmcgYXMgYSBmaXJzdC1pbi1maXJzdC1vdXQgcXVldWUuICBG b3IgZXhhbXBsZToKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggZGZhZmU3 YzVjOS4uYzY3YjEzMjA1YyAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAg LTE2MSw2ICsxNjEsMTAgQEAgVG8gY2F0ZXIgdG8gdXNlIGNhc2VzIHdoZXJlIGNvbW1lbnRzIGFu ZCBzdHJpbmdzIGFyZSB0byBiZSBpZ25vcmVkCiB3aGVuIGxvb2tpbmcgZm9yIGEgbGlzdCwgdGhl IGZ1bmN0aW9uICdsaXN0LWF0LXBvaW50JyBub3cgdGFrZXMgYW4KIG9wdGlvbmFsIGFyZ3VtZW50 IHRvIGRvIHNvLgogCisrKysKKyoqIE5ldyBmdW5jdGlvbiAncmluZy1yZXNpemUnLgorJ3Jpbmct cmVzaXplJyBjYW4gYmUgdXNlZCB0byBncm93IG9yIHNocmluayBhIHJpbmcuCisKIAwKICogQ2hh bmdlcyBpbiBFbWFjcyAyNi4yIG9uIE5vbi1GcmVlIE9wZXJhdGluZyBTeXN0ZW1zCiAKZGlmZiAt LWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9yaW5nLmVsIGIvbGlzcC9lbWFjcy1saXNwL3JpbmcuZWwK aW5kZXggMzEyZGY2YjJkZS4uMWIzNjgxMWY5ZSAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNw L3JpbmcuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3JpbmcuZWwKQEAgLTE4OSwxNyArMTg5LDI4 IEBAIHJpbmctcHJldmlvdXMKIChkZWZ1biByaW5nLWV4dGVuZCAocmluZyB4KQogICAiSW5jcmVh c2UgdGhlIHNpemUgb2YgUklORyBieSBYLiIKICAgKHdoZW4gKGFuZCAoaW50ZWdlcnAgeCkgKD4g eCAwKSkKLSAgICAobGV0KiAoKGhkICAgICAgIChjYXIgcmluZykpCi0JICAgKGxlbmd0aCAgIChy aW5nLWxlbmd0aCByaW5nKSkKLQkgICAoc2l6ZSAgICAgKHJpbmctc2l6ZSByaW5nKSkKLQkgICAo b2xkLXZlYyAgKGNkZHIgcmluZykpCi0JICAgKG5ldy12ZWMgIChtYWtlLXZlY3RvciAoKyBzaXpl IHgpIG5pbCkpKQotICAgICAgKHNldGNkciByaW5nIChjb25zIGxlbmd0aCBuZXctdmVjKSkKLSAg ICAgIDs7IElmIHRoZSByaW5nIGlzIHdyYXBwZWQsIHRoZSBleGlzdGluZyBlbGVtZW50cyBtdXN0 IGJlIHdyaXR0ZW4KLSAgICAgIDs7IG91dCBpbiB0aGUgcmlnaHQgb3JkZXIuCi0gICAgICAoZG90 aW1lcyAoaiBsZW5ndGgpCi0JKGFzZXQgbmV3LXZlYyBqIChhcmVmIG9sZC12ZWMgKG1vZCAoKyBo ZCBqKSBzaXplKSkpKQotICAgICAgKHNldGNhciByaW5nIDApKSkpCisgICAgKHJpbmctcmVzaXpl IHJpbmcgKCsgeCAocmluZy1zaXplIHJpbmcpKSkpKQorCisoZGVmdW4gcmluZy1yZXNpemUgKHJp bmcgc2l6ZSkKKyAgIlNldCB0aGUgc2l6ZSBvZiBSSU5HIHRvIFNJWkUuCitJZiB0aGUgbmV3IHNp emUgaXMgc21hbGxlciwgdGhlbiB0aGUgb2xkZXN0IGl0ZW1zIGluIHRoZSByaW5nIGFyZQorZGlz Y2FyZGVkLiIKKyAgKHdoZW4gKGludGVnZXJwIHNpemUpCisgICAgKGxldCAoKGxlbmd0aCAocmlu Zy1sZW5ndGggcmluZykpCisJICAobmV3LXZlYyAobWFrZS12ZWN0b3Igc2l6ZSBuaWwpKSkKKyAg ICAgIChpZiAoPSBsZW5ndGggMCkKKyAgICAgICAgICAoc2V0Y2RyIHJpbmcgKGNvbnMgMCBuZXct dmVjKSkKKyAgICAgICAgKGxldCogKChoZCAoY2FyIHJpbmcpKQorCSAgICAgICAob2xkLXNpemUg KHJpbmctc2l6ZSByaW5nKSkKKwkgICAgICAgKG9sZC12ZWMgKGNkZHIgcmluZykpCisgICAgICAg ICAgICAgICAoY29weS1sZW5ndGggKG1pbiBzaXplIGxlbmd0aCkpCisgICAgICAgICAgICAgICAo Y29weS1oZCAobW9kICgrIGhkICgtIGxlbmd0aCBjb3B5LWxlbmd0aCkpIGxlbmd0aCkpKQorICAg ICAgICAgIChzZXRjZHIgcmluZyAoY29ucyBjb3B5LWxlbmd0aCBuZXctdmVjKSkKKyAgICAgICAg ICA7OyBJZiB0aGUgcmluZyBpcyB3cmFwcGVkLCB0aGUgZXhpc3RpbmcgZWxlbWVudHMgbXVzdCBi ZSB3cml0dGVuCisgICAgICAgICAgOzsgb3V0IGluIHRoZSByaWdodCBvcmRlci4KKyAgICAgICAg ICAoZG90aW1lcyAoaiBjb3B5LWxlbmd0aCkKKwkgICAgKGFzZXQgbmV3LXZlYyBqIChhcmVmIG9s ZC12ZWMgKG1vZCAoKyBjb3B5LWhkIGopIG9sZC1zaXplKSkpKQorICAgICAgICAgIChzZXRjYXIg cmluZyAwKSkpKSkpCiAKIChkZWZ1biByaW5nLWluc2VydCtleHRlbmQgKHJpbmcgaXRlbSAmb3B0 aW9uYWwgZ3Jvdy1wKQogICAiTGlrZSBgcmluZy1pbnNlcnQnLCBidXQgaWYgR1JPVy1QIGlzIG5v bi1uaWwsIHRoZW4gZW5sYXJnZSByaW5nLgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VtYWNzLWxp c3AvcmluZy10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL3JpbmctdGVzdHMuZWwKaW5k ZXggMGI0ZTNkOWE2OS4uZWE3ODg5NWIwNCAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2VtYWNzLWxp c3AvcmluZy10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZW1hY3MtbGlzcC9yaW5nLXRlc3RzLmVs CkBAIC0xNjIsNiArMTYyLDQzIEBACiAgICAgKHNob3VsZCAoPSAocmluZy1zaXplIHJpbmcpIDUp KQogICAgIChzaG91bGQgKGVxdWFsIChyaW5nLWVsZW1lbnRzIHJpbmcpICcoMyAyIDEpKSkpKQog CisoZXJ0LWRlZnRlc3QgcmluZy10ZXN0LXJpbmctcmVzaXplL2dyb3cgKCkKKyAgKGxldCAoKHJp bmcgKG1ha2UtcmluZyAzKSkpCisgICAgKHJpbmctaW5zZXJ0IHJpbmcgMSkKKyAgICAocmluZy1p bnNlcnQgcmluZyAyKQorICAgIChyaW5nLWluc2VydCByaW5nIDMpCisgICAgKHJpbmctcmVzaXpl IHJpbmcgNSkKKyAgICAoc2hvdWxkICg9IChyaW5nLXNpemUgcmluZykgNSkpCisgICAgKHNob3Vs ZCAoZXF1YWwgKHJpbmctZWxlbWVudHMgcmluZykgJygzIDIgMSkpKSkpCisKKyhlcnQtZGVmdGVz dCByaW5nLXRlc3QtcmluZy1yZXNpemUvZ3Jvdy1lbXB0eSAoKQorICAobGV0ICgocmluZyAobWFr ZS1yaW5nIDMpKSkKKyAgICAocmluZy1yZXNpemUgcmluZyA1KQorICAgIChzaG91bGQgKD0gKHJp bmctc2l6ZSByaW5nKSA1KSkKKyAgICAoc2hvdWxkIChlcXVhbCAocmluZy1lbGVtZW50cyByaW5n KSAnKCkpKSkpCisKKyhlcnQtZGVmdGVzdCByaW5nLXRlc3QtcmluZy1yZXNpemUvZ3Jvdy13cmFw cGVkLXJpbmcgKCkKKyAgKGxldCAoKHJpbmcgKG1ha2UtcmluZyAzKSkpCisgICAgKHJpbmctaW5z ZXJ0IHJpbmcgMSkKKyAgICAocmluZy1pbnNlcnQgcmluZyAyKQorICAgIChyaW5nLWluc2VydCBy aW5nIDMpCisgICAgKHJpbmctaW5zZXJ0IHJpbmcgNCkKKyAgICAocmluZy1pbnNlcnQgcmluZyA1 KQorICAgIChyaW5nLXJlc2l6ZSByaW5nIDUpCisgICAgKHNob3VsZCAoPSAocmluZy1zaXplIHJp bmcpIDUpKQorICAgIChzaG91bGQgKGVxdWFsIChyaW5nLWVsZW1lbnRzIHJpbmcpICcoNSA0IDMp KSkpKQorCisoZXJ0LWRlZnRlc3QgcmluZy10ZXN0LXJpbmctcmVzaXplL3NocmluayAoKQorICAo bGV0ICgocmluZyAobWFrZS1yaW5nIDUpKSkKKyAgICAocmluZy1pbnNlcnQgcmluZyAxKQorICAg IChyaW5nLWluc2VydCByaW5nIDIpCisgICAgKHJpbmctaW5zZXJ0IHJpbmcgMykKKyAgICAocmlu Zy1pbnNlcnQgcmluZyA0KQorICAgIChyaW5nLWluc2VydCByaW5nIDUpCisgICAgKHJpbmctcmVz aXplIHJpbmcgMykKKyAgICAoc2hvdWxkICg9IChyaW5nLXNpemUgcmluZykgMykpCisgICAgKHNo b3VsZCAoZXF1YWwgKHJpbmctZWxlbWVudHMgcmluZykgJyg1IDQgMykpKSkpCisKIChlcnQtZGVm dGVzdCByaW5nLXRlc3RzLWluc2VydCAoKQogICAobGV0ICgocmluZyAobWFrZS1yaW5nIDIpKSkK ICAgICAocmluZy1pbnNlcnQrZXh0ZW5kIHJpbmcgOmEpCi0tIAoyLjE5LjEuNTY4LmcxNTJhZDhl MzM2LWdvb2cKCg== --00000000000073adb80579053b9c-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 27 05:57:54 2018 Received: (at 32849) by debbugs.gnu.org; 27 Oct 2018 09:57:54 +0000 Received: from localhost ([127.0.0.1]:44581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGLLt-0008Rf-Ra for submit@debbugs.gnu.org; Sat, 27 Oct 2018 05:57:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGLLs-0008RT-Ew for 32849@debbugs.gnu.org; Sat, 27 Oct 2018 05:57:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGLLk-0003o6-1L for 32849@debbugs.gnu.org; Sat, 27 Oct 2018 05:57:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGLLj-0003o0-T9; Sat, 27 Oct 2018 05:57:43 -0400 Received: from [176.228.60.248] (port=4084 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gGLLj-0002Et-Fs; Sat, 27 Oct 2018 05:57:43 -0400 Date: Sat, 27 Oct 2018 12:57:47 +0300 Message-Id: <837ei3ogo4.fsf@gnu.org> From: Eli Zaretskii To: Allen Li In-reply-to: (message from Allen Li on Wed, 24 Oct 2018 21:30:51 -0600) Subject: Re: bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter References: <831s9f8i1n.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32849 Cc: 32849@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Allen Li > Date: Wed, 24 Oct 2018 21:30:51 -0600 > Cc: 32849@debbugs.gnu.org > > Patches attached. Thanks. Please see a few minor comments below. > I wrote tests with names function-to-test/case-tested. I'm not sure > if this violates style policies for tests. It seems like existing > code tests multiple cases in a single test, but I find separate tests > easier to understand when they regress. The / makes the test names > easier to read. I don't see any problem with this, we don't have style policy that disallows such style, AFAIK. > I based this off of 26 (as I think this is a minor bugfix/feature add). Hmm... I think we should install this on master, not on emacs-26, as the problem is not serious enough. > +** xref > + > ++++ > +*** Setter added for 'xref-marker-ring-length'. This heading is not on the user level, it's on the implementation level. I'd suggest to use this instead: You can now change 'xref-marker-ring-length' after 'xref.el' is loaded. > +if set before `xref.el` was loaded. Please use quoting 'like this' in NEWS and in comments. > (defcustom xref-marker-ring-length 16 > - "Length of the xref marker ring." > - :type 'integer) > + "Length of the xref marker ring. > +If this variable is not set through Customize, you must call > +‘xref-set-marker-ring-length’ for changes to take effect." I guess you copy-pasted the last line from the *Help* buffer, or you have electric-quotes turned on, because it uses the wrong quote characters; in doc strings, please quote `like this' instead. > +(defun xref-set-marker-ring-length (var val) > + "Set ‘xref-marker-ring-length’. > +VAR is the symbol ‘xref-marker-ring-length’ and VAL is the new Same here. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 28 14:32:59 2018 Received: (at 32849) by debbugs.gnu.org; 28 Oct 2018 18:32:59 +0000 Received: from localhost ([127.0.0.1]:49311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGpru-0003Va-MB for submit@debbugs.gnu.org; Sun, 28 Oct 2018 14:32:58 -0400 Received: from mail-it1-f176.google.com ([209.85.166.176]:55591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGprs-0003VO-Ul for 32849@debbugs.gnu.org; Sun, 28 Oct 2018 14:32:57 -0400 Received: by mail-it1-f176.google.com with SMTP id e17so5360708itk.5 for <32849@debbugs.gnu.org>; Sun, 28 Oct 2018 11:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=v3lArcMvK3D1SCuH0wdqYDM4ezhahbjo85L5TBSzetw=; b=NGThqZt7ehwH2cXduL4vbFQ1yNWTHWnzGKnO4mUfWibIQUL9hluuJ2XfceoELzdD8R NrvIGuTUQhCr58qu1nLiBU8Ak3gRg7YzvKPnJof3soiDyrIUymMOY4odw5Kg6BAh0zFA L9lpQVLpLI8KO1qZ+AFOZ4JnH55AVhgqEI2roGJ3yFuBaXV0pUd8okM50i80/EYX4i6p jOUah7cyUvzp2xWPgg7wX2DOdrbNsvFgD6oQZBlKto+LcVnAReNxgEK38qdwFt3RK8v6 vMK9HoY8LdJCPXuoPiieN0cbwZWnxyNLT8Ot8AU2jVHqOCQsWknABYzAL6h1Yr1aS6z9 D5Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=v3lArcMvK3D1SCuH0wdqYDM4ezhahbjo85L5TBSzetw=; b=iR1Na/ZrG8zOja2i7xlVjA5DLYISE2Cuqo6y5ikRR/IwJiGOQGBBqF+YqvuxaCdtLZ uFKiVdsK8iJCb6gKVDZIOIsk5Vz5ma2tvT3pk8dYgPEBiK2jjIlQ1pnG4F4IcQtMsVG9 AwL3eZRgJlThob8DdYT6eNa7Z0ynaoS085zyaPRfFKAKxpinOopnTBnMD2ZQ6R+15KW6 fNUwXw/0PqZ86Q3euJp929vjW+6spMmWGC2Ep79Cp5NFQgOc8NXr3osGk14yOoMf5NG1 F1L04gKFsXQprXguV7lesxPQjpYy3oLaZlyxaTOMg2pJ1/sapLTOBuUTOJOl6kMZnG5z DgCw== X-Gm-Message-State: AGRZ1gJGA3MBMrNhfJed+g1mII0UKpeHBQ5Hxiyn47jTell3EixhNnSj uOFUSfrLrSnJ+H92xAEiqYqc9MVI X-Google-Smtp-Source: AJdET5dHfyDZmrIpdMpZRzhs0oshCjw8V9AMGdJnaDM8ZuSzJHFK8hcvXV+Rszrv7fobSO25V3Agug== X-Received: by 2002:a24:45d6:: with SMTP id c83-v6mr1885056itd.85.1540751571181; Sun, 28 Oct 2018 11:32:51 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o134-v6sm6123702iod.17.2018.10.28.11.32.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Oct 2018 11:32:50 -0700 (PDT) From: Noam Postavsky To: Allen Li Subject: Re: bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter References: <831s9f8i1n.fsf@gnu.org> Date: Sun, 28 Oct 2018 14:32:49 -0400 In-Reply-To: (Allen Li's message of "Wed, 24 Oct 2018 21:30:51 -0600") Message-ID: <874ld5kjla.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32849 Cc: eliz@gnu.org, 32849@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Allen Li writes: > I wrote tests with names function-to-test/case-tested. I'm not sure > if this violates style policies for tests. It seems like existing > code tests multiple cases in a single test, but I find separate tests > easier to understand when they regress. The / makes the test names > easier to read. > +(ert-deftest ring-test-ring-resize/grow () Like Eli mentioned, there is no policy for this, but I'd say the ring-test- prefix is redundant for test names, ring-resize/grow already has the prefix ring- to avoid nameclashes with other tests (and test namespace is separate from function namespace). From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 28 19:22:54 2018 Received: (at control) by debbugs.gnu.org; 28 Oct 2018 23:22:54 +0000 Received: from localhost ([127.0.0.1]:49460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGuOU-0001kE-4a for submit@debbugs.gnu.org; Sun, 28 Oct 2018 19:22:54 -0400 Received: from mail-it1-f172.google.com ([209.85.166.172]:56111) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGuOS-0001k1-Ls for control@debbugs.gnu.org; Sun, 28 Oct 2018 19:22:52 -0400 Received: by mail-it1-f172.google.com with SMTP id e17so5811204itk.5 for ; Sun, 28 Oct 2018 16:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=tb8gs71N3YUjdmf4pTSHW9Sazw6IAHPnzhZu6dY7CqI=; b=cxp1OUHu39lYWPb8/H9sboAQiHGsOo5qiish5vtBkwn4CAgeMvuT/4ypLtiMkkM9Vv 1wTOcTccqmcw2QlwHx7r3HJhO+LJF32cG4cD3HuTJbKYsLnq++kjnsoK/+LYaU9F/ifC w1wKUqqYFwn+71Pq8Q5UAnbNPoEjejPEPDy0oJ66MeLyX3dwsPeVsublTI/akyNnY0ho 8Ya2xcg7aPNAaNs7fCe19/Jc2hJguL1tjE0UE1FJiKaC2i4TMyd814Gg4nJIWltHkSM5 B240cu7RR2Uos/aK5EteSsVE0H5FQ9cJwqxDVq4NHzUoU84dqMgmOyMBuzLk4T+5CVeM sAZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=tb8gs71N3YUjdmf4pTSHW9Sazw6IAHPnzhZu6dY7CqI=; b=S1u+ucMIPvZEHeJ+2FgQr3IGX/m3ocBRAM13QF3zgrmFDwJ7NBq+/NsnG16v8MiN3Y ASEIhdfhO68HrjohLPd4+QsGHBbLg1QiuB8W+BKMaA8bUkdjIW5sWErwUbKxgiTOYZAB HpafPBabx4I82lKszyjTuoa37sqY1ldF9sr+2Yyux91vYVezaNDks/0pEyS7F3/bCz8Q 7d0fbj/FKkBvnJ44hGbeNn5n+Hu6xS48uphn9tvTQi4h6AzfxamP3sTSQFYUuIryABIy pQ4H9bpgyhyq9TnqVGriG9UTFlIPtG8yE7FMoTZz8eueZXMvtm9UYRw3oHmPXXdt6Xvh YeDw== X-Gm-Message-State: AGRZ1gLXyeis8u999LyrhKY88mSfqbBnlsPxmMATa5X32Iz72tJ+EiHE py0hvN7Q4+eS9alXoh7/PSvw8txx X-Google-Smtp-Source: AJdET5eLf4hjsp/qht9n6xGpxN+b3/8B0aT8JvaVrYA5TR739Yr/WZHtO7Y3nebNZIjeg+z/akrr8Q== X-Received: by 2002:a24:2f41:: with SMTP id j62-v6mr8200785itj.80.1540768966793; Sun, 28 Oct 2018 16:22:46 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z128-v6sm5061186itc.21.2018.10.28.16.22.45 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Oct 2018 16:22:46 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #32849 Date: Sun, 28 Oct 2018 19:22:45 -0400 Message-ID: <8736spk662.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 32849 minor quit From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 09 02:01:41 2018 Received: (at 32849) by debbugs.gnu.org; 9 Nov 2018 07:01:41 +0000 Received: from localhost ([127.0.0.1]:42146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL0nU-00060e-Hm for submit@debbugs.gnu.org; Fri, 09 Nov 2018 02:01:40 -0500 Received: from mail-io1-f51.google.com ([209.85.166.51]:37563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gL0nS-00060Q-9i for 32849@debbugs.gnu.org; Fri, 09 Nov 2018 02:01:38 -0500 Received: by mail-io1-f51.google.com with SMTP id k17-v6so595606ioc.4 for <32849@debbugs.gnu.org>; Thu, 08 Nov 2018 23:01:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BF1eRGUuynoeg6U8gpRUPqM6M1bGL+4mB/3fHTqWiOM=; b=CK5VfVFvbyDtX8k+QL6FBpP7xdYgDyverOlAokfYI/4d1swJn1rrnFIfRs4jaJkFlr 7grcSTgXUwmDcRdpr75RixXm8C251qeWde8U7dX1wKunoIF9nP3KhFR2A6m9S13Q7Xz7 73/TwFDpvN5Io1eT8tOerCQXo6El4MuhkTfFGucwaAPvd7xP2rpJgPcEI0A/RTCX1U0u QzRehFHhcFwvoUTCVW9/Nxsfc3MRvPjz5MJibjxbeLLSTNasy6vq9jy0WBRbtqByGN/5 XFx0DiOup2FotnzVrdaXfpSQBZogYsC7uUmyce7pVakiDf8stPPlTCoTPG/MqkWDIsDx hfBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BF1eRGUuynoeg6U8gpRUPqM6M1bGL+4mB/3fHTqWiOM=; b=op8rE9CkbVW2RCa7ytLj1uf5CiCPtgwbOS9MoYgo8pN1jXpuX87gQ/t8s5fNsCD4nb KZp8kxwb4OCMnO9KVw/9wtBd6QunUSA4pN8vfzs3Yd0XDhMAvqp0eKdIlWUfW/Ly2DoZ iTDM3mNre4lW8bMeZs6KivbYEUf3pFRriQ8NxCNcq0YHtyJNqQU/HRxP6XzSUvbuTNub GF9LRTO0hzduDQgCA6l51+nzjUcap/lyzlh4u3RPSUjSUodzyV6k7aeB/z0UsTBHPknq TP3zFrOkiNVWVVvWqxF2gwO/pqyCPwAq+0bxCYElrjohckx+UqcUfa1q9n+v5aA1ZOvA Kmsg== X-Gm-Message-State: AGRZ1gJ2O5vVL8uFbDRJ0dfj/GLfAo+fczKHpubsI1g+hxTFTCOiATrH PIEcEU4LxNwxfPcUY4ulpaqHSugfdN2J/TvYnLXlKw== X-Google-Smtp-Source: AJdET5fkumPm3oEFK0VqwQuiFRwDbrZjv+eVgrMqi0B5Zg8LLc8A6G0ftioHapWV2uo6HX7f3UxRliNkfRbax7Jk1dE= X-Received: by 2002:a6b:8c43:: with SMTP id o64-v6mr6345944iod.217.1541746892421; Thu, 08 Nov 2018 23:01:32 -0800 (PST) MIME-Version: 1.0 References: <831s9f8i1n.fsf@gnu.org> <837ei3ogo4.fsf@gnu.org> In-Reply-To: <837ei3ogo4.fsf@gnu.org> From: Allen Li Date: Thu, 8 Nov 2018 23:01:21 -0800 Message-ID: Subject: Re: bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter To: eliz@gnu.org Content-Type: multipart/mixed; boundary="000000000000db920e057a35eb0b" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 32849 Cc: 32849@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000db920e057a35eb0b Content-Type: text/plain; charset="UTF-8" On Sat, Oct 27, 2018 at 2:57 AM Eli Zaretskii wrote: > Thanks. Please see a few minor comments below. Thanks for your comments. I have attached new patches based off master. --000000000000db920e057a35eb0b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-ring-resize-function.patch" Content-Disposition: attachment; filename="0001-Add-ring-resize-function.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jo9o9cs50 RnJvbSA3M2YxOTgxNmU1ODdhZDEyMTRmOTFmMmY4ODgwZGE0YWU0OTViMmVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBXZWQsIDI0IE9jdCAyMDE4IDIwOjQ0OjAxIC0wNjAwClN1YmplY3Q6IFtQQVRDSCAxLzJd IEFkZCByaW5nLXJlc2l6ZSBmdW5jdGlvbgoKKiBkb2MvbGlzcHJlZi9zZXF1ZW5jZXMudGV4aSAo UmluZ3MpOiBEb2N1bWVudCBuZXcgZnVuY3Rpb24KKiBldGMvTkVXUzogRG9jdW1lbnQgbmV3IGZ1 bmN0aW9uCiogbGlzcC9lbWFjcy1saXNwL3JpbmcuZWwgKHJpbmctcmVzaXplKTogTmV3IGZ1bmN0 aW9uCiogdGVzdC9saXNwL2VtYWNzLWxpc3AvcmluZy10ZXN0cy5lbCAocmluZy10ZXN0LXJpbmct cmVzaXplKTogTmV3IHRlc3RzCi0tLQogZG9jL2xpc3ByZWYvc2VxdWVuY2VzLnRleGkgICAgICAg ICB8ICA1ICsrKysKIGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgNCArKysr CiBsaXNwL2VtYWNzLWxpc3AvcmluZy5lbCAgICAgICAgICAgIHwgMzMgKysrKysrKysrKysrKysr KystLS0tLS0tLS0KIHRlc3QvbGlzcC9lbWFjcy1saXNwL3JpbmctdGVzdHMuZWwgfCAzNyArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgNjggaW5zZXJ0aW9u cygrKSwgMTEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvc2VxdWVuY2Vz LnRleGkgYi9kb2MvbGlzcHJlZi9zZXF1ZW5jZXMudGV4aQppbmRleCA1NTQ3MTYwODRlLi45NTVh ZDY2OWI4IDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9zZXF1ZW5jZXMudGV4aQorKysgYi9kb2Mv bGlzcHJlZi9zZXF1ZW5jZXMudGV4aQpAQCAtMTc3Nyw2ICsxNzc3LDExIEBAIFJpbmdzCiByb29t IGZvciB0aGUgaW5zZXJ0ZWQgZWxlbWVudC4KIEBlbmQgZGVmdW4KIAorQGRlZnVuIHJpbmctcmVz aXplIHJpbmcgc2l6ZQorU2V0IHRoZSBzaXplIG9mIEB2YXJ7cmluZ30gdG8gQHZhcntzaXplfS4g IElmIHRoZSBuZXcgc2l6ZSBpcyBzbWFsbGVyLAordGhlbiB0aGUgb2xkZXN0IGl0ZW1zIGluIHRo ZSByaW5nIGFyZSBkaXNjYXJkZWQuCitAZW5kIGRlZnVuCisKIEBjaW5kZXggZmlmbyBkYXRhIHN0 cnVjdHVyZQogICBJZiB5b3UgYXJlIGNhcmVmdWwgbm90IHRvIGV4Y2VlZCB0aGUgcmluZyBzaXpl LCB5b3UgY2FuCiB1c2UgdGhlIHJpbmcgYXMgYSBmaXJzdC1pbi1maXJzdC1vdXQgcXVldWUuICBG b3IgZXhhbXBsZToKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggMjliYmRl OTM5NS4uYzM5MzAzZGJjMCAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAg LTEyMTgsNiArMTIxOCwxMCBAQCB0byBtZWFuIHRoYXQgaXQgaXMgbm90IGtub3duIHdoZXRoZXIg RFNUIGlzIGluIGVmZmVjdC4KICdqc29uLWluc2VydCcsICdqc29uLXBhcnNlLXN0cmluZycsIGFu ZCAnanNvbi1wYXJzZS1idWZmZXInLiAgVGhlc2UKIGFyZSBpbXBsZW1lbnRlZCBpbiBDIHVzaW5n IHRoZSBKYW5zc29uIGxpYnJhcnkuCiAKKysrKworKiogTmV3IGZ1bmN0aW9uICdyaW5nLXJlc2l6 ZScuCisncmluZy1yZXNpemUnIGNhbiBiZSB1c2VkIHRvIGdyb3cgb3Igc2hyaW5rIGEgcmluZy4K KwogKiogTWFpbGNhcAogCiAtLS0KZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9yaW5nLmVs IGIvbGlzcC9lbWFjcy1saXNwL3JpbmcuZWwKaW5kZXggMzEyZGY2YjJkZS4uMWIzNjgxMWY5ZSAx MDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL3JpbmcuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNw L3JpbmcuZWwKQEAgLTE4OSwxNyArMTg5LDI4IEBAIHJpbmctcHJldmlvdXMKIChkZWZ1biByaW5n LWV4dGVuZCAocmluZyB4KQogICAiSW5jcmVhc2UgdGhlIHNpemUgb2YgUklORyBieSBYLiIKICAg KHdoZW4gKGFuZCAoaW50ZWdlcnAgeCkgKD4geCAwKSkKLSAgICAobGV0KiAoKGhkICAgICAgIChj YXIgcmluZykpCi0JICAgKGxlbmd0aCAgIChyaW5nLWxlbmd0aCByaW5nKSkKLQkgICAoc2l6ZSAg ICAgKHJpbmctc2l6ZSByaW5nKSkKLQkgICAob2xkLXZlYyAgKGNkZHIgcmluZykpCi0JICAgKG5l dy12ZWMgIChtYWtlLXZlY3RvciAoKyBzaXplIHgpIG5pbCkpKQotICAgICAgKHNldGNkciByaW5n IChjb25zIGxlbmd0aCBuZXctdmVjKSkKLSAgICAgIDs7IElmIHRoZSByaW5nIGlzIHdyYXBwZWQs IHRoZSBleGlzdGluZyBlbGVtZW50cyBtdXN0IGJlIHdyaXR0ZW4KLSAgICAgIDs7IG91dCBpbiB0 aGUgcmlnaHQgb3JkZXIuCi0gICAgICAoZG90aW1lcyAoaiBsZW5ndGgpCi0JKGFzZXQgbmV3LXZl YyBqIChhcmVmIG9sZC12ZWMgKG1vZCAoKyBoZCBqKSBzaXplKSkpKQotICAgICAgKHNldGNhciBy aW5nIDApKSkpCisgICAgKHJpbmctcmVzaXplIHJpbmcgKCsgeCAocmluZy1zaXplIHJpbmcpKSkp KQorCisoZGVmdW4gcmluZy1yZXNpemUgKHJpbmcgc2l6ZSkKKyAgIlNldCB0aGUgc2l6ZSBvZiBS SU5HIHRvIFNJWkUuCitJZiB0aGUgbmV3IHNpemUgaXMgc21hbGxlciwgdGhlbiB0aGUgb2xkZXN0 IGl0ZW1zIGluIHRoZSByaW5nIGFyZQorZGlzY2FyZGVkLiIKKyAgKHdoZW4gKGludGVnZXJwIHNp emUpCisgICAgKGxldCAoKGxlbmd0aCAocmluZy1sZW5ndGggcmluZykpCisJICAobmV3LXZlYyAo bWFrZS12ZWN0b3Igc2l6ZSBuaWwpKSkKKyAgICAgIChpZiAoPSBsZW5ndGggMCkKKyAgICAgICAg ICAoc2V0Y2RyIHJpbmcgKGNvbnMgMCBuZXctdmVjKSkKKyAgICAgICAgKGxldCogKChoZCAoY2Fy IHJpbmcpKQorCSAgICAgICAob2xkLXNpemUgKHJpbmctc2l6ZSByaW5nKSkKKwkgICAgICAgKG9s ZC12ZWMgKGNkZHIgcmluZykpCisgICAgICAgICAgICAgICAoY29weS1sZW5ndGggKG1pbiBzaXpl IGxlbmd0aCkpCisgICAgICAgICAgICAgICAoY29weS1oZCAobW9kICgrIGhkICgtIGxlbmd0aCBj b3B5LWxlbmd0aCkpIGxlbmd0aCkpKQorICAgICAgICAgIChzZXRjZHIgcmluZyAoY29ucyBjb3B5 LWxlbmd0aCBuZXctdmVjKSkKKyAgICAgICAgICA7OyBJZiB0aGUgcmluZyBpcyB3cmFwcGVkLCB0 aGUgZXhpc3RpbmcgZWxlbWVudHMgbXVzdCBiZSB3cml0dGVuCisgICAgICAgICAgOzsgb3V0IGlu IHRoZSByaWdodCBvcmRlci4KKyAgICAgICAgICAoZG90aW1lcyAoaiBjb3B5LWxlbmd0aCkKKwkg ICAgKGFzZXQgbmV3LXZlYyBqIChhcmVmIG9sZC12ZWMgKG1vZCAoKyBjb3B5LWhkIGopIG9sZC1z aXplKSkpKQorICAgICAgICAgIChzZXRjYXIgcmluZyAwKSkpKSkpCiAKIChkZWZ1biByaW5nLWlu c2VydCtleHRlbmQgKHJpbmcgaXRlbSAmb3B0aW9uYWwgZ3Jvdy1wKQogICAiTGlrZSBgcmluZy1p bnNlcnQnLCBidXQgaWYgR1JPVy1QIGlzIG5vbi1uaWwsIHRoZW4gZW5sYXJnZSByaW5nLgpkaWZm IC0tZ2l0IGEvdGVzdC9saXNwL2VtYWNzLWxpc3AvcmluZy10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9l bWFjcy1saXNwL3JpbmctdGVzdHMuZWwKaW5kZXggMGI0ZTNkOWE2OS4uOWZhMzZhYTNkMyAxMDA2 NDQKLS0tIGEvdGVzdC9saXNwL2VtYWNzLWxpc3AvcmluZy10ZXN0cy5lbAorKysgYi90ZXN0L2xp c3AvZW1hY3MtbGlzcC9yaW5nLXRlc3RzLmVsCkBAIC0xNjIsNiArMTYyLDQzIEBACiAgICAgKHNo b3VsZCAoPSAocmluZy1zaXplIHJpbmcpIDUpKQogICAgIChzaG91bGQgKGVxdWFsIChyaW5nLWVs ZW1lbnRzIHJpbmcpICcoMyAyIDEpKSkpKQogCisoZXJ0LWRlZnRlc3QgcmluZy1yZXNpemUvZ3Jv dyAoKQorICAobGV0ICgocmluZyAobWFrZS1yaW5nIDMpKSkKKyAgICAocmluZy1pbnNlcnQgcmlu ZyAxKQorICAgIChyaW5nLWluc2VydCByaW5nIDIpCisgICAgKHJpbmctaW5zZXJ0IHJpbmcgMykK KyAgICAocmluZy1yZXNpemUgcmluZyA1KQorICAgIChzaG91bGQgKD0gKHJpbmctc2l6ZSByaW5n KSA1KSkKKyAgICAoc2hvdWxkIChlcXVhbCAocmluZy1lbGVtZW50cyByaW5nKSAnKDMgMiAxKSkp KSkKKworKGVydC1kZWZ0ZXN0IHJpbmctcmVzaXplL2dyb3ctZW1wdHkgKCkKKyAgKGxldCAoKHJp bmcgKG1ha2UtcmluZyAzKSkpCisgICAgKHJpbmctcmVzaXplIHJpbmcgNSkKKyAgICAoc2hvdWxk ICg9IChyaW5nLXNpemUgcmluZykgNSkpCisgICAgKHNob3VsZCAoZXF1YWwgKHJpbmctZWxlbWVu dHMgcmluZykgJygpKSkpKQorCisoZXJ0LWRlZnRlc3QgcmluZy1yZXNpemUvZ3Jvdy13cmFwcGVk LXJpbmcgKCkKKyAgKGxldCAoKHJpbmcgKG1ha2UtcmluZyAzKSkpCisgICAgKHJpbmctaW5zZXJ0 IHJpbmcgMSkKKyAgICAocmluZy1pbnNlcnQgcmluZyAyKQorICAgIChyaW5nLWluc2VydCByaW5n IDMpCisgICAgKHJpbmctaW5zZXJ0IHJpbmcgNCkKKyAgICAocmluZy1pbnNlcnQgcmluZyA1KQor ICAgIChyaW5nLXJlc2l6ZSByaW5nIDUpCisgICAgKHNob3VsZCAoPSAocmluZy1zaXplIHJpbmcp IDUpKQorICAgIChzaG91bGQgKGVxdWFsIChyaW5nLWVsZW1lbnRzIHJpbmcpICcoNSA0IDMpKSkp KQorCisoZXJ0LWRlZnRlc3QgcmluZy1yZXNpemUvc2hyaW5rICgpCisgIChsZXQgKChyaW5nICht YWtlLXJpbmcgNSkpKQorICAgIChyaW5nLWluc2VydCByaW5nIDEpCisgICAgKHJpbmctaW5zZXJ0 IHJpbmcgMikKKyAgICAocmluZy1pbnNlcnQgcmluZyAzKQorICAgIChyaW5nLWluc2VydCByaW5n IDQpCisgICAgKHJpbmctaW5zZXJ0IHJpbmcgNSkKKyAgICAocmluZy1yZXNpemUgcmluZyAzKQor ICAgIChzaG91bGQgKD0gKHJpbmctc2l6ZSByaW5nKSAzKSkKKyAgICAoc2hvdWxkIChlcXVhbCAo cmluZy1lbGVtZW50cyByaW5nKSAnKDUgNCAzKSkpKSkKKwogKGVydC1kZWZ0ZXN0IHJpbmctdGVz dHMtaW5zZXJ0ICgpCiAgIChsZXQgKChyaW5nIChtYWtlLXJpbmcgMikpKQogICAgIChyaW5nLWlu c2VydCtleHRlbmQgcmluZyA6YSkKLS0gCjIuMTkuMQoK --000000000000db920e057a35eb0b Content-Type: text/x-patch; charset="US-ASCII"; name="0002-Add-setter-for-xref-marker-ring-length.patch" Content-Disposition: attachment; filename="0002-Add-setter-for-xref-marker-ring-length.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jo9o9ct31 RnJvbSA2NDNkY2YyYTc2MmIzNDA3ODEzNWViNGM2NmEyMTA4ZjJjNjRkZmFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBXZWQsIDI0IE9jdCAyMDE4IDIwOjQ4OjE1IC0wNjAwClN1YmplY3Q6IFtQQVRDSCAyLzJd IEFkZCBzZXR0ZXIgZm9yIHhyZWYtbWFya2VyLXJpbmctbGVuZ3RoCgoqIGV0Yy9ORVdTOiBEb2N1 bWVudCBjaGFuZ2UKKiBsaXNwL3Byb2dtb2Rlcy94cmVmLmVsICh4cmVmLW1hcmtlci1yaW5nLWxl bmd0aCk6IEFkZCBzZXR0ZXIKLS0tCiBldGMvTkVXUyAgICAgICAgICAgICAgIHwgIDUgKysrKysK IGxpc3AvcHJvZ21vZGVzL3hyZWYuZWwgfCAxNiArKysrKysrKysrKysrKy0tCiAyIGZpbGVzIGNo YW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZXRj L05FV1MgYi9ldGMvTkVXUwppbmRleCBjMzkzMDNkYmMwLi4yMDNkODllZTA3IDEwMDY0NAotLS0g YS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtNDYwLDYgKzQ2MCwxMSBAQCBmb3IgZXhhbXBs ZS4KIFRoaXMgY29tbWFuZCBmaW5kcyBkZWZpbml0aW9ucyBvZiB0aGUgaWRlbnRpZmllciBhdCB0 aGUgcGxhY2Ugb2YgYQogbW91c2UgY2xpY2sgZXZlbnQsIGFuZCBpcyBpbnRlbmRlZCB0byBiZSBi b3VuZCB0byBhIG1vdXNlIGV2ZW50LgogCisrKysKKyoqKiBDaGFuZ2luZyAneHJlZi1tYXJrZXIt cmluZy1sZW5ndGgnIHdvcmtzIGFmdGVyICd4cmVmLmVsJyBpcyBsb2FkZWQuCitQcmV2aW91c2x5 LCBzZXR0aW5nICd4cmVmLW1hcmtlci1yaW5nLWxlbmd0aCcgd291bGQgb25seSB0YWtlIGVmZmVj dAoraWYgc2V0IGJlZm9yZSAneHJlZi5lbCcgd2FzIGxvYWRlZC4KKwogKiogRWNvbXBsZXRlCiAK ICoqKiBUaGUgZWNvbXBsZXRlIHNvcnRpbmcgaGFzIGNoYW5nZWQgdG8gYSBkZWNheS1iYXNlZCBh bGdvcml0aG0uCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy94cmVmLmVsIGIvbGlzcC9wcm9n bW9kZXMveHJlZi5lbAppbmRleCA2YjE0MjFhNmY3Li4zYjQ0OWJmOWIxIDEwMDY0NAotLS0gYS9s aXNwL3Byb2dtb2Rlcy94cmVmLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3hyZWYuZWwKQEAgLTMx Nyw4ICszMTcsMTIgQEAgeHJlZi0tc2VhcmNoLXByb3BlcnR5CiA7OzsgTWFya2VyIHN0YWNrICAo TS0uIHB1c2hlcywgTS0sIHBvcHMpCiAKIChkZWZjdXN0b20geHJlZi1tYXJrZXItcmluZy1sZW5n dGggMTYKLSAgIkxlbmd0aCBvZiB0aGUgeHJlZiBtYXJrZXIgcmluZy4iCi0gIDp0eXBlICdpbnRl Z2VyKQorICAiTGVuZ3RoIG9mIHRoZSB4cmVmIG1hcmtlciByaW5nLgorSWYgdGhpcyB2YXJpYWJs ZSBpcyBub3Qgc2V0IHRocm91Z2ggQ3VzdG9taXplLCB5b3UgbXVzdCBjYWxsCitgeHJlZi1zZXQt bWFya2VyLXJpbmctbGVuZ3RoJyBmb3IgY2hhbmdlcyB0byB0YWtlIGVmZmVjdC4iCisgIDp0eXBl ICdpbnRlZ2VyCisgIDppbml0aWFsaXplICMnY3VzdG9tLWluaXRpYWxpemUtZGVmYXVsdAorICA6 c2V0ICMneHJlZi1zZXQtbWFya2VyLXJpbmctbGVuZ3RoKQogCiAoZGVmY3VzdG9tIHhyZWYtcHJv bXB0LWZvci1pZGVudGlmaWVyICcobm90IHhyZWYtZmluZC1kZWZpbml0aW9ucwogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB4cmVmLWZpbmQtZGVmaW5pdGlvbnMt b3RoZXItd2luZG93CkBAIC0zNTQsNiArMzU4LDE0IEBAIHhyZWYtYWZ0ZXItcmV0dXJuLWhvb2sK IChkZWZ2YXIgeHJlZi0tbWFya2VyLXJpbmcgKG1ha2UtcmluZyB4cmVmLW1hcmtlci1yaW5nLWxl bmd0aCkKICAgIlJpbmcgb2YgbWFya2VycyB0byBpbXBsZW1lbnQgdGhlIG1hcmtlciBzdGFjay4i KQogCisoZGVmdW4geHJlZi1zZXQtbWFya2VyLXJpbmctbGVuZ3RoICh2YXIgdmFsKQorICAiU2V0 IGB4cmVmLW1hcmtlci1yaW5nLWxlbmd0aCcuCitWQVIgaXMgdGhlIHN5bWJvbCBgeHJlZi1tYXJr ZXItcmluZy1sZW5ndGgnIGFuZCBWQUwgaXMgdGhlIG5ldwordmFsdWUuIgorICAoc2V0LWRlZmF1 bHQgdmFyIHZhbCkKKyAgKGlmIChyaW5nLXAgeHJlZi0tbWFya2VyLXJpbmcpCisgICAgICAocmlu Zy1yZXNpemUgeHJlZi0tbWFya2VyLXJpbmcgdmFsKSkpCisKIChkZWZ1biB4cmVmLXB1c2gtbWFy a2VyLXN0YWNrICgmb3B0aW9uYWwgbSkKICAgIkFkZCBwb2ludCBNIChkZWZhdWx0cyB0byBgcG9p bnQtbWFya2VyJykgdG8gdGhlIG1hcmtlciBzdGFjay4iCiAgIChyaW5nLWluc2VydCB4cmVmLS1t YXJrZXItcmluZyAob3IgbSAocG9pbnQtbWFya2VyKSkpKQotLSAKMi4xOS4xCgo= --000000000000db920e057a35eb0b-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 10 04:47:56 2018 Received: (at 32849-done) by debbugs.gnu.org; 10 Nov 2018 09:47:56 +0000 Received: from localhost ([127.0.0.1]:44170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLPrw-0006AW-2D for submit@debbugs.gnu.org; Sat, 10 Nov 2018 04:47:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLPru-0006AI-R6 for 32849-done@debbugs.gnu.org; Sat, 10 Nov 2018 04:47:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLPrm-0003Ae-R0 for 32849-done@debbugs.gnu.org; Sat, 10 Nov 2018 04:47:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLPrh-00037L-Tz; Sat, 10 Nov 2018 04:47:43 -0500 Received: from [176.228.60.248] (port=2165 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gLPrh-0002Lu-GR; Sat, 10 Nov 2018 04:47:41 -0500 Date: Sat, 10 Nov 2018 11:47:29 +0200 Message-Id: <835zx5b6xa.fsf@gnu.org> From: Eli Zaretskii To: Allen Li In-reply-to: (message from Allen Li on Thu, 8 Nov 2018 23:01:21 -0800) Subject: Re: bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter References: <831s9f8i1n.fsf@gnu.org> <837ei3ogo4.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32849-done Cc: 32849-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Allen Li > Date: Thu, 8 Nov 2018 23:01:21 -0800 > Cc: 32849@debbugs.gnu.org > > On Sat, Oct 27, 2018 at 2:57 AM Eli Zaretskii wrote: > > Thanks. Please see a few minor comments below. > > Thanks for your comments. I have attached new patches based off master. Thanks, I pushed this to the master branch. One nit: > * doc/lispref/sequences.texi (Rings): Document new function > * etc/NEWS: Document new function > * lisp/emacs-lisp/ring.el (ring-resize): New function > * test/lisp/emacs-lisp/ring-tests.el (ring-test-ring-resize): New tests Please end each entry in the commit log with a period, as it's supposed to be one or more complete sentences. From unknown Thu Aug 14 22:20:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 08 Dec 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator