From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 25 15:37:12 2018 Received: (at submit) by debbugs.gnu.org; 25 Sep 2018 19:37:12 +0000 Received: from localhost ([127.0.0.1]:54034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4t8y-0000qB-3K for submit@debbugs.gnu.org; Tue, 25 Sep 2018 15:37:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4t8w-0000pe-9X for submit@debbugs.gnu.org; Tue, 25 Sep 2018 15:37:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4t8q-0005cF-2i for submit@debbugs.gnu.org; Tue, 25 Sep 2018 15:37:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g4t8p-0005be-FQ for submit@debbugs.gnu.org; Tue, 25 Sep 2018 15:37:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4t8o-0006U5-85 for bug-gnu-emacs@gnu.org; Tue, 25 Sep 2018 15:37:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4t8m-0005Z9-Qv for bug-gnu-emacs@gnu.org; Tue, 25 Sep 2018 15:37:01 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:46588 helo=pdx1-sub0-mail-a31.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g4t8m-0005Y8-Im for bug-gnu-emacs@gnu.org; Tue, 25 Sep 2018 15:37:00 -0400 Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id 5948A7F37D for ; Tue, 25 Sep 2018 12:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=HnE9I/m2O9erl0BZQKTw9wsr0Bc=; b=fLOzO0fuPS9ol00uO lnLiOK9rXaaf8nTPFqDy1iBoWb5rohp/7a0n/abgIQ5Sg4Z/hThr+NVCdsLR+Lvf VqKuzb0taR/4Jc/RU3XhNauIY5syQzJSEtsTkujFhvtnRiOa9iyeSLz+nNdCMXj9 8c2cxPm3mL/Qv9Zlfh7nr0MD+o= Received: from localhost.linkov.net (m91-129-111-128.cust.tele2.ee [91.129.111.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id 9F4657F32E for ; Tue, 25 Sep 2018 12:36:58 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a31 X-DH-BACKEND: pdx1-sub0-mail-a31 From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 27.0.50; recenter doesn't redisplay Organization: LINKOV.NET Date: Tue, 25 Sep 2018 22:11:59 +0300 Message-ID: <8736txjvkg.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) As noted in bug#32672, maybe this is a regression, possibly caused by bug#31325 0. emacs -Q 1. Eval: (setq recenter-redisplay t) (add-to-list 'window-scroll-functions (lambda (window display-start) (message "window-scroll-functions %S %S %S" window (window-buffer window) display-start))) 2. Open *Messages* in adjacent window with 'C-h e' 3. Put point in *scratch* preferably not on the first line 4. Type 'C-l' (recenter-top-bottom) with different arguments, e.g. C-0 C-l C-1 C-l C-2 C-l etc. The *Messages* buffer is not refreshed to show new logged messages from the calls of the window-scroll-functions. This means that C-l (recenter-top-bottom) doesn't redisplay the frame - which is strange since it calls 'recenter' with non-nil arg REDISPLAY. Only after switching to the *Messages* buffer with 'C-x o' it gets redisplayed and all previously emitted messages appear in it. 5. Typein *scratch* again: C-l C-l C-l only when C-l puts point to the center of the window, the *Messages* buffer gets redisplayed (but then for some reason window-scroll-functions is not called in this case). From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 25 16:08:26 2018 Received: (at 32839) by debbugs.gnu.org; 25 Sep 2018 20:08:27 +0000 Received: from localhost ([127.0.0.1]:54086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4tdC-0001h7-NY for submit@debbugs.gnu.org; Tue, 25 Sep 2018 16:08:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4td9-0001gr-UZ for 32839@debbugs.gnu.org; Tue, 25 Sep 2018 16:08:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4td0-0004Ly-Ds for 32839@debbugs.gnu.org; Tue, 25 Sep 2018 16:08:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4td0-0004Ls-9y; Tue, 25 Sep 2018 16:08:14 -0400 Received: from [176.228.60.248] (port=3538 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g4tcy-0002Wd-PG; Tue, 25 Sep 2018 16:08:14 -0400 Date: Tue, 25 Sep 2018 23:08:04 +0300 Message-Id: <83lg7p8hnf.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <8736txjvkg.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 25 Sep 2018 22:11:59 +0300) Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay References: <8736txjvkg.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Juri Linkov > Date: Tue, 25 Sep 2018 22:11:59 +0300 > > 1. Eval: > > (setq recenter-redisplay t) > > (add-to-list 'window-scroll-functions > (lambda (window display-start) > (message "window-scroll-functions %S %S %S" > window (window-buffer window) display-start))) > > 2. Open *Messages* in adjacent window with 'C-h e' > > 3. Put point in *scratch* preferably not on the first line > > 4. Type 'C-l' (recenter-top-bottom) with different arguments, e.g. > C-0 C-l > C-1 C-l > C-2 C-l > etc. > > The *Messages* buffer is not refreshed to show new logged messages > from the calls of the window-scroll-functions. > > This means that C-l (recenter-top-bottom) doesn't redisplay the frame - > which is strange since it calls 'recenter' with non-nil arg REDISPLAY. 'recenter' doesn't redisplay the frame, it only redisplays the window which you recenter. > 5. Typein *scratch* again: C-l C-l C-l > only when C-l puts point to the center of the window, > the *Messages* buffer gets redisplayed (but then for some reason > window-scroll-functions is not called in this case). That's a feature: you set recenter-redisplay to t, which causes a complete redraw of the frame when you type C-l. And window-scroll-functions aren't called when the window is not scrolled. Bottom line: I'm unsure what is a bug here, if any. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 25 16:58:14 2018 Received: (at 32839) by debbugs.gnu.org; 25 Sep 2018 20:58:14 +0000 Received: from localhost ([127.0.0.1]:54114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4uPN-00033P-Pl for submit@debbugs.gnu.org; Tue, 25 Sep 2018 16:58:13 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:45778 helo=pdx1-sub0-mail-a31.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4uPL-00033D-EK for 32839@debbugs.gnu.org; Tue, 25 Sep 2018 16:58:12 -0400 Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id 513AF7F32E; Tue, 25 Sep 2018 13:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=WzZJlGjGGBumus/AXRbE6qTzoUI=; b= EQevBzM/pSfWTR+zQcUmd72kGIw9/perijRPQbNGS766C/4iW+OrmfLmM+jr6YrT BKU9BWVfh2gHFBwm0UdQ6AH5ew3hYImBoJh8YuRlIU9BwduRIHmbTszDqL+eSwJw VFBYoIo5m8UgOaYbBrd9uY9zJWzXZpHKWKHzdk8VxV4= Received: from localhost.linkov.net (m91-129-111-128.cust.tele2.ee [91.129.111.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id 5BBAE7F977; Tue, 25 Sep 2018 13:58:09 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a31 X-DH-BACKEND: pdx1-sub0-mail-a31 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay Organization: LINKOV.NET References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> Date: Tue, 25 Sep 2018 23:55:15 +0300 In-Reply-To: <83lg7p8hnf.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Sep 2018 23:08:04 +0300") Message-ID: <87va6tb8lo.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> 5. Typein *scratch* again: C-l C-l C-l >> only when C-l puts point to the center of the window, >> the *Messages* buffer gets redisplayed (but then for some reason >> window-scroll-functions is not called in this case). > > That's a feature: you set recenter-redisplay to t, which causes a > complete redraw of the frame when you type C-l. I thought that recenter-redisplay set to t, which causes a complete redraw of the frame, should also redraw the *Messages* buffer. > And window-scroll-functions aren't called when the window is > not scrolled. I see that the window is scrolled while typing C-l C-l C-l ... (recenter-top-bottom). I tried in the middle of a large buffer like 'C-h C-t' (view-emacs-todo). The first C-l puts the current line in the middle, refreshes the *Message* buffer, and displays the message in the echo area. The second C-l puts the current line at the top, DOESN'T refresh the *Message* buffer, but displays the message in the echo area. The third C-l puts the current line at the bottom, DOESN'T refresh the *Message* buffer, and DOESN'T display the message in the echo area, which means window-scroll-functions is not called at all in this case. All three have a different effect. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 26 01:40:06 2018 Received: (at 32839) by debbugs.gnu.org; 26 Sep 2018 05:40:06 +0000 Received: from localhost ([127.0.0.1]:54306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g52YP-0001WO-Ns for submit@debbugs.gnu.org; Wed, 26 Sep 2018 01:40:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g52YN-0001Vn-LB for 32839@debbugs.gnu.org; Wed, 26 Sep 2018 01:40:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g52YF-0001dS-3D for 32839@debbugs.gnu.org; Wed, 26 Sep 2018 01:39:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g52YE-0001dM-Vo; Wed, 26 Sep 2018 01:39:55 -0400 Received: from [176.228.60.248] (port=2944 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g52YE-0002cw-Ju; Wed, 26 Sep 2018 01:39:54 -0400 Date: Wed, 26 Sep 2018 08:39:52 +0300 Message-Id: <83k1n895qv.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87va6tb8lo.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 25 Sep 2018 23:55:15 +0300) Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Juri Linkov > Cc: 32839@debbugs.gnu.org > Date: Tue, 25 Sep 2018 23:55:15 +0300 > > >> 5. Typein *scratch* again: C-l C-l C-l > >> only when C-l puts point to the center of the window, > >> the *Messages* buffer gets redisplayed (but then for some reason > >> window-scroll-functions is not called in this case). > > > > That's a feature: you set recenter-redisplay to t, which causes a > > complete redraw of the frame when you type C-l. > > I thought that recenter-redisplay set to t, which causes a complete > redraw of the frame, should also redraw the *Messages* buffer. Only when you invoke 'recenter' with no arguments. > > And window-scroll-functions aren't called when the window is > > not scrolled. > > I see that the window is scrolled while typing C-l C-l C-l ... > (recenter-top-bottom). My point was that C-l without arguments doesn't necessarily scroll. When the window is scrolled, the hook is being called. That's what I see here. > I tried in the middle of a large buffer > like 'C-h C-t' (view-emacs-todo). > > The first C-l puts the current line in the middle, refreshes > the *Message* buffer, and displays the message in the echo area. > > The second C-l puts the current line at the top, DOESN'T refresh > the *Message* buffer, but displays the message in the echo area. > > The third C-l puts the current line at the bottom, DOESN'T refresh > the *Message* buffer, and DOESN'T display the message in the echo area, > which means window-scroll-functions is not called at all in this case. > > All three have a different effect. Because each one calls 'recenter' with a different argument, or no argument at all. I see nothing unexpected in what you describe, FWIW. You need to keep in mind that "scrolling" is well defined only for scroll commands and functions (scroll-up, scroll-down, etc.). For other commands and functions that move the viewport in the buffer, it is up to the display engine whether to apply a scroll-like redraw (in which case window-scroll-functions will be called) or not. I think setting scroll-conservatively to a large value will make the display engine scroll in many more situations, but even then C-l might not always call window-scroll-functions. Also, you are talking about 2 different functions -- 'recenter' and 'recenter-top-bottom' -- and that adds confusion to the discussion, so maybe I misunderstood something you wanted to say. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 26 20:05:21 2018 Received: (at 32839) by debbugs.gnu.org; 27 Sep 2018 00:05:21 +0000 Received: from localhost ([127.0.0.1]:55782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5Jo1-0005ov-IV for submit@debbugs.gnu.org; Wed, 26 Sep 2018 20:05:21 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:46412 helo=pdx1-sub0-mail-a31.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5Jo0-0005on-3s for 32839@debbugs.gnu.org; Wed, 26 Sep 2018 20:05:20 -0400 Received: from pdx1-sub0-mail-a31.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTP id B5BFB7F97A; Wed, 26 Sep 2018 17:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=LeInKgLt0mT1RF7Yolf1MBE3s60=; b= EFb4bpOmZ7h1Ck94FOM7+VjJYRt/sXPkFzvGzEgK5ff4Rs9QnKs8ZaQpbTxEs6yO NV4CZFMXhYbL3tDyL46EDByAjzmanPTblpgB5A3KyT5qow6gul6HNYmj/GEaja18 eQVmEzKEd3tWMFioZ79aAyVUArRRuQkqWD0EDnbXVFs= Received: from localhost.linkov.net (m91-129-111-128.cust.tele2.ee [91.129.111.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a31.g.dreamhost.com (Postfix) with ESMTPSA id 5A1447F96E; Wed, 26 Sep 2018 17:05:17 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a31 X-DH-BACKEND: pdx1-sub0-mail-a31 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay Organization: LINKOV.NET References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> Date: Thu, 27 Sep 2018 02:55:38 +0300 In-Reply-To: <83k1n895qv.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 Sep 2018 08:39:52 +0300") Message-ID: <87tvmbq2pp.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Also, you are talking about 2 different functions -- 'recenter' and > 'recenter-top-bottom' -- and that adds confusion to the discussion, so > maybe I misunderstood something you wanted to say. I wanted to say that I see two problems here: 1. recenter doesn't redraw the frame when it is called with a non-nil REDISPLAY argument. In `recenter-top-bottom', when `recenter-last-op' is `top', this gets called: (recenter this-scroll-margin t) When `this-scroll-margin' is 0, the actual call is: (recenter 0 t) Despite its REDISPLAY argument set to t, the frame is not redisplayed. 2. The second problem is that after the call to (recenter -1 t), window-scroll-functions is called only when recenter moves the current buffer line to the second-last window line (when the last window line is partially visible). But when the last window line is fully visible, window-scroll-functions is not called after (recenter -1 t). From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 27 02:45:12 2018 Received: (at 32839) by debbugs.gnu.org; 27 Sep 2018 06:45:12 +0000 Received: from localhost ([127.0.0.1]:55857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5Q2x-0000rs-TN for submit@debbugs.gnu.org; Thu, 27 Sep 2018 02:45:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5Q2w-0000rc-AB for 32839@debbugs.gnu.org; Thu, 27 Sep 2018 02:45:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5Q2o-0001t0-2Y for 32839@debbugs.gnu.org; Thu, 27 Sep 2018 02:45:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5Q2n-0001ss-UQ; Thu, 27 Sep 2018 02:45:02 -0400 Received: from [176.228.60.248] (port=1500 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g5Q2n-0001Om-Dq; Thu, 27 Sep 2018 02:45:01 -0400 Date: Thu, 27 Sep 2018 09:44:43 +0300 Message-Id: <835zyr8mn8.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87tvmbq2pp.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 27 Sep 2018 02:55:38 +0300) Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Juri Linkov > Cc: 32839@debbugs.gnu.org > Date: Thu, 27 Sep 2018 02:55:38 +0300 > > 1. recenter doesn't redraw the frame when it is called with > a non-nil REDISPLAY argument. > > In `recenter-top-bottom', when `recenter-last-op' is `top', > this gets called: > > (recenter this-scroll-margin t) > > When `this-scroll-margin' is 0, the actual call is: > > (recenter 0 t) > > Despite its REDISPLAY argument set to t, the frame is not redisplayed. This is how 'recenter' is documented to behave: If ARG is omitted or nil, then recenter with point on the middle line of the selected window; if REDISPLAY & ‘recenter-redisplay’ are non-nil, also erase the entire frame and redraw it [...] IOW, the frame is redrawn only when ARG is nil and REDISPLAY is non-nil. > 2. The second problem is that after the call to (recenter -1 t), > window-scroll-functions is called only when recenter moves the current > buffer line to the second-last window line (when the last window line is > partially visible). But when the last window line is fully visible, > window-scroll-functions is not called after (recenter -1 t). Depending on the exact dimensions of the window and the size of your font, this can legitimately happen. You see, the way 'recenter' works, it sets a couple of fields in the window object which instruct the display engine to change the window-start point. The actual recentering happens during the very next redisplay cycle, at which time the display engine sees these fields and acts accordingly. To redisplay a window, the display engine has several methods at its disposal; starting with the cheapest one, it attempts to find the first applicable one, and then uses it. Only some of the methods are considered to use "scrolling", others aren't. So that's why window-scroll-functions might not be called when the text was "scrolled" by 'recenter' and its derivatives. Like I said: "scrolling" is only well-defined when you use the scrolling functions and commands, like scroll-up, scroll-down-command, etc. It is not well-defined with other functions which move the viewport, so window-scroll-functions may or may not be called when those other functions are invoked. Bottom line, I see no problem in the behavior described in this bug report, and I think it should be closed. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 27 19:12:09 2018 Received: (at 32839) by debbugs.gnu.org; 27 Sep 2018 23:12:09 +0000 Received: from localhost ([127.0.0.1]:57064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5fS5-0006X7-I1 for submit@debbugs.gnu.org; Thu, 27 Sep 2018 19:12:09 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:38448 helo=pdx1-sub0-mail-a9.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5fS3-0006Wv-Fn for 32839@debbugs.gnu.org; Thu, 27 Sep 2018 19:12:07 -0400 Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id 0DA1880B75; Thu, 27 Sep 2018 16:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=XuRwcy a6g9VD1/vP3iMNYdAx6Kc=; b=D0ChMCN0+5G3I917ZdvZ4GRwJx42xm+ZaCgBVb BpJGs/81ZMUL7WWQmyZnEgSi0ncomGjm/UoUvr0KXm/vhiT2kyPfst1EeMqB9QUK F+XWoGOH78H07bmqhOxmlQXvFfmS6uJvqKXM5cDNk04yYI0r0GmKk7ngV47uORp2 6e8Yg= Received: from localhost.linkov.net (m91-129-107-184.cust.tele2.ee [91.129.107.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id B4C027E426; Thu, 27 Sep 2018 16:12:05 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a9 X-DH-BACKEND: pdx1-sub0-mail-a9 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay Organization: LINKOV.NET References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> Date: Fri, 28 Sep 2018 01:59:04 +0300 In-Reply-To: <835zyr8mn8.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Sep 2018 09:44:43 +0300") Message-ID: <875zyqwnrb.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> (recenter 0 t) >> >> Despite its REDISPLAY argument set to t, the frame is not redisplay= ed. > > This is how 'recenter' is documented to behave: > > If ARG is omitted or nil, then recenter with point on the middle line > of the selected window; if REDISPLAY & =E2=80=98recenter-redisplay=E2= =80=99 are > non-nil, also erase the entire frame and redraw it [...] > > IOW, the frame is redrawn only when ARG is nil and REDISPLAY is > non-nil. Then why REDISPLAY is non-nil, if it doesn't redisplay the frame? I still don't understand the logic: `recenter-redisplay' is non-nil, the arg REDISPLAY is non-nil, and yet no redisplay, this makes no sense and looks like a bug. Maybe the problem lies in the name of the new arg REDISPLAY - from its current behavior a more correct name would be: `recenter-redisplay-only-when-another-arg-is-nil'. But such a long name indicates broken logic. It would make sense for a nil value of the REDISPLAY arg not to redisplay, and for a non-nil - to redisplay, or to take a special value like (recenter 0 'force) >> 2. The second problem is that after the call to (recenter -1 t), >> window-scroll-functions is called only when recenter moves the curr= ent >> buffer line to the second-last window line (when the last window li= ne is >> partially visible). But when the last window line is fully visible= , >> window-scroll-functions is not called after (recenter -1 t). > > Depending on the exact dimensions of the window and the size of your > font, this can legitimately happen. > > You see, the way 'recenter' works, it sets a couple of fields in the > window object which instruct the display engine to change the > window-start point. The actual recentering happens during the very > next redisplay cycle, at which time the display engine sees these > fields and acts accordingly. To redisplay a window, the display > engine has several methods at its disposal; starting with the cheapest > one, it attempts to find the first applicable one, and then uses it. > Only some of the methods are considered to use "scrolling", others > aren't. So that's why window-scroll-functions might not be called > when the text was "scrolled" by 'recenter' and its derivatives. I thought that scrolling for the sake of window-scroll-functions implies the changes in the value of window-start, i.e. when an old value of window-start is not the same as its new value, this guarantees the call of window-scroll-functions. The docstring of window-scroll-functions says: These functions are called whenever the =E2=80=98window-start=E2=80=99 = marker is modified, either to point into another buffer (e.g. via =E2=80=98set-window-buffe= r=E2=80=99) or another place in the same buffer. (recenter -1 t) definitely modifies the value of window-start, so it's expected that window-scroll-functions should be called. Maybe it will be called in the new hook window-state-change-functions proposed by Martin. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 28 02:22:33 2018 Received: (at 32839) by debbugs.gnu.org; 28 Sep 2018 06:22:33 +0000 Received: from localhost ([127.0.0.1]:57151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5mAb-0000sC-3a for submit@debbugs.gnu.org; Fri, 28 Sep 2018 02:22:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g5mAZ-0000rx-BM for 32839@debbugs.gnu.org; Fri, 28 Sep 2018 02:22:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g5mAQ-00047l-7X for 32839@debbugs.gnu.org; Fri, 28 Sep 2018 02:22:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g5mAQ-00047f-3W; Fri, 28 Sep 2018 02:22:22 -0400 Received: from [176.228.60.248] (port=2815 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g5mAP-0001KC-N9; Fri, 28 Sep 2018 02:22:22 -0400 Date: Fri, 28 Sep 2018 09:22:07 +0300 Message-Id: <83k1n66t0w.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <875zyqwnrb.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 28 Sep 2018 01:59:04 +0300) Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> <875zyqwnrb.fsf@mail.linkov.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Juri Linkov > Cc: 32839@debbugs.gnu.org > Date: Fri, 28 Sep 2018 01:59:04 +0300 > > >> (recenter 0 t) > >> > >> Despite its REDISPLAY argument set to t, the frame is not redisplayed. > > > > This is how 'recenter' is documented to behave: > > > > If ARG is omitted or nil, then recenter with point on the middle line > > of the selected window; if REDISPLAY & ‘recenter-redisplay’ are > > non-nil, also erase the entire frame and redraw it [...] > > > > IOW, the frame is redrawn only when ARG is nil and REDISPLAY is > > non-nil. > > Then why REDISPLAY is non-nil, if it doesn't redisplay the frame? There's a long history to this, you may wish to use "git -L" and look at the discussions/bug reports related to 'recenter'. The short answer is that this arrangement (which is new in Emacs 27) has its main goal to allow "C-l" to redraw the entire frame when the user so desires (by default, only on TTY frames), while avoiding the frame redraw in most, if not all, other situations, because redrawing a frame causes flickering. This flickering is caused by Lisp programs calling 'recenter', directly or indirectly. > I thought that scrolling for the sake of window-scroll-functions > implies the changes in the value of window-start, i.e. when > an old value of window-start is not the same as its new value, > this guarantees the call of window-scroll-functions. That'd cause window-scroll-functions to be called in too many unrelated situations, because almost every redisplay cycle changes the value of window-start. E.g., consider goto-char or goto-line or even C-s that finds the match off-screen. > The docstring of window-scroll-functions says: > > These functions are called whenever the ‘window-start’ marker is modified, > either to point into another buffer (e.g. via ‘set-window-buffer’) or another > place in the same buffer. You've omitted the first line of the doc string: List of functions to call before redisplaying a window with scrolling. ^^^^^^^^^^^^^^ > Maybe it will be called in the new hook window-state-change-functions > proposed by Martin. I hope not. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 29 20:00:45 2018 Received: (at 32839) by debbugs.gnu.org; 30 Sep 2018 00:00:45 +0000 Received: from localhost ([127.0.0.1]:59289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6PAD-0005j5-59 for submit@debbugs.gnu.org; Sat, 29 Sep 2018 20:00:45 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:59434 helo=pdx1-sub0-mail-a9.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6PAA-0005it-RZ for 32839@debbugs.gnu.org; Sat, 29 Sep 2018 20:00:43 -0400 Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id 1029F7E9E5; Sat, 29 Sep 2018 17:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=W2/i0f cXMHok1x0hPOZ84rqfs6Q=; b=i5kA0k1Vc3UpxE6WTYjzLgsk1oROG9Hgb1WhOz YsL+ZfeG1ABBj9l8fJFoy/oAdEUte4YQ2/YhkUtvoP02EPuCCzt0b2bEN8ESci7a 9o5mCah+xX0KrPkrW//b15qPDU/oR2stCeyEWzzH23mjVnZiPHZoN2rbLjZ7tq3m I+3KA= Received: from localhost.linkov.net (m91-129-107-184.cust.tele2.ee [91.129.107.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id 642E67EC94; Sat, 29 Sep 2018 17:00:39 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a9 X-DH-BACKEND: pdx1-sub0-mail-a9 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay Organization: LINKOV.NET References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> <875zyqwnrb.fsf@mail.linkov.net> <83k1n66t0w.fsf@gnu.org> Date: Sun, 30 Sep 2018 02:32:57 +0300 In-Reply-To: <83k1n66t0w.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Sep 2018 09:22:07 +0300") Message-ID: <87k1n3ev6e.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> >> (recenter 0 t) >> >> >> >> Despite its REDISPLAY argument set to t, the frame is not redisp= layed. >> > >> > This is how 'recenter' is documented to behave: >> > >> > If ARG is omitted or nil, then recenter with point on the middle l= ine >> > of the selected window; if REDISPLAY & =E2=80=98recenter-redisplay= =E2=80=99 are >> > non-nil, also erase the entire frame and redraw it [...] >> > >> > IOW, the frame is redrawn only when ARG is nil and REDISPLAY is >> > non-nil. >> >> Then why REDISPLAY is non-nil, if it doesn't redisplay the frame? > > There's a long history to this, you may wish to use "git -L" and look > at the discussions/bug reports related to 'recenter'. > > The short answer is that this arrangement (which is new in Emacs 27) > has its main goal to allow "C-l" to redraw the entire frame when the > user so desires (by default, only on TTY frames), while avoiding the > frame redraw in most, if not all, other situations, because redrawing > a frame causes flickering. This flickering is caused by Lisp programs > calling 'recenter', directly or indirectly. I see that before the recent changes, on a TTY 'C-l' and all non-interactive calls of 'recenter' cleared the frame, but now only interactive calls of 'recenter' redraw the frame. OTOH, what I'm trying to achieve here is to allow C-l with a non-nil argument to refresh the *Messages* buffer when recenter-redisplay is t. An additional problem is that when 'recenter-positions' is customized to not contain the keyword 'middle', then 'recenter-top-bottom' never uses a nil arg of 'recenter', thus never redraws the frame. But since redrawing a frame causes flickering, I'm not interested in setting recenter-redisplay to t. So I could implement more fundamental changes for this only if you insist. However, a minimal change that is needed here is to fix inconsistencies in the recent changes: the argument name 'redisplay' is confusing - it implies that it overrides the default value of recenter-redisplay to force the redisplay. A proper name would be 'interactive'. There are dozens of commands already that use this naming convention. diff --git a/lisp/window.el b/lisp/window.el index 76de4207e7..584b25224c 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -8759,17 +8759,19 @@ recenter-positions :version "23.2" :group 'windows) =20 -(defun recenter-top-bottom (&optional arg) +(defun recenter-top-bottom (&optional arg interactive) "Move current buffer line to the specified window line. With no prefix argument, successive calls place point according to the cycling order defined by `recenter-positions'. =20 A prefix argument is handled like `recenter': With numeric prefix ARG, move current line to window-line ARG. - With plain `C-u', move current line to window center." - (interactive "P") + With plain `C-u', move current line to window center. + +Interactively, INTERACTIVE is non-nil and handled like in `recenter'." + (interactive "P\np") (cond - (arg (recenter arg t)) ; Always respect ARG. + (arg (recenter arg interactive)) ; Always respect ARG. (t (setq recenter-last-op (if (eq this-command last-command) @@ -8780,15 +8782,15 @@ recenter-top-bottom (min (max 0 scroll-margin) (truncate (/ (window-body-height) 4.0))))) (cond ((eq recenter-last-op 'middle) - (recenter nil t)) + (recenter nil interactive)) ((eq recenter-last-op 'top) - (recenter this-scroll-margin t)) + (recenter this-scroll-margin interactive)) ((eq recenter-last-op 'bottom) - (recenter (- -1 this-scroll-margin) t)) + (recenter (- -1 this-scroll-margin) interactive)) ((integerp recenter-last-op) - (recenter recenter-last-op t)) + (recenter recenter-last-op interactive)) ((floatp recenter-last-op) - (recenter (round (* recenter-last-op (window-height))) t))))))) + (recenter (round (* recenter-last-op (window-height))) interactive= ))))))) =20 (define-key global-map [?\C-l] 'recenter-top-bottom) =20 diff --git a/src/window.c b/src/window.c index 6cdc52f90e..dd8c221308 100644 --- a/src/window.c +++ b/src/window.c @@ -5944,16 +5944,16 @@ relative to the selected window. If ARG is negat= ive, it counts up from the bottom of the window. (ARG should be less than the height of the window= .) =20 If ARG is omitted or nil, then recenter with point on the middle line -of the selected window; if REDISPLAY & `recenter-redisplay' are +of the selected window; if INTERACTIVE & `recenter-redisplay' are non-nil, also erase the entire frame and redraw it (when `auto-resize-tool-bars' is set to `grow-only', this resets the tool-bar's height to the minimum height needed); if `recenter-redisplay' has the special value `tty', then only tty frames -are redrawn. Interactively, REDISPLAY is always non-nil. +are redrawn. Interactively, INTERACTIVE is always non-nil. =20 Just C-u as prefix means put point in the center of the window and redisplay normally--don't erase and redraw the frame. */) - (Lisp_Object arg, Lisp_Object redisplay) + (Lisp_Object arg, Lisp_Object interactive) { struct window *w =3D XWINDOW (selected_window); struct buffer *buf =3D XBUFFER (w->contents); @@ -5973,7 +5973,7 @@ and redisplay normally--don't erase and redraw the = frame. */) =20 if (NILP (arg)) { - if (!NILP (redisplay) + if (!NILP (interactive) && !NILP (Vrecenter_redisplay) && (!EQ (Vrecenter_redisplay, Qtty) || !NILP (Ftty_type (selected_frame)))) From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 29 20:00:50 2018 Received: (at 32839) by debbugs.gnu.org; 30 Sep 2018 00:00:50 +0000 Received: from localhost ([127.0.0.1]:59292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6PAI-0005jS-Fu for submit@debbugs.gnu.org; Sat, 29 Sep 2018 20:00:50 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:59462 helo=pdx1-sub0-mail-a9.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6PAG-0005jJ-TZ for 32839@debbugs.gnu.org; Sat, 29 Sep 2018 20:00:49 -0400 Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id 63E5080B75; Sat, 29 Sep 2018 17:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:message-id:mime-version:content-type :content-transfer-encoding; s=linkov.net; bh=hfqFKX9H6MmP+dBFNhk 7UmeFHoo=; b=QekAcFsjyAYyK2cDDpaRlPZ8YV1Hc4XM8SYFTKx6cJIxexPyCkZ Fn++TbEkNkOmLPd0bsvERB/KuOTgEd0cEVrCIspuqu3e/N0ZE/DRhTqhIf5JtGFU kfObdr2d1c0SWl3ZSgrHeTEBfTrirx83A+Rs3E5EFHabr5Q5k21Cz9KE= Received: from localhost.linkov.net (m91-129-107-184.cust.tele2.ee [91.129.107.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id CDB0E7E9E5; Sat, 29 Sep 2018 17:00:46 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a9 X-DH-BACKEND: pdx1-sub0-mail-a9 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay Organization: LINKOV.NET References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> <875zyqwnrb.fsf@mail.linkov.net> <83k1n66t0w.fsf@gnu.org> Date: Sun, 30 Sep 2018 02:38:03 +0300 Message-ID: <87k1n3c0vo.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> The docstring of window-scroll-functions says: >> >> These functions are called whenever the =E2=80=98window-start=E2=80=99= marker is modified, >> either to point into another buffer (e.g. via =E2=80=98set-window-bu= ffer=E2=80=99) or another >> place in the same buffer. > > You've omitted the first line of the doc string: > > List of functions to call before redisplaying a window with scrolling= . > ^^^^^^^^^^^^^^ But (info "(emacs) Recentering") says that recentering is scrolling: Typing =E2=80=98C-l=E2=80=99 twice in a row (=E2=80=98C-l C-l=E2=80=99= ) scrolls the window so that ^^^^^^^ point is on the topmost screen line. Typing a third =E2=80=98C-l=E2=80= =99 scrolls the ^^^^^^^ window so that point is on the bottom-most screen line. Each successiv= e =E2=80=98C-l=E2=80=99 cycles through these three positions. So 'C-l C-l C-l' is eligible for the calls of window-scroll-functions. >> Maybe it will be called in the new hook window-state-change-functions >> proposed by Martin. > > I hope not. I grepped for window-scroll-functions, and see that the current situation is quite bad: 1. tabulated-list-window-scroll-function is not called on 'C-u -1 C-l' when the last window line is fully visible, so it doesn't adjust the width for display-line-numbers in this case. 2. linum-mode relies more on post-command-hook because window-scroll-functions is not reliable. 3. erc-scroll-to-bottom was forced to replace window-scroll-functions with post-command-hook because window-scroll-functions doesn't support altering the way the window is scrolled. The only hope to fix these problems and to close this report is to call the new hook window-state-change-functions at the very end when the redisplay is completely finished, probably at the same time when post-command-hook is called. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 30 02:08:43 2018 Received: (at 32839) by debbugs.gnu.org; 30 Sep 2018 06:08:43 +0000 Received: from localhost ([127.0.0.1]:59357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6UuI-0006gW-Vt for submit@debbugs.gnu.org; Sun, 30 Sep 2018 02:08:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6UuH-0006gJ-9D for 32839@debbugs.gnu.org; Sun, 30 Sep 2018 02:08:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6Uu7-0000hj-5C for 32839@debbugs.gnu.org; Sun, 30 Sep 2018 02:08:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6Uu6-0000hR-H3; Sun, 30 Sep 2018 02:08:31 -0400 Received: from [176.228.60.248] (port=1223 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g6Uu6-0004Ao-4x; Sun, 30 Sep 2018 02:08:30 -0400 Date: Sun, 30 Sep 2018 09:08:20 +0300 Message-Id: <83a7nz5xgr.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87k1n3ev6e.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 30 Sep 2018 02:32:57 +0300) Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> <875zyqwnrb.fsf@mail.linkov.net> <83k1n66t0w.fsf@gnu.org> <87k1n3ev6e.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Juri Linkov > Cc: 32839@debbugs.gnu.org > Date: Sun, 30 Sep 2018 02:32:57 +0300 > > I see that before the recent changes, on a TTY 'C-l' and > all non-interactive calls of 'recenter' cleared the frame, > but now only interactive calls of 'recenter' redraw the frame. More or less, yes. There's still a way to call 'recenter' non-interactively in a way that will cause the frame to be redrawn, but it needs a special arrangement. > OTOH, what I'm trying to achieve here is to allow C-l with a non-nil > argument to refresh the *Messages* buffer when recenter-redisplay is t. That's not C-l's purpose, so IMO you are using the wrong tool for the job. > An additional problem is that when 'recenter-positions' is customized > to not contain the keyword 'middle', then 'recenter-top-bottom' never > uses a nil arg of 'recenter', thus never redraws the frame. Again, it is not recenter-redisplay's purpose to redraw the frame. If you want to redraw the frame, there's a command for that (and much more): redraw-display. There's also a function redraw-frame. > But since redrawing a frame causes flickering, I'm not interested > in setting recenter-redisplay to t. So I could implement more > fundamental changes for this only if you insist. I don't think any changes are necessary, because the functions mentioned all work as intended. I'm not interested in making the complex arrangement we already have even more complex. It is already quite an unholy mess. > However, a minimal change that is needed here is to fix inconsistencies > in the recent changes: the argument name 'redisplay' is confusing - > it implies that it overrides the default value of recenter-redisplay > to force the redisplay. A proper name would be 'interactive'. > There are dozens of commands already that use this naming convention. I don't think I agree. The current name reflects what that argument causes, you just interpret "redisplay" to mean "redraw the frame", which is not an accurate interpretation, since the display engine has its own logic to decide what exactly needs to be redrawn at any particular moment. Renaming the argument as you propose would be a step backwards, since it describes the _purpose_ (as opposed to _effect_) of that argument, and that could easily change with further development, and is not accurate even with the current code. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 30 02:22:31 2018 Received: (at 32839) by debbugs.gnu.org; 30 Sep 2018 06:22:31 +0000 Received: from localhost ([127.0.0.1]:59363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6V7f-00070k-CF for submit@debbugs.gnu.org; Sun, 30 Sep 2018 02:22:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6V7e-00070Y-O6 for 32839@debbugs.gnu.org; Sun, 30 Sep 2018 02:22:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6V7W-0001mP-Ga for 32839@debbugs.gnu.org; Sun, 30 Sep 2018 02:22:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6V7V-0001m4-WA; Sun, 30 Sep 2018 02:22:22 -0400 Received: from [176.228.60.248] (port=2078 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g6V7U-0005BY-Tt; Sun, 30 Sep 2018 02:22:21 -0400 Date: Sun, 30 Sep 2018 09:22:11 +0300 Message-Id: <838t3j5wto.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87k1n3c0vo.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 30 Sep 2018 02:38:03 +0300) Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> <875zyqwnrb.fsf@mail.linkov.net> <83k1n66t0w.fsf@gnu.org> <87k1n3c0vo.fsf@mail.linkov.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Juri Linkov > Cc: 32839@debbugs.gnu.org > Date: Sun, 30 Sep 2018 02:38:03 +0300 > > > List of functions to call before redisplaying a window with scrolling. > > ^^^^^^^^^^^^^^ > > But (info "(emacs) Recentering") says that recentering is scrolling: > > Typing ‘C-l’ twice in a row (‘C-l C-l’) scrolls the window so that > ^^^^^^^ > point is on the topmost screen line. Typing a third ‘C-l’ scrolls the > ^^^^^^^ > window so that point is on the bottom-most screen line. Each successive > ‘C-l’ cycles through these three positions. That's because C-l in most cases indeed scrolls, and I don't see a point in making the documentation much more complicated due to this special case. But if you think it's important enough, we could come up with some wording that would reflect the situation more accurately, or say things more vaguely. > So 'C-l C-l C-l' is eligible for the calls of window-scroll-functions. It's eligible, but its eligibility doesn't always materialize. Frankly, I'm not sure where this discussion goes. > I grepped for window-scroll-functions, and see that the current situation > is quite bad: > > 1. tabulated-list-window-scroll-function is not called on 'C-u -1 C-l' > when the last window line is fully visible, so it doesn't adjust > the width for display-line-numbers in this case. A bug report with a recipe would be appreciated. > 2. linum-mode relies more on post-command-hook because > window-scroll-functions is not reliable. > > 3. erc-scroll-to-bottom was forced to replace window-scroll-functions > with post-command-hook because window-scroll-functions doesn't > support altering the way the window is scrolled. Like I said a few days ago: the hooks provided by the display engine cannot possibly be as accurate as you expect, because the display engine doesn't know enough about the application, and its main purpose is to redraw the screen as cheaply as possible. The correlation between what the display engine does and higher-level concepts like "scrolling" can be quite low in some cases, because "scrolling" means something very different to the display engine than what it means to users and Lisp programs. > The only hope to fix these problems and to close this report is to call > the new hook window-state-change-functions at the very end when the > redisplay is completely finished "Redisplay is completely finished" is not well defined. Especially since some (most?) hooks only care about a specific window, whereas redisplay considers more than one window. Moreover, what would be the purpose of such a hook? It can tell nothing about what was done to perform redisplay. For example, if the display engine decided that the single displayed window didn't need to be redrawn at all, the "redisplay completely finished" hook will still be called, yes? > probably at the same time when post-command-hook is called. That hook is not called from the display code. But in any case, if post-command-hook is what you want, just use it. Why do we need another hook at the same place? It sounds redundant. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 30 16:04:32 2018 Received: (at 32839) by debbugs.gnu.org; 30 Sep 2018 20:04:32 +0000 Received: from localhost ([127.0.0.1]:60276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6hx9-000422-OY for submit@debbugs.gnu.org; Sun, 30 Sep 2018 16:04:31 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:59708 helo=pdx1-sub0-mail-a9.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6hx8-00041u-0F for 32839@debbugs.gnu.org; Sun, 30 Sep 2018 16:04:30 -0400 Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id 475BF80B4E; Sun, 30 Sep 2018 13:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=PRWzpHrELpXyC2t2tJpW7mceqfA=; b= 0XSPAgzV6J5TPnhOaExWnt6y2VmWbSvN4A7Sq5xzDBG9XG2X2T/MncPaSygQXOVp bRzcL/fGqMd2g5jjpZrxI5FlN/fFCbuBR6fSIVEOlTAakc70E+GGGiPtE+cgk9O1 zkDGAXl9bbxBnoA1fGUB5+N9L4UAc2aUQYnMFGJIakg= Received: from localhost.linkov.net (m91-129-107-184.cust.tele2.ee [91.129.107.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id D37D37E426; Sun, 30 Sep 2018 13:04:27 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a9 X-DH-BACKEND: pdx1-sub0-mail-a9 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay Organization: LINKOV.NET References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> <875zyqwnrb.fsf@mail.linkov.net> <83k1n66t0w.fsf@gnu.org> <87k1n3ev6e.fsf@mail.linkov.net> <83a7nz5xgr.fsf@gnu.org> Date: Sun, 30 Sep 2018 22:40:18 +0300 In-Reply-To: <83a7nz5xgr.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 Sep 2018 09:08:20 +0300") Message-ID: <87efdau63h.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> However, a minimal change that is needed here is to fix inconsistencies >> in the recent changes: the argument name 'redisplay' is confusing - >> it implies that it overrides the default value of recenter-redisplay >> to force the redisplay. A proper name would be 'interactive'. >> There are dozens of commands already that use this naming convention. > > I don't think I agree. The current name reflects what that argument > causes, you just interpret "redisplay" to mean "redraw the frame", > which is not an accurate interpretation, since the display engine has > its own logic to decide what exactly needs to be redrawn at any > particular moment. When an argument name is a verb in the imperative mood, this means only one thing: it should do what it claims it will do. If it can't ensure the result because it interprets it depending on other external conditions, then the argument should be renamed to e.g. 'maybe-redisplay'. > Renaming the argument as you propose would be a step backwards, since > it describes the _purpose_ (as opposed to _effect_) of that argument, > and that could easily change with further development, and is not > accurate even with the current code. Other commands that use the argument name 'interactive' have the same assumption of describing the purpose, not effect. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 30 16:04:35 2018 Received: (at 32839) by debbugs.gnu.org; 30 Sep 2018 20:04:35 +0000 Received: from localhost ([127.0.0.1]:60279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6hxD-00042J-0R for submit@debbugs.gnu.org; Sun, 30 Sep 2018 16:04:35 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:59722 helo=pdx1-sub0-mail-a9.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6hxB-00042A-QA for 32839@debbugs.gnu.org; Sun, 30 Sep 2018 16:04:34 -0400 Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id 62F027E426; Sun, 30 Sep 2018 13:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=5z7RLKZZt15QOYIM02dIjii/rq0=; b= M8Q6Yo622L4hAj9d3/a5J0ppt4dS0bWok49VCugB3EWDi838/LdXkCZZ0298XFqo 9b9d5142xyyIcMJWuXCqK/dIWJscLW54n0OOTWq6eXyBIELbOOVPmV0ObwVp01xW L9UNc4BoBr5ZfoduIoBq7fz74OYaHlMgeSRvqfqt18g= Received: from localhost.linkov.net (m91-129-107-184.cust.tele2.ee [91.129.107.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id 58E3080B4E; Sun, 30 Sep 2018 13:04:32 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a9 X-DH-BACKEND: pdx1-sub0-mail-a9 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay Organization: LINKOV.NET References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> <875zyqwnrb.fsf@mail.linkov.net> <83k1n66t0w.fsf@gnu.org> <87k1n3c0vo.fsf@mail.linkov.net> <838t3j5wto.fsf@gnu.org> Date: Sun, 30 Sep 2018 22:46:47 +0300 In-Reply-To: <838t3j5wto.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 Sep 2018 09:22:11 +0300") Message-ID: <87murysr88.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> I grepped for window-scroll-functions, and see that the current situation >> is quite bad: >> >> 1. tabulated-list-window-scroll-function is not called on 'C-u -1 C-l' >> when the last window line is fully visible, so it doesn't adjust >> the width for display-line-numbers in this case. > > A bug report with a recipe would be appreciated. The recipe is essentially the same as for this bug report, but more complicated. >> probably at the same time when post-command-hook is called. > > That hook is not called from the display code. But in any case, if > post-command-hook is what you want, just use it. Why do we need > another hook at the same place? It sounds redundant. If window-scroll-functions can't be fixed, then indeed a workaround is to remember an old value of window-start in pre-command-hook, and compare it with a new value of window-start in post-command-hook. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 01 01:34:40 2018 Received: (at 32839) by debbugs.gnu.org; 1 Oct 2018 05:34:40 +0000 Received: from localhost ([127.0.0.1]:60540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6qqu-0001ML-FX for submit@debbugs.gnu.org; Mon, 01 Oct 2018 01:34:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6qqt-0001M5-D3 for 32839@debbugs.gnu.org; Mon, 01 Oct 2018 01:34:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6qqk-000770-64 for 32839@debbugs.gnu.org; Mon, 01 Oct 2018 01:34:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6qqh-0006zg-4j; Mon, 01 Oct 2018 01:34:29 -0400 Received: from [176.228.60.248] (port=1876 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g6qqg-0002Lp-Oa; Mon, 01 Oct 2018 01:34:27 -0400 Date: Mon, 01 Oct 2018 08:34:18 +0300 Message-Id: <83ftxq44dh.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87efdau63h.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 30 Sep 2018 22:40:18 +0300) Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> <875zyqwnrb.fsf@mail.linkov.net> <83k1n66t0w.fsf@gnu.org> <87k1n3ev6e.fsf@mail.linkov.net> <83a7nz5xgr.fsf@gnu.org> <87efdau63h.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Juri Linkov > Cc: 32839@debbugs.gnu.org > Date: Sun, 30 Sep 2018 22:40:18 +0300 > > > I don't think I agree. The current name reflects what that argument > > causes, you just interpret "redisplay" to mean "redraw the frame", > > which is not an accurate interpretation, since the display engine has > > its own logic to decide what exactly needs to be redrawn at any > > particular moment. > > When an argument name is a verb in the imperative mood, this means only > one thing: it should do what it claims it will do. And it does: it redisplays the current window. It does _not_ always redisplay other windows, and does _not_ redraw the entire frame unless another argument tells it to do so. IOW, "redisplay" is not the same as "redraw the frame". If the argument's name were "redraw-frame", then I'd agree with you that the name is misleading. > > Renaming the argument as you propose would be a step backwards, since > > it describes the _purpose_ (as opposed to _effect_) of that argument, > > and that could easily change with further development, and is not > > accurate even with the current code. > > Other commands that use the argument name 'interactive' have the same > assumption of describing the purpose, not effect. It is possible that in other cases that name is the best one we found; or it could be that some of those arguments need to be renamed to something else. The decision is on a per-case basis, and cannot be global. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 01 02:59:42 2018 Received: (at 32839) by debbugs.gnu.org; 1 Oct 2018 06:59:42 +0000 Received: from localhost ([127.0.0.1]:60568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6sBC-0003Le-4R for submit@debbugs.gnu.org; Mon, 01 Oct 2018 02:59:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6sBA-0003LQ-0u for 32839@debbugs.gnu.org; Mon, 01 Oct 2018 02:59:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6sB0-0002pc-01 for 32839@debbugs.gnu.org; Mon, 01 Oct 2018 02:59:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6sAv-0002p1-TH; Mon, 01 Oct 2018 02:59:28 -0400 Received: from [176.228.60.248] (port=3491 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g6sAc-00078e-Tx; Mon, 01 Oct 2018 02:59:22 -0400 Date: Mon, 01 Oct 2018 09:58:59 +0300 Message-Id: <83bm8e40gc.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87murysr88.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 30 Sep 2018 22:46:47 +0300) Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> <875zyqwnrb.fsf@mail.linkov.net> <83k1n66t0w.fsf@gnu.org> <87k1n3c0vo.fsf@mail.linkov.net> <838t3j5wto.fsf@gnu.org> <87murysr88.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Juri Linkov > Cc: 32839@debbugs.gnu.org > Date: Sun, 30 Sep 2018 22:46:47 +0300 > > >> I grepped for window-scroll-functions, and see that the current situation > >> is quite bad: > >> > >> 1. tabulated-list-window-scroll-function is not called on 'C-u -1 C-l' > >> when the last window line is fully visible, so it doesn't adjust > >> the width for display-line-numbers in this case. > > > > A bug report with a recipe would be appreciated. > > The recipe is essentially the same as for this bug report, > but more complicated. I'd appreciate if you could show the recipe, TIA. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 08 19:08:17 2018 Received: (at 32839) by debbugs.gnu.org; 8 Oct 2018 23:08:17 +0000 Received: from localhost ([127.0.0.1]:40914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9edN-00012o-A4 for submit@debbugs.gnu.org; Mon, 08 Oct 2018 19:08:17 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:59200 helo=pdx1-sub0-mail-a36.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9edL-00012g-CZ for 32839@debbugs.gnu.org; Mon, 08 Oct 2018 19:08:15 -0400 Received: from pdx1-sub0-mail-a36.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a36.g.dreamhost.com (Postfix) with ESMTP id E99F480367; Mon, 8 Oct 2018 16:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=ql5ipu9GT6+EAfVjfmZ+OGdaC2o=; b= TYI0V27/nHDyiVulqVZ0p7J9Lu/8EMjhB67WfkPZTDXwBLQfUy1sMfo5eGQqab9c XvwFFH1I5APavYG/CYUWBXL7gzgzcNEnsW7gyZsnCmfecGrVRiSYz9o88pclg9oG A9X+sFVkaCmROomHMQUl7rZtbbLMrtdNlttatVUP0DU= Received: from localhost.linkov.net (m91-129-107-184.cust.tele2.ee [91.129.107.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a36.g.dreamhost.com (Postfix) with ESMTPSA id 190FF8035F; Mon, 8 Oct 2018 16:08:12 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a36 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay Organization: LINKOV.NET References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> <875zyqwnrb.fsf@mail.linkov.net> <83k1n66t0w.fsf@gnu.org> <87k1n3c0vo.fsf@mail.linkov.net> <838t3j5wto.fsf@gnu.org> Date: Tue, 09 Oct 2018 01:56:12 +0300 In-Reply-To: <838t3j5wto.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 Sep 2018 09:22:11 +0300") Message-ID: <87d0skoxo3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudefgddulecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtjedrudekgeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghloheplhhotggrlhhhohhsthdrlhhinhhkohhvrdhnvghtpdhinhgvthepledurdduvdelrddutdejrddukeegpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepvghlihiisehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgepud X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> The only hope to fix these problems and to close this report is to call >> the new hook window-state-change-functions at the very end when the >> redisplay is completely finished > > "Redisplay is completely finished" is not well defined. Especially > since some (most?) hooks only care about a specific window, whereas > redisplay considers more than one window. I found another case when window-size-change-functions is not called: it's when invoking winner-undo that restores a previous window-configuration and where the same window has different window sizes in prev/next window-configurations. Perhaps this problem will be fixed by window-state-change-functions that Martin is currently implementing. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 09 03:44:25 2018 Received: (at 32839) by debbugs.gnu.org; 9 Oct 2018 07:44:25 +0000 Received: from localhost ([127.0.0.1]:41133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9mgr-0000hT-H4 for submit@debbugs.gnu.org; Tue, 09 Oct 2018 03:44:25 -0400 Received: from mout.gmx.net ([212.227.17.20]:53151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9mgq-0000hG-1S for 32839@debbugs.gnu.org; Tue, 09 Oct 2018 03:44:24 -0400 Received: from [192.168.1.101] ([46.125.250.96]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MZ7bs-1gO09J3I4a-00KzOj; Tue, 09 Oct 2018 09:44:13 +0200 Received: from [192.168.1.101] ([46.125.250.96]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MZ7bs-1gO09J3I4a-00KzOj; Tue, 09 Oct 2018 09:44:13 +0200 Message-ID: <5BBC5C47.4040705@gmx.at> Date: Tue, 09 Oct 2018 09:44:07 +0200 From: martin rudalics MIME-Version: 1.0 To: Juri Linkov , Eli Zaretskii Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> <875zyqwnrb.fsf@mail.linkov.net> <83k1n66t0w.fsf@gnu.org> <87k1n3c0vo.fsf@mail.linkov.net> <838t3j5wto.fsf@gnu.org> <87d0skoxo3.fsf@mail.linkov.net> In-Reply-To: <87d0skoxo3.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:nN+GLrxZRoodnECMOb/KCiyU1dLeMgB+z6JV62A86LY9IRxjsmF aGsC+weMGUky6fnB0yaoE2nitw3oPjc2xV+F8ZTJCh95aym/Q8INPLLPJGcFAwIE5ucl8+z 7fXsGe2XxpM4Wm7TZOLOQMD4A0GYRbxb4LPP7TF9y41bNip+kM+PpTnASTzUg4ikQGp6zJv UiAQxhs7hazdju67rhGgw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:Q+FX7bkkX6U=:PIuncy2izGlicfZ/H6T9Cm oiaCTmrUc7G6b2Me6AT1g04LWdC8LEQXqYF/RrlX+UfkXNmaA4GviO/gElcw16UeLJ7a++uGl EGNl9wGdjhmuwNgnIbm21/6aJFinY+BydYqqIhoLxEM7Voi9DPZQ1wQYtIOF/qc/7Y7pMGZFk 3Zu9JTS/gaCSZ9Yr+r6wdeMKUcFEji1N0Fl1pbts25bEkSGh3BBncjIea+BCAaTcyu4P+c0en J+VytFxUCFStMYZHiTrrXRGnTtQhffI4g5KEr0h+cKk0WUP89EGz4/T4OgGlJJdH4V8dbWEfG IRMVgAqsuKQ0kV1PkV9GkmhX2zKWQrb++du4s76uhft7NktqOCxMIFMdp7+QXfCK2jmbjjIRZ 6GZQbL+1gpEum7b+wEsNvSLIzkV2sXgP48UnEe5gA1Yu8/Y9Ks/zA1PPUQHnxAFCCFlwVPn+U idqP37389fNjsYGnGOvG0CId819HXG0UufbFzUkKaw2GHbP6YY+pv/AKrFB3TJ4H+cotluksk 18YX/ZVSE8TQM1YBgyVqsjGZP8XlLLk2GBCgYWfkN+t+7Ycpn9h6Dl3TJh8k7D0iwPMBGcjdM WpxpdD0GFF4/fn0guJGI9nz40ZraZWaZdLQgNZn9jbft3CLFxMLHcOQabEJcPHxLrvB+GmDGr ZfpxihKrzAouqTn7DRkrVhA29GIRn63fviOhxpaZO+q/OanY3kBJFBtbvJRA/0WM6qZLyJI2x ohovUvOuu/tkjVxjcKdJrvrDNgjeHsscEOu4NbdqQvwTJO5VHwrkS5xLpVCXwM1uyvrXP17Tr L4jMSOPoYb4pzNuFos9ESzEqrbDtfW5eLv2q85pig9rTgOePqM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I found another case when window-size-change-functions is not called: > it's when invoking winner-undo that restores a previous > window-configuration and where the same window has different > window sizes in prev/next window-configurations. Looks like 'set-window-configuration' doesn't trigger a call of 'window-size-change-functions' when it changes only the sizes of involved windows and no window was added or removed. I think I can fix that easily but in the context of Bug#32720 I'm afraid that most optimizations I tried to apply here are just void anyway. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 06 19:43:01 2020 Received: (at 32839) by debbugs.gnu.org; 7 Feb 2020 00:43:01 +0000 Received: from localhost ([127.0.0.1]:48755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izrjZ-0003CW-3M for submit@debbugs.gnu.org; Thu, 06 Feb 2020 19:43:01 -0500 Received: from bird.elm.relay.mailchannels.net ([23.83.212.17]:2910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izrjW-0003CL-R3; Thu, 06 Feb 2020 19:42:59 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 9E76C541366; Fri, 7 Feb 2020 00:42:57 +0000 (UTC) Received: from pdx1-sub0-mail-a28.g.dreamhost.com (100-96-1-6.trex.outbound.svc.cluster.local [100.96.1.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4DBEB54120B; Fri, 7 Feb 2020 00:42:57 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a28.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Fri, 07 Feb 2020 00:42:57 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Madly-Stretch: 0e849fef296cc2ec_1581036177373_1367028132 X-MC-Loop-Signature: 1581036177373:1543867932 X-MC-Ingress-Time: 1581036177373 Received: from pdx1-sub0-mail-a28.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a28.g.dreamhost.com (Postfix) with ESMTP id 15DF4817CE; Thu, 6 Feb 2020 16:42:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=EXoDT1CMRPLTG+KKvaC7zPMBGCE=; b= BvoEzBq9WLMpstvRsk4sWQe20Qw+zHjSyvR+77z4hpTuZ0XpPGCg7rRv0dhox7JS j0JwwHwOL1Rz/D6WkbYXdKbwqbaSG9S3kqZeURXPAY+s+3wUbVsNQMFGthqypvp8 YMq72/CdYeiHRHVvyMheZu6AvruAtAxxGlO//v9Fjw8= Received: from mail.jurta.org (m91-129-105-126.cust.tele2.ee [91.129.105.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a28.g.dreamhost.com (Postfix) with ESMTPSA id 24B36817C9; Thu, 6 Feb 2020 16:42:49 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a28 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#32839: 27.0.50; recenter doesn't redisplay Organization: LINKOV.NET References: <8736txjvkg.fsf@mail.linkov.net> <83lg7p8hnf.fsf@gnu.org> <87va6tb8lo.fsf@mail.linkov.net> <83k1n895qv.fsf@gnu.org> <87tvmbq2pp.fsf@mail.linkov.net> <835zyr8mn8.fsf@gnu.org> Date: Fri, 07 Feb 2020 02:30:48 +0200 In-Reply-To: <835zyr8mn8.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Sep 2018 09:44:43 +0300") Message-ID: <8736bn44sn.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrheeggddvhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddthedruddvieenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedruddviedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32839 Cc: 32839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 32839 wontfix close 32839 28.0.50 quit > Bottom line, I see no problem in the behavior described in this bug > report, and I think it should be closed. OK, closed. From unknown Mon Jun 16 23:43:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 06 Mar 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator