GNU bug report logs - #32836
emacs-magit is broken (and probably others) due to package renaming

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32836 in the body.
You can then email your comments to 32836 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: <bug-guix <at> gnu.org>
Cc: Pierre Neidhardt <mail <at> ambrevar.xyz>
Subject: emacs-magit is broken (and probably others) due to package renaming
Date: Tue, 25 Sep 2018 15:54:42 +0200

[Message part 1 (text/plain, inline)]

Commit

5c8031ff7382ec9079040d08ae5a05b4dd2352b7

mass-renamed emacs-packages from "foo" to "emacs-foo". Unfortunately,
some package definitions use the package-name for building the URL.
That is for example the case in emacs-magit:

(define-public emacs-magit
  (package
    (name "emacs-magit")
    (version "2.13.0")
    (source (origin
             (method url-fetch)
             (uri (string-append
                   "https://github.com/magit/magit/releases/download/"
                   version "/" name "-" version ".tar.gz"))

Thus, it can no longer be built:

Starting download of /gnu/store/h01ag9sr8nxiqbnlblmxplnv43a2005j-emacs-magit-2.13.0.tar.gz
From https://github.com/magit/magit/releases/download/2.13.0/emacs-magit-2.13.0.tar.gz...
ERROR: download failed "https://github.com/magit/magit/releases/download/2.13.0/emacs-magit-2.13.0.tar.gz" 404 "Not Found"

Pierre, could you have a look into it?

Thanks

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: bug-guix <at> gnu.org
Subject: Re: emacs-magit is broken (and probably others) due to package
 renaming
Date: Tue, 25 Sep 2018 17:04:39 +0200

[Message part 1 (text/plain, inline)]

Oopsy, missed that indeed! xD
Sorry for the trouble, will fix as soon as possible.

By the way, I think using "name" for URLs is a bad practice, we only need
"version" there.  What do you people think?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 32836 <at> debbugs.gnu.org (full text, mbox):

From: Taylan Kammer <taylanbayirli <at> gmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 32836 <at> debbugs.gnu.org
Subject: Re: bug#32836: emacs-magit is broken (and probably others) due to
 package renaming
Date: Tue, 25 Sep 2018 21:29:51 +0200

Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> Oopsy, missed that indeed! xD
> Sorry for the trouble, will fix as soon as possible.
>
> By the way, I think using "name" for URLs is a bad practice, we only need
> "version" there.  What do you people think?

I agree.  Whenever I've seen 'name' being used in URL definitions in the
past I wondered what the point is, since our naming doesn't necessarily
align with the name of the file to be downloaded.

Taylan

Message #14 received at 32836 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Taylan Kammer <taylanbayirli <at> gmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 32836 <at> debbugs.gnu.org
Subject: Re: bug#32836: emacs-magit is broken (and probably others) due to
 package renaming
Date: Tue, 25 Sep 2018 19:58:04 +0200

[Message part 1 (text/plain, inline)]

OK, I'll add this recommendation to the Guix packaging tutorial.

I've pushed the fix upstream.  Only magit and groovy-modes were affected.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 32836 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 32836 <at> debbugs.gnu.org
Subject: Re: bug#32836: emacs-magit is broken (and probably others) due to
 package renaming
Date: Wed, 26 Sep 2018 01:23:19 +0300

Pierre Neidhardt (2018-09-25 17:04 +0200) wrote:

> Oopsy, missed that indeed! xD
> Sorry for the trouble, will fix as soon as possible.
>
> By the way, I think using "name" for URLs is a bad practice, we only need
> "version" there.  What do you people think?

I totally agree!  I don't like this practice very much.

-- 
Alex

Message #22 received at 32836-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: Björn Höfling
 <bjoern.hoefling <at> bjoernhoefling.de>, Taylan Kammer <taylanbayirli <at> gmail.com>,
 32836-done <at> debbugs.gnu.org
Subject: Re: bug#32836: emacs-magit is broken (and probably others) due to
 package renaming
Date: Wed, 26 Sep 2018 11:38:02 +0200

Pierre Neidhardt <mail <at> ambrevar.xyz> skribis:

> OK, I'll add this recommendation to the Guix packaging tutorial.

Sounds good.

> I've pushed the fix upstream.  Only magit and groovy-modes were affected.

Thanks for the quick fix!

Ludo’.

Message #25 received at 32836 <at> debbugs.gnu.org (full text, mbox):

From: Nils Gillmann <ng0 <at> n0.is>
To: Alex Kost <alezost <at> gmail.com>
Cc: 32836 <at> debbugs.gnu.org, Pierre Neidhardt <mail <at> ambrevar.xyz>
Subject: Re: bug#32836: emacs-magit is broken (and probably others) due to
 package renaming
Date: Wed, 26 Sep 2018 16:21:20 +0000

Alex Kost transcribed 331 bytes:
> Pierre Neidhardt (2018-09-25 17:04 +0200) wrote:
> 
> > Oopsy, missed that indeed! xD
> > Sorry for the trouble, will fix as soon as possible.
> >
> > By the way, I think using "name" for URLs is a bad practice, we only need
> > "version" there.  What do you people think?
> 
> I totally agree!  I don't like this practice very much.
> 
> -- 
> Alex
> 
> 
> 

Very often the name we use, except for language specific packages, is the same
as upstream uses. "name" can be shorter than "whatever-long-name".

Message #28 received at 32836 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Nils Gillmann <ng0 <at> n0.is>
Cc: 32836 <at> debbugs.gnu.org, Alex Kost <alezost <at> gmail.com>
Subject: Re: bug#32836: emacs-magit is broken (and probably others) due to
 package renaming
Date: Wed, 26 Sep 2018 19:05:39 +0200

[Message part 1 (text/plain, inline)]

> Very often the name we use, except for language specific packages, is the same
> as upstream uses. "name" can be shorter than "whatever-long-name".

It often works, but at the cost of raising issues like this thread.
I think it's more important to make the URL reliable than to make it short :)

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 32836 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 32836 <at> debbugs.gnu.org
Subject: Re: bug#32836: emacs-magit is broken (and probably others) due to
 package renaming
Date: Thu, 27 Sep 2018 00:37:25 +0200

[Message part 1 (text/plain, inline)]

On Tue, 25 Sep 2018 19:58:04 +0200
Pierre Neidhardt <mail <at> ambrevar.xyz> wrote:

> OK, I'll add this recommendation to the Guix packaging tutorial.
> 
> I've pushed the fix upstream.  Only magit and groovy-modes were
> affected.
> 

Looks good. Thanks for fixing!

Björn

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.