GNU bug report logs - #32828
27.0.50; Docstring of `dbus-init-bus' incorrect

Previous Next

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Philipp <p.stephani2 <at> gmail.com>
Cc: 32828 <at> debbugs.gnu.org
Subject: bug#32828: 27.0.50; Docstring of `dbus-init-bus' incorrect
Date: Tue, 25 Sep 2018 11:33:38 +0200

Philipp <p.stephani2 <at> gmail.com> writes:

Hi Philipp,

> The docstring of `dbus-init-bus' says:
>
>> The function returns a number, which counts the connections this Emacs
>> session has established to the BUS under the same unique name
>
> However:
>
> (dbus-init-bus :system)
>
> ==> ((:signal :system "org.freedesktop.DBus.Local" "Disconnected") (nil "/org/freedesktop/DBus/Local" dbus-handle-bus-disconnect))
>
> Looking at the definition of `dbus-init-bus', it seems that only a
> `prog1' form is missing to make the docstring correct:
>
>   (prog1 (dbus--init-bus ...) (dbus-register-signal ...))

Indeed. dbus--init-bus keeps the original implementation of dbus-init-bus.
It would be safe to apply this patch even to the emacs-26 branch, IMHO.

Eli?

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.