Subject: Re: [bug#32813] [PATCH 3/4] gnu: Add osm2pgsql.

From: Björn Höfling <[email-masked]>
Date: Tue, 25 Sep 2018 19:37:40 +0200

On Sun, 23 Sep 2018 22:43:10 +0200
Julien Lepiller <[email-masked]> wrote:

> * gnu/packages/geo.scm (osm2pgsql): New variable.
> ---
>  gnu/packages/geo.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
> index 81bffcc88..efc68ea85 100644
> --- a/gnu/packages/geo.scm
> +++ b/gnu/packages/geo.scm
> @@ -824,3 +824,33 @@ delivered to any client.")
>  files and imports the data into PostgreSQL/PostGIS databases.  It is
> designed to create databases that are optimized for
> rendering/tile/map-services.") (license license:asl2.0)))
> +
> +(define-public osm2pgsql
> +  (package
> +    (name "osm2pgsql")
> +    (version "0.96.0")

[..]

> +    (license license:gpl2)))

Hm. 
The COPYING file says gpl2.
The README is saying nothing about the license. A LICENSE file is
missing.
Most .cpp/.h files do not have a header and do not clarify it.
But these 3 do:

./parse-osmium.cpp: *No copyright* GPL (v2 or later)
./parse-osmium.hpp: *No copyright* GPL (v2 or later)
./tests/test-options-projection.cpp: GPL (v2 or later)

Is this (list gpl2 gpl2+) ?!

Found more:

./contrib/protozero/LICENSE.from_folly: *No copyright* Apache License (v2.0)
./contrib/protozero/LICENSE.md: BSD 2-clause "Simplified" License
./contrib/libosmium/osmium/*: BSL

Does it make sense/have you tried to
unbundle protozero and libosmonium:

https://github.com/mapbox/protozero
https://github.com/osmcode/libosmium

Either unbundle or add to copyright line.

Missing import:

  #:use-module (gnu packages lua)

Otherwise, LGTM

Thanks,

Björn

-- 
Dipl.-Inf. Björn Höfling
Software Developer (GIS, Java)
http://www.bjoernhoefling.de/
+49-176-666 875 06
USt-IdNr: DE275885245