GNU bug report logs - #32809
[PATCH 0/1] import: hackage: Do not repeat inputs in native-inputs.

Previous Next

Package: guix-patches;

Reported by: Arun Isaac <arunisaac <at> systemreboot.net>

Date: Sat, 22 Sep 2018 17:20:01 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32809: closed ([PATCH 0/1] import: hackage: Do not repeat
 inputs in native-inputs.)
Date: Sun, 28 Oct 2018 09:17:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 28 Oct 2018 14:46:00 +0530
with message-id <cu7efcao2i7.fsf <at> systemreboot.net>
and subject line Re: [bug#32809] [PATCH 1/1] import: hackage: Do not repeat inputs in native-inputs.
has caused the debbugs.gnu.org bug report #32809,
regarding [PATCH 0/1] import: hackage: Do not repeat inputs in native-inputs.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32809: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32809
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 0/1] import: hackage: Do not repeat inputs in native-inputs.
Date: Sat, 22 Sep 2018 22:48:48 +0530
Tha hackage importer lists packages in native-inputs even if they have already
been listed in inputs. This should not be. The following patch fixes this.

As an illustration of what I mean, look at the difference when importing the
hackage package test-framework with and without this patch applied.

Arun Isaac (1):
  import: hackage: Do not repeat inputs in native-inputs.

 guix/import/hackage.scm | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

-- 
2.19.0



[Message part 3 (message/rfc822, inline)]
From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 32809-done <at> debbugs.gnu.org
Subject: Re: [bug#32809] [PATCH 1/1] import: hackage: Do not repeat inputs in
 native-inputs.
Date: Sun, 28 Oct 2018 14:46:00 +0530
> In short: the patch looks good to me.

Pushed, thanks!


This bug report was last modified 6 years and 259 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.