GNU bug report logs - #32802
[PATCH] gnu: gnucash: Update to 3.2.

Previous Next

Full log

Message #11 received at 32802 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 32802 <at> debbugs.gnu.org
Subject: Re: [bug#32802] [PATCH] gnu: gnucash: Update to 3.2.
Date: Fri, 05 Oct 2018 13:43:38 -0400

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hello,
>
> Kei Kebreau <kkebreau <at> posteo.net> skribis:
>
>> * gnu/packages/patches/gnucash-disable-failing-tests.patch: New file.
>> * gnu/local.mk (dist_patch_DATA): Register it.
>> * gnu/packages/gnucash.scm (gnucash): Update to 3.2.
>> [source]: Add patch.
>> [arguments]: Add 'glib-or-gtk-compile-schemas' and 'glib-or-gtk-wrap' phases..
>
> [...]
>
>> --- /dev/null
>> +++ b/gnu/packages/patches/gnucash-disable-failing-tests.patch
>> @@ -0,0 +1,39 @@
>> +diff -ur gnucash-3.2.old/libgnucash/backend/xml/test/CMakeLists.txt
>> gnucash-3.2/libgnucash/backend/xml/test/CMakeLists.txt
>> +--- gnucash-3.2.old/libgnucash/backend/xml/test/CMakeLists.txt
>> 2018-09-16 22:07:42.445865806 -0400
>> ++++ gnucash-3.2/libgnucash/backend/xml/test/CMakeLists.txt
>> 2018-09-16 22:08:29.246608711 -0400
>
> Please add couple of lines at the top explaining what the patch does and
> roughly what the problem is with these tests.
>

Done!

>> +-gnc_add_test(test-gnc-timezone "${test_gnc_timezone_SOURCES}"
>> +-  gtest_engine_INCLUDES gtest_old_engine_LIBS)
>
> Could it be that you need ‘tzdata-for-tests’ as an input, with TZDIR set
> accordingly?
>

Yes, this fixed the "test-real-data" test.

> Otherwise LGTM, thanks!
>
> Ludo’.

Pushed to master with the newly-released GnuCash 3.3!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.