GNU bug report logs - #32800
t/silent-custom fails for certain parent directory sequences

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mike Frysinger <vapier <at> gentoo.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32800: closed (t/silent-custom fails for certain parent
 directory sequences)
Date: Thu, 24 Feb 2022 05:58:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 24 Feb 2022 00:57:01 -0500
with message-id <20220224055701.23375-1-vapier <at> gentoo.org>
and subject line [PATCH/committed] tests: make silent-custom regex a little more robust
has caused the debbugs.gnu.org bug report #32800,
regarding t/silent-custom fails for certain parent directory sequences
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32800: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32800
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Frank Schaefer <kelledin <at> gmail.com>
To: bug-automake <at> gnu.org
Subject: t/silent-custom fails for certain parent directory sequences
Date: Fri, 21 Sep 2018 19:38:13 -0500

I just discovered that t/silent-custom can fail if any parent of the
build directory matches the "[012]\.h" regex.  Specifically, the 'grep
'[012]\.h' output && exit 1' command triggers a test failure.

(If you're wondering, one of my CI build-boxes just happened to kick
off a build in a '/var/tmp/.build.automake_1.16.1-0.hzA5PJ' tmpdir.)

Maybe refine this regex to " sub/[012]\.h"?

[Message part 3 (message/rfc822, inline)]

From: Mike Frysinger <vapier <at> gentoo.org>
To: 32800-done <at> debbugs.gnu.org
Subject: [PATCH/committed] tests: make silent-custom regex a little more robust
Date: Thu, 24 Feb 2022 00:57:01 -0500

Fixes automake bug https://bugs.gnu.org/32800.

Have the regex match the entire path with word boundaries on both
sides.  This should reduce false positives when the full cwd happens
to match parent directories.

* t/silent-custom.sh: Update the header output regex.
---
 t/silent-custom.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/silent-custom.sh b/t/silent-custom.sh
index 01cf464b99eb..977255b1312e 100644
--- a/t/silent-custom.sh
+++ b/t/silent-custom.sh
@@ -74,7 +74,7 @@ do_check ()
     $FGREP 'cp ' output && exit 1
     $FGREP 'generate-header' output && exit 1
     $FGREP 'rm -f' output && exit 1
-    grep '[012]\.h' output && exit 1
+    grep '\bsub/[012]\.h\b' output && exit 1
     grep '^ XGEN    foo$' output
     grep '^ GEN     \[headers\]$' output
   else
-- 
2.34.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.