From unknown Thu Aug 14 21:56:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32800: t/silent-custom fails for certain parent directory sequences Resent-From: Frank Schaefer Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 22 Sep 2018 00:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32800 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 32800@debbugs.gnu.org X-Debbugs-Original-To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15375769923070 (code B ref -1); Sat, 22 Sep 2018 00:44:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Sep 2018 00:43:12 +0000 Received: from localhost ([127.0.0.1]:48537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3W0t-0000nQ-OY for submit@debbugs.gnu.org; Fri, 21 Sep 2018 20:43:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3VwP-0000fu-8q for submit@debbugs.gnu.org; Fri, 21 Sep 2018 20:38:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3VwJ-0002rP-9k for submit@debbugs.gnu.org; Fri, 21 Sep 2018 20:38:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44465) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g3VwJ-0002rJ-6q for submit@debbugs.gnu.org; Fri, 21 Sep 2018 20:38:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3VwI-0001SG-9m for bug-automake@gnu.org; Fri, 21 Sep 2018 20:38:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3VwH-0002qb-Ls for bug-automake@gnu.org; Fri, 21 Sep 2018 20:38:26 -0400 Received: from mail-it1-x12c.google.com ([2607:f8b0:4864:20::12c]:35251) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g3VwH-0002oO-GZ for bug-automake@gnu.org; Fri, 21 Sep 2018 20:38:25 -0400 Received: by mail-it1-x12c.google.com with SMTP id 139-v6so4067730itf.0 for ; Fri, 21 Sep 2018 17:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=oRpi1dMt9Zo8h08Ixde7T+n3H7S2tRYNstoydBZ2FZE=; b=d9Z+FOaDgjIVgb4L8Bibgfq4r8118Po/GEOmjdnrNG7xx9oeznDmnsaidExl8byLpR gaLqpFh4e3a4rL+v96WdEff6bGTtGvja3vIU+NGuoengOr5OaAPT1RUFscFN+5GvzKZ9 IoZ8cEZYzXjqmUJEK7HTPWauckc0hqUHkRcUXlxc/BNU6cfFyfbBD7c4nZZTOp3pESoY 9Bffn2qCRdlUVy9Prw+cwYAB8DfMii7jCLaw1FelQY5d8o4i2g9AmBKS3hwQv6ORqn15 xeVe/Kl48M+SN1tkkyuMzldv/EkKFr+WNqIXkF8HK5F9bpcDKud4uW8DmLf+2gC7HJjJ 9CMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=oRpi1dMt9Zo8h08Ixde7T+n3H7S2tRYNstoydBZ2FZE=; b=ZvISJIktouUH2TsUSIEtqCrpugB5nfWNIElCeURR+uDZhowiehP+190d3eyAXz6jWh mozMj9p5NikMkcXQWKmixXhjYkRkwTuEb2p6S1vnMEzegLc49E4D9ICmGp6ZqUzhf8/Y 1AMe/JnIZNu184Dp04HYIdSRNrKfF/J9BurEkCnpY7hwlglPevvbY0x2irxSyYJ1bze3 kq4mFv49nzwovzw2Ah5DicTetQHEzKmdTriLo7GiTcgsBbimrEXWgMCFSP2Nyrv3L1jJ dSK3DrEuvWKHZA++dZmpeY5EvByG8PVap5nafJjWupX5Mv6Drp4u4lLNjrUPNQ9UJFlQ hZ2Q== X-Gm-Message-State: APzg51DzDo+NFWhfjq8XBw+tZpZ+r5jIFmK69zJYdkDAfRee6jZWKBXL U+bAEbifF7cj96fOMjX0aWELrwQEPw6HHog9xye0HdTS X-Google-Smtp-Source: ANB0VdaRciulXAy2fnIawXN2zy97lxqUAHH84ydJh2KZtyWuC132MXYQgcbj/ISnY0K/Hn6Px3eMpzOAwjrvgpWgjEE= X-Received: by 2002:a24:c741:: with SMTP id t62-v6mr99942itg.88.1537576704165; Fri, 21 Sep 2018 17:38:24 -0700 (PDT) MIME-Version: 1.0 From: Frank Schaefer Date: Fri, 21 Sep 2018 19:38:13 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Fri, 21 Sep 2018 20:43:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I just discovered that t/silent-custom can fail if any parent of the build directory matches the "[012]\.h" regex. Specifically, the 'grep '[012]\.h' output && exit 1' command triggers a test failure. (If you're wondering, one of my CI build-boxes just happened to kick off a build in a '/var/tmp/.build.automake_1.16.1-0.hzA5PJ' tmpdir.) Maybe refine this regex to " sub/[012]\.h"? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 00:57:02 2022 Received: (at control) by debbugs.gnu.org; 24 Feb 2022 05:57:02 +0000 Received: from localhost ([127.0.0.1]:47224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN77e-0005zD-Dz for submit@debbugs.gnu.org; Thu, 24 Feb 2022 00:57:02 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:39474 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN77c-0005yg-PH for control@debbugs.gnu.org; Thu, 24 Feb 2022 00:57:01 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 1E852342CAC; Thu, 24 Feb 2022 05:56:55 +0000 (UTC) From: Mike Frysinger To: control@debbugs.gnu.org Subject: Control message Message-Id: <20220224055655.1E852342CAC@smtp.gentoo.org> Date: Thu, 24 Feb 2022 05:56:54 +0000 (UTC) X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) tag 32800 = confirmed thankyou From unknown Thu Aug 14 21:56:16 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Frank Schaefer Subject: bug#32800: closed ([PATCH/committed] tests: make silent-custom regex a little more robust) Message-ID: References: <20220224055701.23375-1-vapier@gentoo.org> X-Gnu-PR-Message: they-closed 32800 X-Gnu-PR-Package: automake X-Gnu-PR-Keywords: confirmed Reply-To: 32800@debbugs.gnu.org Date: Thu, 24 Feb 2022 05:58:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1645682282-23121-1" This is a multi-part message in MIME format... ------------=_1645682282-23121-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #32800: t/silent-custom fails for certain parent directory sequences which was filed against the automake package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 32800@debbugs.gnu.org. --=20 32800: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32800 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1645682282-23121-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 32800-done) by debbugs.gnu.org; 24 Feb 2022 05:57:10 +0000 Received: from localhost ([127.0.0.1]:47227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN77l-0005zW-Lr for submit@debbugs.gnu.org; Thu, 24 Feb 2022 00:57:09 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:39492 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nN77i-0005yu-QS for 32800-done@debbugs.gnu.org; Thu, 24 Feb 2022 00:57:07 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 3CA12342CA9; Thu, 24 Feb 2022 05:57:01 +0000 (UTC) From: Mike Frysinger To: 32800-done@debbugs.gnu.org Subject: [PATCH/committed] tests: make silent-custom regex a little more robust Date: Thu, 24 Feb 2022 00:57:01 -0500 Message-Id: <20220224055701.23375-1-vapier@gentoo.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32800-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Fixes automake bug https://bugs.gnu.org/32800. Have the regex match the entire path with word boundaries on both sides. This should reduce false positives when the full cwd happens to match parent directories. * t/silent-custom.sh: Update the header output regex. --- t/silent-custom.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/silent-custom.sh b/t/silent-custom.sh index 01cf464b99eb..977255b1312e 100644 --- a/t/silent-custom.sh +++ b/t/silent-custom.sh @@ -74,7 +74,7 @@ do_check () $FGREP 'cp ' output && exit 1 $FGREP 'generate-header' output && exit 1 $FGREP 'rm -f' output && exit 1 - grep '[012]\.h' output && exit 1 + grep '\bsub/[012]\.h\b' output && exit 1 grep '^ XGEN foo$' output grep '^ GEN \[headers\]$' output else -- 2.34.1 ------------=_1645682282-23121-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Sep 2018 00:43:12 +0000 Received: from localhost ([127.0.0.1]:48537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3W0t-0000nQ-OY for submit@debbugs.gnu.org; Fri, 21 Sep 2018 20:43:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3VwP-0000fu-8q for submit@debbugs.gnu.org; Fri, 21 Sep 2018 20:38:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3VwJ-0002rP-9k for submit@debbugs.gnu.org; Fri, 21 Sep 2018 20:38:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44465) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g3VwJ-0002rJ-6q for submit@debbugs.gnu.org; Fri, 21 Sep 2018 20:38:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3VwI-0001SG-9m for bug-automake@gnu.org; Fri, 21 Sep 2018 20:38:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3VwH-0002qb-Ls for bug-automake@gnu.org; Fri, 21 Sep 2018 20:38:26 -0400 Received: from mail-it1-x12c.google.com ([2607:f8b0:4864:20::12c]:35251) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g3VwH-0002oO-GZ for bug-automake@gnu.org; Fri, 21 Sep 2018 20:38:25 -0400 Received: by mail-it1-x12c.google.com with SMTP id 139-v6so4067730itf.0 for ; Fri, 21 Sep 2018 17:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=oRpi1dMt9Zo8h08Ixde7T+n3H7S2tRYNstoydBZ2FZE=; b=d9Z+FOaDgjIVgb4L8Bibgfq4r8118Po/GEOmjdnrNG7xx9oeznDmnsaidExl8byLpR gaLqpFh4e3a4rL+v96WdEff6bGTtGvja3vIU+NGuoengOr5OaAPT1RUFscFN+5GvzKZ9 IoZ8cEZYzXjqmUJEK7HTPWauckc0hqUHkRcUXlxc/BNU6cfFyfbBD7c4nZZTOp3pESoY 9Bffn2qCRdlUVy9Prw+cwYAB8DfMii7jCLaw1FelQY5d8o4i2g9AmBKS3hwQv6ORqn15 xeVe/Kl48M+SN1tkkyuMzldv/EkKFr+WNqIXkF8HK5F9bpcDKud4uW8DmLf+2gC7HJjJ 9CMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=oRpi1dMt9Zo8h08Ixde7T+n3H7S2tRYNstoydBZ2FZE=; b=ZvISJIktouUH2TsUSIEtqCrpugB5nfWNIElCeURR+uDZhowiehP+190d3eyAXz6jWh mozMj9p5NikMkcXQWKmixXhjYkRkwTuEb2p6S1vnMEzegLc49E4D9ICmGp6ZqUzhf8/Y 1AMe/JnIZNu184Dp04HYIdSRNrKfF/J9BurEkCnpY7hwlglPevvbY0x2irxSyYJ1bze3 kq4mFv49nzwovzw2Ah5DicTetQHEzKmdTriLo7GiTcgsBbimrEXWgMCFSP2Nyrv3L1jJ dSK3DrEuvWKHZA++dZmpeY5EvByG8PVap5nafJjWupX5Mv6Drp4u4lLNjrUPNQ9UJFlQ hZ2Q== X-Gm-Message-State: APzg51DzDo+NFWhfjq8XBw+tZpZ+r5jIFmK69zJYdkDAfRee6jZWKBXL U+bAEbifF7cj96fOMjX0aWELrwQEPw6HHog9xye0HdTS X-Google-Smtp-Source: ANB0VdaRciulXAy2fnIawXN2zy97lxqUAHH84ydJh2KZtyWuC132MXYQgcbj/ISnY0K/Hn6Px3eMpzOAwjrvgpWgjEE= X-Received: by 2002:a24:c741:: with SMTP id t62-v6mr99942itg.88.1537576704165; Fri, 21 Sep 2018 17:38:24 -0700 (PDT) MIME-Version: 1.0 From: Frank Schaefer Date: Fri, 21 Sep 2018 19:38:13 -0500 Message-ID: Subject: t/silent-custom fails for certain parent directory sequences To: bug-automake@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 21 Sep 2018 20:43:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I just discovered that t/silent-custom can fail if any parent of the build directory matches the "[012]\.h" regex. Specifically, the 'grep '[012]\.h' output && exit 1' command triggers a test failure. (If you're wondering, one of my CI build-boxes just happened to kick off a build in a '/var/tmp/.build.automake_1.16.1-0.hzA5PJ' tmpdir.) Maybe refine this regex to " sub/[012]\.h"? ------------=_1645682282-23121-1--