From unknown Mon Aug 18 11:15:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#32795 <32795@debbugs.gnu.org> To: bug#32795 <32795@debbugs.gnu.org> Subject: Status: 26.1; provided-mode-derived-p does not support parent modes set with defalias Reply-To: bug#32795 <32795@debbugs.gnu.org> Date: Mon, 18 Aug 2025 18:15:16 +0000 retitle 32795 26.1; provided-mode-derived-p does not support parent modes s= et with defalias reassign 32795 emacs submitter 32795 Andrew Schwartzmeyer severity 32795 minor tag 32795 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 21 11:21:20 2018 Received: (at submit) by debbugs.gnu.org; 21 Sep 2018 15:21:20 +0000 Received: from localhost ([127.0.0.1]:48350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3NFA-0003Bs-1k for submit@debbugs.gnu.org; Fri, 21 Sep 2018 11:21:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3Fl5-0003yb-CL for submit@debbugs.gnu.org; Fri, 21 Sep 2018 03:21:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3Fkz-0004Ec-EL for submit@debbugs.gnu.org; Fri, 21 Sep 2018 03:21:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45606) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g3Fkz-0004EN-A8 for submit@debbugs.gnu.org; Fri, 21 Sep 2018 03:21:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3Fky-0002Bv-15 for bug-gnu-emacs@gnu.org; Fri, 21 Sep 2018 03:21:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3Fkt-00049u-4U for bug-gnu-emacs@gnu.org; Fri, 21 Sep 2018 03:21:39 -0400 Received: from mout02.posteo.de ([185.67.36.142]:56589) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g3Fks-00046o-LW for bug-gnu-emacs@gnu.org; Fri, 21 Sep 2018 03:21:35 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id AC495210D9 for ; Fri, 21 Sep 2018 09:21:31 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 42GlQK6LbTz9rxD for ; Fri, 21 Sep 2018 09:21:29 +0200 (CEST) From: Andrew Schwartzmeyer To: bug-gnu-emacs@gnu.org Subject: 26.1; provided-mode-derived-p does not support parent modes set with defalias Date: Fri, 21 Sep 2018 00:20:48 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 21 Sep 2018 11:21:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The actual bug was that I expected was for `TODO` to be highlighted in a `CMakeLists.txt` file. Normally this is done by `global-hl-todo-mode`, which is activated for all modes derived from `prog-mode`. However, `cmake-mode` is derived from `cmake--parent-mode` which is set like this: ;; For compatibility with Emacs < 24 (defalias 'cmake--parent-mode (if (fboundp 'prog-mode) 'prog-mode 'fundamental-mode)) After researching, I found multiple packages that set the parent mode like this, using `prog-mode` when it's available. So with Emacs 26.1, `cmake-mode` definitely derives from `prog-mode`, but the function that `hl-todo-mode` uses to check this, `derived-mode-p`, does not handle `defalias` correctly. The `hl-todo-mode` logic is: (defcustom hl-todo-activate-in-modes '(prog-mode) ...) (defun hl-todo--turn-on-mode-if-desired () (when (apply #'derived-mode-p hl-todo-activate-in-modes) (hl-todo-mode 1))) If this was working as expected, it would see `cmake-mode` as derived from `prog-mode`, and therefore highlight the `TODO`, but it does not. I was able to make a minimal repro as follows: ;; Broken behavior (seen in cmake-mode.el and groovy-mode.el): (defalias 'alias-parent-mode (if (fboundp 'prog-mode) 'prog-mode 'fundamental-mode)) (define-derived-mode alias-mode alias-parent-mode "Test") ;; Should print `prog-mode', but prints `alias-parent-mode' (message "Aliased derived: %s" (provided-mode-derived-p 'alias-mode 'prog-mode)) ;; Existing working behavior: (define-derived-mode test-mode prog-mode "Test") ;; Correctly prints `prog-mode' (message "Directly derived: %s" (provided-mode-derived-p 'test-mode 'prog-mode)) After looking at `derived-mode-p`, I followed it to `provided-mode-derived-p`, and I would like to propose the following patch to it (with an appropriate added commit message): --- lisp/subr.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lisp/subr.el b/lisp/subr.el index 9e880bc88..a35734812 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -1922,7 +1922,11 @@ Only affects hooks run in the current buffer." Uses the `derived-mode-parent' property of the symbol to trace backwards. If you just want to check `major-mode', use `derived-mode-p'." (while (and (not (memq mode modes)) - (setq mode (get mode 'derived-mode-parent)))) + (let ((parent (get mode 'derived-mode-parent))) + (let ((parentfn (symbol-function parent))) + (setq mode (if (and parentfn (symbolp parentfn)) + parentfn + parent)))))) mode) (defun derived-mode-p (&rest modes) -- This is kind of similar to the logic used by https://github.com/Fanael/parent-mode/blob/master/parent-mode.el, except (a) I wrote it originally, and (b) their implementation is recursive, while I've kept `provided-mode-derived-p` iterative. After testing, this fixes my original bug, and has not appeared to cause unexpected behavior. It possibly fixes other bugs, anything that expected to accurately deduce the parent of a derived mode. Thanks, Andy P.S. Thanks molloy on #emacs for your help when looking at this. Emacs Version(s): In GNU Emacs 26.1 (build 1, x86_64-apple-darwin14.5.0, NS appkit-1348.17 Version 10.10.5 (Build 14F2511)) of 2018-05-30 built on builder10-10.porkrind.org Also exhibited on Emacs 26.1 on Linux From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 24 22:36:26 2018 Received: (at 32795) by debbugs.gnu.org; 25 Sep 2018 02:36:26 +0000 Received: from localhost ([127.0.0.1]:52648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4dD8-0001l0-7B for submit@debbugs.gnu.org; Mon, 24 Sep 2018 22:36:26 -0400 Received: from mout01.posteo.de ([185.67.36.141]:51639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4dD6-0001kk-0C for 32795@debbugs.gnu.org; Mon, 24 Sep 2018 22:36:24 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 414B921099 for <32795@debbugs.gnu.org>; Tue, 25 Sep 2018 04:36:18 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 42K4vP55Z5z6tm5 for <32795@debbugs.gnu.org>; Tue, 25 Sep 2018 04:36:17 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 24 Sep 2018 19:36:11 -0700 From: Andrew Schwartzmeyer To: 32795@debbugs.gnu.org Subject: Re: bug#32795: Acknowledgement (26.1; provided-mode-derived-p does not support parent modes set with defalias) In-Reply-To: References: Message-ID: <2ee9d7be53e24d69a1fce4efb6333e71@posteo.net> X-Sender: andrew@schwartzmeyer.com User-Agent: Posteo Webmail X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 32795 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi all, I actually just found _another_ scenario that breaks due to this. I was editing a Jenkinsfile (groovy-mode) and expecting dtrt-indent to automatically adjust the indent, but it was not. Turns out it's the same reason again! https://github.com/jscheid/dtrt-indent/blob/e860db7235147ed5ac1fd8f12b51dbb7cf2e75f1/dtrt-indent.el#L207 (define-globalized-minor-mode dtrt-indent-global-mode dtrt-indent-mode (lambda () (when (derived-mode-p 'prog-mode 'text-mode) (dtrt-indent-mode)))) The check `(derived-mode-p 'prog-mode 'text-mode)` returns nil, because the mode that groovy-mode derived from is set up like this: (defalias 'groovy-parent-mode (if (fboundp 'prog-mode) 'prog-mode 'fundamental-mode)) Using this for `provided-mode-derived-p` fixes it: (defun provided-mode-derived-p (mode &rest modes) "Non-nil if MODE is derived from one of MODES. Uses the `derived-mode-parent' property of the symbol to trace backwards. If you just want to check `major-mode', use `derived-mode-p'." (while (and (not (memq mode modes)) (let* ((parent (get mode 'derived-mode-parent)) (parentfn (symbol-function parent))) (setq mode (if (and parentfn (symbolp parentfn)) parentfn parent))))) mode) Thanks Robert Pluim for the `let*` trick, I was wondering how you do that without nesting `let` expressions. Does anyone have other suggestions before I send a patch file? Thanks, Andy On 09/21/2018 8:22 am, help-debbugs@gnu.org wrote: > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > Your message has been sent to the package maintainer(s): > bug-gnu-emacs@gnu.org > > If you wish to submit further information on this problem, please > send it to 32795@debbugs.gnu.org. > > Please do not send mail to help-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 25 00:16:04 2018 Received: (at 32795) by debbugs.gnu.org; 25 Sep 2018 04:16:04 +0000 Received: from localhost ([127.0.0.1]:52700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4elW-0004Tv-Vc for submit@debbugs.gnu.org; Tue, 25 Sep 2018 00:16:03 -0400 Received: from mout01.posteo.de ([185.67.36.141]:42211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4elV-0004TE-1m for 32795@debbugs.gnu.org; Tue, 25 Sep 2018 00:16:01 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 23C1220F5B for <32795@debbugs.gnu.org>; Tue, 25 Sep 2018 06:15:28 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 42K75r2kTCz6tm9 for <32795@debbugs.gnu.org>; Tue, 25 Sep 2018 06:15:28 +0200 (CEST) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_8c303201c1c8c6a31c646fa1c9255fac" Date: Mon, 24 Sep 2018 21:15:28 -0700 From: Andrew Schwartzmeyer To: 32795@debbugs.gnu.org Subject: Re: bug#32795: Acknowledgement (26.1; provided-mode-derived-p does not support parent modes set with defalias) In-Reply-To: References: Message-ID: <6ab54491416605d957ece9ee6154a6a5@posteo.net> X-Sender: andrew@schwartzmeyer.com User-Agent: Posteo Webmail X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 32795 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=_8c303201c1c8c6a31c646fa1c9255fac Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Patch with tests attached. Please let me know if I missed anything, or if the code could be improved. I read through CONTRIBUTE and may have accidentally sent this patch in as a new bug report, sorry! This was generated from 'emacs-26' where the bug occurs, and will merge just fine into 'master'. The bug also exists on 'emacs-25' but the code is slightly different ('provided-mode-derived-p' had not been extracted yet from 'derived-mode-p'). I can supply a back-ported patch as well. Thanks, Andy On 09/21/2018 8:22 am, help-debbugs@gnu.org wrote: > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > Your message has been sent to the package maintainer(s): > bug-gnu-emacs@gnu.org > > If you wish to submit further information on this problem, please > send it to 32795@debbugs.gnu.org. > > Please do not send mail to help-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. --=_8c303201c1c8c6a31c646fa1c9255fac Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Fix-provided-mode-derived-p-when-the-parent-is-an-al.patch Content-Disposition: attachment; filename=0001-Fix-provided-mode-derived-p-when-the-parent-is-an-al.patch; size=2833 RnJvbSBmMzlkN2YyYjVlOTJlMDg1OTI3OTE4Y2Y0ZjlkYTRiYThkZjhmMzY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgU2Nod2FydHptZXllciA8YW5kcmV3QHNjaHdhcnR6 bWV5ZXIuY29tPgpEYXRlOiBGcmksIDIxIFNlcCAyMDE4IDAwOjEwOjQ3IC0wNzAwClN1YmplY3Q6 IFtQQVRDSF0gRml4ICdwcm92aWRlZC1tb2RlLWRlcml2ZWQtcCcgd2hlbiB0aGUgcGFyZW50IGlz IGFuIGFsaWFzCgpBdXRob3JzIG9mIEVtYWNzIHBhY2thZ2VzIG9mdGVuIGRlcml2ZSBmcm9tIGFu IGFsaWFzIG9mIGEgbW9kZSBpbnN0ZWFkCm9mIHRoZSBtb2RlIGRpcmVjdGx5LiAgVGhpcyBpcyBl c3BlY2lhbGx5IHRoZSBjYXNlIHdoZW4gZGVyaXZpbmcgZnJvbQoncHJvZy1tb2RlJyBhcyBpdCBp cyByZWxhdGl2ZWx5IG5ldy4gIFVuZm9ydHVuYXRlbHksIHVzaW5nCidkZXJpdmVkLW1vZGUtcCcg dG8gY2hlY2sgaWYgc29tZSBtb2RlIGlzIGRlcml2ZWQgZnJvbSBhbiBhbGlhcyBvZgoncHJvZy1t b2RlJyBkb2VzIG5vdCB3b3JrIGFzIGV4cGVjdGVkLiAgVGhlIGJ1ZyBpcyB0aGF0Cidwcm92aWRl ZC1tb2RlLWRlcml2ZWQtcCcgc2hvdWxkIG5vdCBvbmx5IHJldHVybiBub24tbmlsIHdoZW4gTU9E RSBpcwpvbmUgb2YgTU9ERVMsIGJ1dCBhbHNvIHdoZW4gTU9ERSBpcyBhbiBhbGlhcyBvZiBvbmUg b2YgTU9ERVMuCiogbGlzcC9zdWJyLmVsIChwcm92aWRlZC1tb2RlLWRlcml2ZWQtcCk6ClJldHVy biBub24tbmlsIHdoZW4gTU9ERSBpcyBhbiBhbGlhcyBvZiBhbnkgb2YgTU9ERVMgKEJ1ZyMzMjc5 NSkuCiogdGVzdC9saXNwL3N1YnItdGVzdHMuZWw6IEFkZCB0ZXN0cyBmb3IgdGhlIGFib3ZlLgot LS0KIGxpc3Avc3Vici5lbCAgICAgICAgICAgIHwgIDkgKysrKysrKy0tCiB0ZXN0L2xpc3Avc3Vi ci10ZXN0cy5lbCB8IDEyICsrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avc3Vici5lbCBiL2xpc3Av c3Vici5lbAppbmRleCA3NTgyYjZjZGIuLjZjNjI1YjQwZCAxMDA2NDQKLS0tIGEvbGlzcC9zdWJy LmVsCisrKyBiL2xpc3Avc3Vici5lbApAQCAtMTkxOSw5ICsxOTE5LDE0IEBAIGRlbGF5LW1vZGUt aG9va3MKIChkZWZ1biBwcm92aWRlZC1tb2RlLWRlcml2ZWQtcCAobW9kZSAmcmVzdCBtb2RlcykK ICAgIk5vbi1uaWwgaWYgTU9ERSBpcyBkZXJpdmVkIGZyb20gb25lIG9mIE1PREVTLgogVXNlcyB0 aGUgYGRlcml2ZWQtbW9kZS1wYXJlbnQnIHByb3BlcnR5IG9mIHRoZSBzeW1ib2wgdG8gdHJhY2Ug YmFja3dhcmRzLgorTm9uLW5pbCBldmVuIGlmIE1PREUgaXMgZGVyaXZlZCBmcm9tIGFuIGFsaWFz IG9mIGFueSBvZiBNT0RFUy4KIElmIHlvdSBqdXN0IHdhbnQgdG8gY2hlY2sgYG1ham9yLW1vZGUn LCB1c2UgYGRlcml2ZWQtbW9kZS1wJy4iCi0gICh3aGlsZSAoYW5kIChub3QgKG1lbXEgbW9kZSBt b2RlcykpCi0gICAgICAgICAgICAgIChzZXRxIG1vZGUgKGdldCBtb2RlICdkZXJpdmVkLW1vZGUt cGFyZW50KSkpKQorICAod2hpbGUKKyAgICAgIChhbmQKKyAgICAgICAobm90IChtZW1xIG1vZGUg bW9kZXMpKQorICAgICAgIChsZXQqICgocGFyZW50IChnZXQgbW9kZSAnZGVyaXZlZC1tb2RlLXBh cmVudCkpCisgICAgICAgICAgICAgIChwYXJlbnRmbiAoc3ltYm9sLWZ1bmN0aW9uIHBhcmVudCkp KQorICAgICAgICAgKHNldHEgbW9kZSAoaWYgKGFuZCBwYXJlbnRmbiAoc3ltYm9scCBwYXJlbnRm bikpIHBhcmVudGZuIHBhcmVudCkpKSkpCiAgIG1vZGUpCiAKIChkZWZ1biBkZXJpdmVkLW1vZGUt cCAoJnJlc3QgbW9kZXMpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3Avc3Vici10ZXN0cy5lbCBiL3Rl c3QvbGlzcC9zdWJyLXRlc3RzLmVsCmluZGV4IDQzMGQ3MTkwMy4uYTlmNzJjMjZkIDEwMDY0NAot LS0gYS90ZXN0L2xpc3Avc3Vici10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3Avc3Vici10ZXN0cy5l bApAQCAtNjIsNiArNjIsMTggQEAKICAgICAgICAgICAgICAgICAgICAgIChxdW90ZQogICAgICAg ICAgICAgICAgICAgICAgICgwIGZvbnQtbG9jay1rZXl3b3JkLWZhY2UpKSkpKSkpKQogCisoZXJ0 LWRlZnRlc3QgcHJvdmlkZWQtbW9kZS1kZXJpdmVkLXAgKCkKKyAgOzsgYmFzZSBjYXNlOiBgZGVy aXZlZC1tb2RlJyBkaXJlY3RseSBkZXJpdmVzIGBwcm9nLW1vZGUnCisgIChzaG91bGQgKHByb2du CisgICAgICAgICAgICAoZGVmaW5lLWRlcml2ZWQtbW9kZSBkZXJpdmVkLW1vZGUgcHJvZy1tb2Rl ICJ0ZXN0IikKKyAgICAgICAgICAgIChwcm92aWRlZC1tb2RlLWRlcml2ZWQtcCAnZGVyaXZlZC1t b2RlICdwcm9nLW1vZGUpKSkKKyAgOzsgZWRnZSBjYXNlOiBgZGVyaXZlZC1tb2RlJyBkZXJpdmVz IGFuIGFsaWFzIG9mIGBwcm9nLW1vZGUnCisgIChzaG91bGQgKHByb2duCisgICAgICAgICAgICAo ZGVmYWxpYXMgJ3BhcmVudC1tb2RlCisgICAgICAgICAgICAgIChpZiAoZmJvdW5kcCAncHJvZy1t b2RlKSAncHJvZy1tb2RlICdmdW5kYW1lbnRhbC1tb2RlKSkKKyAgICAgICAgICAgIChkZWZpbmUt ZGVyaXZlZC1tb2RlIGRlcml2ZWQtbW9kZSBwYXJlbnQtbW9kZSAidGVzdCIpCisgICAgICAgICAg ICAocHJvdmlkZWQtbW9kZS1kZXJpdmVkLXAgJ2Rlcml2ZWQtbW9kZSAncHJvZy1tb2RlKSkpKQor CiAoZXJ0LWRlZnRlc3QgbnVtYmVyLXNlcXVlbmNlLXRlc3QgKCkKICAgKHNob3VsZCAoPSAobGVu Z3RoCiAgICAgICAgICAgICAgIChudW1iZXItc2VxdWVuY2UgKDEtIG1vc3QtcG9zaXRpdmUtZml4 bnVtKSBtb3N0LXBvc2l0aXZlLWZpeG51bSkpCi0tIAoyLjE5LjAKCg== --=_8c303201c1c8c6a31c646fa1c9255fac-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 25 01:23:08 2018 Received: (at 32795) by debbugs.gnu.org; 25 Sep 2018 05:23:08 +0000 Received: from localhost ([127.0.0.1]:52733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4foS-0006Kd-3u for submit@debbugs.gnu.org; Tue, 25 Sep 2018 01:23:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4foQ-0006K5-92 for 32795@debbugs.gnu.org; Tue, 25 Sep 2018 01:23:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4foI-0006pJ-2T for 32795@debbugs.gnu.org; Tue, 25 Sep 2018 01:23:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4foH-0006pF-Uy; Tue, 25 Sep 2018 01:22:58 -0400 Received: from [176.228.60.248] (port=3330 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g4foH-0002M3-Hw; Tue, 25 Sep 2018 01:22:57 -0400 Date: Tue, 25 Sep 2018 08:22:53 +0300 Message-Id: <83a7o69mmq.fsf@gnu.org> From: Eli Zaretskii To: Andrew Schwartzmeyer In-reply-to: <6ab54491416605d957ece9ee6154a6a5@posteo.net> (message from Andrew Schwartzmeyer on Mon, 24 Sep 2018 21:15:28 -0700) Subject: Re: bug#32795: Acknowledgement (26.1; provided-mode-derived-p does not support parent modes set with defalias) References: <6ab54491416605d957ece9ee6154a6a5@posteo.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32795 Cc: 32795@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Mon, 24 Sep 2018 21:15:28 -0700 > From: Andrew Schwartzmeyer > > The bug also exists on 'emacs-25' but the code is slightly different > ('provided-mode-derived-p' had not been extracted yet from > 'derived-mode-p'). I can supply a back-ported patch as well. No need for that, as we don't expect to make any more releases from the emacs-25 branch. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 26 08:18:18 2018 Received: (at control) by debbugs.gnu.org; 26 Sep 2018 12:18:18 +0000 Received: from localhost ([127.0.0.1]:54498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g58lm-0007QT-CU for submit@debbugs.gnu.org; Wed, 26 Sep 2018 08:18:18 -0400 Received: from mail-io1-f46.google.com ([209.85.166.46]:41367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g58ll-0007QE-9X; Wed, 26 Sep 2018 08:18:17 -0400 Received: by mail-io1-f46.google.com with SMTP id q4-v6so23079037iob.8; Wed, 26 Sep 2018 05:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=A8RKfgURyVehdAs34Q0IfFlmikR1MEzMEGDFII6wGts=; b=fsd2wm9fzKKx3ffwNUG06WYH9U1wxNcLPZRGuD+1vj9pl2+dmuDIGQVnsglzlqtJrH hhAySchOoublsUTBK/0fphIpXuH4lHolLLgM4SNtKB8xuxvDzyghsxmnaxus+I+QArMW haKXsIyTJbi7nfKmxSSCdkQbA8Muycrfula0gY39wipKH681wgYmb8Oo0XDEKQy5Uwg9 UNCDMSkx3wPR2fngDw7hJmAZWjU1PPRyUg/UTQ8gmDilXX7RFyDOhb60cHXzKgKuo/ZB fzcGISPVd8TYi3rQdRu5v/QA2WrGZvgyX48+wvawdyDTsr9lcRn6s6jq5KKRoGCxGnz8 x0Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=A8RKfgURyVehdAs34Q0IfFlmikR1MEzMEGDFII6wGts=; b=LXPpz46jh5r3iFefMywiCsEd27Iyt3MzJnQVElpSVVAnuBUPaxleiLwHzTKj0jceKz mLb0BzrHb+0P9Duu6yJH9SguZWfL2Moqr1v724Q1UUG3AOKqufHr840LP/VWuQQDcOTn xX+mqhjSuzDm4wPEB7z7SEJDedPOws5grOzdVmcutDrXEnuDUfwN+VeIReaOgV65aXtR deHf0xs7/NXaxCvcazwi/k3myFq8/Cf9SNSQ4MhmOKSOtHUTDB9OjLh9Dr8epfLf6sqt e8Z1OYo+YnTQnPloR08P3z/G1010tjR6yOGv4B5jXBMBXly1AEFGmxc/D5E+y6boNoDs tAIg== X-Gm-Message-State: ABuFfoiV61hu+yBMaceW8zHnG0Ccb2n99bdVZzOl50Op8+lA5SG23soZ d16gmAfY4KuyuiDcss+gLLe7Virw X-Google-Smtp-Source: ACcGV602sUGHY1gjANWqkkYPsGojCe35OuxhqZKjotd5qaDtAiYtKsINL5L7rjw0mLfJvlVPtV1DWg== X-Received: by 2002:a6b:8e14:: with SMTP id q20-v6mr4727870iod.169.1537964291544; Wed, 26 Sep 2018 05:18:11 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w64-v6sm2369570ita.7.2018.09.26.05.18.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Sep 2018 05:18:10 -0700 (PDT) From: Noam Postavsky To: Andrew Schwartzmeyer Subject: Re: bug#32832: Please close this bug References: <20180925040939.66376-1-andrew@schwartzmeyer.com> Date: Wed, 26 Sep 2018 08:18:09 -0400 In-Reply-To: (Andrew Schwartzmeyer's message of "Tue, 25 Sep 2018 22:10:29 -0700") Message-ID: <87h8ico3jy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 32832@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 32832 tags 32795 + patch quit Andrew Schwartzmeyer writes: > I'm sorry, this patch was meant for #32795, but I accidentally created > a new bug. The patch has been successfully attached to the correct > bug; that bug can be classified as "Patch Available" and this bug > closed. Done. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 29 03:01:31 2018 Received: (at 32795-done) by debbugs.gnu.org; 29 Sep 2018 07:01:31 +0000 Received: from localhost ([127.0.0.1]:58231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g69Fr-0003uf-AB for submit@debbugs.gnu.org; Sat, 29 Sep 2018 03:01:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g69Fo-0003uS-Et for 32795-done@debbugs.gnu.org; Sat, 29 Sep 2018 03:01:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g69Fa-0008Ki-Px for 32795-done@debbugs.gnu.org; Sat, 29 Sep 2018 03:01:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g69Fa-0008Ke-KK; Sat, 29 Sep 2018 03:01:14 -0400 Received: from [176.228.60.248] (port=4063 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g69FZ-0004K0-Hk; Sat, 29 Sep 2018 03:01:14 -0400 Date: Sat, 29 Sep 2018 10:01:01 +0300 Message-Id: <831s9c7poy.fsf@gnu.org> From: Eli Zaretskii To: andrew@schwartzmeyer.com In-reply-to: <20180925040939.66376-1-andrew@schwartzmeyer.com> Subject: Re: bug#32832: [PATCH] Fix 'provided-mode-derived-p' when the parent is an alias References: <20180925040939.66376-1-andrew@schwartzmeyer.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32795-done Cc: 32795-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: andrew@schwartzmeyer.com > Date: Mon, 24 Sep 2018 21:09:39 -0700 > > From: Andrew Schwartzmeyer > > Authors of Emacs packages often derive from an alias of a mode instead > of the mode directly. This is especially the case when deriving from > 'prog-mode' as it is relatively new. Unfortunately, using > 'derived-mode-p' to check if some mode is derived from an alias of > 'prog-mode' does not work as expected. The bug is that > 'provided-mode-derived-p' should not only return non-nil when MODE is > one of MODES, but also when MODE is an alias of one of MODES. > * lisp/subr.el (provided-mode-derived-p): > Return non-nil when MODE is an alias of any of MODES (Bug#32795). > * test/lisp/subr-tests.el: Add tests for the above. Thanks, pushed. In the future please either format your patches with "git format-patch" or make sure the first line of the commit log message is a single sentence followed by an empty line (this is explained in CONTRIBUTE), to make the patch application easier. Also, you don't seem to have a copyright assignment on file, and this contribution comes close to exhausting the amount of changes we can accept without such an assignment. So I urge you to start your legal paperwork rolling, to allow us to accept more contributions from you. If you are interested, I will send you the assignment form off-list. From unknown Mon Aug 18 11:15:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Oct 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator