GNU bug report logs - #32785
[PATCH] services: wpa-supplicant: Extend to support configuration parameters.

Previous Next

Full log

Message #11 received at 32785 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 32785 <at> debbugs.gnu.org
Subject: Re: [bug#32785] [PATCH] services: wpa-supplicant: Extend to support
 configuration parameters.
Date: Mon, 24 Sep 2018 17:47:05 +0200

Hello,

Marius Bakke <mbakke <at> fastmail.com> skribis:

> This allows using WPA Supplicant "standalone" without an additional
> network manager.  The default configuration is unchanged.
>
> * gnu/services/networking.scm (<wpa-supplicant-configuration>): New record type.
> (wpa-supplicant-shepherd-service): Pass configuration records to the daemon.
> (wpa-supplicant-service-type): Adjust accordingly.
> * doc/guix.texi (Networking Services): Document the new service type.

[...]

> +@deftp {Data Type} wpa-supplicant-manager-configuration
                                     ^
Should be ‘wpa-supplicant-configuration’.

> +    (service-type (name 'wpa-supplicant)
> +                  (extensions
> +                   (list (service-extension shepherd-root-service-type
> +                                            wpa-supplicant-shepherd-service)
> +                         (service-extension dbus-root-service-type config->package)
> +                         (service-extension profile-service-type config->package)))
> +                  (default-value (wpa-supplicant-configuration)))))

While you’re at it you can add a ‘description’ field.  :-)

I haven’t tested it but it LGTM.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.