From unknown Thu Aug 14 21:22:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#32785 <32785@debbugs.gnu.org> To: bug#32785 <32785@debbugs.gnu.org> Subject: Status: [PATCH] services: wpa-supplicant: Extend to support configuration parameters. Reply-To: bug#32785 <32785@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:22:40 +0000 retitle 32785 [PATCH] services: wpa-supplicant: Extend to support configura= tion parameters. reassign 32785 guix-patches submitter 32785 Marius Bakke severity 32785 normal tag 32785 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 20 11:42:39 2018 Received: (at submit) by debbugs.gnu.org; 20 Sep 2018 15:42:39 +0000 Received: from localhost ([127.0.0.1]:47229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3168-00011X-J8 for submit@debbugs.gnu.org; Thu, 20 Sep 2018 11:42:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3166-00011K-Bu for submit@debbugs.gnu.org; Thu, 20 Sep 2018 11:42:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g315z-0008Q1-Sv for submit@debbugs.gnu.org; Thu, 20 Sep 2018 11:42:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60164) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g315z-0008Pv-PJ for submit@debbugs.gnu.org; Thu, 20 Sep 2018 11:42:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g315y-00089z-CR for guix-patches@gnu.org; Thu, 20 Sep 2018 11:42:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g315v-0008Om-6K for guix-patches@gnu.org; Thu, 20 Sep 2018 11:42:22 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:54131) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g315u-0008LL-Tx for guix-patches@gnu.org; Thu, 20 Sep 2018 11:42:19 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D040821910 for ; Thu, 20 Sep 2018 11:42:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 20 Sep 2018 11:42:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=qDt/VBSEvGM5k9Lrb4txUHUPmlypHR/PFVX598e6Kpo=; b=lcufpdRp QpzzGuIGmaU9y1VmSCBADEzmPWS74mGqQ/CxSWwbktvOcJJEm/7dtmp6cqCZldlz 5NBOMRp2iy/32B8O3tPzbJsVjmM+rtyrvGw4qZsEuWSiQ3szV/OTea1bkUnpMm9r CoJ37RntdGVMlmK8yG0W9I8W4s1S+JI9VL+scefdV3tWs8q6QJUUztvb1Hyov+nH 21+g6K+r839avW1z3rP8WAaXgOoLJMbTj8cnnUw6bX18w0GvgEyRXHP4Y/sSKI0O sPGdfFDXBz49L/bE2H0TmsOhRfKtPc+qgHQhSexZDGETUMDui9x0+7UtS/aDQ3+u uTvSWxzrE0O5hA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=qDt/VBSEvGM5k9Lrb4txUHUPmlypH R/PFVX598e6Kpo=; b=QRORcCcjiGyoC901v7GjcpWPeN9DzCqP9TwdOxOTZTHcK wGzitFrietZRKhnFusphHWaI4a22wf6n+9qXEwFmZdPaOC5i0v+itu04bFumDKVj /krps94+Sln2ZvxCKe7UGfn2ooqXd5MljDMhPIB8aBK8XfDlYDklOvKRLS9r5Wkp dVX3FfoWQ6qNFtcU3huUC8ykbOFCVruQBrcseMi0OgLUAEor1kWqPgG7ral2FmE7 kRTqaLangioKwBzl4F0OkSSfK4wAsYOH00J9tl2skpvHFTFy2G3iQf3nLyuUOBMa kR4G74nzsA17Wb+CzgJPN2OLGja2UHc7zIBr4n6UQ== X-ME-Proxy: X-ME-Sender: Received: from localhost (140.226.16.62.customer.cdi.no [62.16.226.140]) by mail.messagingengine.com (Postfix) with ESMTPA id 12D9AE447F for ; Thu, 20 Sep 2018 11:42:15 -0400 (EDT) From: Marius Bakke To: guix-patches@gnu.org Subject: [PATCH] services: wpa-supplicant: Extend to support configuration parameters. Date: Thu, 20 Sep 2018 17:42:14 +0200 Message-Id: <20180920154214.4418-1-mbakke@fastmail.com> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) This allows using WPA Supplicant "standalone" without an additional network manager. The default configuration is unchanged. * gnu/services/networking.scm (): New record type. (wpa-supplicant-shepherd-service): Pass configuration records to the daemon. (wpa-supplicant-service-type): Adjust accordingly. * doc/guix.texi (Networking Services): Document the new service type. --- doc/guix.texi | 35 ++++++++++++---- gnu/services/networking.scm | 84 +++++++++++++++++++++++++++---------- 2 files changed, 89 insertions(+), 30 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index b10e96aa9..6968a1212 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -11643,18 +11643,35 @@ When true, enable connman's vpn plugin. @defvr {Scheme Variable} wpa-supplicant-service-type This is the service type to run @url{https://w1.fi/wpa_supplicant/,WPA supplicant}, an authentication daemon required to authenticate against -encrypted WiFi or ethernet networks. It is configured to listen for -requests on D-Bus. +encrypted WiFi or ethernet networks. +@end defvr -The value of this service is the @code{wpa-supplicant} package to use. -Thus, it can be instantiated like this: +@deftp {Data Type} wpa-supplicant-manager-configuration +Data type representing the configuration of WPA Supplicant. -@lisp -(use-modules (gnu services networking)) +It takes the following parameters: -(service wpa-supplicant-service-type) -@end lisp -@end defvr +@table @asis +@item @code{wpa-supplicant} (default: @code{wpa-supplicant}) +The WPA Supplicant package to use. + +@item @code{dbus?} (default: @code{#t}) +Whether to listen for requests on D-Bus. + +@item @code{pid-file} (default: @code{"/var/run/wpa_supplicant.pid"}) +Where to store the PID file. + +@item @code{interface} (default: @code{#f}) +If this is set, it must specify the name of a network interface that +WPA supplicant will control. + +@item @code{config-file} (default: @code{#f}) +Optional configuration file to use. + +@item @code{extra-options} (default: @code{'()}) +List of additional command-line arguments to pass to the daemon. +@end table +@end deftp @cindex iptables @defvr {Scheme Variable} iptables-service-type diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm index d8cf8cb68..32884c7e1 100644 --- a/gnu/services/networking.scm +++ b/gnu/services/networking.scm @@ -5,7 +5,7 @@ ;;; Copyright © 2016 John Darrington ;;; Copyright © 2017 Clément Lassieur ;;; Copyright © 2017 Thomas Danckaert -;;; Copyright © 2017 Marius Bakke +;;; Copyright © 2017, 2018 Marius Bakke ;;; Copyright © 2018 Tobias Geerinckx-Rice ;;; Copyright © 2018 Chris Marusich ;;; Copyright © 2018 Arun Isaac @@ -107,6 +107,16 @@ modem-manager-configuration modem-manager-configuration? modem-manager-service-type + + + wpa-supplicant-configuration + wpa-supplicant-configuration? + wpa-supplicant-configuration-wpa-supplicant + wpa-supplicant-configuration-pid-file + wpa-supplicant-configuration-dbus? + wpa-supplicant-configuration-interface + wpa-supplicant-configuration-config-file + wpa-supplicant-configuration-custom-arguments wpa-supplicant-service-type openvswitch-service-type @@ -1159,28 +1169,60 @@ networking.")))) ;;; WPA supplicant ;;; - -(define (wpa-supplicant-shepherd-service wpa-supplicant) - "Return a shepherd service for wpa_supplicant" - (list (shepherd-service - (documentation "Run WPA supplicant with dbus interface") - (provision '(wpa-supplicant)) - (requirement '(user-processes dbus-system loopback)) - (start #~(make-forkexec-constructor - (list (string-append #$wpa-supplicant - "/sbin/wpa_supplicant") - "-u" "-B" "-P/var/run/wpa_supplicant.pid") - #:pid-file "/var/run/wpa_supplicant.pid")) - (stop #~(make-kill-destructor))))) +(define-record-type* + wpa-supplicant-configuration make-wpa-supplicant-configuration + wpa-supplicant-configuration? + (wpa-supplicant wpa-supplicant-configuration-wpa-supplicant ; + (default wpa-supplicant)) + (pid-file wpa-supplicant-configuration-pid-file ;string + (default "/var/run/wpa_supplicant.pid")) + (dbus? wpa-supplicant-configuration-dbus? ;Boolean + (default #t)) + (interface wpa-supplicant-configuration-interface ;#f | string + (default #f)) + (config-file wpa-supplicant-configuration-config-file ;#f | + (default #f)) + (extra-options wpa-supplicant-configuration-extra-options ;list of strings + (default '()))) + +(define wpa-supplicant-shepherd-service + (match-lambda + (($ wpa-supplicant pid-file dbus? interface + config-file extra-options) + (list (shepherd-service + (documentation "Run the WPA supplicant daemon") + (provision '(wpa-supplicant)) + (requirement '(user-processes dbus-system loopback)) + (start #~(make-forkexec-constructor + (list (string-append #$wpa-supplicant + "/sbin/wpa_supplicant") + (string-append "-P" #$pid-file) + "-B" ;run in background + #$@(if dbus? + #~("-u") + #~()) + #$@(if interface + #~(string-append "-i" #$interface) + #~()) + #$@(if config-file + #~(string-append "-c" #$config-file) + #~()) + #$@extra-options) + #:pid-file #$pid-file)) + (stop #~(make-kill-destructor))))))) (define wpa-supplicant-service-type - (service-type (name 'wpa-supplicant) - (extensions - (list (service-extension shepherd-root-service-type - wpa-supplicant-shepherd-service) - (service-extension dbus-root-service-type list) - (service-extension profile-service-type list))) - (default-value wpa-supplicant))) + (let ((config->package + (match-lambda + (($ wpa-supplicant) + (list wpa-supplicant))))) + (service-type (name 'wpa-supplicant) + (extensions + (list (service-extension shepherd-root-service-type + wpa-supplicant-shepherd-service) + (service-extension dbus-root-service-type config->package) + (service-extension profile-service-type config->package))) + (default-value (wpa-supplicant-configuration))))) ;;; -- 2.19.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 20 12:12:47 2018 Received: (at 32785) by debbugs.gnu.org; 20 Sep 2018 16:12:47 +0000 Received: from localhost ([127.0.0.1]:47244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g31ZP-0001oW-GP for submit@debbugs.gnu.org; Thu, 20 Sep 2018 12:12:47 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g31ZN-0001oO-O5 for 32785@debbugs.gnu.org; Thu, 20 Sep 2018 12:12:46 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5F198217CF for <32785@debbugs.gnu.org>; Thu, 20 Sep 2018 12:12:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 20 Sep 2018 12:12:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=upPknL2oAqRZr1SziGmlWRaSbZftJpcMzq6mgW9ZfuE=; b=nRlJhOMp 0MyRwvzqKcT0I4gcw0VNroWOfpPvfAFsqoXwzmTUtrSn4+gCfxopcMsJ4mP4wdco BeD62ErQpeIgGxCRUpWMLFEJXDwSqyh3yFZIA53+XM0+g3aFYWunuAcbeqw9VCal y9iyAOu6sB5wskJ7kn5msgZJhH5hi3Yykog5n4C+91MjfRH/lYRjYQUxwAiSDqET M62P+cZ/oS6fZYk5u5RUeN99oLdTZJgHD6FS2rnOkVKM5OsQRLPSqMVIt1eV9Qqv l9csC939KNAmkU2vbEpwpmLYHGG0vq8v8pqOPsMxtKcZlWiOpiUCcDYYKuBzAFbr AoA5vM5coE44zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=upPknL2oAqRZr1SziGmlWRaSbZftJ pcMzq6mgW9ZfuE=; b=K/JG6L2uJZk/XH/y4bfwTqb3qyqQuo8FfxZEwSDqRqJXM Nl3O3tTHjDs32ja0RZRmaIZy0hqrIYpRitT/qNNyEmRXyAfQPgFOeTMxUGfq19xD CGOQUOSjWSz/m4vqhGPDqsOjNE9t49FGHSLwu+n17wt0HeK51NnmRQ27tCiLMZcS NjR8wO+Op1xj/dh3tUQ/8RLQ4Tl17fQk7dBUDmXINa1vtuCX0ICZsQEhYkwk+ANP SaNOSSZ123rzdyimd5jmtuE00nGrML9rJpHe/9ySHjGKa1+0Hmh4dyGNpMRgunYq eo4tomHM7ayAvVkdGwnojM783n8WLJ/bgT7R+hYIA== X-ME-Proxy: X-ME-Sender: Received: from localhost (140.226.16.62.customer.cdi.no [62.16.226.140]) by mail.messagingengine.com (Postfix) with ESMTPA id 6ABF1E4506 for <32785@debbugs.gnu.org>; Thu, 20 Sep 2018 12:12:44 -0400 (EDT) From: Marius Bakke To: 32785@debbugs.gnu.org Subject: Re: [bug#32785] [PATCH] services: wpa-supplicant: Extend to support configuration parameters. In-Reply-To: <20180920154214.4418-1-mbakke@fastmail.com> References: <20180920154214.4418-1-mbakke@fastmail.com> User-Agent: Notmuch/0.27 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Thu, 20 Sep 2018 18:12:42 +0200 Message-ID: <87in30no5h.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 32785 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Marius Bakke writes: > This allows using WPA Supplicant "standalone" without an additional > network manager. The default configuration is unchanged. > > * gnu/services/networking.scm (): New record type. > (wpa-supplicant-shepherd-service): Pass configuration records to the daemon. > (wpa-supplicant-service-type): Adjust accordingly. > * doc/guix.texi (Networking Services): Document the new service type. A bit of background, since I forgot to add --notes: I have used this patch for a long time, and decided to submit it since there was a question about it on help-guix. I have not tested the standalone configuration with the Guix DHCP client service since I use a custom one. Though I expect that to work fine. Feedback appreciated! [...] > + > + > + wpa-supplicant-configuration > + wpa-supplicant-configuration? > + wpa-supplicant-configuration-wpa-supplicant > + wpa-supplicant-configuration-pid-file > + wpa-supplicant-configuration-dbus? > + wpa-supplicant-configuration-interface > + wpa-supplicant-configuration-config-file > + wpa-supplicant-configuration-custom-arguments ^^^^^^^^^ This is called 'extra-options' elsewhere and fixed locally. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlujxvsACgkQoqBt8qM6 VPpHwwgAy2STnAdaS+oiVlBrnKgPQ4CVR6GtV0rrIJw0MUlkBYzZbxXmQN4JPh/Q Ud2zgPRfrDlzCjSd3QRfARdimwEoW76QrvBWcswWq0hrnAI9DyYZQHZvu0YeRyHD KaAQqDOiF83+Kpo+p5zuXBBNpIp2U+x3VvaEPeGEceMdPFlEx58h8e/TGqK6MXWc fYMGp4ImueJA3nzbzSkuc5wHvZmxk1JKkrkMXrV5OlHjuFpNMxpAv1f75Hq+yE/+ zjYGfrLuTNqxswx1ekpzYz3To0esh/1uoU47rtOqmdOqw+wph8vnULSYeqfeazWu QL6u1uFie0BV4TjEZGz9njL7+YBsbg== =4kWZ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 24 11:47:19 2018 Received: (at 32785) by debbugs.gnu.org; 24 Sep 2018 15:47:19 +0000 Received: from localhost ([127.0.0.1]:52259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4T4w-0000Ut-T6 for submit@debbugs.gnu.org; Mon, 24 Sep 2018 11:47:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4T4v-0000Uf-Lo for 32785@debbugs.gnu.org; Mon, 24 Sep 2018 11:47:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4T4l-0003hm-9R for 32785@debbugs.gnu.org; Mon, 24 Sep 2018 11:47:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4T4l-0003hi-5I; Mon, 24 Sep 2018 11:47:07 -0400 Received: from [193.50.110.247] (port=59684 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g4T4k-00048O-OR; Mon, 24 Sep 2018 11:47:07 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Marius Bakke Subject: Re: [bug#32785] [PATCH] services: wpa-supplicant: Extend to support configuration parameters. References: <20180920154214.4418-1-mbakke@fastmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 3 =?utf-8?Q?Vend=C3=A9miaire?= an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 24 Sep 2018 17:47:05 +0200 In-Reply-To: <20180920154214.4418-1-mbakke@fastmail.com> (Marius Bakke's message of "Thu, 20 Sep 2018 17:42:14 +0200") Message-ID: <87bm8muccm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32785 Cc: 32785@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Marius Bakke skribis: > This allows using WPA Supplicant "standalone" without an additional > network manager. The default configuration is unchanged. > > * gnu/services/networking.scm (): New recor= d type. > (wpa-supplicant-shepherd-service): Pass configuration records to the daem= on. > (wpa-supplicant-service-type): Adjust accordingly. > * doc/guix.texi (Networking Services): Document the new service type. [...] > +@deftp {Data Type} wpa-supplicant-manager-configuration ^ Should be =E2=80=98wpa-supplicant-configuration=E2=80=99. > + (service-type (name 'wpa-supplicant) > + (extensions > + (list (service-extension shepherd-root-service-type > + wpa-supplicant-shepherd-serv= ice) > + (service-extension dbus-root-service-type confi= g->package) > + (service-extension profile-service-type config-= >package))) > + (default-value (wpa-supplicant-configuration))))) While you=E2=80=99re at it you can add a =E2=80=98description=E2=80=99 fiel= d. :-) I haven=E2=80=99t tested it but it LGTM. Thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 17 14:37:39 2018 Received: (at 32785-done) by debbugs.gnu.org; 17 Oct 2018 18:37:39 +0000 Received: from localhost ([127.0.0.1]:55629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCqhO-0001XN-Q7 for submit@debbugs.gnu.org; Wed, 17 Oct 2018 14:37:38 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCqhN-0001XG-VR for 32785-done@debbugs.gnu.org; Wed, 17 Oct 2018 14:37:38 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C038321B6A; Wed, 17 Oct 2018 14:37:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 17 Oct 2018 14:37:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=TibMiW19GDZ47NJS3gSck2i91a ouyrlifhtEwq0GVhw=; b=bH8xOdMLEJauTz6zyjQT99Q6tyr226NCQj4cXYxLWA usW8pGhSNB24bTZPuMEkv8QtZkBAaXyWoDSWQAXNucbZxbvr91P85ZQg/0WnTMp8 J+yQObqmHcQ/gK2tc6cZ0trMgLTx7UDjPyy3BbForTpWvbk6m6Xqrfxwz7XXjt1L 50QfTnVDGwDYOL1qKwiF1nH6hMmmyGDFa0v1Q0nhnFPndSoSgu5KXY+hOOgzJsFb NT9pOJIPGy64mNBBzWBYwEhDgrjgEM/X0SNYQ0JGjgh1VK1BR8p5vIDWgJEApPqH cjAzmPN5XVey0/+0keUdsnOv2kb2PIV+3jWI6Gck2UqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=TibMiW 19GDZ47NJS3gSck2i91aouyrlifhtEwq0GVhw=; b=uTiRccyHGHH9L8OZnhmeeb rjGPvcMWf6peN8si+9xNxuVDHL+6NYnLvKUViGSTbCZWzew+mrbfs9iPv6JN12Fc HNgxYeVWXqu3aic5iW8h5j3oc/kcUCT+rYmjC0roJffbiBujhYVFdpiZHRlVPpPe oNtKwnSuHs5xxKg9X7iRiF2mfNj6QwAYXolWEH3qmv35JY5JXzlBuqrhvM90+9qe AFfAxOZZ9kQL6HueOYD7IGiWSdTqf9DEdcQG8WH2U/R108eC5kuJuvoYeBiiBb3L QEQt67YuTludjAk89WKVzs7TWVKlL6tyF8RzZhl7NbfKP2b21fefLxWNibBVa32Q == X-ME-Sender: X-ME-Proxy: Received: from localhost (140.226.16.62.customer.cdi.no [62.16.226.140]) by mail.messagingengine.com (Postfix) with ESMTPA id A1670E4074; Wed, 17 Oct 2018 14:37:36 -0400 (EDT) From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#32785] [PATCH] services: wpa-supplicant: Extend to support configuration parameters. In-Reply-To: <87bm8muccm.fsf@gnu.org> References: <20180920154214.4418-1-mbakke@fastmail.com> <87bm8muccm.fsf@gnu.org> User-Agent: Notmuch/0.27 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Wed, 17 Oct 2018 20:37:35 +0200 Message-ID: <8736t4h11s.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 32785-done Cc: 32785-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hello, > > Marius Bakke skribis: > >> This allows using WPA Supplicant "standalone" without an additional >> network manager. The default configuration is unchanged. >> >> * gnu/services/networking.scm (): New reco= rd type. >> (wpa-supplicant-shepherd-service): Pass configuration records to the dae= mon. >> (wpa-supplicant-service-type): Adjust accordingly. >> * doc/guix.texi (Networking Services): Document the new service type. > > [...] > >> +@deftp {Data Type} wpa-supplicant-manager-configuration > ^ > Should be =E2=80=98wpa-supplicant-configuration=E2=80=99. Good catch; fixed! > >> + (service-type (name 'wpa-supplicant) >> + (extensions >> + (list (service-extension shepherd-root-service-type >> + wpa-supplicant-shepherd-ser= vice) >> + (service-extension dbus-root-service-type conf= ig->package) >> + (service-extension profile-service-type config= ->package))) >> + (default-value (wpa-supplicant-configuration))))) > > While you=E2=80=99re at it you can add a =E2=80=98description=E2=80=99 fi= eld. :-) See previous comment. > I haven=E2=80=99t tested it but it LGTM. I have done some testing and the default configuration seems to work as before. Pushed as acce0a474c1493ab18912bc46285248e4ccb0314. Thank you! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlvHgW8ACgkQoqBt8qM6 VPrptwgAl6YLR6bgF3LJHBvSjCX3NgO5usnzj+JkY8gyzdzmpFuCOfcEjGDs3Ksw U1oruJutuFxlJKOQMmva840gGDG0TCxPGcn018FbKNfFEuKymNBxcM1ENDZ0fnv5 wodS0/RzQrw7/5kz4F5WnlqPdUGOThofREoYcyR/5gHa3XHQlISXXTasvTKsThrw ha+BX2x7u3xZmrFehLqQCGPcOkUTxtLVVRJW6HZocf4IO8Pj70JnCA9VGlwP005l qBdInQQU602TCMrUQSv8UwZ/mDSLkMLLld0wquacSwWQi83zFv4uxzTAXPHxeCa6 W0qFX09L7tKPaPuweW+iuLvFQsDrhg== =rmks -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Aug 14 21:22:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 15 Nov 2018 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator