From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 18 23:56:01 2018 Received: (at submit) by debbugs.gnu.org; 19 Sep 2018 03:56:01 +0000 Received: from localhost ([127.0.0.1]:44993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Taq-0000DX-9f for submit@debbugs.gnu.org; Tue, 18 Sep 2018 23:56:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Sc7-0006xZ-KL for submit@debbugs.gnu.org; Tue, 18 Sep 2018 22:53:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2Sc1-0008Fm-0N for submit@debbugs.gnu.org; Tue, 18 Sep 2018 22:53:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45177) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g2Sc0-0008FZ-O4 for submit@debbugs.gnu.org; Tue, 18 Sep 2018 22:53:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2Sbz-0003aD-FV for guix-patches@gnu.org; Tue, 18 Sep 2018 22:53:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2Sbv-00086m-IW for guix-patches@gnu.org; Tue, 18 Sep 2018 22:53:07 -0400 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]:40146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g2Sbv-000849-Bd for guix-patches@gnu.org; Tue, 18 Sep 2018 22:53:03 -0400 Received: by mail-io1-xd2d.google.com with SMTP id l14-v6so3272767iob.7 for ; Tue, 18 Sep 2018 19:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version :content-transfer-encoding; bh=R/pYmaeSKDP4VTSsvSrklJaJo5yP14N1QwgAF1SxWlI=; b=T3/MMA9L2tbB8mEilWKibL+EfU2R/OG4F3sBJ0WZk+KMhdWpIpWJqYclgkJqDpLwjf +EPMswdZq7jx2QAnEz0ZqQJIQh67yiJqYk/C6XDXFNAvvnnyC9YwxZE+9/fotgl2visp oGkC9GTtrkb5mhAwIro7P0OX8mX30aqGYgbbrU2Yt4fGafIMlqjJYZjusIDGtI9FGVDe rlSqDqotC9TggW7YGWzV5XNUR3OIFO+rkA3GjcltY3URnEcvsz1VzZbAn8SqYxQ7VuJZ llNCSiLTePbkjVdbJJq3ix8ke4+/+i6RY3ca7plU1XxAF/4FnHJ7knqBw01SBcvNb3QU jUzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=R/pYmaeSKDP4VTSsvSrklJaJo5yP14N1QwgAF1SxWlI=; b=AwMy3vuRwatjv+9qfZKmN0UKN17iOBqTB+N+DUuNbM4mWYc44d7kZARNQ6rbrcMaZq hPzl1G4vp8+sjx9J2IKRoat14I9bYEeSkhhKFZRJ2YiYW9J+F/IeAEyQVkgimWoyqkth gR6Ibvs4d0PiIm5uPBMHOLcEX91TYb/6MZ1eZgG1gEGd59aj7wANO3dy/uyd2mv16DPq k9y5XZT7t7P72zzfJjQpJzbZxcbeJuth6HI3r2QGLCJrfhELJYDWbGAOibP96A5Z3v9Z ZZvZM1EMMimUvatbUmcC+KOnlCD++SjKJuunl8p8D7LAFjhSKTdL3cjjliP5QW0kn/AR edLw== X-Gm-Message-State: APzg51C5OeWet/b368L1ImQJ66cAKjLrcapHH2TXPd7Et6MoCkMmmemO iqAbMWEd5die3wAKLx793CJU7BDg X-Google-Smtp-Source: ANB0VdYlJz5EijAE5wlTcaTtfFmTSRA5y1kUJzL28xX5whvWgbya6WY3cdmh11F2Wj9bLYC327Ko1A== X-Received: by 2002:a6b:1d47:: with SMTP id d68-v6mr29184898iod.78.1537325581840; Tue, 18 Sep 2018 19:53:01 -0700 (PDT) Received: from gazelle-pro (172-221-246-205.dhcp.chtrptr.net. [172.221.246.205]) by smtp.gmail.com with ESMTPSA id m123-v6sm5409407itg.29.2018.09.18.19.52.59 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Sep 2018 19:52:59 -0700 (PDT) From: Katherine Cox-Buday To: guix-patches@gnu.org Subject: [PATCH] gnu: go-1.11: Add New Version Date: Tue, 18 Sep 2018 21:52:58 -0500 Message-ID: <877ejinqph.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 18 Sep 2018 23:55:59 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --- gnu/packages/golang.scm | 128 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 128 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index b4a088a05..be404cc16 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -12,6 +12,7 @@ ;;; Copyright =C2=A9 2018 Tom=C3=A1=C5=A1 =C4=8Cech ;;; Copyright =C2=A9 2018 Pierre-Antoine Rouby ;;; Copyright =C2=A9 2018 Pierre Neidhardt +;;; Copyright @ 2018 Katherine Cox-Buday ;;; ;;; This file is part of GNU Guix. ;;; @@ -499,6 +500,133 @@ in the style of communicating sequential processes (@= dfn{CSP}).") (setenv "HOME" "/tmp") #t))))))))) =20 +(define-public go-1.11 + (package + (inherit go-1.10) + (name "go") + (version "1.11") + (source + (origin + (method url-fetch) + (uri (string-append "https://storage.googleapis.com/golang/" + name version ".src.tar.gz")) + (sha256 + (base32 + "1ysj04jzds6xa8kdflkdsgyv3mg9fdn90zdf78g4g6p4bwpy3hdg")))) + (arguments + (substitute-keyword-arguments (package-arguments go-1.10) + ((#:phases phases) + `(modify-phases ,phases + (replace 'prebuild + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") = "/lib")) + (ld (string-append (assoc-ref inputs "libc") "/lib")) + (loader (car (find-files ld "^ld-linux.+"))) + (net-base (assoc-ref inputs "net-base")) + (tzdata-path + (string-append (assoc-ref inputs "tzdata") "/share/= zoneinfo")) + (output (assoc-ref outputs "out"))) + + (for-each delete-file + ;; Removing net/ tests, which fail when attempt= ing to access + ;; network resources not present in the build c= ontainer. + '("net/listen_test.go" + "net/parse_test.go" + "net/cgo_unix_test.go" + ;; A side affect of these test scripts is tes= ting + ;; cgo. Attempts at using cgo flags and + ;; directives with these scripts as specified + ;; here (https://golang.org/cmd/cgo/) have not + ;; worked. The tests continue to state that t= hey + ;; can not find crt1.o despite being present. + "cmd/go/testdata/script/list_compiled_imports= .txt" + "cmd/go/testdata/script/mod_case_cgo.txt" + ;; https://github.com/golang/go/issues/24884 + "os/user/user_test.go")) + + (substitute* "os/os_test.go" + (("/usr/bin") (getcwd)) + (("/bin/pwd") (which "pwd")) + (("/bin/sh") (which "sh"))) + + (substitute* "cmd/vendor/golang.org/x/sys/unix/syscall_un= ix_test.go" + (("/usr/bin") "/tmp")) + + ;; Add libgcc to runpath + (substitute* "cmd/link/internal/ld/lib.go" + (("!rpath.set") "true")) + (substitute* "cmd/go/internal/work/gccgo.go" + (("cgoldflags :=3D \\[\\]string\\{\\}") + (string-append "cgoldflags :=3D []string{" + "\"-rpath=3D" gcclib "\"" + "}")) + (("\"-lgcc_s\", ") + (string-append + "\"-Wl,-rpath=3D" gcclib "\", \"-lgcc_s\", "))) + (substitute* "cmd/go/internal/work/gc.go" + (("ldflags =3D setextld\\(ldflags, compiler\\)") + (string-append + "ldflags =3D setextld(ldflags, compiler)\n" + "ldflags =3D append(ldflags, \"-r\")\n" + "ldflags =3D append(ldflags, \"" gcclib "\")\n"))) + + ;; Disable failing tests: these tests attempt to access + ;; commands or network resources which are neither availa= ble + ;; nor necessary for the build to succeed. + (for-each + (match-lambda + ((file regex) + (substitute* file + ((regex all before test_name) + (string-append before "Disabled" test_name))))) + '(("net/net_test.go" "(.+)(TestShutdownUnix.+)") + ("net/dial_test.go" "(.+)(TestDialTimeout.+)") + ("os/os_test.go" "(.+)(TestHostname.+)") + ("time/format_test.go" "(.+)(TestParseInSydney.+)") + ("time/format_test.go" "(.+)(TestParseInLocation.+)") + ("os/exec/exec_test.go" "(.+)(TestEcho.+)") + ("os/exec/exec_test.go" "(.+)(TestCommandRelativeName.= +)") + ("os/exec/exec_test.go" "(.+)(TestCatStdin.+)") + ("os/exec/exec_test.go" "(.+)(TestCatGoodAndBadFile.+)= ") + ("os/exec/exec_test.go" "(.+)(TestExitStatus.+)") + ("os/exec/exec_test.go" "(.+)(TestPipes.+)") + ("os/exec/exec_test.go" "(.+)(TestStdinClose.+)") + ("os/exec/exec_test.go" "(.+)(TestIgnorePipeErrorOnSuc= cess.+)") + ("syscall/syscall_unix_test.go" "(.+)(TestPassFD\\(.+)= ") + ("os/exec/exec_test.go" "(.+)(TestExtraFiles/areturn.+= )") + ("cmd/go/go_test.go" "(.+)(TestCoverageWithCgo.+)") + ("cmd/go/go_test.go" "(.+)(TestTwoPkgConfigs.+)") + ("os/exec/exec_test.go" "(.+)(TestOutputStderrCapture.= +)") + ("os/exec/exec_test.go" "(.+)(TestExtraFiles.+)") + ("os/exec/exec_test.go" "(.+)(TestExtraFilesRace.+)") + ("net/lookup_test.go" "(.+)(TestLookupPort.+)") + ("syscall/exec_linux_test.go" + "(.+)(TestCloneNEWUSERAndRemapNoRootDisableSetgroups.= +)"))) + + ;; fix shebang for testar script + ;; note the target script is generated at build time. + (substitute* "../misc/cgo/testcarchive/carchive_test.go" + (("#!/usr/bin/env") (string-append "#!" (which "env")))) + + (substitute* "net/lookup_unix.go" + (("/etc/protocols") (string-append net-base "/etc/proto= cols"))) + (substitute* "net/port_unix.go" + (("/etc/services") (string-append net-base "/etc/servic= es"))) + (substitute* "time/zoneinfo_unix.go" + (("/usr/share/zoneinfo/") tzdata-path)) + (substitute* (find-files "cmd" "\\.go") + (("/lib(64)?/ld-linux.*\\.so\\.[0-9]") loader)) + #t))) + (replace 'set-bootstrap-variables + (lambda* (#:key outputs inputs #:allow-other-keys) + ;; Tell the build system where to find the bootstrap Go. + (let ((go (assoc-ref inputs "go"))) + (setenv "GOROOT_BOOTSTRAP" go) + (setenv "GOGC" "400") + ;; Go 1.10 tries to write to $HOME in a test + (setenv "HOME" "/tmp") + #t))))))))) + (define-public go go-1.9) =20 (define-public go-github-com-alsm-ioprogress --=20 2.17.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 19 17:20:37 2018 Received: (at 32768) by debbugs.gnu.org; 19 Sep 2018 21:20:37 +0000 Received: from localhost ([127.0.0.1]:46091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2jtk-00008p-Mc for submit@debbugs.gnu.org; Wed, 19 Sep 2018 17:20:36 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:54469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2jti-00008h-QD for 32768@debbugs.gnu.org; Wed, 19 Sep 2018 17:20:35 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7536921CE2; Wed, 19 Sep 2018 17:20:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 19 Sep 2018 17:20:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=9rjcO5MpBEuiynATf+pNi1jgkxuPGmKQME76wVkw0ew=; b=yvae2 gLxoqBZmsA42VR1DhXjBOcWRmDPqmGoN/vBmu+D4D+ZQNKxeceaXW4QjOpJ554Vr uk37hrcJ/4f4k6cvmt6xpGSvSLu7SNRPzK75LOJN/FjkrmVtNnzMBIJ+5WLztI7B tV6wgOVoROTYcis6qGpftEQ9e/l6Ct9UJTZ3z0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=9rjcO5MpBEuiynATf+pNi1jgkxuPG mKQME76wVkw0ew=; b=pySk1T6xMccFsxg092gLotyBeEifAIlbEMNxT+UXEN6cP dedfTOekwobvi2IZpb6rd/D0+a0N3nMiAeRuB+I/9cpW/WdbFWa76l2F/UzAjiaZ 8gwmYGd6H8z6vfPdFgTgX5t/gJ8c5uVma+8uaL5/bd9VA9Dwp9/dIVGoXjh3D8H8 R4owf83fc4MBxnvKF3mUjKDDcE0Cvio5j9iUlGX+GcISGftd+6/CcEZelvg4eZrQ P46C3/xn6035Nmq4LVq/Hc4BpZYHaBznGDX2vtZDrEusgwqZb4ciaQ+Hw6x6uS4B RIhtJ6jLJKaEdKiPB01I7gLccSNnEpPSoBwJheCxg== X-ME-Proxy: X-ME-Sender: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 935BFE4149; Wed, 19 Sep 2018 17:20:33 -0400 (EDT) Date: Wed, 19 Sep 2018 17:20:32 -0400 From: Leo Famulari To: Katherine Cox-Buday Subject: Re: [bug#32768] [PATCH] gnu: go-1.11: Add New Version Message-ID: <20180919212032.GA6893@jasmine.lan> References: <877ejinqph.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: <877ejinqph.fsf@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 32768 Cc: 32768@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 18, 2018 at 09:52:58PM -0500, Katherine Cox-Buday wrote: > +(define-public go-1.11 Thanks! I tested that some basic packages build within the go-build-system using Go 1.11 (several need to be updated to support Go 1.11, however). > + ;; A side affect of these test scripts is testing > + ;; cgo. Attempts at using cgo flags and > + ;; directives with these scripts as specified > + ;; here (https://golang.org/cmd/cgo/) have not > + ;; worked. The tests continue to state that they > + ;; can not find crt1.o despite being present. > + "cmd/go/testdata/script/list_compiled_imports.txt" > + "cmd/go/testdata/script/mod_case_cgo.txt" > + ;; https://github.com/golang/go/issues/24884 > + "os/user/user_test.go")) Okay, we can punt on this for now. > + (replace 'set-bootstrap-variables > + (lambda* (#:key outputs inputs #:allow-other-keys) > + ;; Tell the build system where to find the bootstrap Go. > + (let ((go (assoc-ref inputs "go"))) > + (setenv "GOROOT_BOOTSTRAP" go) > + (setenv "GOGC" "400") > + ;; Go 1.10 tries to write to $HOME in a test > + (setenv "HOME" "/tmp") > + #t))))))))) This phase is identical to the one that would be inherited from Go 1.10, right? --huq684BweRXVnRxX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAluivZ0ACgkQJkb6MLrK fwgRqw//T+LVyXgkI6xdWTiR/PjNIBUWMWmhj2YCpZAr6HyHIVZxQfYTu9FUaBXm Plwc/EW3HzhFc3pMTcRIWUQqaHTEmsFba3UVKNUNk2ckjjPlSOyBe0jAlKYJC/xF DAlFnO8O8mtB/KrRe1aPRjumOMdDz/YsU5m4vJfFQcD6+abjc2iZ1IxhJU6/aRKo sWyZlR7ehoITpmfTpBDcQ4zU2b5cvtniSfDLqOsGaooR2sumxcxpUWvXNyknpzOo 7O2Mdko/tCB9EJL/GFFU9dt0KK8vJ0XzarNXVqNoT0YsdMemZUaVAU9JXDiXrDRB rZzpgXmy9jJ/m2qT+PATHwYE/8dN9f2QIKAVNDVDdzCxviavCMHOPuv/tAGSQALG 4rHhlmQOgX3vbOvUlQAmd3y61CW5Q/M/F63Jw9RBlihr0H+IXfktDtYG0SK1CLHM qb9t+DMe3RbGoGwmBtNlZQL4CbGa3CtHNQUcmzIeJGWm0hpses1EoHOOhYc/wRWa BgqB5QDTVvBF9E1ccwa3nQZ5ygra1KB2nFe1KjfPGiqWSsJMwbKAomNEgwcbDnkM 34+leODsZZXhN2HP8fQusYoyAGswPINf96W3PlhznaDhmJ3wv2YSF0Hf5cImzXW9 AHQB8lzSdqh8+cReojF8HDPuFMjHT/qvWD9iHAEoc12CG4sXFIg= =JgKn -----END PGP SIGNATURE----- --huq684BweRXVnRxX-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 21 10:58:42 2018 Received: (at 32768) by debbugs.gnu.org; 21 Sep 2018 14:58:42 +0000 Received: from localhost ([127.0.0.1]:48321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3MtD-0002T6-2d for submit@debbugs.gnu.org; Fri, 21 Sep 2018 10:58:42 -0400 Received: from mail-it1-f169.google.com ([209.85.166.169]:37435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3MtB-0002Sp-9V for 32768@debbugs.gnu.org; Fri, 21 Sep 2018 10:58:37 -0400 Received: by mail-it1-f169.google.com with SMTP id h20-v6so2197617itf.2 for <32768@debbugs.gnu.org>; Fri, 21 Sep 2018 07:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4+c2CTjkmj0Mq0IS5IzfVrFKCiP5vklZ5suife2itmc=; b=Kwfw2XKEfHE//+RZdAxCfAY4ZWzHlr8Yd0y58Fcc8UKG/Qa7gvCSVEovuKqpJrd/eR UkjOzoOUGWCQwi8MJUhvcJgJOrBJe0f+eTyCbxSndud/ylYDQi4uNtZ1g0O7YFWGjkCF OUUPP/9nH82AKb4xnz9i0UEl9G6cQliFEWCSF/8S4WXHA6e5fiKZqMla1FnXRE+jPv16 PpiZE8bDqHyPUaq2tCqeAEp40adHp5Y5ADrVvEr9z8IxnS066FfncBmgdLpHEHO2vfdf YO609ptYDSqt4bgUG1EtM6sfSHIunpMWQgbi6tSh+xKiysdzFBnqQ6HoParS7qct3+QP bshg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=4+c2CTjkmj0Mq0IS5IzfVrFKCiP5vklZ5suife2itmc=; b=Spe7mXyNBxPb3MVbrol/+xkFW+jbjTBX2IzXOoLSCvOG6o+wEgr+tB2lg+of2SzstR 4rLa6qmO1kX9E5YHb7/89s5BIn+IBeb0aa3Y/bT8dMBMAkuog0t+2HBl4VLW7viJgCpe Sn3idzo+SFv0hKSnEJRW4C1CBqBVkdsFFe8xkiKRj+A5rm63UCY4uVgZehYqFJkK4c51 QpVIHGoQCzl1awoWnCo6A27kFvP25nxDmYb2srXvhtGFclkH7akEX1Undn35b31sPPd/ XB6S5604bjWmsNpsAjsoFUgVbFkwA9wuEM4+GN6CiUjgPUPhT9brUqbqfntL595AI1EL y5jg== X-Gm-Message-State: APzg51BNrgx9p9Zh1mnhe+EPbqrO0tOi++GWhxreZ/aVXmgDdxwaJplb xo2+JNMoxUD7LdLnIW4RL1ssdgfu X-Google-Smtp-Source: ANB0VdZFE5QaSt9RJs8Kn+gyWJllvOviJfxu5g9VSuB5hlbdDvmz3cNztI0stbGnQ5cibrhH8iS8Ig== X-Received: by 2002:a24:3d52:: with SMTP id n79-v6mr6064599itn.68.1537541911177; Fri, 21 Sep 2018 07:58:31 -0700 (PDT) Received: from gazelle-pro (172-221-246-205.dhcp.chtrptr.net. [172.221.246.205]) by smtp.gmail.com with ESMTPSA id w64-v6sm2502498ita.7.2018.09.21.07.58.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Sep 2018 07:58:29 -0700 (PDT) From: Katherine Cox-Buday To: Leo Famulari Subject: Re: [bug#32768] [PATCH] gnu: go-1.11: Add New Version References: <877ejinqph.fsf@gmail.com> <20180919212032.GA6893@jasmine.lan> Date: Fri, 21 Sep 2018 09:58:28 -0500 In-Reply-To: <20180919212032.GA6893@jasmine.lan> (Leo Famulari's message of "Wed, 19 Sep 2018 17:20:32 -0400") Message-ID: <8736u2oq23.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32768 Cc: 32768@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > I tested that some basic packages build within the go-build-system > using Go 1.11 (several need to be updated to support Go 1.11, > however). Great to hear. I didn't think to do that, thanks! > Okay, we can punt on this for now. For future code spelunkers, I tried setting environmental variables in the scripts pointing to glibc's lib path (and verified this was correct), and also tried using cgo directives in the files. This technique worked for resolving linux headers, but did not work for resolving requisite libraries. I'm guessing this is because they try and sandbox these scripts, but I'm not sure. >> + (replace 'set-bootstrap-variables >> + (lambda* (#:key outputs inputs #:allow-other-keys) >> + ;; Tell the build system where to find the bootstrap Go. >> + (let ((go (assoc-ref inputs "go"))) >> + (setenv "GOROOT_BOOTSTRAP" go) >> + (setenv "GOGC" "400") >> + ;; Go 1.10 tries to write to $HOME in a test >> + (setenv "HOME" "/tmp") >> + #t))))))))) > > This phase is identical to the one that would be inherited from Go > 1.10, > right? Yes, thanks! Removed. As an aside, this workflow is new to me. I'd greatly appreciate any pointers on convention if anyone has any. I hope I'm doing this correctly :) --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Remove-Unecessary-Stage-Replacement.patch >From 52199d74e7e417f6257b2bdf73b9982724183347 Mon Sep 17 00:00:00 2001 In-Reply-To: <32768@debbugs.gnu.org> References: <32768@debbugs.gnu.org> From: Katherine Cox-Buday Date: Fri, 21 Sep 2018 09:38:23 -0500 Subject: [PATCH] Remove Unecessary Stage Replacement --- gnu/packages/golang.scm | 9 --------- 1 file changed, 9 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index be404cc16..9c7a2e209 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -616,15 +616,6 @@ in the style of communicating sequential processes (@dfn{CSP}).") (("/usr/share/zoneinfo/") tzdata-path)) (substitute* (find-files "cmd" "\\.go") (("/lib(64)?/ld-linux.*\\.so\\.[0-9]") loader)) - #t))) - (replace 'set-bootstrap-variables - (lambda* (#:key outputs inputs #:allow-other-keys) - ;; Tell the build system where to find the bootstrap Go. - (let ((go (assoc-ref inputs "go"))) - (setenv "GOROOT_BOOTSTRAP" go) - (setenv "GOGC" "400") - ;; Go 1.10 tries to write to $HOME in a test - (setenv "HOME" "/tmp") #t))))))))) (define-public go go-1.9) -- 2.17.1 --=-=-= Content-Type: text/plain -- Katherine --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 22 14:44:25 2018 Received: (at 32768-done) by debbugs.gnu.org; 22 Sep 2018 18:44:25 +0000 Received: from localhost ([127.0.0.1]:49859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3mtF-0001GO-Fd for submit@debbugs.gnu.org; Sat, 22 Sep 2018 14:44:25 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3mtC-0001GF-Ng for 32768-done@debbugs.gnu.org; Sat, 22 Sep 2018 14:44:24 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3F38E21C5F; Sat, 22 Sep 2018 14:44:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 22 Sep 2018 14:44:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=tF9KCx0Oktny0EDtD4bgW7Xdjjke+7HG1146n14zU0w=; b=sT9df SNL53eTcBSAjA7COMzZs++se8FdFP6RcnsBdmTj16PJXq4r0XivcF+rLbZFbgzdV fEP6Py27D7yW+MyDlJV+IY/tx+LWVScXk0oeC9I1mN26FVCva6iuRJMlFdjt2BpL /F7BccnF2GnKouPMka2uvbcgVtSRbVg96ZNzqE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=tF9KCx0Oktny0EDtD4bgW7Xdjjke+ 7HG1146n14zU0w=; b=Au3VV/7Tdt5QJhqB4wUNpy/JzREG9MvJJ5LehUW0YrZbi E7bkSfpIzCId5x9IO4ETJQWr6Na7kPnL3VTVn8PU4WSr20FEzMwu/6MxaqjLSpbM eT4r2br3f6+iGgBu8JsaO9JC20oybbgumKmdS0FqCQgCOKAFtl5m+kugebaF/SZb T7tIdZSzKNJZ43vbP8XUFmDobJgROAllZZ/V5rkpUVk5U8qpLRZaivLw4Ermwu63 c1l6oypUo5TK2oeuv1S9adczlKpX3msAgkCct9oVob+tzDMAccKYrOeECx6HpMGU 9w8Jihdsgrx6yrcTUwuVJfTrIsh/VjOLGGbyWWK2w== X-ME-Proxy: X-ME-Sender: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 79580E447F; Sat, 22 Sep 2018 14:44:19 -0400 (EDT) Date: Sat, 22 Sep 2018 14:44:18 -0400 From: Leo Famulari To: Katherine Cox-Buday Subject: Re: [bug#32768] [PATCH] gnu: go-1.11: Add New Version Message-ID: <20180922184418.GA32763@jasmine.lan> References: <877ejinqph.fsf@gmail.com> <20180919212032.GA6893@jasmine.lan> <8736u2oq23.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <8736u2oq23.fsf@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 32768-done Cc: 32768-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 21, 2018 at 09:58:28AM -0500, Katherine Cox-Buday wrote: >=20 > > I tested that some basic packages build within the go-build-system > > using Go 1.11 (several need to be updated to support Go 1.11, > > however). >=20 > Great to hear. I didn't think to do that, thanks! It can be done per-package by setting '#:go ,go-1.11' in the arguments field of the package you'd like to test, or for the entire go-build-system like this: diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm index cf9116327..80894677f 100644 --- a/guix/build-system/go.scm +++ b/guix/build-system/go.scm @@ -44,7 +44,7 @@ (define (default-go) ;; Lazily resolve the binding to avoid a circular dependency. (let ((go (resolve-interface '(gnu packages golang)))) - (module-ref go 'go))) + (module-ref go 'go-1.11))) =20 (define* (lower name #:key source inputs native-inputs outputs system target > > This phase is identical to the one that would be inherited from Go > > 1.10, > > right? >=20 > Yes, thanks! Removed. Great! Pushed as 21280a8cd805ace5f95cd2580b8a6ca1e25050d7 > As an aside, this workflow is new to me. I'd greatly appreciate any > pointers on convention if anyone has any. I hope I'm doing this > correctly :) > From 52199d74e7e417f6257b2bdf73b9982724183347 Mon Sep 17 00:00:00 2001 > In-Reply-To: <32768@debbugs.gnu.org> > References: <32768@debbugs.gnu.org> > From: Katherine Cox-Buday > Date: Fri, 21 Sep 2018 09:38:23 -0500 > Subject: [PATCH] Remove Unecessary Stage Replacement In general, I prefer to make a change like this locally, amend the original commit (I use `git add --patch && git commit --amend --verbose`), and then send a new version of the original patch. git-format-patch and git-send-email both take the --subject-prefix argument, so you can generate the new patch with, for example, '--subject-prefix=3Dv2'. Then the subject line of your patch or email is helpfully annotated: Subject: [v2] gnu: Add Go 1.11. But, for simple edits like this, or when there is only one patch, sending a diff on the original patch works, too. Please let us know if you have other workflow questions! --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlumjYEACgkQJkb6MLrK fwhKAhAArXVspfbDfb8WLzJeNiC/qVAPTEkQpDUx0+MmdtjJpYBnN+pz7rdBeSSg ICJg4uIaExDeSIfsbHkX1hXD69UhIMJWL8tR58P4zEvltWjK4WlH9fn0pFSiEI1p T0Yps+DjemtGJZMoL/Dy4wGpNSpKL0d9u7Vxk7jJpKJHfOG4EuvYD2WKE1q0oQ4K Bv90lhwwKekX/Mr+51xB0nDoYnBO6Jbd3tnQ1/th3W3uZhpKvAxjou+fOr9Ut2JV w34fj6kbBIOYRd68di5ThZkwR6A3iSFb+YYouFixirUw7Uj1hULJ/onKdfQyxeFS ZZ/zBZ+H8T98cGGuBWlKOYU41c2hfWdC2ON/fATaeETiFjFFIToFumzumX7vLORj fVBRlvz4E+3fSpk54mf+7JeymF8nrZVKfSXORieEGKVeOzBC0D4kAdZNsnBvFVyt aUI/uahNHN+uIg3hUMa9Ey+Jcde9RKR0wh2ATTnWd1yMd6n1aH7OHgwrllBsHjBc BAJEqXb3hLXwL41F/L7VlSuHLkAz8MUpefDKXqgerCVqlX3Zdzu4uOipRKIATYzz 0zHoPIf9r+Y7mpgz9RGYjGtQRKvxKPU+/ug1RvcBo3aE37AUIW/hQJIKeAfDcCj2 AJanhKt1tJ9F9Xvv+AQ2nfFjMBb2lnaD/QHPqru396zqf6yeb1c= =jXg+ -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU-- From unknown Sat Jun 21 10:39:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 21 Oct 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator