From unknown Mon Jun 23 09:36:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#32755 <32755@debbugs.gnu.org> To: bug#32755 <32755@debbugs.gnu.org> Subject: Status: [PATCH] erc.el: Remove warning during compilation. Reply-To: bug#32755 <32755@debbugs.gnu.org> Date: Mon, 23 Jun 2025 16:36:39 +0000 retitle 32755 [PATCH] erc.el: Remove warning during compilation. reassign 32755 emacs submitter 32755 Gabriel Beauchamp severity 32755 minor tag 32755 wontfix patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 17 17:37:45 2018 Received: (at submit) by debbugs.gnu.org; 17 Sep 2018 21:37:45 +0000 Received: from localhost ([127.0.0.1]:43434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g21DF-0004Jy-1P for submit@debbugs.gnu.org; Mon, 17 Sep 2018 17:37:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g21DE-0004Jk-5F for submit@debbugs.gnu.org; Mon, 17 Sep 2018 17:37:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g21D7-0006O6-RJ for submit@debbugs.gnu.org; Mon, 17 Sep 2018 17:37:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40833) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g21D7-0006NX-JO for submit@debbugs.gnu.org; Mon, 17 Sep 2018 17:37:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g21D6-0007l6-Gf for bug-gnu-emacs@gnu.org; Mon, 17 Sep 2018 17:37:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g21D3-0005uV-7M for bug-gnu-emacs@gnu.org; Mon, 17 Sep 2018 17:37:36 -0400 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]:40417) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g21D2-0005Z0-LP for bug-gnu-emacs@gnu.org; Mon, 17 Sep 2018 17:37:32 -0400 Received: by mail-qk1-x72c.google.com with SMTP id c126-v6so9862572qkd.7 for ; Mon, 17 Sep 2018 14:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=9uMXYkZq7ZMqwI/7GrmQM2Tz75kZGfIPKNx3H+AfXPQ=; b=hNOq2FYwsVkli2ayQfg4g3FMeSVv7ZZSjUjSgm9ly6JfKjj7W+m0eN3PSMNM99YS5n c3mW7lmZ0WlvchheUugCy/RdBpWBFMwdLPI97hJXEAfgtRFDesVJCq9jmaaYiMO8thYA Gxnka/vs8/NterYK81c6qLr7HF6MjOOYIh2PomyFgTyHJNSed3x+S2Hbmy4KoUp3gmtW KHV9o3NqPPadiR9dyM9WkAtps2FYFLHyzkc6+9jIAiYt5WAcjKgjHJn9ffWTP3ziyfWS UiE4F8jY0c04u877Dqy12jVDgVpUrP+zhsZxAh6qiNHw0ENHZ3YfwegTjofbWULzt9YM GsBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=9uMXYkZq7ZMqwI/7GrmQM2Tz75kZGfIPKNx3H+AfXPQ=; b=BRPhw3YGL6h/RwethXOvg9gdkypAGicac7+z5BxY8FZWxJ432LLrcNppyEenHm0rMs vE7tyoXTsEDWcSzEag6MeYtVD4MX50zvvNJpx8opz4YleJsy4sPAXGxQzmwz7Al7WBQ8 tDC1fWNJyKQaIRUSJ9ed5iUwWA0rQV98NLVLlt1JqLWCd8orBVBQfpl8YFC1p1KxgLJd DADuoVZ9DKGlxtJ2mg3O9+u+MUn8ARlSD24MXiqg2MrL1ts5vPNxdHzdOZd/aLzC2owg Quxvd3doX3a1rP9XB3AfTRU2JggwdJ1GGZ/raj699/ECg28nRJhutcUULUfAlyDkos+Z 6jdA== X-Gm-Message-State: APzg51DhYM7WmILL+jFcgzLLkFuGWMilOAXiRh0kkUrJ/ewmyZFbuDKX A/HvwFECVoVuOq1ATv2GB5Syodjencs= X-Google-Smtp-Source: ANB0VdbaqyAo2E6EqqjlDtMA57B5Kt5T4Fu+mxY/yME73Gp44s4YSZux9xNn0yeknw84vgrfcqWK9A== X-Received: by 2002:a37:1383:: with SMTP id 3-v6mr18123630qkt.129.1537220241035; Mon, 17 Sep 2018 14:37:21 -0700 (PDT) Received: from g-ThinkPad-X230 ([206.167.112.182]) by smtp.gmail.com with ESMTPSA id o5-v6sm11788508qtc.63.2018.09.17.14.37.20 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Sep 2018 14:37:20 -0700 (PDT) From: Gabriel Beauchamp To: bug-gnu-emacs@gnu.org Subject: [PATCH] erc.el: Remove warning during compilation. Date: Mon, 17 Sep 2018 17:37:20 -0400 Message-ID: <87d0tbiz5b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Hi, I have attached a patch that removes a warning during the compilation of erc. Tested with `emacs -Q -q' running on HEAD. Thanks, Gabriel --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-erc-erc.el-erc-handle-irc-url-Remove-warning-du.patch Content-Description: Remove warning during compilation >From cc6d9c0c83fb62172aec5456c1ae16f217478346 Mon Sep 17 00:00:00 2001 From: Gabriel Beauchamp Date: Mon, 17 Sep 2018 17:07:13 -0400 Subject: [PATCH] * lisp/erc/erc.el (erc-handle-irc-url): Remove warning during compilation. --- lisp/erc/erc.el | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index fc51009641..eb9082fa2f 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -5450,14 +5450,14 @@ erc-send-input (beep)) nil) (t - (defvar str) ;; FIXME: Make it obey the "erc-" prefix convention. - (let ((str input) + (defvar erc--str) + (let ((erc--str input) (erc-insert-this t)) (setq erc-send-this t) (run-hook-with-args 'erc-send-pre-hook input) (when erc-send-this - (if (or (string-match "\n" str) - (not (string-match erc-command-regexp str))) + (if (or (string-match "\n" erc--str) + (not (string-match erc-command-regexp erc--str))) (mapc (lambda (line) (mapc @@ -5468,8 +5468,8 @@ erc-send-input (null erc-flood-protect) t)) (or (and erc-flood-protect (erc-split-line line)) (list line)))) - (split-string str "\n")) - (erc-process-input-line (concat str "\n") t nil)) + (split-string erc--str "\n")) + (erc-process-input-line (concat erc--str "\n") t nil)) t))))) (defun erc-display-command (line) -- 2.17.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 17 23:19:37 2018 Received: (at 32755) by debbugs.gnu.org; 18 Sep 2018 03:19:37 +0000 Received: from localhost ([127.0.0.1]:43506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g26Y5-0006U5-6j for submit@debbugs.gnu.org; Mon, 17 Sep 2018 23:19:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g26Y3-0006Ts-OE for 32755@debbugs.gnu.org; Mon, 17 Sep 2018 23:19:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g26Xx-0000RZ-R9 for 32755@debbugs.gnu.org; Mon, 17 Sep 2018 23:19:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g26Xw-0000Pi-Gw; Mon, 17 Sep 2018 23:19:28 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1g26Xw-0001k6-CV; Mon, 17 Sep 2018 23:19:28 -0400 From: Glenn Morris To: Gabriel Beauchamp Subject: Re: bug#32755: [PATCH] erc.el: Remove warning during compilation. References: <87d0tbiz5b.fsf@gmail.com> X-Spook: Airplane munitions National security Conficker ASIO DES X-Ran: ])c:ts!ySP8r0_kSQs=]smg~n>[_(THQi-o=H6~kU50%d93fPG[DSDSmXi-669pnr=~Uj6 X-Hue: brightwhite X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 17 Sep 2018 23:19:28 -0400 In-Reply-To: <87d0tbiz5b.fsf@gmail.com> (Gabriel Beauchamp's message of "Mon, 17 Sep 2018 17:37:20 -0400") Message-ID: <1kfty7sda7.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32755 Cc: 32755@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Gabriel Beauchamp wrote: > I have attached a patch that removes a warning during the compilation of > erc. Tested with `emacs -Q -q' running on HEAD. Thanks for the patch, however if someone writes FIXME for this kind of thing rather than just doing it, it's usually because it's not so straightforward. In this case, `str' is an advertised part of the interface - see doc of `erc-send-pre-hook'. > Subject: [PATCH] * lisp/erc/erc.el (erc-handle-irc-url): Remove > warning during compilation. You changed erc-send-input, not erc-handle-irc-url. (You can use eg C-x 4 a on the diff for this kind of thing.) From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 19 13:54:08 2018 Received: (at control) by debbugs.gnu.org; 19 Sep 2018 17:54:08 +0000 Received: from localhost ([127.0.0.1]:45937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2gfv-0000VL-Rf for submit@debbugs.gnu.org; Wed, 19 Sep 2018 13:54:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2gfu-0000Us-Ud for control@debbugs.gnu.org; Wed, 19 Sep 2018 13:54:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2gfo-0003Tz-Ty for control@debbugs.gnu.org; Wed, 19 Sep 2018 13:54:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2gfn-0003Sl-DZ for control@debbugs.gnu.org; Wed, 19 Sep 2018 13:53:59 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1g2gfl-0002pt-Fm for control@debbugs.gnu.org; Wed, 19 Sep 2018 13:53:59 -0400 Subject: control message for bug 32755 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Wed, 19 Sep 2018 13:53:57 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) # talked off-list tag 32755 wontfix close 32755 From unknown Mon Jun 23 09:36:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 18 Oct 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator