From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 17 15:47:47 2018 Received: (at submit) by debbugs.gnu.org; 17 Sep 2018 19:47:47 +0000 Received: from localhost ([127.0.0.1]:43379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1zUp-0005wO-Cr for submit@debbugs.gnu.org; Mon, 17 Sep 2018 15:47:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1zUn-0005wB-NX for submit@debbugs.gnu.org; Mon, 17 Sep 2018 15:47:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1zUh-0005Tr-TS for submit@debbugs.gnu.org; Mon, 17 Sep 2018 15:47:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45689) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g1zUh-0005Ti-QC for submit@debbugs.gnu.org; Mon, 17 Sep 2018 15:47:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1zUh-0008Ll-4Q for bug-gnu-emacs@gnu.org; Mon, 17 Sep 2018 15:47:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1zUg-0005Rm-Hf for bug-gnu-emacs@gnu.org; Mon, 17 Sep 2018 15:47:39 -0400 Received: from sinyavsky.aurox.ch ([2a03:2040:2:1b::1]:58878) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g1zUg-0005OH-7V for bug-gnu-emacs@gnu.org; Mon, 17 Sep 2018 15:47:38 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id BCF062285A for ; Mon, 17 Sep 2018 19:51:20 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= subject:subject:to:from:from:message-id:date:date; s=dkim; t= 1537213880; x=1538077881; bh=iQYciWMHrO/3lfFBeyBb5S+C84Y2mJftenY Az1hiB4A=; b=hoUiW8hVnI6tvwniTHEg/iFrPGLWUfp5iI5ZUG4dg270vWO++mL GGqie8MWyFVqM9fFqkqcG7pPMlkxhtAtJgcPMHp6ot0DG4DI1svLx4oN7FRgwVi+ tPyNifHodyxZcszGbwQo6tazyn5BPcn7t1Y45gYrs2hE9yEU1nDrlwFE= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jpl5hNuAIvGT for ; Mon, 17 Sep 2018 19:51:20 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 4B7A222858 for ; Mon, 17 Sep 2018 19:51:20 +0000 (UTC) Date: Mon, 17 Sep 2018 21:49:44 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: bug-gnu-emacs@gnu.org Subject: vc-retrieve-tag-hook X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) We have this hook in vc.el: ;;;###autoload (defcustom vc-checkout-hook nil "Normal hook (list of functions) run after checking out a file. See `run-hooks'." :type 'hook :group 'vc :version "21.1") It does not seem to run when you retrieve a tag or branch with C-x v r with the vc-git backend, and correctly so (I think), as the docstring mentions that it should only run after checking out a file, not a tag or branch. I suggest adding a hook to run at the end of vc-retrieve-tag, named "vc-retrieve-tag-hook". From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 01 14:22:24 2018 Received: (at 32754) by debbugs.gnu.org; 1 Oct 2018 18:22:24 +0000 Received: from localhost ([127.0.0.1]:33502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g72pq-0003Kx-Fj for submit@debbugs.gnu.org; Mon, 01 Oct 2018 14:22:23 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:54021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g72po-0003Kh-0f for 32754@debbugs.gnu.org; Mon, 01 Oct 2018 14:22:20 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id B1A6D2287C for <32754@debbugs.gnu.org>; Mon, 1 Oct 2018 18:26:11 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1538418371; x=1539282372; bh=3V OJ9P+oEvrjKuiWyr19CKBiV10qcah7SbTl1S+WQfs=; b=V7H06lo5cdjnb7cgUB MC9d/Af5JRWkIvczc1VAfc2tZNmgv/R6IFK3oX7HrLui67vjs4VJJYM0luQyL5V1 enp04weCemPdXQ+Hk1PKPC8emh8AunbKuEzLvy6IJ6CU9laqRzfG7oHuqlAD8iLQ K3cKXCRTT4OWblcVFhudZYrrM= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sGuBuPeGOCTG for <32754@debbugs.gnu.org>; Mon, 1 Oct 2018 18:26:11 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id E6887226F4 for <32754@debbugs.gnu.org>; Mon, 1 Oct 2018 18:26:10 +0000 (UTC) Date: Mon, 01 Oct 2018 20:25:24 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: 32754@debbugs.gnu.org In-reply-to: (help-debbugs@gnu.org) Subject: Re: bug#32754: (vc-retrieve-tag-hook) References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 32754 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: charles@aurox.ch Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Here's the patch for review. Hooks in VC are documented only in vc.el, so I have not added further documentation elsewhere. diff --git a/etc/NEWS b/etc/NEWS index daacf49..1d5820c 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -329,6 +329,8 @@ git-grep when 'vc-git-grep' is used. When some files are marked, only those are stashed. When no files are marked, all modified files are stashed, as before. +*** The new hook 'vc-retrieve-tag-hook' runs after retrieving a tag. + ** diff-mode *** Hunks are now automatically refined by default. To disable it, set the new defcustom 'diff-font-lock-refine' to nil. diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index d3d66d6..243a796 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -834,6 +834,13 @@ vc-before-checkin-hook :type 'hook :group 'vc) +;;;###autoload +(defcustom vc-retrieve-tag-hook nil + "Normal hook (list of functions) run after retrieving a tag." + :type 'hook + :group 'vc + :version "27.1") + (defcustom vc-revert-show-diff t "If non-nil, `vc-revert' shows a `vc-diff' buffer before querying." :type 'boolean @@ -2154,7 +2161,8 @@ vc-retrieve-tag If NAME is empty, it refers to the latest revisions of the current branch. If locking is used for the files in DIR, then there must not be any locked files at or below DIR (but if NAME is empty, locked files are -allowed and simply skipped)." +allowed and simply skipped). +This function runs the hook `vc-retrieve-tag-hook' when finished." (interactive (let* ((granularity (vc-call-backend (vc-responsible-backend default-directory) @@ -2181,6 +2189,7 @@ vc-retrieve-tag (vc-call-backend (vc-responsible-backend dir) 'retrieve-tag dir name update) (vc-resynch-buffer dir t t t) + (run-hooks 'vc-retrieve-tag-hook) (message "%s" (concat msg "done")))) From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 08 15:51:36 2018 Received: (at 32754) by debbugs.gnu.org; 8 Oct 2018 19:51:36 +0000 Received: from localhost ([127.0.0.1]:40786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9bZ2-0002YJ-LL for submit@debbugs.gnu.org; Mon, 08 Oct 2018 15:51:36 -0400 Received: from sinyavsky.aurox.ch ([37.35.109.145]:59898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9bYz-0002Y0-ME for 32754@debbugs.gnu.org; Mon, 08 Oct 2018 15:51:34 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 11C0E22892 for <32754@debbugs.gnu.org>; Mon, 8 Oct 2018 19:55:32 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1539028531; x=1539892532; bh=Co 9cPSGLfpdHnBu4WnD/Y7MlD2sBSPfTn2eO2S/qD4g=; b=VSoi1gFVnKRsUCkfnt DkC66rmd3mQqalaqOcAlt3bE8GEoYBn3TFesbMz/osSfS+wqOhaADsbsS8iWU8VL vRv9z9hOWw9Qp1ByAY3h/6vqNiqyRKypfauXAwXl/iX+iYTIniMbdHrkSMwGNZvM KI4annBqJloBHBwPwqlScfw7o= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ytgaBuck_WXQ for <32754@debbugs.gnu.org>; Mon, 8 Oct 2018 19:55:31 +0000 (UTC) Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 2CADE22882; Mon, 8 Oct 2018 19:55:30 +0000 (UTC) Date: Mon, 08 Oct 2018 21:55:14 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: 32754@debbugs.gnu.org In-reply-to: (charles@aurox.ch) Subject: Re: bug#32754: (vc-retrieve-tag-hook) References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 32754 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: charles@aurox.ch Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 32754 fixed close 32754 27.1 quit > Date: Mon, 01 Oct 2018 20:25:24 +0200 > From: charles@aurox.ch (Charles A. Roelli) > > Here's the patch for review. Hooks in VC are documented only in > vc.el, so I have not added further documentation elsewhere. > > [...] I've pushed this as commit 76372161. From unknown Mon Jun 23 14:58:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 06 Nov 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator