GNU bug report logs - #32750
[PATCH 2/2] dfa: optmization of alternation in NFA

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Mon, 17 Sep 2018 14:16:02 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Eric Blake <eblake <at> redhat.com>
To: Paul Jackson <pj <at> usa.net>, 32750 <at> debbugs.gnu.org
Subject: bug#32750: [PATCH 2/2] dfa: optmization of alternation in NFA
Date: Tue, 18 Sep 2018 11:24:10 -0500

On 9/18/18 11:15 AM, Paul Jackson wrote:
> Norihiro Tanaka wrote:
>>> It means "No use superset for utf8".
> 
> Would a comment be useful,  such as in the following,
> (which may have to be reworded to be correct) ?
> 
> /*   Optimize DFA,  but don't use superset (noss) for utf8 */
>   static void
> -dfaoptimize (struct dfa *d)
> +dfautf8noss (struct dfa *d)

Or even some strategic spelling, as in:

dfa_utf8_no_ss

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
This bug report was last modified 6 years and 251 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.