Subject: Re: bug#32750: [PATCH 2/2] dfa: optmization of alternation in NFA

From: Eric Blake <[email-masked]>
Date: Tue, 18 Sep 2018 11:24:10 -0500

On 9/18/18 11:15 AM, Paul Jackson wrote:
> Norihiro Tanaka wrote:
>>> It means "No use superset for utf8".
> 
> Would a comment be useful,  such as in the following,
> (which may have to be reworded to be correct) ?
> 
> /*   Optimize DFA,  but don't use superset (noss) for utf8 */
>   static void
> -dfaoptimize (struct dfa *d)
> +dfautf8noss (struct dfa *d)

Or even some strategic spelling, as in:

dfa_utf8_no_ss

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org