From unknown Tue Aug 19 01:58:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32741: [PATCH] Update references in core emacs from save-place to save-place-mode Resent-From: "Mark A. Hershberger" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Sep 2018 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32741 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 32741@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15370302094194 (code B ref -1); Sat, 15 Sep 2018 16:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Sep 2018 16:50:09 +0000 Received: from localhost ([127.0.0.1]:41744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1Dlo-00015a-JG for submit@debbugs.gnu.org; Sat, 15 Sep 2018 12:50:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1Dln-00015I-CM for submit@debbugs.gnu.org; Sat, 15 Sep 2018 12:50:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1Dlg-0001Ch-WA for submit@debbugs.gnu.org; Sat, 15 Sep 2018 12:50:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g1Dlg-0001Bn-Q9 for submit@debbugs.gnu.org; Sat, 15 Sep 2018 12:50:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1Dlf-0001KA-L9 for bug-gnu-emacs@gnu.org; Sat, 15 Sep 2018 12:50:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1Dla-00015w-Lz for bug-gnu-emacs@gnu.org; Sat, 15 Sep 2018 12:49:59 -0400 Received: from nospam.nichework.com ([206.71.169.33]:42999) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g1Dla-0000zU-Ce for bug-gnu-emacs@gnu.org; Sat, 15 Sep 2018 12:49:54 -0400 Received: from localhost (localhost.localdmain [127.0.0.1]) by nospam.nichework.com (Postfix) with ESMTP id 500202AC006 for ; Sat, 15 Sep 2018 12:49:37 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at nospam.nichework.com Received: from nospam.nichework.com ([127.0.0.1]) by localhost (nospam.nichework.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3mOyDdayig0P for ; Sat, 15 Sep 2018 12:49:37 -0400 (EDT) Received: from mail.nichework.com (mail.nichework.com [108.161.151.158]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by nospam.nichework.com (Postfix) with ESMTPS id 0C9EE2AC003 for ; Sat, 15 Sep 2018 12:49:37 -0400 (EDT) Received: from mail.nichework.com (localhost.localdomain [127.0.0.1]) by mail.nichework.com (Postfix) with ESMTPS id 4AE1A4E14C6 for ; Sat, 15 Sep 2018 09:49:51 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.nichework.com (Postfix) with ESMTP id 3F1294E14AE for ; Sat, 15 Sep 2018 09:49:51 -0700 (PDT) X-Virus-Scanned: amavisd-new at mail.nichework.com Received: from mail.nichework.com ([127.0.0.1]) by localhost (mail.nichework.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9igM6onNe09t for ; Sat, 15 Sep 2018 09:49:51 -0700 (PDT) Received: from slink.everybody.org (unknown [24.229.149.248]) by mail.nichework.com (Postfix) with ESMTPSA id DF63D4E0C07 for ; Sat, 15 Sep 2018 09:49:50 -0700 (PDT) From: "Mark A. Hershberger" Date: Sat, 15 Sep 2018 12:49:49 -0400 Message-ID: <87in367ljm.fsf@everybody.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * lisp/menu-bar.el (menu-bar-options-save, menu-bar-options-menu): * lisp/saveplace.el (save-place-to-alist, save-places-to-alist, save-place-find-file-hook, save-place-dired-hook): Use save-place-mode instead of the obsolete save-place. * doc/lispref/customize.texi (Variable Definitions): Replace defcustom example from 2005 with a more recent one. --- doc/lispref/customize.texi | 12 ++++++------ lisp/menu-bar.el | 6 +++--- lisp/saveplace.el | 12 ++++++------ 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/doc/lispref/customize.texi b/doc/lispref/customize.texi index b3528b12d5..d7e97fcae7 100644 --- a/doc/lispref/customize.texi +++ b/doc/lispref/customize.texi @@ -450,14 +450,14 @@ Variable Definitions that turns on a certain feature. This causes Emacs to load the feature, if it is not already loaded, whenever the option is set. @xref{Common Keywords}. Here is an example, from the library -@file{saveplace.el}: +@file{org-bbdb.el}: @example -(defcustom save-place nil - "Non-nil means automatically save place in each file..." - :type 'boolean - :require 'saveplace - :group 'save-place) +(defcustom org-bbdb-default-anniversary-format "birthday" + "Default anniversary class." + :type 'string + :group 'org-bbdb-anniversaries + :require 'bbdb) @end example If a customization item has a type such as @code{hook} or diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 20d5ad95d8..e626369cfb 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -689,7 +689,7 @@ menu-bar-options-save debug-on-quit debug-on-error ;; Somehow this works, when tool-bar and menu-bar don't. tooltip-mode window-divider-mode - save-place uniquify-buffer-name-style fringe-mode + save-place-mode uniquify-buffer-name-style fringe-mode indicate-empty-lines indicate-buffer-boundaries case-fold-search font-use-system-font current-language-environment default-input-method @@ -1409,7 +1409,7 @@ menu-bar-options-menu (bindings--define-key menu [save-place] (menu-bar-make-toggle - toggle-save-place-globally save-place + toggle-save-place-globally save-place-mode "Save Place in Files between Sessions" "Saving place in files %s" "Visit files of previous session when restarting Emacs" @@ -1417,7 +1417,7 @@ menu-bar-options-menu ;; Do it by name, to avoid a free-variable ;; warning during byte compilation. (set-default - 'save-place (not (symbol-value 'save-place))))) + 'save-place-mode (not (symbol-value 'save-place-mode))))) (bindings--define-key menu [uniquify] (menu-bar-make-toggle diff --git a/lisp/saveplace.el b/lisp/saveplace.el index 9d3f10ac35..f8f15cabcd 100644 --- a/lisp/saveplace.el +++ b/lisp/saveplace.el @@ -27,7 +27,7 @@ ;; Automatically save place in files, so that visiting them later ;; (even during a different Emacs session) automatically moves point ;; to the saved position, when the file is first found. Uses the -;; value of buffer-local variable save-place to determine whether to +;; value of buffer-local variable save-place-mode to determine whether to ;; save position or not. ;; ;; Thanks to Stefan Schoef, who sent a patch with the @@ -176,7 +176,7 @@ save-place-local-mode (defun save-place-to-alist () ;; put filename and point in a cons box and then cons that onto the - ;; front of the save-place-alist, if save-place is non-nil. + ;; front of the save-place-alist, if save-place-mode is non-nil. ;; Otherwise, just delete that file from the alist. ;; first check to make sure alist has been loaded in from the master ;; file. If not, do so, then feel free to modify the alist. It @@ -306,8 +306,8 @@ load-save-place-alist-from-file nil)))) (defun save-places-to-alist () - ;; go through buffer-list, saving places to alist if save-place is - ;; non-nil, deleting them from alist if it is nil. + ;; go through buffer-list, saving places to alist if save-place-mode + ;; is non-nil, deleting them from alist if it is nil. (let ((buf-list (buffer-list))) (while buf-list ;; put this into a save-excursion in case someone is counting on @@ -332,7 +332,7 @@ save-place-find-file-hook (and (integerp (cdr cell)) (goto-char (cdr cell)))) ;; and make sure it will be saved again for later - (setq save-place t))))) + (setq save-place-mode t))))) (declare-function dired-goto-file "dired" (file)) @@ -357,7 +357,7 @@ save-place-dired-hook ((and (listp (cdr cell)) (assq 'dired-filename (cdr cell))) (dired-goto-file (cdr (assq 'dired-filename (cdr cell))))))) ;; and make sure it will be saved again for later - (setq save-place t))))) + (setq save-place-mode t))))) (defun save-place-kill-emacs-hook () ;; First update the alist. This loads the old save-place-file if nec. -- 2.18.0 From unknown Tue Aug 19 01:58:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Mark A. Hershberger" Subject: bug#32741: closed (Re: bug#32741: [PATCH] Update references in core emacs from save-place to save-place-mode) Message-ID: References: <83lg7uc602.fsf@gnu.org> <87in367ljm.fsf@everybody.org> X-Gnu-PR-Message: they-closed 32741 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 32741@debbugs.gnu.org Date: Sat, 22 Sep 2018 08:06:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1537603561-23946-1" This is a multi-part message in MIME format... ------------=_1537603561-23946-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #32741: [PATCH] Update references in core emacs from save-place to save-pla= ce-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 32741@debbugs.gnu.org. --=20 32741: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32741 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1537603561-23946-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 32741-done) by debbugs.gnu.org; 22 Sep 2018 08:05:10 +0000 Received: from localhost ([127.0.0.1]:48678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3cub-0006D0-TU for submit@debbugs.gnu.org; Sat, 22 Sep 2018 04:05:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3cua-0006Cf-0O for 32741-done@debbugs.gnu.org; Sat, 22 Sep 2018 04:05:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3cuR-0006R2-1l for 32741-done@debbugs.gnu.org; Sat, 22 Sep 2018 04:05:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3cuP-0006QI-N3; Sat, 22 Sep 2018 04:04:58 -0400 Received: from [176.228.60.248] (port=2452 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g3cuP-0003Vh-9g; Sat, 22 Sep 2018 04:04:57 -0400 Date: Sat, 22 Sep 2018 11:04:45 +0300 Message-Id: <83lg7uc602.fsf@gnu.org> From: Eli Zaretskii To: "Mark A. Hershberger" In-reply-to: <87in367ljm.fsf@everybody.org> (mah@everybody.org) Subject: Re: bug#32741: [PATCH] Update references in core emacs from save-place to save-place-mode References: <87in367ljm.fsf@everybody.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32741-done Cc: 32741-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: "Mark A. Hershberger" > Date: Sat, 15 Sep 2018 12:49:49 -0400 > > * lisp/menu-bar.el (menu-bar-options-save, menu-bar-options-menu): > * lisp/saveplace.el (save-place-to-alist, save-places-to-alist, > save-place-find-file-hook, save-place-dired-hook): Use > save-place-mode instead of the obsolete save-place. > * doc/lispref/customize.texi (Variable Definitions): Replace defcustom > example from 2005 with a more recent one. Thanks. I installed the first 2 changes on the release branch. Instead of the last one, I preferred to use a fictitious example, to avoid its bit-rotting with time, as the code in Emacs evolves. Btw, your employer's disclaimer has expired, so if you are still working for the same company, you need to ask them to renew it. If you changed your workplace, you may need a disclaimer from your current employer. ------------=_1537603561-23946-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Sep 2018 16:50:09 +0000 Received: from localhost ([127.0.0.1]:41744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1Dlo-00015a-JG for submit@debbugs.gnu.org; Sat, 15 Sep 2018 12:50:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1Dln-00015I-CM for submit@debbugs.gnu.org; Sat, 15 Sep 2018 12:50:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1Dlg-0001Ch-WA for submit@debbugs.gnu.org; Sat, 15 Sep 2018 12:50:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g1Dlg-0001Bn-Q9 for submit@debbugs.gnu.org; Sat, 15 Sep 2018 12:50:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1Dlf-0001KA-L9 for bug-gnu-emacs@gnu.org; Sat, 15 Sep 2018 12:50:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1Dla-00015w-Lz for bug-gnu-emacs@gnu.org; Sat, 15 Sep 2018 12:49:59 -0400 Received: from nospam.nichework.com ([206.71.169.33]:42999) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g1Dla-0000zU-Ce for bug-gnu-emacs@gnu.org; Sat, 15 Sep 2018 12:49:54 -0400 Received: from localhost (localhost.localdmain [127.0.0.1]) by nospam.nichework.com (Postfix) with ESMTP id 500202AC006 for ; Sat, 15 Sep 2018 12:49:37 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at nospam.nichework.com Received: from nospam.nichework.com ([127.0.0.1]) by localhost (nospam.nichework.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3mOyDdayig0P for ; Sat, 15 Sep 2018 12:49:37 -0400 (EDT) Received: from mail.nichework.com (mail.nichework.com [108.161.151.158]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by nospam.nichework.com (Postfix) with ESMTPS id 0C9EE2AC003 for ; Sat, 15 Sep 2018 12:49:37 -0400 (EDT) Received: from mail.nichework.com (localhost.localdomain [127.0.0.1]) by mail.nichework.com (Postfix) with ESMTPS id 4AE1A4E14C6 for ; Sat, 15 Sep 2018 09:49:51 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.nichework.com (Postfix) with ESMTP id 3F1294E14AE for ; Sat, 15 Sep 2018 09:49:51 -0700 (PDT) X-Virus-Scanned: amavisd-new at mail.nichework.com Received: from mail.nichework.com ([127.0.0.1]) by localhost (mail.nichework.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9igM6onNe09t for ; Sat, 15 Sep 2018 09:49:51 -0700 (PDT) Received: from slink.everybody.org (unknown [24.229.149.248]) by mail.nichework.com (Postfix) with ESMTPSA id DF63D4E0C07 for ; Sat, 15 Sep 2018 09:49:50 -0700 (PDT) From: "Mark A. Hershberger" To: bug-gnu-emacs@gnu.org Subject: [PATCH] Update references in core emacs from save-place to save-place-mode Date: Sat, 15 Sep 2018 12:49:49 -0400 Message-ID: <87in367ljm.fsf@everybody.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * lisp/menu-bar.el (menu-bar-options-save, menu-bar-options-menu): * lisp/saveplace.el (save-place-to-alist, save-places-to-alist, save-place-find-file-hook, save-place-dired-hook): Use save-place-mode instead of the obsolete save-place. * doc/lispref/customize.texi (Variable Definitions): Replace defcustom example from 2005 with a more recent one. --- doc/lispref/customize.texi | 12 ++++++------ lisp/menu-bar.el | 6 +++--- lisp/saveplace.el | 12 ++++++------ 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/doc/lispref/customize.texi b/doc/lispref/customize.texi index b3528b12d5..d7e97fcae7 100644 --- a/doc/lispref/customize.texi +++ b/doc/lispref/customize.texi @@ -450,14 +450,14 @@ Variable Definitions that turns on a certain feature. This causes Emacs to load the feature, if it is not already loaded, whenever the option is set. @xref{Common Keywords}. Here is an example, from the library -@file{saveplace.el}: +@file{org-bbdb.el}: @example -(defcustom save-place nil - "Non-nil means automatically save place in each file..." - :type 'boolean - :require 'saveplace - :group 'save-place) +(defcustom org-bbdb-default-anniversary-format "birthday" + "Default anniversary class." + :type 'string + :group 'org-bbdb-anniversaries + :require 'bbdb) @end example If a customization item has a type such as @code{hook} or diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 20d5ad95d8..e626369cfb 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -689,7 +689,7 @@ menu-bar-options-save debug-on-quit debug-on-error ;; Somehow this works, when tool-bar and menu-bar don't. tooltip-mode window-divider-mode - save-place uniquify-buffer-name-style fringe-mode + save-place-mode uniquify-buffer-name-style fringe-mode indicate-empty-lines indicate-buffer-boundaries case-fold-search font-use-system-font current-language-environment default-input-method @@ -1409,7 +1409,7 @@ menu-bar-options-menu (bindings--define-key menu [save-place] (menu-bar-make-toggle - toggle-save-place-globally save-place + toggle-save-place-globally save-place-mode "Save Place in Files between Sessions" "Saving place in files %s" "Visit files of previous session when restarting Emacs" @@ -1417,7 +1417,7 @@ menu-bar-options-menu ;; Do it by name, to avoid a free-variable ;; warning during byte compilation. (set-default - 'save-place (not (symbol-value 'save-place))))) + 'save-place-mode (not (symbol-value 'save-place-mode))))) (bindings--define-key menu [uniquify] (menu-bar-make-toggle diff --git a/lisp/saveplace.el b/lisp/saveplace.el index 9d3f10ac35..f8f15cabcd 100644 --- a/lisp/saveplace.el +++ b/lisp/saveplace.el @@ -27,7 +27,7 @@ ;; Automatically save place in files, so that visiting them later ;; (even during a different Emacs session) automatically moves point ;; to the saved position, when the file is first found. Uses the -;; value of buffer-local variable save-place to determine whether to +;; value of buffer-local variable save-place-mode to determine whether to ;; save position or not. ;; ;; Thanks to Stefan Schoef, who sent a patch with the @@ -176,7 +176,7 @@ save-place-local-mode (defun save-place-to-alist () ;; put filename and point in a cons box and then cons that onto the - ;; front of the save-place-alist, if save-place is non-nil. + ;; front of the save-place-alist, if save-place-mode is non-nil. ;; Otherwise, just delete that file from the alist. ;; first check to make sure alist has been loaded in from the master ;; file. If not, do so, then feel free to modify the alist. It @@ -306,8 +306,8 @@ load-save-place-alist-from-file nil)))) (defun save-places-to-alist () - ;; go through buffer-list, saving places to alist if save-place is - ;; non-nil, deleting them from alist if it is nil. + ;; go through buffer-list, saving places to alist if save-place-mode + ;; is non-nil, deleting them from alist if it is nil. (let ((buf-list (buffer-list))) (while buf-list ;; put this into a save-excursion in case someone is counting on @@ -332,7 +332,7 @@ save-place-find-file-hook (and (integerp (cdr cell)) (goto-char (cdr cell)))) ;; and make sure it will be saved again for later - (setq save-place t))))) + (setq save-place-mode t))))) (declare-function dired-goto-file "dired" (file)) @@ -357,7 +357,7 @@ save-place-dired-hook ((and (listp (cdr cell)) (assq 'dired-filename (cdr cell))) (dired-goto-file (cdr (assq 'dired-filename (cdr cell))))))) ;; and make sure it will be saved again for later - (setq save-place t))))) + (setq save-place-mode t))))) (defun save-place-kill-emacs-hook () ;; First update the alist. This loads the old save-place-file if nec. -- 2.18.0 ------------=_1537603561-23946-1--