From danc@merrillpress.com Wed May 13 11:01:40 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 13 May 2009 18:01:40 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4DFB5W6021821 for ; Wed, 13 May 2009 08:11:07 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M4G6q-0006bB-Am for bug-gnu-emacs@gnu.org; Wed, 13 May 2009 11:11:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M4G6l-0006Ul-M8 for bug-gnu-emacs@gnu.org; Wed, 13 May 2009 11:11:03 -0400 Received: from [199.232.76.173] (port=50409 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M4G6l-0006US-55 for bug-gnu-emacs@gnu.org; Wed, 13 May 2009 11:10:59 -0400 Received: from vpn.merrillpress.com ([64.61.107.78]:48454) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M4G6k-0005hH-M6 for bug-gnu-emacs@gnu.org; Wed, 13 May 2009 11:10:58 -0400 Received: from pluto.merrillpress.net ([10.136.5.5] helo=localhost.localdomain) by mars.merrillpress.net with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1M4G6i-0003ms-MR for bug-gnu-emacs@gnu.org; Wed, 13 May 2009 11:10:56 -0400 Received: from danc by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1M4G6i-0001Aq-FS for bug-gnu-emacs@gnu.org; Wed, 13 May 2009 11:10:56 -0400 From: Daniel Colascione To: bug-gnu-emacs@gnu.org Subject: ido-completing-read doesn't work unless ido-mode is executed Message-Id: Sender: Daniel Colascione Date: Wed, 13 May 2009 11:10:56 -0400 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) ido-completing-read acts very strangely when ido-mode hasn't been run. It creates a minibuffer with default bindings for RET which doesn't report to C-g. This stub buffer is very difficult to exit. Ideally, ido-completing-read would read in ido style regardless of whether ido-mode is run. At the very least, it should act like completing-read. To reproduce, run emacs -Q, then evaluate (ido-completing-read "test" '("1" "2" "3")) In GNU Emacs 22.3.1 (i386-redhat-linux-gnu, GTK+ Version 2.14.7) of 2009-02-09 on x86-5.fedora.phx.redhat.com Windowing system distributor `The X.Org Foundation', version 11.0.10503000 configured using `configure '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i386-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/usr/com' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i386-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 locale-coding-system: utf-8 default-enable-multibyte-characters: t Major mode: PHP Minor modes in effect: shell-dirtrack-mode: t which-function-mode: t cua-mode: t global-hi-lock-mode: t hi-lock-mode: t show-paren-mode: t savehist-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t unify-8859-on-encoding-mode: t utf-translate-cjk-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: c o n t a c t _ e m a i l , SPC M-b M-b M-d C-x C-s C-x v v S y u c S u c k SPC e m a i l s SPC i n t o SPC p r o d u c t i o n SPC s y s t e m SPC ( w h y SPC w a s n ' t SPC t h i s SPC d o n e SPC b e f o r e ? ) C-c C-c C-x C-f p r p r i w o o r d . s / r p r o r . C-s e m a i l C-s C-s C-x k M-x g r e C-g C-x C-f / o r d C-x k C-x C-f s M-x g r e p p e m a i l SPC * . p h p C-x 1 C-s e m a i l C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s M-x r e p o r t - e m Recent messages: Making completion list... [4 times] Mark saved where search started Quit (New file) Loading dired...done Loading grep...done Mark set Mark saved where search started Loading emacsbug...done call-interactively: Text is read-only [2 times] From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 28 08:32:15 2010 Received: (at 3274) by debbugs.gnu.org; 28 Nov 2010 13:32:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMhMU-0005t7-ME for submit@debbugs.gnu.org; Sun, 28 Nov 2010 08:32:14 -0500 Received: from ppsw-41.csi.cam.ac.uk ([131.111.8.141]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMhMS-0005st-Ms for 3274@debbugs.gnu.org; Sun, 28 Nov 2010 08:32:13 -0500 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com ([86.9.122.85]:60014 helo=Victoria.local) by ppsw-41.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1PMhRm-0001zZ-RD (Exim 4.72) (return-path ); Sun, 28 Nov 2010 13:37:42 +0000 From: Leo To: 3274@debbugs.gnu.org Subject: Re: ido-completing-read doesn't work unless ido-mode is executed Date: Sun, 28 Nov 2010 13:37:41 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (Mac OS X 10.6.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 3274 Cc: Daniel Colascione , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) I also ran into this bug a while back but didn't stop to fix it. Could you verify the following patch fixes the bug? commit 6ca8e9da0d6b61424a4f60073be0d42bd5b23d05 Date: Sun Nov 28 13:32:44 2010 +0000 Fix initialization in ido-completing-read Modified lisp/ido.el diff --git a/lisp/ido.el b/lisp/ido.el index 70d2d98..f1fc323 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -4853,6 +4853,9 @@ DEF, if non-nil, is the default value." (ido-directory-too-big nil) (ido-context-switch-command 'ignore) (ido-choice-list choices)) + ;; Initialize ido before invoking ido-read-internal + (unless (keymapp ido-common-completion-map) + (let (ido-mode) (ido-mode 1))) (ido-read-internal 'list prompt hist def require-match initial-input))) (defun ido-unload-function () From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 28 08:48:05 2010 Received: (at 3274) by debbugs.gnu.org; 28 Nov 2010 13:48:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMhbo-0006FE-Av for submit@debbugs.gnu.org; Sun, 28 Nov 2010 08:48:04 -0500 Received: from ppsw-41.csi.cam.ac.uk ([131.111.8.141]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMhbl-0006Ef-LX for 3274@debbugs.gnu.org; Sun, 28 Nov 2010 08:48:02 -0500 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com ([86.9.122.85]:60021 helo=Victoria.local) by ppsw-41.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1PMhh1-0006B7-Qd (Exim 4.72) (return-path ); Sun, 28 Nov 2010 13:53:27 +0000 From: Leo To: 3274@debbugs.gnu.org Subject: Re: bug#3274: ido-completing-read doesn't work unless ido-mode is executed References: Date: Sun, 28 Nov 2010 13:53:26 +0000 In-Reply-To: (Leo's message of "Sun, 28 Nov 2010 13:37:41 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (Mac OS X 10.6.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 3274 Cc: Daniel Colascione , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) On 2010-11-28 13:37 +0000, Leo wrote: > I also ran into this bug a while back but didn't stop to fix it. > > Could you verify the following patch fixes the bug? Please consider this patch instead. While the previous fix is minimal it does a bit too much by calling (ido-mode 1). commit eb3f3a514c7ebd2db402ca8c2f3ce7088dd8736a (HEAD, refs/heads/Ferrari) Date: Sun Nov 28 13:32:44 2010 +0000 Fix initialisation in ido-completing-read (#3274) Modified lisp/ido.el diff --git a/lisp/ido.el b/lisp/ido.el index 70d2d98..2cc10b2 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -1490,6 +1490,11 @@ Removes badly formatted data and ignored directories." ;; ido kill emacs hook (ido-save-history)) +(defun ido-common-initilization () + (ido-init-completion-maps) + (add-hook 'minibuffer-setup-hook 'ido-minibuffer-setup) + (add-hook 'choose-completion-string-functions 'ido-choose-completion-string)) + (define-minor-mode ido-everywhere "Toggle using ido speed-ups everywhere file and directory names are read. With ARG, turn ido speed-up on if arg is positive, off otherwise." @@ -1533,12 +1538,9 @@ This function also adds a hook to the minibuffer." (t nil))) (ido-everywhere (if ido-everywhere 1 -1)) - (when ido-mode - (ido-init-completion-maps)) (when ido-mode - (add-hook 'minibuffer-setup-hook 'ido-minibuffer-setup) - (add-hook 'choose-completion-string-functions 'ido-choose-completion-string) + (ido-common-initilization) (ido-load-history) (add-hook 'kill-emacs-hook 'ido-kill-emacs-hook) @@ -4853,6 +4855,8 @@ DEF, if non-nil, is the default value." (ido-directory-too-big nil) (ido-context-switch-command 'ignore) (ido-choice-list choices)) + ;; Initialize ido before invoking ido-read-internal + (ido-common-initilization) (ido-read-internal 'list prompt hist def require-match initial-input))) (defun ido-unload-function () From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 28 15:44:52 2010 Received: (at 3274) by debbugs.gnu.org; 28 Nov 2010 20:44:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMo7A-0007H7-B1 for submit@debbugs.gnu.org; Sun, 28 Nov 2010 15:44:52 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMo78-0007Gv-8V for 3274@debbugs.gnu.org; Sun, 28 Nov 2010 15:44:50 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id oASKoJ0e029921; Sun, 28 Nov 2010 15:50:20 -0500 Received: by pastel.home (Postfix, from userid 20848) id 7DE6AA85F1; Sun, 28 Nov 2010 15:50:19 -0500 (EST) From: Stefan Monnier To: Leo Subject: Re: bug#3274: ido-completing-read doesn't work unless ido-mode is executed Message-ID: References: Date: Sun, 28 Nov 2010 15:50:19 -0500 In-Reply-To: (Leo's message of "Sun, 28 Nov 2010 13:53:26 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3693=0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 3274 Cc: 3274@debbugs.gnu.org, Daniel Colascione X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> I also ran into this bug a while back but didn't stop to fix it. >> Could you verify the following patch fixes the bug? > --- a/lisp/ido.el > +++ b/lisp/ido.el > @@ -4853,6 +4853,9 @@ DEF, if non-nil, is the default value." > (ido-directory-too-big nil) > (ido-context-switch-command 'ignore) > (ido-choice-list choices)) > + ;; Initialize ido before invoking ido-read-internal > + (unless (keymapp ido-common-completion-map) > + (let (ido-mode) (ido-mode 1))) > (ido-read-internal 'list prompt hist def require-match initial-input))) "(let (ido-mode) (ido-mode 1))" is an "ugly hack" (not only because it calls (ido-mode 1) but because of the let-binding). > Please consider this patch instead. While the previous fix is minimal it > does a bit too much by calling (ido-mode 1). Glad you found a better solution. Your patch looks good. Savannah is down right now, so I'll install it later. Thanks. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 02 18:06:00 2010 Received: (at 3274-done) by debbugs.gnu.org; 2 Dec 2010 23:06:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POIDv-0002aF-R4 for submit@debbugs.gnu.org; Thu, 02 Dec 2010 18:06:00 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POI84-0002R6-7N for 3274-done@debbugs.gnu.org; Thu, 02 Dec 2010 17:59:56 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id oB2N5aIY013744; Thu, 2 Dec 2010 18:05:37 -0500 Received: by pastel.home (Postfix, from userid 20848) id 2EFEBA8785; Thu, 2 Dec 2010 18:05:36 -0500 (EST) From: Stefan Monnier To: Leo Subject: Re: bug#3274: ido-completing-read doesn't work unless ido-mode is executed Message-ID: References: Date: Thu, 02 Dec 2010 18:05:36 -0500 In-Reply-To: (Stefan Monnier's message of "Sun, 28 Nov 2010 15:50:19 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3697=0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 3274-done X-Mailman-Approved-At: Thu, 02 Dec 2010 18:05:58 -0500 Cc: Daniel Colascione X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> Please consider this patch instead. While the previous fix is minimal it >> does a bit too much by calling (ido-mode 1). > Glad you found a better solution. Your patch looks good. Savannah is > down right now, so I'll install it later. Thanks. Should be fixed in emacs-23 now. Stefan From unknown Sun Jun 22 08:09:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 31 Dec 2010 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator