GNU bug report logs -
#32727
[PATCH] gnu: Add telegram-purple.
Previous Next
Reported by: Tomáš Čech <sleep_walker <at> gnu.org>
Date: Thu, 13 Sep 2018 11:46:01 UTC
Severity: normal
Tags: patch
Done: ludo <at> gnu.org (Ludovic Courtès)
Bug is archived. No further changes may be made.
Full log
Message #20 received at 32727 <at> debbugs.gnu.org (full text, mbox):
Hello!
Tomáš, did you have a chance to look into this?
Thanks,
Ludo’.
Leo Famulari <leo <at> famulari.name> skribis:
> On Thu, Sep 13, 2018 at 02:20:56PM +0200, Tomáš Čech wrote:
>> + (source (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/majn/telegram-purple")
>> + (commit (string-append "v" version))
>> + (recursive? #t)))
>
> This recursive Git clone brings brings two libraries with it, 'tgl' and
> 'tl-parser':
>
> https://github.com/majn/tgl/
> https://github.com/vysheng/tl-parser
>
> Is it possible to include these as their own separate Guix packages?
> Would anything else potentially use them?
>
> In general we try to avoid bundling things, but sometimes the effort is
> not worth it.
>
>> + `(#:tests? #f
>
> If there are no tests, please add a comment like "No test suite". Or
> else leave a comment explaining why we skip the tests.
>
>> + (add-after 'unpack 'prepare-commit.h
>> + (lambda _
>> + (with-output-to-file "./commit.h"
>> + (lambda ()
>> + (display
>> + (string-append "//generated by guix, use version instead of "
>> + "commit\n"
>> + "#ifndef GIT_COMMIT\n"
>> + "# define GIT_COMMIT \"v"
>> + ,version "\"\n"
>> + "#endif\n"))))))
>
> Can you add a brief comment explaining this?
>
>> + (description "Telegram protocol support for pidgin.")
>
> To make it a complete sentence, how about ""Telegram-purple is a Libpurple
> protocol plugin that adds support for the Telegram messenger."?
This bug report was last modified 6 years and 268 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.